Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5218
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159691205
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/StringValueParser.java
---
@@ -45,6 +45,12 @@ public void enableQuotedStringParsing(byte
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159691114
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/StringParser.java ---
@@ -42,6 +42,12 @@ public void enableQuotedStringParsing(byte
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159683964
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/LongParser.java ---
@@ -86,6 +92,11 @@ public int parseField(byte[] bytes, int
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159682488
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/StringParser.java ---
@@ -42,6 +42,12 @@ public void enableQuotedStringParsing(byte
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159670504
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/StringValueParser.java
---
@@ -45,6 +45,12 @@ public void enableQuotedStringParsing(byte
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159670229
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/StringParser.java ---
@@ -42,6 +42,12 @@ public void enableQuotedStringParsing(byte
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159667871
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/LongValueParser.java ---
@@ -89,6 +95,11 @@ public int parseField(byte[] bytes, int
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159667815
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/LongParser.java ---
@@ -86,6 +92,11 @@ public int parseField(byte[] bytes, int startPos,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159678062
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/FieldParserTest.java ---
@@ -43,4 +46,100 @@ public void testEndsWithDelimiter() throws
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159139198
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -407,26 +407,47 @@ public void
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159139167
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -362,61 +365,95 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159137345
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -407,26 +407,47 @@ public void
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159136839
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -407,26 +407,47 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159135944
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -407,26 +407,47 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159135908
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -407,26 +407,47 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159136001
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -362,61 +365,95 @@ public void
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159134590
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159132545
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159127981
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/FieldParserTest.java ---
@@ -43,4 +43,38 @@ public void testEndsWithDelimiter() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159128212
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/FieldParserTest.java ---
@@ -43,4 +43,38 @@ public void testEndsWithDelimiter() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159127955
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/FieldParserTest.java ---
@@ -43,4 +43,38 @@ public void testEndsWithDelimiter() throws
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159128322
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final String
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/5218
[FLINK-8331][core] FieldParser do not correctly set EMPT_COLUMN error state.
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To
24 matches
Mail list logo
