[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5701 ---

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175755400 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java --- @@ -194,49 +187,35 @@ protected

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175751892 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java --- @@ -194,49 +187,35 @@ protected final void

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175747950 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java --- @@ -194,49 +187,35 @@ protected

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175747586 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/AccumulatorReport.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175735031 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java --- @@ -194,49 +187,35 @@ protected final void

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175733781 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/AccumulatorReport.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175733627 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/AccumulatorReport.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175731028 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java --- @@ -87,17 +89,24 @@ protected static

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175731826 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java --- @@ -194,49 +187,35 @@ protected

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175731427 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java --- @@ -194,49 +187,35 @@ protected

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175730158 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/AccumulatorReport.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175729168 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java --- @@ -1515,8 +1516,22 @@ public void

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

2018-03-20 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5701#discussion_r175727728 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/AccumulatorReport.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to