MartijnVisser closed pull request #23489: [ FLINK-33603][FileSystems] shade
guava in gs-fs filesystem
URL: https://github.com/apache/flink/pull/23489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1859734539
Superseded by https://issues.apache.org/jira/browse/FLINK-33704 - Thanks for
the help/thinking on this @singhravidutt
@singhravidutt @cnauroth Do you have any bandwidth to
singhravidutt commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1858146657
Licensing issue is fixed in the latest commit but I still feel we should
exclude guava specific jars coming from `flink-fs-hadoop-shaded`. @JingGe
@MartijnVisser
singhravidutt commented on code in PR #23489:
URL: https://github.com/apache/flink/pull/23489#discussion_r1428174024
##
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##
@@ -188,6 +212,29 @@ under the License.
shade
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1857914683
There are two possibilities to solve this:
1. Backport https://issues.apache.org/jira/browse/FLINK-33704 to
`release-1.18` - This resolves the issue for 1.18
2. Merge the
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1857706468
@snuyanzin I'm also looping you in here
> I'm currently testing if my patch would also work when backported to 1.18.
Newsflash: I didn't work Which in hindsight, is
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1857672990
@JingGe @singhravidutt I think I've cracked it :)
1. I've setup a GCS bucket and created a checkpointing test job in order to
reproduce the error that's happening in Flink
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1857461633
@JingGe Thanks for the comments. I've been looking at different options to
shade the artifacts, and also try that with a local application that writes to
GCS. Unfortunately, I
singhravidutt commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1857360296
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
singhravidutt commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1855726357
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
JingGe commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1854677694
Hi folks, thanks for driving it.
@MartijnVisser my understanding is that your version won't work, since there
still a `guava 27.0-jre` in the classpath.
@singhravidutt:
JingGe commented on code in PR #23489:
URL: https://github.com/apache/flink/pull/23489#discussion_r1425851930
##
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##
@@ -188,6 +212,29 @@ under the License.
shade
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1853706439
@singhravidutt Can I get your thoughts on
https://github.com/apache/flink/pull/23920 as an alternative solution?
--
This is an automated message from the Apache Git Service.
To
MartijnVisser commented on code in PR #23489:
URL: https://github.com/apache/flink/pull/23489#discussion_r1425195367
##
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##
@@ -204,20 +251,13 @@ under the License.
singhravidutt commented on code in PR #23489:
URL: https://github.com/apache/flink/pull/23489#discussion_r1425171966
##
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##
@@ -188,6 +212,29 @@ under the License.
shade
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1852784610
@singhravidutt I've created
https://github.com/apache/flink/commit/2ebe7f6e090690486c1954099a2b57283c578192
to test it out on private CI. Let me know what you think
--
This is
MartijnVisser commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1852416614
> Introduced dependency on guava version(`31.1-jre`) required by
`google-cloud-storage`.
I'm still kind of puzzled. If this is required by `google-cloud-storage`,
shouldn't
MartijnVisser commented on code in PR #23489:
URL: https://github.com/apache/flink/pull/23489#discussion_r1424292057
##
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##
@@ -204,20 +251,13 @@ under the License.
MartijnVisser commented on code in PR #23489:
URL: https://github.com/apache/flink/pull/23489#discussion_r1424285751
##
flink-filesystems/flink-gs-fs-hadoop/pom.xml:
##
@@ -188,6 +212,29 @@ under the License.
shade
singhravidutt commented on PR #23489:
URL: https://github.com/apache/flink/pull/23489#issuecomment-1840388220
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
20 matches
Mail list logo
