Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
libenchao closed pull request #24133: [FLINK-33264][table] Support source parallelism setting for DataGen connector URL: https://github.com/apache/flink/pull/24133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
XComp commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911845153 Ah I see, thanks for the pointer. I approved and merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911838497 @XComp Thanks for the notice. We've already prepared another separate PR: #24200 on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
XComp commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1911798162 @X-czh thanks for discovering the compilation error that was merged into `master`. Could you merge the hotfix commit separately from the bigger change of this PR? The hotfix commit doesn't need to wait for CI to pass and would enable `master` to be stable again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467174161 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the table is unbounded. + + scan.parallelism + optional + (none) + Long Review Comment: Fixed in the new commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467171751 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the table is unbounded. + + scan.parallelism + optional + (none) + Long Review Comment: Thanks for catching this. I'll fix that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467171607 ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -581,6 +588,27 @@ void testWrongTypes() { anyCauseMatches("Could not parse value 'Wrong' for key 'fields.f0.start'")); } +@Test +void testWithParallelism() { Review Comment: I've already included an IT case in `DataGeneratorConnectorITCase#testWithParallelism` where the physical execution plan is checked, would that be enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
libenchao commented on code in PR #24133: URL: https://github.com/apache/flink/pull/24133#discussion_r1467163104 ## docs/content/docs/connectors/table/datagen.md: ## @@ -270,6 +270,13 @@ Connector Options Long The total number of rows to emit. By default, the table is unbounded. + + scan.parallelism + optional + (none) + Long Review Comment: Actually it's defined as `int` in the code. ## flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java: ## @@ -581,6 +588,27 @@ void testWrongTypes() { anyCauseMatches("Could not parse value 'Wrong' for key 'fields.f0.start'")); } +@Test +void testWithParallelism() { Review Comment: In FLINK-33263, we've introduced a way to verify that the transformation, could you also add a test based on that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1902132296 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
libenchao commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1899537774 > @libenchao Could you help review it after #24128 is merged? I assigned it to myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1899531944 @libenchao Could you help review it after #24128 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
flinkbot commented on PR #24133: URL: https://github.com/apache/flink/pull/24133#issuecomment-1898552816 ## CI report: * ce0c1fb08207d66bb5693b1311bb03d7ba1fda3d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure` re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [FLINK-33264][table] Support source parallelism setting for DataGen connector [flink]
X-czh opened a new pull request, #24133: URL: https://github.com/apache/flink/pull/24133 ## What is the purpose of the change Support source parallelism setting for DataGen connector. ## Brief change log - Add SOURCE_PARALLELISM into DataGenConnectorOptions and pass it to planner - Update docs, introducing scan.parallelism ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) no - The runtime per-record code paths (performance sensitive): (yes / no / don't know) no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no - The S3 file system connector: (yes / no / don't know) no ## Documentation - Does this pull request introduce a new feature? (yes / no) yes - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org