TanYuxin-tyx commented on PR #64:
URL:
https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1809787649
@MartijnVisser Thanks a lot for the careful review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
boring-cyborg[bot] commented on PR #64:
URL:
https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1809784080
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MartijnVisser merged PR #64:
URL: https://github.com/apache/flink-connector-kafka/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TanYuxin-tyx commented on PR #64:
URL:
https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1789985229
@MartijnVisser Thanks. It's my fault to use the wrong target branch. I have
updated the target branch to v3.0.
The reason why it can fix the incorrect -1.18
MartijnVisser commented on PR #64:
URL:
https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1788773208
> This fix aims to resolve the issue of displaying the incorrect version
number (-1.18) for the Kafka connector.
How it should work, is that in the right branch
TanYuxin-tyx commented on PR #64:
URL:
https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1788206919
@MartijnVisser, Thanks for helping review.
This fix aims to resolve the issue of displaying the incorrect version
number (-1.18) for the Kafka connector.
TanYuxin-tyx commented on PR #64:
URL:
https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1786393530
@MartijnVisser Hi, Martijn, could you please help review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
TanYuxin-tyx opened a new pull request, #64:
URL: https://github.com/apache/flink-connector-kafka/pull/64
Currently, Kafka Connector official documentation has a bug in the download
link and the version number.
This is the fix for https://issues.apache.org/jira/browse/FLINK-33401.
boring-cyborg[bot] commented on PR #64:
URL:
https://github.com/apache/flink-connector-kafka/pull/64#issuecomment-1786384204
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is