snuyanzin merged PR #24140:
URL: https://github.com/apache/flink/pull/24140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
RyanSkraba commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1562627239
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.java:
##
@@ -0,0 +1,89 @@
+/*
snuyanzin commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1519024028
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.java:
##
@@ -0,0 +1,90 @@
+/*
+
JingGe commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1471343469
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.java:
##
@@ -0,0 +1,90 @@
+/*
+ *
JingGe commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1468844018
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala:
##
@@ -268,7 +268,7 @@ object FlinkBatchRuleSets {
snuyanzin commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1470433205
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.java:
##
@@ -0,0 +1,90 @@
+/*
+
snuyanzin commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1470432426
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.java:
##
@@ -0,0 +1,90 @@
+/*
+
snuyanzin commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1470432177
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkBatchRuleSets.scala:
##
@@ -268,7 +268,7 @@ object
JingGe commented on code in PR #24140:
URL: https://github.com/apache/flink/pull/24140#discussion_r1468850983
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowAggregateReduceFunctionsRule.java:
##
@@ -0,0 +1,90 @@
+/*
+ *
flinkbot commented on PR #24140:
URL: https://github.com/apache/flink/pull/24140#issuecomment-1899349577
## CI report:
* 43dc43ac4748dfc387fbac363d0ed17ae87adca2 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
snuyanzin opened a new pull request, #24140:
URL: https://github.com/apache/flink/pull/24140
## What is the purpose of the change
The PR migrates `WindowAggregateReduceFunctionsRule` to java
it doesn't touch `WindowAggregateReduceFunctionsRuleTest` to be sure that
java version
11 matches
Mail list logo