[jira] [Commented] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111234#comment-17111234 ] Gyula Fora commented on FLINK-17619: Merged: release-1.11: cf29c2c9c21eba72535a5eb86

[jira] [Commented] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110903#comment-17110903 ] Gyula Fora commented on FLINK-17619: We could do it either way, If you review the PR

[jira] [Commented] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-18 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110352#comment-17110352 ] Jark Wu commented on FLINK-17619: - Hi [~Leonard Xu], we can review and merge this one fi

[jira] [Commented] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-18 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110295#comment-17110295 ] Leonard Xu commented on FLINK-17619: [~jark] I think yes,  the new kafka table sourc

[jira] [Commented] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-18 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110256#comment-17110256 ] Jark Wu commented on FLINK-17619: - cc [~Leonard Xu], should we fix this in the new Kafka

[jira] [Commented] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-18 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110099#comment-17110099 ] Gyula Fora commented on FLINK-17619: Seems like Jira did not pick up the PR: [https:

[jira] [Commented] (FLINK-17619) Only set offset commit if group id is configured for Kafka Table source

2020-05-18 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110096#comment-17110096 ] Aljoscha Krettek commented on FLINK-17619: -- Sounds legit, yes. > Only set offs