[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[
https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17426225#comment-17426225
]
Dawid Wysakowicz commented on FLINK-18934:
--
It has not been backported to previous versions because it needed to change the
{{Input}} interface which is marked as {{PublicEvolving}}. We did not want to
introduce such a change in a minor release.
> Idle stream does not advance watermark in connected stream
> --
>
> Key: FLINK-18934
> URL: https://issues.apache.org/jira/browse/FLINK-18934
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream, Runtime / Task
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: Truong Duc Kien
>Assignee: Dawid Wysakowicz
>Priority: Critical
> Labels: pull-request-available, stale-assigned
> Fix For: 1.14.0
>
>
> Per Flink documents, when a stream is idle, it will allow watermarks of
> downstream operator to advance. However, when I connect an active data stream
> with an idle data stream, the output watermark of the CoProcessOperator does
> not increase.
> Here's a small test that reproduces the problem.
> https://github.com/kien-truong/flink-idleness-testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326982#comment-17326982 ] Flink Jira Bot commented on FLINK-18934: This issue is assigned but has not received an update in 7 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream, Runtime / Task >Affects Versions: 1.11.0, 1.12.0 >Reporter: Truong Duc Kien >Assignee: Dawid Wysakowicz >Priority: Major > Labels: stale-assigned > Fix For: 1.14.0, 1.13.1 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319388#comment-17319388 ] Dawid Wysakowicz commented on FLINK-18934: -- We agreed offline it is an important bug that lingers for a long time and thus we should consider this a must for 1.13.1 and 1.14 > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream, Runtime / Task >Affects Versions: 1.11.0, 1.12.0 >Reporter: Truong Duc Kien >Priority: Major > Fix For: 1.14.0, 1.13.1 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319382#comment-17319382 ] Konstantin Knauf commented on FLINK-18934: -- [~dwysakowicz] Why is this a blocker? It is not an infrastructure failure and its not a bug that is blocking us from releasing. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream, Runtime / Task >Affects Versions: 1.11.0, 1.12.0 >Reporter: Truong Duc Kien >Priority: Major > Fix For: 1.14.0, 1.13.1 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319373#comment-17319373 ] Dawid Wysakowicz commented on FLINK-18934: -- Actually it is a blocker that we've not handled well so far :( > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream, Runtime / Task >Affects Versions: 1.11.0, 1.12.0 >Reporter: Truong Duc Kien >Priority: Major > Fix For: 1.14.0 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319371#comment-17319371 ] Konstantin Knauf commented on FLINK-18934: -- As this is clearly not a Blocker (open for > 6 months), I've deprioritized it to Major for now (see also https://cwiki.apache.org/confluence/display/FLINK/Flink+Jira+Process). > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream, Runtime / Task >Affects Versions: 1.11.0, 1.12.0 >Reporter: Truong Duc Kien >Priority: Major > Fix For: 1.14.0 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229963#comment-17229963 ] Dian Fu commented on FLINK-18934: - [~aljoscha] Thanks a lot. I have updated the fix version to 1.13.0. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Critical > Fix For: 1.12.0, 1.11.3 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229959#comment-17229959 ] Aljoscha Krettek commented on FLINK-18934: -- I don't think we can fix it for Flink 1.12. This requires extending the operator interface to "teach" operators about idleness as well so that they can combine the two sides and forward an appropriate watermark/idleness. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Critical > Fix For: 1.12.0, 1.11.3 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229711#comment-17229711 ] Dian Fu commented on FLINK-18934: - What's the status of this issue? Is it still target to fixed in 1.12.0? > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Critical > Fix For: 1.12.0, 1.11.3 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[
https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200082#comment-17200082
]
Piotr Nowojski commented on FLINK-18934:
Note to anyone who will be fixing this issue. In the
{{MultipleInputStreamTaskTest#testWatermarkAndStreamStatusForwarding}}
(implemented as part of FLINK-18907 ) there is a workaround of this bug, that
needs to be removed when this bug is fixed.
> Idle stream does not advance watermark in connected stream
> --
>
> Key: FLINK-18934
> URL: https://issues.apache.org/jira/browse/FLINK-18934
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream
>Affects Versions: 1.11.1
>Reporter: Truong Duc Kien
>Priority: Critical
> Fix For: 1.12.0, 1.11.3
>
>
> Per Flink documents, when a stream is idle, it will allow watermarks of
> downstream operator to advance. However, when I connect an active data stream
> with an idle data stream, the output watermark of the CoProcessOperator does
> not increase.
> Here's a small test that reproduces the problem.
> https://github.com/kien-truong/flink-idleness-testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191470#comment-17191470 ] Zhu Zhu commented on FLINK-18934: - I think this ticket still needs some time to figure out a proper solution, so moving it to 1.11.3. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Critical > Fix For: 1.12.0, 1.11.2 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189816#comment-17189816 ] Zhu Zhu commented on FLINK-18934: - [~knaufk] [~aljoscha] Given that this issue was proposed as a blocker for releasing 1.11.2, I have a couple of questions to understand the state of it. Appreciate if you can help with them. - Should it be a strict blocker of releasing 1.11.2? - Is there a concise on how we can fix it? - Does next Monday as the deadline to cut RC1 work for the fix? > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Critical > Fix For: 1.12.0, 1.11.2 > > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[
https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187696#comment-17187696
]
Piotr Nowojski commented on FLINK-18934:
Side note, if you need to fix {{AbstractStreamOperator}}, please remember about
fixing {{AbstractStreamOperatorV2}} as well.
> Idle stream does not advance watermark in connected stream
> --
>
> Key: FLINK-18934
> URL: https://issues.apache.org/jira/browse/FLINK-18934
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream
>Affects Versions: 1.11.1
>Reporter: Truong Duc Kien
>Priority: Major
>
> Per Flink documents, when a stream is idle, it will allow watermarks of
> downstream operator to advance. However, when I connect an active data stream
> with an idle data stream, the output watermark of the CoProcessOperator does
> not increase.
> Here's a small test that reproduces the problem.
> https://github.com/kien-truong/flink-idleness-testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186872#comment-17186872 ] Benchao Li commented on FLINK-18934: +1 for fixing this issue, we also found this limitation when using 'temporal table function', and fixed it in our internal branch. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Major > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[
https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186823#comment-17186823
]
Kenneth William Krugler commented on FLINK-18934:
-
On the list, [~dwysakowicz] said:
{quote}Hi Kien,
I am afraid this is a valid bug. I am not 100% sure but the way I
understand the code the idleness mechanism applies to input channels,
which means e.g. when multiple parallell instances shuffle its results
to downstream operators.
In case of a two input operator, combining the watermark of two
different upstream operators happens inside of the operator itself.
There we do not have the idleness status. We do not have a status that a
whole upstream operator became idle. That's definitely a bug/limitation.
I'm also cc'ing Aljoscha who could maybe confirm my analysis.
Best,
Dawid{quote}
And [~aljoscha] added:
{quote}Yes, I'm afraid this analysis is correct. The StreamOperator,
AbstractStreamOperator to be specific, computes the combined watermarks from
both inputs here:
https://github.com/apache/flink/blob/f0ed29c06d331892a06ee9bddea4173d6300835d/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java#L573.
The operator layer is not aware of idleness so it will never notice. The
idleness only works on the level of inputs but is never forwarded to an
operator itself.
To fix this we would have to also make operators aware of idleness such that
they can take this into account when computing the combined output watermark.
Best,
Aljoscha{quote}
> Idle stream does not advance watermark in connected stream
> --
>
> Key: FLINK-18934
> URL: https://issues.apache.org/jira/browse/FLINK-18934
> Project: Flink
> Issue Type: Bug
> Components: API / DataStream
>Affects Versions: 1.11.1
>Reporter: Truong Duc Kien
>Priority: Major
>
> Per Flink documents, when a stream is idle, it will allow watermarks of
> downstream operator to advance. However, when I connect an active data stream
> with an idle data stream, the output watermark of the CoProcessOperator does
> not increase.
> Here's a small test that reproduces the problem.
> https://github.com/kien-truong/flink-idleness-testing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183311#comment-17183311 ] Truong Duc Kien commented on FLINK-18934: - Sorry, I've forgotten about this issue so I've only made a post to the mailing list just now. Maybe we could wait a few days to see if there's any response. Thanks. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Major > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183225#comment-17183225 ] Aljoscha Krettek commented on FLINK-18934: -- Is there any update on this? > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Major > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-18934) Idle stream does not advance watermark in connected stream
[ https://issues.apache.org/jira/browse/FLINK-18934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177070#comment-17177070 ] Kenneth William Krugler commented on FLINK-18934: - Hi [~kien_truong] - I would suggest posting this question to the Flink user mailing list, and after reviewing the responses, decide whether this is really a bug. > Idle stream does not advance watermark in connected stream > -- > > Key: FLINK-18934 > URL: https://issues.apache.org/jira/browse/FLINK-18934 > Project: Flink > Issue Type: Bug > Components: API / DataStream >Affects Versions: 1.11.1 >Reporter: Truong Duc Kien >Priority: Major > > Per Flink documents, when a stream is idle, it will allow watermarks of > downstream operator to advance. However, when I connect an active data stream > with an idle data stream, the output watermark of the CoProcessOperator does > not increase. > Here's a small test that reproduces the problem. > https://github.com/kien-truong/flink-idleness-testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
