[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484109#comment-17484109 ] Jing Zhang commented on FLINK-25614: Fixed in master: d46548c5024c4c47d6e52168e1d92c68d3ce58f8 >

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478712#comment-17478712 ] Martijn Visser commented on FLINK-25614: Awesome, thanks [~lmagics]  > Let LocalWindowAggregate

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-19 Thread Q Kang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478706#comment-17478706 ] Q Kang commented on FLINK-25614: [~MartijnVisser] I have fixed other `getLong`s in `SliceAssigner`, so

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478386#comment-17478386 ] Martijn Visser commented on FLINK-25614: [~lmagics] Given that the Flink 1.15 release branch

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-18 Thread Q Kang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478347#comment-17478347 ] Q Kang commented on FLINK-25614: [~jingzhang] Sorry for the late response. [~wenlong.lwl] had given the

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-17 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477524#comment-17477524 ] Jing Zhang commented on FLINK-25614: [~wenlong.lwl][~lmagics]Thanks a lot for explain. I understand.

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-17 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477160#comment-17477160 ] Wenlong Lyu commented on FLINK-25614: - [~jark][~jingzhang], we can not use getLong anymore actually

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-17 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477073#comment-17477073 ] Jark Wu commented on FLINK-25614: - Currently, we only support TIMESTAMP(<=3) as the rowtime attribute,

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-15 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476563#comment-17476563 ] Jing Zhang commented on FLINK-25614: [~wenlong.lwl] [~lmagics] Sorry for late response. I agree

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-13 Thread Q Kang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17475897#comment-17475897 ] Q Kang commented on FLINK-25614: Hi [~wenlong.lwl] , I have fixed `SlicingWindowAggOperatorTest`, but

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-12 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474394#comment-17474394 ] Wenlong Lyu commented on FLINK-25614: - hi, I think this is a bug actually. [~lmagics] could you also

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-11 Thread Q Kang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17473245#comment-17473245 ] Q Kang commented on FLINK-25614: The original intention of this change is to eliminate ser/deser between

[jira] [Commented] (FLINK-25614) Let LocalWindowAggregate be chained with upstream

2022-01-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17473102#comment-17473102 ] Martijn Visser commented on FLINK-25614: [~jingzhang] What do you think? > Let