[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287653#comment-15287653
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/1982


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>Assignee: Mark Reddy
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287257#comment-15287257
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1982#issuecomment-219814739
  
Race condition ;-)
@fhueske  I have locally merged this already. To me the names are good, I 
would keep them unless you feel strongly about the names.


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>Assignee: Mark Reddy
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287262#comment-15287262
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1982#issuecomment-219815351
  
No, names are OK. 
Just thought `DataSetJob` / `DataStreamJob` would be more consistent with 
API and documentation.
We can update the names later.


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>Assignee: Mark Reddy
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287253#comment-15287253
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user fhueske commented on the pull request:

https://github.com/apache/flink/pull/1982#issuecomment-219814341
  
Thanks for reworking the quickstart jobs @markreddy. Change look good to me.
I am not sure about the naming of the jobs. Should we use `DataSetJob` 
instead of `BatchJob` and `DataStreamJob` instead of `StreamingJob`?


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>Assignee: Mark Reddy
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15287250#comment-15287250
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user StephanEwen commented on the pull request:

https://github.com/apache/flink/pull/1982#issuecomment-219814154
  
Merging this...


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>Assignee: Mark Reddy
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286590#comment-15286590
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user rmetzger commented on the pull request:

https://github.com/apache/flink/pull/1982#issuecomment-219713912
  
I like the pull request! (You updated the docs, the PR describes the 
changes).

+1 to merge


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>Assignee: Mark Reddy
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279879#comment-15279879
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/1982#discussion_r62820828
  
--- Diff: 
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
 ---
@@ -32,28 +32,29 @@
  * mvn clean package
  * in the projects root directory.
  * You will find the jar in
- * target/flink-quickstart-0.1-SNAPSHOT-Sample.jar
- *
+ * target/flink-quickstart-0.1-SNAPSHOT.jar
+ * From the cli you can then run
+ * ./bin/flink run -c  BatchJob quickstart 
jar
--- End diff --

Perhaps we can add a link to the cli introduction?
https://ci.apache.org/projects/flink/flink-docs-release-1.0/apis/cli.html


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279876#comment-15279876
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user tzulitai commented on the pull request:

https://github.com/apache/flink/pull/1982#issuecomment-218413341
  
Made comments on some rather trivial javadoc / comment related stuff, 
overall the PR looks good!
I like how you've also made effort to tidy up some details in the original 
code too :)



> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279859#comment-15279859
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/1982#discussion_r62818792
  
--- Diff: 
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
 ---
@@ -32,28 +32,29 @@
  * mvn clean package
  * in the projects root directory.
  * You will find the jar in
- * target/flink-quickstart-0.1-SNAPSHOT-Sample.jar
- *
+ * target/flink-quickstart-0.1-SNAPSHOT.jar
+ * From the cli you can then run
+ * ./bin/flink run -c  BatchJob quickstart 
jar
  */
-public class Job {
+public class BatchJob {
 
public static void main(String[] args) throws Exception {
-   // set up the execution environment
+   // set up the batch execution environment
final ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
 
-
/**
 * Here, you can start creating your execution plan for Flink.
 *
 * Start with getting some data from the environment, like
-*  env.readTextFile(textPath);
+* env.readTextFile(textPath);
--- End diff --

I think this space was intended formatting, like the below .filter(), 
.flatMap() etc.


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279856#comment-15279856
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/1982#discussion_r62818171
  
--- Diff: 
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
 ---
@@ -32,28 +32,29 @@
  * mvn clean package
  * in the projects root directory.
  * You will find the jar in
- * target/flink-quickstart-0.1-SNAPSHOT-Sample.jar
- *
+ * target/flink-quickstart-0.1-SNAPSHOT.jar
+ * From the cli you can then run
+ * ./bin/flink run -c  BatchJob quickstart 
jar
--- End diff --

1 Excessive space after '-c'.
Also, maybe this would be more specific: `./bin/flink run -c 
${package}.BatchJob target/flink-quickstart-0.1-SNAPSHOT.jar`


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279853#comment-15279853
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/1982#discussion_r62817913
  
--- Diff: 
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
 ---
@@ -32,28 +32,29 @@
  * mvn clean package
  * in the projects root directory.
  * You will find the jar in
- * target/flink-quickstart-0.1-SNAPSHOT-Sample.jar
- *
+ * target/flink-quickstart-0.1-SNAPSHOT.jar
--- End diff --

Sorry, I misunderstood. The naming of the jar here depends on the user. 


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279846#comment-15279846
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/1982#discussion_r62816955
  
--- Diff: 
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/StreamingJob.scala
 ---
@@ -0,0 +1,69 @@
+package ${package}
+
+/**
+  * Licensed to the Apache Software Foundation (ASF) under one
+  * or more contributor license agreements.  See the NOTICE file
+  * distributed with this work for additional information
+  * regarding copyright ownership.  The ASF licenses this file
+  * to you under the Apache License, Version 2.0 (the
+  * "License"); you may not use this file except in compliance
+  * with the License.  You may obtain a copy of the License at
+  *
+  * http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing, software
+  * distributed under the License is distributed on an "AS IS" BASIS,
+  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
+  * See the License for the specific language governing permissions and
+  * limitations under the License.
+  */
+
+import org.apache.flink.api.scala._
+
+/**
+  * Skeleton for a Flink Streaming Job.
+  *
+  * For a full example of a Flink Streaming Job, see the 
SocketTextStreamWordCount.java
+  * file in the same package/directory or have a look at the website.
+  *
+  * You can also generate a .jar file that you can submit on your Flink
+  * cluster. Just type
+  * {{{
+  *   mvn clean package
+  * }}}
+  * in the projects root directory. You will find the jar in
+  * target/flink-quickstart-0.1-SNAPSHOT.jar
+  * From the cli you can then run
+  * {{{
+  *./bin/flink run -c  
+  * }}}
+  */
+object StreamingJob {
+  def main(args: Array[String]) {
+// set up the streaming execution environment
+val env = StreamExecutionEnvironment.getExecutionEnvironment
+
+/**
+  * Here, you can start creating your execution plan for Flink.
+  *
+  * Start with getting some data from the environment, like
+  * env.readTextFile(textPath);
+  *
+  * then, transform the resulting DataSet[String] using operations
--- End diff --

Mistype here, DataStream[String] ?


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279840#comment-15279840
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

Github user tzulitai commented on a diff in the pull request:

https://github.com/apache/flink/pull/1982#discussion_r62816359
  
--- Diff: 
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/BatchJob.java
 ---
@@ -32,28 +32,29 @@
  * mvn clean package
  * in the projects root directory.
  * You will find the jar in
- * target/flink-quickstart-0.1-SNAPSHOT-Sample.jar
- *
+ * target/flink-quickstart-0.1-SNAPSHOT.jar
--- End diff --

Should we update the version in this line too?


> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279820#comment-15279820
 ] 

ASF GitHub Bot commented on FLINK-3852:
---

GitHub user markreddy opened a pull request:

https://github.com/apache/flink/pull/1982

[FLINK-3852] update the quickstart module to include a streaming skeleton

- Added skeleton StreamingJob
- Moved Job to BatchJob
- Commented out transformers for the mainClass setting with a guide to 
uncomment
- Updated java and scala docs with a guide on how to run via the cli
- Updated the site docs to include all four sample classes
- Tidied up SocketTextStreamWordCount

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/markreddy/flink 
FLINK-3852-quickstart-streaming

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/1982.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1982


commit 6cb9a098a8a4dac6a1ac2484aa00efbd41b54ebe
Author: markreddy 
Date:   2016-05-11T08:55:19Z

[FLINK-3852] added skeleton StreamingJob, moved Job to BatchJob, commented 
out transformers for the mainClass setting, tidied up SocketTextStreamWordCount 
and updated docs




> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[Tzu-Li (Gordon) Tai (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279400#comment-15279400
 ] 

Tzu-Li (Gordon) Tai commented on FLINK-3852:


Hi Mark,

I think replacing the StreamingJob skeleton as the main class doesn't match 
what this issue is aiming for.

I see 2 approaches here:

1. BatchJob skeleton and StreamingJob skeleton within same quickstart module ( 
i.e. Batch & Streaming Java / Batch & Streaming Scala)
In the javadoc within each skeleton, you can guide the user to use 
{noformat}./bin/flink run -c   
{noformat} as instructed in 
https://ci.apache.org/projects/flink/flink-docs-release-1.0/apis/cli.html.
Instead of defining a mainClass in the shade plugin, comment the transformers 
for the mainClass setting out with instructions that the user can add this back 
if they decide to simply use {noformat}./bin/flink run {noformat} with either one of the skeletons as main class entry point.

2. Have 4 separate quickstarts, i.e. Batch Java / Batch Scala / Streaming Java 
/ Streaming Scala.
I like the first approach better, since it also has a natural way of letting 
the user know that there are different submission options for a packaged Flink 
jar job.

> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[Tzu-Li (Gordon) Tai (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279399#comment-15279399
 ] 

Tzu-Li (Gordon) Tai commented on FLINK-3852:


Hi Mark,

I think replacing the StreamingJob skeleton as the main class doesn't match 
what this issue is aiming for.

I see 2 approaches here:

1. BatchJob skeleton and StreamingJob skeleton within same quickstart module ( 
i.e. Batch & Streaming Java / Batch & Streaming Scala)
In the javadoc within each skeleton, you can guide the user to use `./bin/flink 
run -c  ` as instructed in 
https://ci.apache.org/projects/flink/flink-docs-release-1.0/apis/cli.html.
Instead on defining a mainClass in the shade plugin, comment the transformers 
for the mainClass setting out with instructions that the user can add this back 
if they decide to simply use `./bin/flink run ` with either one 
of the skeletons as main class entry point.

2. Have 4 separate quickstarts, i.e. Batch Java / Batch Scala / Streaming Java 
/ Streaming Scala.

I like the first approach better, since it also has a natural way of letting 
the user know that there are different submission options for a packaged Flink 
jar job.

> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[Mark Reddy (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279155#comment-15279155
 ] 

Mark Reddy commented on FLINK-3852:
---

I can take this. 

One quick question after taking an initial look. The shade plugin specifies a 
mainClass, if we create a BatchJob and a StreamingJob skeleton would I be 
correct in saying that the main class for the packaged jar would be 
StreamingJob?

If so, for clarity would it be best to remove the following javadoc from the 
BatchJob and only have it in the StreamingJob
{noformat}
 * You can also generate a .jar file that you can submit on your Flink
 * cluster.
 * Just type
 *  mvn clean package
 * in the projects root directory.
 * You will find the jar in
 *  target/flink-quickstart-0.1-SNAPSHOT-Sample.jar
{noformat}

> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[Robert Metzger (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263819#comment-15263819
 ] 

Robert Metzger commented on FLINK-3852:
---

Yes, I think its a good idea to have a file for dataset and data stream API 
programs.

> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLINK-3852) Use a StreamExecutionEnvironment in the quickstart job skeleton

[Stefano Baghino (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263763#comment-15263763
 ] 

Stefano Baghino commented on FLINK-3852:


I agree, but would it make sense to have a quickstart for both the DataSet and 
DataStream APIs instead of replacing it completely?

> Use a StreamExecutionEnvironment in the quickstart job skeleton
> ---
>
> Key: FLINK-3852
> URL: https://issues.apache.org/jira/browse/FLINK-3852
> Project: Flink
>  Issue Type: Task
>  Components: Quickstarts
>Reporter: Robert Metzger
>  Labels: starter
>
> The Job skeleton created by the maven archetype "quickstart" is still setting 
> up an ExecutionEnvironment, not a StreamExecutionEnvironment.
> These days, most users are using Flink for streaming, so we should reflect 
> that in the quickstart as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)