[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843393#comment-15843393 ] ASF GitHub Bot commented on FLINK-4521: --- Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @uce, No worries about the long delay. Just write here if you decide to merge it and I'll rebase it. Best regards, Ivan. > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842509#comment-15842509 ] ASF GitHub Bot commented on FLINK-4521: --- Github user uce commented on the issue: https://github.com/apache/flink/pull/2431 Sorry for the long delay with this one. The jar request URL has been fixed in another PR by now. This leaves the refactoring with the util instead of manually concatenating the URL. Should we change this @iampeter? I like it, but we would have to rebase this yet again as new requests have been added in the mean time. Sorry again for the long delay. > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15663532#comment-15663532 ] ASF GitHub Bot commented on FLINK-4521: --- Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 @rmetzger @iampeter I've rebased my PR on top of mainline. > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15661515#comment-15661515 ] ASF GitHub Bot commented on FLINK-4521: --- Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2431 @mushketyk I suppose so, right @rmetzger ? > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660428#comment-15660428 ] ASF GitHub Bot commented on FLINK-4521: --- Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @iampeter Thank you for your review. Do I need to rebase this PR to merge it? > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15658085#comment-15658085 ] ASF GitHub Bot commented on FLINK-4521: --- Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2431 @mushketyk looks good, thanks. > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651797#comment-15651797 ] ASF GitHub Bot commented on FLINK-4521: --- Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @iampeter I've fixed the code according to your review. Could you please review it again? Best regards, Ivan. > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642067#comment-15642067 ] ASF GitHub Bot commented on FLINK-4521: --- Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2431 Hi @iampeter Thank you for your review and sorry for the long delay. I'll update the code in the next few days. > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[ https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15608867#comment-15608867 ] ASF GitHub Bot commented on FLINK-4521: --- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2431 @rmetzger and @iampeter What do you think about this pull request? Does this fit with the current Web UI efforts? > Fix "Submit new Job" panel in development mode > -- > > Key: FLINK-4521 > URL: https://issues.apache.org/jira/browse/FLINK-4521 > Project: Flink > Issue Type: Bug > Components: Webfrontend >Reporter: Ivan Mushketyk >Assignee: Ivan Mushketyk > > If web frontend is started in the development mode, "Submit new Job" panel is > empty. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[
https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453371#comment-15453371
]
ASF GitHub Bot commented on FLINK-4521:
---
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2448
[FLINK-4521] Enhance dashboard to show execution attempts
I've added support for displaying execution attempts in the dashboard.
The JIRA item also includes that we should add accumulators for different
attempts, but it seems that accumulators are going to be deprecated (judging
from this JIRA item https://issues.apache.org/jira/browse/FLINK-4527) so I
didn't implement that.
Here are few screenshots of the new feature:
A list of opened attempts are collapsed:
A list of opened attempts is opened:
If there is no attempts the button is not displayed:
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mushketyk/flink show-attempts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2448.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2448
commit 78dac4ea8e4a73c562ce1f96cc6a220548774314
Author: Ivan Mushketyk
Date: 2016-08-31T21:00:05Z
[FLINK-4521] Enhance dashboard to show execution attempts
> Fix "Submit new Job" panel in development mode
> --
>
> Key: FLINK-4521
> URL: https://issues.apache.org/jira/browse/FLINK-4521
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
>Reporter: Ivan Mushketyk
>Assignee: Ivan Mushketyk
>
> If web frontend is started in the development mode, "Submit new Job" panel is
> empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLINK-4521) Fix "Submit new Job" panel in development mode
[
https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443338#comment-15443338
]
ASF GitHub Bot commented on FLINK-4521:
---
GitHub user mushketyk opened a pull request:
https://github.com/apache/flink/pull/2431
[FLINK-4521] Fix "Submit new Job" panel in development mode
Submit panel was completely empty in the development mode. This happened
because client-side code sent AJAX requests to a development HTTP server
(`localhost:3000`) and not to the the JobServer (`localhost:8081`) and
development server rejected all AJAX requests.
To fix the issue I did the following:
- Updated `server.js` to pass both GET and POST requests to the JobServer
(`localhost:8081`)
- Changed all AJAX requests to use development HTTP server
- Added a helper function to build a correct URL for both dev and prod modes
Also, it seems that CoffeeScript and JavaScript code were out of sync in
the `master`, so this PR contains a significant number of changes to `index.js`.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mushketyk/flink fix-submit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2431.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2431
commit 8b4ac3453bdae08c9f59594dfaf529026fa7e1d5
Author: Ivan Mushketyk
Date: 2016-08-28T11:04:12Z
[FLINK-4521] Fix Submit panel in development mode
commit 406512b219738a721911f7709e532111c35e67fa
Author: Ivan Mushketyk
Date: 2016-08-28T11:36:00Z
[FLINK-4521] Add utils.jobServerUrl helper method
> Fix "Submit new Job" panel in development mode
> --
>
> Key: FLINK-4521
> URL: https://issues.apache.org/jira/browse/FLINK-4521
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
>Reporter: Ivan Mushketyk
>Assignee: Ivan Mushketyk
>
> If web frontend is started in the development mode, "Submit new Job" panel is
> empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
