[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550960#comment-16550960 ] ASF GitHub Bot commented on FLINK-9849: --- Github user tedyu commented on the issue: https://github.com/apache/flink/pull/6365 That would be ideal - a new connector for hbase 2.x considering that: hbase 1.x is stable hbase 2.y is newly released. > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > Attachments: hbase-2.1.0.dep > > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550957#comment-16550957 ] ASF GitHub Bot commented on FLINK-9849: --- Github user greghogan commented on the issue: https://github.com/apache/flink/pull/6365 Should this be a separate connector for HBase 2.x where we would also keep a connector for HBase 1.x? > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > Attachments: hbase-2.1.0.dep > > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[
https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550141#comment-16550141
]
Ted Yu commented on FLINK-9849:
---
I generated the dependency tree where I don't see SNAPSHOT .
Here is some occurrence of glassfish dependency:
{code}
[INFO] +- org.glassfish:javax.el:jar:3.0.1-b08:compile
[INFO] | | \- org.glassfish:javax.el:jar:3.0.1-b08:compile
[INFO] | | \- org.glassfish:javax.el:jar:3.0.1-b08:compile
[INFO] | | \- org.glassfish:javax.el:jar:3.0.1-b08:compile
{code}
> Upgrade hbase version to 2.0.1 for hbase connector
> --
>
> Key: FLINK-9849
> URL: https://issues.apache.org/jira/browse/FLINK-9849
> Project: Flink
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: zhangminglei
>Priority: Major
> Labels: pull-request-available
> Attachments: hbase-2.1.0.dep
>
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550139#comment-16550139 ] ASF GitHub Bot commented on FLINK-9849: --- Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6365 Thanks @yanghua for pointing this out! > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549081#comment-16549081 ] ASF GitHub Bot commented on FLINK-9849: --- Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6365 Hi, @yanghua I do not use a inner maven repo. It seems does not work for me.Exclude SNAPSHOT dependency and add a stable glassfish but still useless. > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549035#comment-16549035 ] ASF GitHub Bot commented on FLINK-9849: --- Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6365 seems `org.glassfish:javax.el:jar 3.0.1` has a non-SNAPSHOT version in maven repository, see here : https://mvnrepository.com/artifact/org.glassfish/javax.el/3.0.1-b10, Do you use a inner maven repository hosted in your company? If yes, maybe it forbid you to download. You can exclude this dependency in hbase and introduce a single dependency in your pom about it. > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548979#comment-16548979 ] ASF GitHub Bot commented on FLINK-9849: --- Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6365 @yanghua Could you please take on look this issue also ? > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548969#comment-16548969 ] ASF GitHub Bot commented on FLINK-9849: --- Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6365 Hi, @tedyu I found an issue when upgrade the hbase version to either 2.0.1 or 2.1.0. Both can lead problem. ```Failed to read artifact descriptor for org.glassfish:javax.el:jar 3.0.1-b06-SNAPSHOT```. And then cause some problem. Maybe because of my network? > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548654#comment-16548654 ] ASF GitHub Bot commented on FLINK-9849: --- Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6365 Thanks @yanghua you are right! I just want waiting the travis ending. then give the old and new version's dependency tree. > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[
https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548029#comment-16548029
]
ASF GitHub Bot commented on FLINK-9849:
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203439890
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void configure(Configuration parameters) {
@Override
public void open(int taskNumber, int numTasks) throws
IOException {
- table = new HTable(conf, "flinkExample");
+ Connection connection =
ConnectionFactory.createConnection(conf);
--- End diff --
I think we should add try / catch block to protect the connect leak.
> Upgrade hbase version to 2.0.1 for hbase connector
> --
>
> Key: FLINK-9849
> URL: https://issues.apache.org/jira/browse/FLINK-9849
> Project: Flink
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: zhangminglei
>Priority: Major
> Labels: pull-request-available
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[
https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548031#comment-16548031
]
ASF GitHub Bot commented on FLINK-9849:
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203439859
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void configure(Configuration parameters) {
@Override
public void open(int taskNumber, int numTasks) throws
IOException {
- table = new HTable(conf, "flinkExample");
+ Connection connection =
ConnectionFactory.createConnection(conf);
--- End diff --
I think we should add try / catch block to protect the connect leak.
> Upgrade hbase version to 2.0.1 for hbase connector
> --
>
> Key: FLINK-9849
> URL: https://issues.apache.org/jira/browse/FLINK-9849
> Project: Flink
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: zhangminglei
>Priority: Major
> Labels: pull-request-available
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[
https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548030#comment-16548030
]
ASF GitHub Bot commented on FLINK-9849:
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203440989
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void configure(Configuration parameters) {
@Override
public void open(int taskNumber, int numTasks) throws
IOException {
- table = new HTable(conf, "flinkExample");
+ Connection connection =
ConnectionFactory.createConnection(conf);
--- End diff --
Based on [HBase Connection
JavaDoc](https://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Connection.html#close--)
it seems the caller should invoke `close` method to release resource? so I
suggest we should close connection in udf's `close` method.
> Upgrade hbase version to 2.0.1 for hbase connector
> --
>
> Key: FLINK-9849
> URL: https://issues.apache.org/jira/browse/FLINK-9849
> Project: Flink
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: zhangminglei
>Priority: Major
> Labels: pull-request-available
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[
https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548027#comment-16548027
]
ASF GitHub Bot commented on FLINK-9849:
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203438579
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
@@ -81,7 +85,9 @@ private HTable createTable() {
org.apache.hadoop.conf.Configuration hConf =
HBaseConfiguration.create();
try {
- return new HTable(hConf, getTableName());
+ Connection connection =
ConnectionFactory.createConnection(hConf);
+ Table table =
connection.getTable(TableName.valueOf(getTableName()));
+ return (HTable) table;
--- End diff --
I think we should release the connection when happens exception
> Upgrade hbase version to 2.0.1 for hbase connector
> --
>
> Key: FLINK-9849
> URL: https://issues.apache.org/jira/browse/FLINK-9849
> Project: Flink
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: zhangminglei
>Priority: Major
> Labels: pull-request-available
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[
https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548028#comment-16548028
]
ASF GitHub Bot commented on FLINK-9849:
---
Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6365#discussion_r203439523
--- Diff:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java
---
@@ -87,22 +90,22 @@ public void configure(Configuration parameters) {
@Override
public void open(int taskNumber, int numTasks) throws
IOException {
- table = new HTable(conf, "flinkExample");
+ Connection connection =
ConnectionFactory.createConnection(conf);
--- End diff --
I think we should add try / catch block to protect the connect leak.
> Upgrade hbase version to 2.0.1 for hbase connector
> --
>
> Key: FLINK-9849
> URL: https://issues.apache.org/jira/browse/FLINK-9849
> Project: Flink
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: zhangminglei
>Priority: Major
> Labels: pull-request-available
>
> Currently hbase 1.4.3 is used for hbase connector.
> We should upgrade to 2.0.1 which was recently released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547862#comment-16547862 ] ASF GitHub Bot commented on FLINK-9849: --- GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/6365 [FLINK-9849] [hbase] Hbase upgrade ## What is the purpose of the change Upgrade hbase version to 2.0.1 for hbase connector You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-9849-hbase-upgrade Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6365.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6365 commit cb4bc4b641565e6caf823e85d541df3022a59237 Author: zhangminglei Date: 2018-07-18T13:44:37Z [FLINK-9849] [hbase] Hbase upgrade > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > Labels: pull-request-available > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547342#comment-16547342 ] zhangminglei commented on FLINK-9849: - Hi, [~yuzhih...@gmail.com] Is the problem raised by this FLINK-2153 solved ? hbase-annotations module issue. Thank you. > Upgrade hbase version to 2.0.1 for hbase connector > -- > > Key: FLINK-9849 > URL: https://issues.apache.org/jira/browse/FLINK-9849 > Project: Flink > Issue Type: Improvement >Reporter: Ted Yu >Assignee: zhangminglei >Priority: Major > > Currently hbase 1.4.3 is used for hbase connector. > We should upgrade to 2.0.1 which was recently released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
