[jira] [Commented] (GEODE-8197) Embedded Pulse fails to start with custom log4j2.xml
[
https://issues.apache.org/jira/browse/GEODE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127450#comment-17127450
]
ASF GitHub Bot commented on GEODE-8197:
---
onichols-pivotal commented on a change in pull request #5196:
URL: https://github.com/apache/geode/pull/5196#discussion_r436309760
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithCustomLogConfigAcceptanceTest.java
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.launchers;
+
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.util.ResourceUtils.createFileFromResource;
+import static org.apache.geode.test.util.ResourceUtils.getResource;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.test.assertj.LogFileAssert;
+import org.apache.geode.test.junit.rules.RequiresGeodeHome;
+
+public class LocatorLauncherWithCustomLogConfigAcceptanceTest {
+
+ private static final String CONFIG_FILE_NAME =
+ "LocatorLauncherWithCustomLogConfigAcceptanceTest.xml";
+ private static final String LOCATOR_NAME = "the-locator";
+
+ private int locatorPort;
+ private Path configFile;
+ private Process locator;
+ private Path geodeDependencies;
+ private Path stdoutFile;
+ private Path locatorLogFile;
+ private Path pulseLogFile;
+
+ @Rule
+ public RequiresGeodeHome requiresGeodeHome = new RequiresGeodeHome();
+ @Rule
+ public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ @Before
+ public void setUpLogConfigFile() {
+configFile = createFileFromResource(getResource(CONFIG_FILE_NAME),
temporaryFolder.getRoot(),
+CONFIG_FILE_NAME)
+.toPath();
+ }
+
+ @Before
+ public void setUpGeodeDependencies() {
+Path geodeHome = requiresGeodeHome.getGeodeHome().toPath();
+geodeDependencies = geodeHome.resolve("lib/geode-dependencies.jar");
+
+assertThat(geodeDependencies).exists();
+ }
+
+ @Before
+ public void setUpOutputFiles() {
+stdoutFile = temporaryFolder.getRoot().toPath().resolve("stdout.txt");
+locatorLogFile = temporaryFolder.getRoot().toPath().resolve(LOCATOR_NAME +
".log");
+pulseLogFile = temporaryFolder.getRoot().toPath().resolve("pulse.log");
+ }
+
+ @Before
+ public void setUpRandomPorts() {
+locatorPort = AvailablePortHelper.getRandomAvailableTCPPort();
+ }
+
+ @After
+ public void stopLocator() throws Exception {
+if (locator != null) {
+ locator.destroyForcibly().waitFor(4, TimeUnit.SECONDS);
+}
+ }
+
+ @Test
+ public void locatorLauncherUsesLog4jConfigurationFile() throws Exception {
+ProcessBuilder processBuilder = new ProcessBuilder()
+.redirectErrorStream(true)
+.redirectOutput(stdoutFile.toFile())
+.directory(temporaryFolder.getRoot())
+.command("java",
Review comment:
If system property java.home is defined, please use
`System.getProperty("java.home")+"/bin/java"` instead. Only use `java` if
system property java.home is not defined
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Embedded Pulse fails to start with custom log4j2.xml
>
>
> Key: GEODE-8197
> URL: https://issues.apache.org/jira/browse/GEODE-8197
> Project: Geode
> Issue Type: Bug
> Components: logging, pulse
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
[jira] [Commented] (GEODE-8159) Cache boost dependency for CI, builds
[ https://issues.apache.org/jira/browse/GEODE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127437#comment-17127437 ] ASF subversion and git services commented on GEODE-8159: Commit c4fb6b53cd2b5683ccb04515d5da1ffbbdbc7b72 in geode-native's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=c4fb6b5 ] GEODE-8159: Adds sourceforge as alternative download source for Boost. (#614) > Cache boost dependency for CI, builds > - > > Key: GEODE-8159 > URL: https://issues.apache.org/jira/browse/GEODE-8159 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Blake Bender >Assignee: Jacob Barrett >Priority: Major > > Boost has monthly bandwidth caps for downloads, which means if they hit their > cap we can't run CI again until the first of the month. It would benefit > both us and the boost folks greatly if we were to simply set up a job that > downloads boost, say, once per day and caches it in a storage bucket that we > own, then have our builds all retrieve it from there. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8159) Cache boost dependency for CI, builds
[ https://issues.apache.org/jira/browse/GEODE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127438#comment-17127438 ] ASF GitHub Bot commented on GEODE-8159: --- pivotal-jbarrett merged pull request #614: URL: https://github.com/apache/geode-native/pull/614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cache boost dependency for CI, builds > - > > Key: GEODE-8159 > URL: https://issues.apache.org/jira/browse/GEODE-8159 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Blake Bender >Assignee: Jacob Barrett >Priority: Major > > Boost has monthly bandwidth caps for downloads, which means if they hit their > cap we can't run CI again until the first of the month. It would benefit > both us and the boost folks greatly if we were to simply set up a job that > downloads boost, say, once per day and caches it in a storage bucket that we > own, then have our builds all retrieve it from there. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Ivanac updated GEODE-7414:
Fix Version/s: 1.14.0
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Ivanac resolved GEODE-7414.
-
Resolution: Fixed
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127134#comment-17127134
]
ASF subversion and git services commented on GEODE-7414:
Commit 917f4c921c9c9fb3b19687ee67fe0dfe4f885056 in geode's branch
refs/heads/develop from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=917f4c9 ]
Feature/GEODE-7414_2_redo (#5115)
* GEODE-7414_2: modify init() method argument (#5040)
(cherry picked from commit 5f9800b291d3a11140eb5a1a972459207e07b50c)
* Add exemption for SSLParameterExtension API change
Following feedback on the SSLParameterExtension
Accept a map of as a more definite set of inputs than
'Properties'. Extend as needed.
Authored-by: Robert Houghton
* Applying feedback to use a real class to hold TLS context
* move SSLParameterExtensionContextImpl to an internal package
* prune un-needed value from exception list
* fixup - remove now-internal javadoc from assembly
Co-authored-by: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8223) Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
[ https://issues.apache.org/jira/browse/GEODE-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127133#comment-17127133 ] ASF GitHub Bot commented on GEODE-8223: --- davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436181874 ## File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb ## @@ -2197,6 +2197,9 @@ gfsh Advantages of <%=vars.product_name%> over Redis Review comment: Not part of this PR, but a potential problem. We use template variables to allow portability to other products that use the geode open-source repo. Use in section names (such as "Advantages of <%=vars.product_name%>..." follows this intention. However, use in target ids (such as "#advantages-of-<%=vars.product_name_lowercase%>-over-redis") defeats the purpose, as the links are almost certainly guaranteed to fail in other contexts. The anchor tags should be genericized, for example "advantages-over-redis". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update documentation of expiration accuracy as well as supported, > unsupported, and unimplemented commands in Redis API for Geode docs > - > > Key: GEODE-8223 > URL: https://issues.apache.org/jira/browse/GEODE-8223 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > > Update documentation to match changes in Redis API for Geode. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127135#comment-17127135
]
ASF subversion and git services commented on GEODE-7414:
Commit 917f4c921c9c9fb3b19687ee67fe0dfe4f885056 in geode's branch
refs/heads/develop from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=917f4c9 ]
Feature/GEODE-7414_2_redo (#5115)
* GEODE-7414_2: modify init() method argument (#5040)
(cherry picked from commit 5f9800b291d3a11140eb5a1a972459207e07b50c)
* Add exemption for SSLParameterExtension API change
Following feedback on the SSLParameterExtension
Accept a map of as a more definite set of inputs than
'Properties'. Extend as needed.
Authored-by: Robert Houghton
* Applying feedback to use a real class to hold TLS context
* move SSLParameterExtensionContextImpl to an internal package
* prune un-needed value from exception list
* fixup - remove now-internal javadoc from assembly
Co-authored-by: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8223) Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
[ https://issues.apache.org/jira/browse/GEODE-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127127#comment-17127127 ] ASF GitHub Bot commented on GEODE-8223: --- davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436178644 ## File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb ## @@ -60,30 +65,52 @@ If the server is functioning properly, you should see a response of `PONG`. The Redis API for <%=vars.product_name%> currently supports the following commands. See [Redis commands](https://redis.io/commands/) for a complete list of and more information on Redis commands. -- **Strings**: APPEND, GET, GETRANGE, SET +**Note**: These commands are supported for Redis 5. + +- **Connection**: AUTH, PING, QUIT - **Hashes**: HGETALL, HMSET, HSET -- **Sets**: SADD, SMEMBERS, SREM +- **Keys**: DEL, EXISTS, EXPIRE, EXPIREAT, KEYS, PERSIST, PEXPIRE, PEXPIREAT, PTTL, RENAME, TTL, TYPE - **Publish/Subscribe**: PUBLISH, PSUBSCRIBE, PUNSUBSCRIBE, SUBSCRIBE, UNSUBSCRIBE -- **Keys**: DEL, EXISTS, EXPIRE, PERSIST, PEXPIRE, PEXPIREAT, RENAME +- **Sets**: SADD, SMEMBERS, SREM +- **Strings**: APPEND, GET, SET -The following Redis API for <%=vars.product_name%> commands are **experimental**: +The following Redis API for <%=vars.product_name%> commands are **unsupported**. Unsupported +commands are available to use, but have not been fully tested. There is no guarantee they will work +exactly as expected. -- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET, - MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, STRLEN -- **Lists**: LINDEX, LLEN, LPOP, LPUSH, LPUSHX, LRANGE, LREM, LSET, LTRIM, RPOP, RPUSH, RPUSHX -- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HMGET, HSETNX, HLEN, HSCAN, HVALS +- **Connection**: ECHO +- **Hashes**: HDEL, HEXISTS, HGET, HINCRBY, HINCRBYFLOAT, HKEYS, HLEN, HMGET, HSCAN, HSETNX, HVALS +- **Keys**: SCAN +- **Server**: DBSIZE, FLUSHALL (no async option), FLUSHDB (no async option), SHUTDOWN, TIME - **Sets**: SCARD, SDIFF, SDIFFSTORE, SINTER, SINTERSTORE, SISMEMBER, SMOVE, SPOP, SRANDMEMBER, SSCAN, SUNION, SUNIONSTORE -- **SortedSets**: ZADD, ZCARD, ZCOUNT, ZINCRBY, ZLEXCOUNT, ZRANGE, ZRANGEBYLEX, ZRANGEBYSCORE, - ZRANK, ZREM, ZREMRANGEBYLEX, ZREMRANGEBYRANK, ZREMRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE, - ZREVRANK, ZSCAN, ZSCORE -- **HyperLogLog**: PFADD, PFCOUNT, PFMERGE -- **Keys**: DBSIZE, EXPIREAT, FLUSHDB, FLUSHALL, KEYS, PTTL, SCAN, TTL -- **Transactions**: DISCARD, EXEC, MULTI -- **Server**: AUTH, ECHO, PING, QUIT +- **Strings**: BITCOUNT, BITOP, BITPOS, DECR, DECRBY, GETBIT, GETRANGE, GETSET, INCR, INCRBY, INCRBYFLOAT, MGET, + MSET, MSETNX, PSETEX, SETBIT, SETEX, SETNX, SETRANGE, STRLEN + + +To enable unsupported commands, the Geode server must be started with the Java property `enable-redis-unsupported-commands=true`: + +```pre +start server \ + --J=-Denable-redis-unsupported-commands=true \ + --name= \ + --locators= \ + --redis-port= \ + --redis-bind-address= \ + --redis-password= +``` + +Commands not listed above are **not implemented**. ## Advantages of <%=vars.product_name%> over Redis <%=vars.product_name%>’s primary advantage is its **scalability**. While the Redis server is single threaded, <%=vars.product_name%> supports high concurrency. Many Redis clients can execute commands on the <%=vars.product_name%> cluster simultaneously. -<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client. \ No newline at end of file +<%=vars.product_name%>'s architecture and management features help detect and resolve **network partitioning** problems without explicit management on the part of the Redis client. + +## Expiration Accuracy + +Keys are expired in two ways, actively and passively: + +- Expiration is evaluated whenever a key is accessed. If the key is due to expire, it is deleted. Active expiration is accurate to the millisecond. Review comment: For clarity, please begin each bullet with the type of expiration it explains. A bit more stilted, stylistically, but worth it I think for ease of apprehension. Something like this: - With active expiration, expiration is evaluated.. - With passive expiration, keys are evaluated every second... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update documentation of expiration accuracy as well as supported,
[jira] [Commented] (GEODE-8223) Update documentation of expiration accuracy as well as supported, unsupported, and unimplemented commands in Redis API for Geode docs
[ https://issues.apache.org/jira/browse/GEODE-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127130#comment-17127130 ] ASF GitHub Bot commented on GEODE-8223: --- davebarnes97 commented on a change in pull request #5214: URL: https://github.com/apache/geode/pull/5214#discussion_r436181874 ## File path: geode-book/master_middleman/source/subnavs/geode-subnav.erb ## @@ -2197,6 +2197,9 @@ gfsh Advantages of <%=vars.product_name%> over Redis Review comment: Not part of this PR, but a potential problem. We use template variables to allow portability to other products that use the geode open-source repo. Use in section names (such as "Advantages of <%=vars.product_name%>..." follows this intention. However, use in target ids (such as "#advantages-of-<%=vars.product_name_lowercase%>-over-redis") defeats the purpose, as the links are almost certainly guaranteed to fail in other contexts. The hash tags should be genericized, for example "advantages-over-redis". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update documentation of expiration accuracy as well as supported, > unsupported, and unimplemented commands in Redis API for Geode docs > - > > Key: GEODE-8223 > URL: https://issues.apache.org/jira/browse/GEODE-8223 > Project: Geode > Issue Type: Improvement > Components: docs, redis >Reporter: Sarah Abbey >Priority: Major > > Update documentation to match changes in Redis API for Geode. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6901) If a region is replicate and replicate persistent in different members and a replicate persistent member crashes, the replicate members throw a ToDataException attempti
[
https://issues.apache.org/jira/browse/GEODE-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127190#comment-17127190
]
ASF subversion and git services commented on GEODE-6901:
Commit 5fffb15203d4b9fe988606e126eee246d9a2fb60 in geode's branch
refs/heads/feature/GEODE-6901 from Barry Oglesby
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5fffb15 ]
GEODE-6901: Modified RegionVersionVector to handle a mix of VersionSources
> If a region is replicate and replicate persistent in different members and a
> replicate persistent member crashes, the replicate members throw a
> ToDataException attempting to synchronize the region
>
>
> Key: GEODE-6901
> URL: https://issues.apache.org/jira/browse/GEODE-6901
> Project: Geode
> Issue Type: Bug
> Components: persistence, regions
>Reporter: Barrett Oglesby
>Priority: Major
>
> If a region is replicate and replicate persistent in different members and a
> replicate persistent member crashes, the replicate members throw a
> ToDataException attempting to synchronize the region
> In this case, an exception like this is thrown in the replicate member:
> {noformat}
> [warn 2019/06/21 17:06:33.516 PDT tid=0x2b] Timer task
> encountered
> exception
> org.apache.geode.ToDataException: class
> org.apache.geode.internal.cache.versions.VMRegionVersionVector
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2331)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1492)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2067)
> at org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2943)
> at
> org.apache.geode.internal.cache.InitialImageOperation$RequestImageMessage.toData(InitialImageOperation.java:2135)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2300)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1492)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:242)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:385)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:241)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:596)
> at
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.directChannelSend(GMSMembershipManager.java:1711)
> at
> org.apache.geode.distributed.internal.membership.gms.mgr.GMSMembershipManager.send(GMSMembershipManager.java:1892)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2852)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:2779)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2816)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1526)
> at
> org.apache.geode.internal.cache.InitialImageOperation.synchronizeWith(InitialImageOperation.java:649)
> at
> org.apache.geode.internal.cache.DistributedRegion.synchronizeWith(DistributedRegion.java:1321)
> at
> org.apache.geode.internal.cache.DistributedRegion.synchronizeForLostMember(DistributedRegion.java:1310)
> at
> org.apache.geode.internal.cache.DistributedRegion.performSynchronizeForLostMemberTask(DistributedRegion.java:1295)
> at
> org.apache.geode.internal.cache.DistributedRegion$1.run2(DistributedRegion.java:1285)
> at
> org.apache.geode.internal.SystemTimer$SystemTimerTask.run(SystemTimer.java:445)
> at java.util.TimerThread.mainLoop(Timer.java:555)
> at java.util.TimerThread.run(Timer.java:505)
> Caused by: java.lang.ClassCastException:
> org.apache.geode.internal.cache.persistence.DiskStoreID cannot be cast to
> org.apache.geode.distributed.internal.membership.InternalDistributedMember
> at
> org.apache.geode.internal.cache.versions.VMRegionVersionVector.writeMember(VMRegionVersionVector.java:31)
> at
> org.apache.geode.internal.cache.versions.RegionVersionVector.toData(RegionVersionVector.java:1204)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2300)
> ... 24 more
> {noformat}
> RegionVersionVector.java:1204 is here:
> {noformat}
> for (Map.Entry> entry :
> this.memberToVersion.entrySet()) {
> ->
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127191#comment-17127191
]
ASF GitHub Bot commented on GEODE-8173:
---
agingade commented on a change in pull request #5208:
URL: https://github.com/apache/geode/pull/5208#discussion_r436215854
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java
##
@@ -0,0 +1,598 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.catchThrowable;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.distributed.DistributedLockService;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.DistributionManager;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.distributed.internal.MembershipListener;
+import
org.apache.geode.distributed.internal.membership.InternalDistributedMember;
+import org.apache.geode.internal.cache.partitioned.RegionAdvisor;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+
+public class PartitionedRegionClearTest {
+
+
+ private PartitionedRegionClear partitionedRegionClear;
+ private DistributionManager distributionManager;
+ private PartitionedRegion partitionedRegion;
+
+ @Before
+ public void setUp() {
+
+partitionedRegion = mock(PartitionedRegion.class);
+distributionManager = mock(DistributionManager.class);
+
+
when(partitionedRegion.getDistributionManager()).thenReturn(distributionManager);
+when(partitionedRegion.getName()).thenReturn("prRegion");
+
+partitionedRegionClear = new PartitionedRegionClear(partitionedRegion);
+ }
+
+ private Set setupBucketRegions(
+ PartitionedRegionDataStore partitionedRegionDataStore,
+ BucketAdvisor bucketAdvisor) {
+final int numBuckets = 2;
+HashSet bucketRegions = new HashSet<>();
+for (int i = 0; i < numBuckets; i++) {
+ BucketRegion bucketRegion = mock(BucketRegion.class);
+ when(bucketRegion.getBucketAdvisor()).thenReturn(bucketAdvisor);
+ when(bucketRegion.size()).thenReturn(1);
+ when(bucketRegion.getId()).thenReturn(i);
+ bucketRegions.add(bucketRegion);
+}
+
+
when(partitionedRegionDataStore.getAllLocalBucketRegions()).thenReturn(bucketRegions);
+
when(partitionedRegionDataStore.getAllLocalPrimaryBucketRegions()).thenReturn(bucketRegions);
+
+return bucketRegions;
+ }
+
+ @Test
+ public void isLockedForListenerAndClientNotificationReturnsTrueWhenLocked() {
+InternalDistributedMember internalDistributedMember =
mock(InternalDistributedMember.class);
+
when(distributionManager.isCurrentMember(internalDistributedMember)).thenReturn(true);
+partitionedRegionClear.obtainClearLockLocal(internalDistributedMember);
+
+
assertThat(partitionedRegionClear.isLockedForListenerAndClientNotification()).isTrue();
+ }
+
+ @Test
+ public void
isLockedForListenerAndClientNotificationReturnsFalseWhenMemberNotInTheSystemRequestsLock()
{
+InternalDistributedMember internalDistributedMember =
mock(InternalDistributedMember.class);
+
when(distributionManager.isCurrentMember(internalDistributedMember)).thenReturn(false);
+
+
assertThat(partitionedRegionClear.isLockedForListenerAndClientNotification()).isFalse();
+ }
+
+ @Test
+ public void
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127192#comment-17127192
]
ASF GitHub Bot commented on GEODE-8173:
---
agingade commented on a change in pull request #5208:
URL: https://github.com/apache/geode/pull/5208#discussion_r436215906
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java
##
@@ -0,0 +1,598 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.catchThrowable;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.distributed.DistributedLockService;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.DistributionManager;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.distributed.internal.MembershipListener;
+import
org.apache.geode.distributed.internal.membership.InternalDistributedMember;
+import org.apache.geode.internal.cache.partitioned.RegionAdvisor;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+
+public class PartitionedRegionClearTest {
+
+
+ private PartitionedRegionClear partitionedRegionClear;
+ private DistributionManager distributionManager;
+ private PartitionedRegion partitionedRegion;
+
+ @Before
+ public void setUp() {
+
+partitionedRegion = mock(PartitionedRegion.class);
+distributionManager = mock(DistributionManager.class);
+
+
when(partitionedRegion.getDistributionManager()).thenReturn(distributionManager);
+when(partitionedRegion.getName()).thenReturn("prRegion");
+
+partitionedRegionClear = new PartitionedRegionClear(partitionedRegion);
+ }
+
+ private Set setupBucketRegions(
+ PartitionedRegionDataStore partitionedRegionDataStore,
+ BucketAdvisor bucketAdvisor) {
+final int numBuckets = 2;
+HashSet bucketRegions = new HashSet<>();
+for (int i = 0; i < numBuckets; i++) {
+ BucketRegion bucketRegion = mock(BucketRegion.class);
+ when(bucketRegion.getBucketAdvisor()).thenReturn(bucketAdvisor);
+ when(bucketRegion.size()).thenReturn(1);
+ when(bucketRegion.getId()).thenReturn(i);
+ bucketRegions.add(bucketRegion);
+}
+
+
when(partitionedRegionDataStore.getAllLocalBucketRegions()).thenReturn(bucketRegions);
+
when(partitionedRegionDataStore.getAllLocalPrimaryBucketRegions()).thenReturn(bucketRegions);
+
+return bucketRegions;
+ }
+
+ @Test
+ public void isLockedForListenerAndClientNotificationReturnsTrueWhenLocked() {
+InternalDistributedMember internalDistributedMember =
mock(InternalDistributedMember.class);
+
when(distributionManager.isCurrentMember(internalDistributedMember)).thenReturn(true);
+partitionedRegionClear.obtainClearLockLocal(internalDistributedMember);
+
+
assertThat(partitionedRegionClear.isLockedForListenerAndClientNotification()).isTrue();
+ }
+
+ @Test
+ public void
isLockedForListenerAndClientNotificationReturnsFalseWhenMemberNotInTheSystemRequestsLock()
{
+InternalDistributedMember internalDistributedMember =
mock(InternalDistributedMember.class);
+
when(distributionManager.isCurrentMember(internalDistributedMember)).thenReturn(false);
+
+
assertThat(partitionedRegionClear.isLockedForListenerAndClientNotification()).isFalse();
+ }
+
+ @Test
+ public void
[jira] [Assigned] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols reassigned GEODE-8230: --- Assignee: Owen Nichols > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8095) Create restore redundancy and status redundancy REST API commands
[ https://issues.apache.org/jira/browse/GEODE-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127145#comment-17127145 ] ASF GitHub Bot commented on GEODE-8095: --- mhansonp commented on pull request #5195: URL: https://github.com/apache/geode/pull/5195#issuecomment-639888115 Taking a different path. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create restore redundancy and status redundancy REST API commands > - > > Key: GEODE-8095 > URL: https://issues.apache.org/jira/browse/GEODE-8095 > Project: Geode > Issue Type: Bug > Components: rest (admin) >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add two REST API commands to allow redundancy to be restored and to check the > current redundancy status. > Similar to: https://issues.apache.org/jira/browse/GEODE-7954 > More on restore redundancy can be found at > https://cwiki.apache.org/confluence/display/GEODE/Redundancy+Gfsh+Commands -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8197) Embedded Pulse fails to start with custom log4j2.xml
[
https://issues.apache.org/jira/browse/GEODE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127123#comment-17127123
]
ASF GitHub Bot commented on GEODE-8197:
---
kirklund commented on a change in pull request #5196:
URL: https://github.com/apache/geode/pull/5196#discussion_r436186564
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest.java
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.launchers;
+
+import static java.nio.file.Files.copy;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.util.ResourceUtils.createFileFromResource;
+import static org.apache.geode.test.util.ResourceUtils.getResource;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.test.assertj.LogFileAssert;
+import org.apache.geode.test.junit.rules.RequiresGeodeHome;
+
+public class LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest {
+
+ private static final String CONFIG_WITH_GEODE_PLUGINS_FILE_NAME =
+
"LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTestWithGeodePlugins.xml";
+ private static final String CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME =
+
"LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTestWithoutGeodePlugins.xml";
+ private static final String LOCATOR_NAME = "the-locator";
+
+ private int locatorPort;
+ private int httpServicePort;
+ private Path configWithGeodePluginsFile;
+ private Path configWithoutGeodePluginsFile;
+ private Process locator;
+ private Path geodeDependencies;
+ private Path stdoutFile;
+ private Path locatorLogFile;
+ private Path pulseLogFile;
+
+ @Rule
+ public RequiresGeodeHome requiresGeodeHome = new RequiresGeodeHome();
+ @Rule
+ public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ @Before
+ public void setUpLogConfigFiles() {
+configWithGeodePluginsFile = createFileFromResource(
+getResource(CONFIG_WITH_GEODE_PLUGINS_FILE_NAME),
temporaryFolder.getRoot(),
+CONFIG_WITH_GEODE_PLUGINS_FILE_NAME)
+.toPath();
+
+configWithoutGeodePluginsFile = createFileFromResource(
+getResource(CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME),
temporaryFolder.getRoot(),
+CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME)
+.toPath();
+ }
+
+ @Before
+ public void setUpGeodeDependencies() {
+Path geodeHome = requiresGeodeHome.getGeodeHome().toPath();
+geodeDependencies = geodeHome.resolve("lib/geode-dependencies.jar");
+
+assertThat(geodeDependencies).exists();
+ }
+
+ @Before
+ public void setUpOutputFiles() {
+stdoutFile = temporaryFolder.getRoot().toPath().resolve("stdout.txt");
+locatorLogFile = temporaryFolder.getRoot().toPath().resolve(LOCATOR_NAME +
".log");
+pulseLogFile = temporaryFolder.getRoot().toPath().resolve("pulse.log");
+ }
+
+ @Before
+ public void setUpRandomPorts() {
+int[] ports = AvailablePortHelper.getRandomAvailableTCPPorts(2);
+locatorPort = ports[0];
+httpServicePort = ports[1];
+ }
+
+ @After
+ public void stopLocator() throws Exception {
+if (locator != null) {
+ locator.destroyForcibly().waitFor(4, TimeUnit.SECONDS);
+}
+ }
+
+ @Test
+ public void locatorLauncherUsesSpecifiedConfigFileWithoutGeodePlugins()
throws Exception {
+ProcessBuilder processBuilder = new ProcessBuilder()
+.redirectErrorStream(true)
+.redirectOutput(stdoutFile.toFile())
+.directory(temporaryFolder.getRoot())
+.command("java",
+"-Dgemfire.http-service-port=" + httpServicePort,
+"-Dgemfire.jmx-manager-start=true",
+"-Djava.awt.headless=true",
+"-Dlog4j.configurationFile=" +
[jira] [Commented] (GEODE-8197) Embedded Pulse fails to start with custom log4j2.xml
[
https://issues.apache.org/jira/browse/GEODE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127124#comment-17127124
]
ASF GitHub Bot commented on GEODE-8197:
---
kirklund commented on a change in pull request #5196:
URL: https://github.com/apache/geode/pull/5196#discussion_r436186564
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest.java
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.launchers;
+
+import static java.nio.file.Files.copy;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.util.ResourceUtils.createFileFromResource;
+import static org.apache.geode.test.util.ResourceUtils.getResource;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.test.assertj.LogFileAssert;
+import org.apache.geode.test.junit.rules.RequiresGeodeHome;
+
+public class LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest {
+
+ private static final String CONFIG_WITH_GEODE_PLUGINS_FILE_NAME =
+
"LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTestWithGeodePlugins.xml";
+ private static final String CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME =
+
"LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTestWithoutGeodePlugins.xml";
+ private static final String LOCATOR_NAME = "the-locator";
+
+ private int locatorPort;
+ private int httpServicePort;
+ private Path configWithGeodePluginsFile;
+ private Path configWithoutGeodePluginsFile;
+ private Process locator;
+ private Path geodeDependencies;
+ private Path stdoutFile;
+ private Path locatorLogFile;
+ private Path pulseLogFile;
+
+ @Rule
+ public RequiresGeodeHome requiresGeodeHome = new RequiresGeodeHome();
+ @Rule
+ public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ @Before
+ public void setUpLogConfigFiles() {
+configWithGeodePluginsFile = createFileFromResource(
+getResource(CONFIG_WITH_GEODE_PLUGINS_FILE_NAME),
temporaryFolder.getRoot(),
+CONFIG_WITH_GEODE_PLUGINS_FILE_NAME)
+.toPath();
+
+configWithoutGeodePluginsFile = createFileFromResource(
+getResource(CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME),
temporaryFolder.getRoot(),
+CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME)
+.toPath();
+ }
+
+ @Before
+ public void setUpGeodeDependencies() {
+Path geodeHome = requiresGeodeHome.getGeodeHome().toPath();
+geodeDependencies = geodeHome.resolve("lib/geode-dependencies.jar");
+
+assertThat(geodeDependencies).exists();
+ }
+
+ @Before
+ public void setUpOutputFiles() {
+stdoutFile = temporaryFolder.getRoot().toPath().resolve("stdout.txt");
+locatorLogFile = temporaryFolder.getRoot().toPath().resolve(LOCATOR_NAME +
".log");
+pulseLogFile = temporaryFolder.getRoot().toPath().resolve("pulse.log");
+ }
+
+ @Before
+ public void setUpRandomPorts() {
+int[] ports = AvailablePortHelper.getRandomAvailableTCPPorts(2);
+locatorPort = ports[0];
+httpServicePort = ports[1];
+ }
+
+ @After
+ public void stopLocator() throws Exception {
+if (locator != null) {
+ locator.destroyForcibly().waitFor(4, TimeUnit.SECONDS);
+}
+ }
+
+ @Test
+ public void locatorLauncherUsesSpecifiedConfigFileWithoutGeodePlugins()
throws Exception {
+ProcessBuilder processBuilder = new ProcessBuilder()
+.redirectErrorStream(true)
+.redirectOutput(stdoutFile.toFile())
+.directory(temporaryFolder.getRoot())
+.command("java",
+"-Dgemfire.http-service-port=" + httpServicePort,
+"-Dgemfire.jmx-manager-start=true",
+"-Djava.awt.headless=true",
+"-Dlog4j.configurationFile=" +
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127188#comment-17127188
]
ASF GitHub Bot commented on GEODE-8173:
---
agingade commented on a change in pull request #5208:
URL: https://github.com/apache/geode/pull/5208#discussion_r436214984
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##
@@ -10269,4 +10269,8 @@ boolean hasAnyClientsInterested() {
return (getRegionAdvisor().hasPRServerWithInterest()
|| getRegionAdvisor().hasPRServerWithCQs());
}
+
+ boolean isTransactionDistributed() {
Review comment:
Removed the change.
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java
##
@@ -0,0 +1,598 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.catchThrowable;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.distributed.DistributedLockService;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.DistributionManager;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.distributed.internal.MembershipListener;
+import
org.apache.geode.distributed.internal.membership.InternalDistributedMember;
+import org.apache.geode.internal.cache.partitioned.RegionAdvisor;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+
+public class PartitionedRegionClearTest {
+
+
+ private PartitionedRegionClear partitionedRegionClear;
+ private DistributionManager distributionManager;
+ private PartitionedRegion partitionedRegion;
+
+ @Before
+ public void setUp() {
+
+partitionedRegion = mock(PartitionedRegion.class);
+distributionManager = mock(DistributionManager.class);
+
+
when(partitionedRegion.getDistributionManager()).thenReturn(distributionManager);
+when(partitionedRegion.getName()).thenReturn("prRegion");
+
+partitionedRegionClear = new PartitionedRegionClear(partitionedRegion);
+ }
+
+ private Set setupBucketRegions(
+ PartitionedRegionDataStore partitionedRegionDataStore,
+ BucketAdvisor bucketAdvisor) {
+final int numBuckets = 2;
+HashSet bucketRegions = new HashSet<>();
Review comment:
Modified in the latest checkin
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache/ReplicateCacheListenerDistributedTest.java
##
@@ -179,7 +180,13 @@ public void afterRegionDestroyIsInvokedInEveryMember() {
region.destroyRegion();
-
assertThat(sharedCountersRule.getTotal(REGION_DESTROY)).isEqualTo(expectedRegionDestroys());
+if (region instanceof PartitionedRegion) {
Review comment:
Separated the PRCacheListenerDistributedTest
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add test coverage for PartitionedRegionClear class
> --
>
> Key: GEODE-8173
> URL: https://issues.apache.org/jira/browse/GEODE-8173
> Project: Geode
> Issue Type: Bug
>
[jira] [Commented] (GEODE-8197) Embedded Pulse fails to start with custom log4j2.xml
[
https://issues.apache.org/jira/browse/GEODE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127122#comment-17127122
]
ASF GitHub Bot commented on GEODE-8197:
---
kirklund commented on a change in pull request #5196:
URL: https://github.com/apache/geode/pull/5196#discussion_r436186564
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/launchers/LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest.java
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.launchers;
+
+import static java.nio.file.Files.copy;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.util.ResourceUtils.createFileFromResource;
+import static org.apache.geode.test.util.ResourceUtils.getResource;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import org.apache.geode.internal.AvailablePortHelper;
+import org.apache.geode.test.assertj.LogFileAssert;
+import org.apache.geode.test.junit.rules.RequiresGeodeHome;
+
+public class LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTest {
+
+ private static final String CONFIG_WITH_GEODE_PLUGINS_FILE_NAME =
+
"LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTestWithGeodePlugins.xml";
+ private static final String CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME =
+
"LocatorLauncherWithPulseAndCustomLogConfigAcceptanceTestWithoutGeodePlugins.xml";
+ private static final String LOCATOR_NAME = "the-locator";
+
+ private int locatorPort;
+ private int httpServicePort;
+ private Path configWithGeodePluginsFile;
+ private Path configWithoutGeodePluginsFile;
+ private Process locator;
+ private Path geodeDependencies;
+ private Path stdoutFile;
+ private Path locatorLogFile;
+ private Path pulseLogFile;
+
+ @Rule
+ public RequiresGeodeHome requiresGeodeHome = new RequiresGeodeHome();
+ @Rule
+ public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ @Before
+ public void setUpLogConfigFiles() {
+configWithGeodePluginsFile = createFileFromResource(
+getResource(CONFIG_WITH_GEODE_PLUGINS_FILE_NAME),
temporaryFolder.getRoot(),
+CONFIG_WITH_GEODE_PLUGINS_FILE_NAME)
+.toPath();
+
+configWithoutGeodePluginsFile = createFileFromResource(
+getResource(CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME),
temporaryFolder.getRoot(),
+CONFIG_WITHOUT_GEODE_PLUGINS_FILE_NAME)
+.toPath();
+ }
+
+ @Before
+ public void setUpGeodeDependencies() {
+Path geodeHome = requiresGeodeHome.getGeodeHome().toPath();
+geodeDependencies = geodeHome.resolve("lib/geode-dependencies.jar");
+
+assertThat(geodeDependencies).exists();
+ }
+
+ @Before
+ public void setUpOutputFiles() {
+stdoutFile = temporaryFolder.getRoot().toPath().resolve("stdout.txt");
+locatorLogFile = temporaryFolder.getRoot().toPath().resolve(LOCATOR_NAME +
".log");
+pulseLogFile = temporaryFolder.getRoot().toPath().resolve("pulse.log");
+ }
+
+ @Before
+ public void setUpRandomPorts() {
+int[] ports = AvailablePortHelper.getRandomAvailableTCPPorts(2);
+locatorPort = ports[0];
+httpServicePort = ports[1];
+ }
+
+ @After
+ public void stopLocator() throws Exception {
+if (locator != null) {
+ locator.destroyForcibly().waitFor(4, TimeUnit.SECONDS);
+}
+ }
+
+ @Test
+ public void locatorLauncherUsesSpecifiedConfigFileWithoutGeodePlugins()
throws Exception {
+ProcessBuilder processBuilder = new ProcessBuilder()
+.redirectErrorStream(true)
+.redirectOutput(stdoutFile.toFile())
+.directory(temporaryFolder.getRoot())
+.command("java",
+"-Dgemfire.http-service-port=" + httpServicePort,
+"-Dgemfire.jmx-manager-start=true",
+"-Djava.awt.headless=true",
+"-Dlog4j.configurationFile=" +
[jira] [Assigned] (GEODE-8229) Experiencing Slowness in operations with any version greater than 1.8
[
https://issues.apache.org/jira/browse/GEODE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols reassigned GEODE-8229:
---
Assignee: Owen Nichols
> Experiencing Slowness in operations with any version greater than 1.8
> -
>
> Key: GEODE-8229
> URL: https://issues.apache.org/jira/browse/GEODE-8229
> Project: Geode
> Issue Type: Bug
> Components: configuration
>Reporter: Amit Agrawal
>Assignee: Owen Nichols
>Priority: Major
>
> Our company uses Geode services for some of our applications, we are making
> use of Geode Member group configurations as well for maintaining different
> regions.
> We have been undergoing an effort of migrating our applications from Geode
> version 1.6 to the latest version 1.12.
> We have seen dramatic performance decrease after the upgrade, if we use the
> older parameters for the server and locator startup scripts, and things work
> fine when we remove those parameters.
> We are now planning to take the route of understanding the parameters
> (earlier used) and available, to determine the most optimal configurations
> for the server and locator to get the best out of the new Geode version.
>
> Below are the configurations for the Geode locator and server startup scripts
> for old and new versions.
>
> h2. Locator startup command
>
> *---Old configurations* ( works great with Geode 1.6 version but not with any
> version after Geode 1.8)
> {{gfsh start locator --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net --initial-heap=2G
> --max-heap=2G --dir=/opt/compnayname/geode/locator
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-locator.xml
> --J=-DCLUSTER=${ECS_CLUSTER}
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-locator.xml'
> --J=-Dgemfire.distributed-system-id=${DISTRIBUTED_SYSTEM_ID}
> --J=-Dgemfire.member-timeout=3 --J=-Dgemfire.max-num-reconnect-tries=0
> --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true
> --J=-Dgemfire.jmx-manager-port=1099 --J=-Dgemfire.http-service-port=0
> --J=-Dgemfire.log-level=info --J=-Dgemfire.log-file-size-limit=10
> --J=-Dgemfire.log-disk-space-limit=10
> --J=-Dgemfire.disable-auto-reconnect=true}}
>
> *---New configuration* (works great with all versions)
> {{gfsh start locator --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net --J=-Xmx2048m
> --dir=/opt/compnayname/geode/locator
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-locator.xml
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-locator.xml'}}
>
>
> h2. Server Startup command
>
> *---Old configurations* ( works great with Geode 1.6 version but not with any
> version after Geode 1.8)
> {{gfsh start server --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net
> --initial-heap=${GEODE_INIT_HEAP} --max-heap=${GEODE_MAX_HEAP}
> --group=${SERVER_GROUP} --dir=/opt/compnayname/geode/server
> --classpath=/opt/compnayname/geode/services-geode.jar
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-server.xml
> --J=-DCLUSTER=${ECS_CLUSTER}
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-server.xml'
> --J=-Dgemfire.distributed-system-id=${DISTRIBUTED_SYSTEM_ID}
> --J=-Dgemfire.member-timeout=3 --J=-Dgemfire.max-num-reconnect-tries=0
> --J=-Dgemfire.socket-buffer-size=16777215
> --J=-Dgemfire.off-heap-memory-size=${GEODE_OFF_HEAP} --J=-XX:+UseParNewGC
> --J=-XX:+UseConcMarkSweepGC --J=-XX:CMSInitiatingOccupancyFraction=60
> --eviction-heap-percentage=70 --critical-heap-percentage=90
> --J=-Dgemfire.http-service-port=0 --J=-Dgemfire.log-level=info
> --J=-Dgemfire.log-file-size-limit=10 --J=-Dgemfire.log-disk-space-limit=10
> --J=-Dgemfire.disable-auto-reconnect=true $\{ADDTL_GEODE_SERVER_OPTS}}}
>
> *---New configuration* (works great with all versions)
> {{gfsh start server --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net --J=-Xmx${GEODE_MAX_HEAP}
> --group=${SERVER_GROUP} --dir=/opt/compnayname/geode/server
> --classpath=/opt/compnayname/geode/services-geode.jar
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-server.xml
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-server.xml'}}
>
>
> h2. Test Environment Details
> We are using the exact same environment (read AWS) for testing the old and
> new configurations and performing the same test to measure the response time.
> We are using 3 Geode locators and 3 Geode servers for the different member
> groups.
> The only difference
[jira] [Commented] (GEODE-8095) Create restore redundancy and status redundancy REST API commands
[ https://issues.apache.org/jira/browse/GEODE-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127144#comment-17127144 ] ASF GitHub Bot commented on GEODE-8095: --- mhansonp closed pull request #5195: URL: https://github.com/apache/geode/pull/5195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create restore redundancy and status redundancy REST API commands > - > > Key: GEODE-8095 > URL: https://issues.apache.org/jira/browse/GEODE-8095 > Project: Geode > Issue Type: Bug > Components: rest (admin) >Reporter: Anilkumar Gingade >Priority: Major > Labels: GeodeOperationAPI > Fix For: 1.14.0 > > > Add two REST API commands to allow redundancy to be restored and to check the > current redundancy status. > Similar to: https://issues.apache.org/jira/browse/GEODE-7954 > More on restore redundancy can be found at > https://cwiki.apache.org/confluence/display/GEODE/Redundancy+Gfsh+Commands -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8230) cut pipeline time from 10hrs to 5hrs by running benchmarks in parallel with other tests
Owen Nichols created GEODE-8230: --- Summary: cut pipeline time from 10hrs to 5hrs by running benchmarks in parallel with other tests Key: GEODE-8230 URL: https://issues.apache.org/jira/browse/GEODE-8230 Project: Geode Issue Type: Improvement Components: ci Reporter: Owen Nichols currently, we run Build, then all Test jobs in parallel (which takes ~5 hours), then all Benchmark jobs (which takes ~5 hours). Presumably the benchmarks were run after all tests, on the premise that benchmarks are meaningless if the code is not correct. However, required PR checks now prevent incorrect code from getting into develop in the first place, and the remaining occasional failures are flaky, so it's rather arbitrary to gate benchmarks on a lottery. However, faster feedback has clear benefits, and cutting our CI pipeline from 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8159) Cache boost dependency for CI, builds
[ https://issues.apache.org/jira/browse/GEODE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127383#comment-17127383 ] ASF GitHub Bot commented on GEODE-8159: --- pivotal-jbarrett opened a new pull request #614: URL: https://github.com/apache/geode-native/pull/614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Cache boost dependency for CI, builds > - > > Key: GEODE-8159 > URL: https://issues.apache.org/jira/browse/GEODE-8159 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Blake Bender >Assignee: Jacob Barrett >Priority: Major > > Boost has monthly bandwidth caps for downloads, which means if they hit their > cap we can't run CI again until the first of the month. It would benefit > both us and the boost folks greatly if we were to simply set up a job that > downloads boost, say, once per day and caches it in a storage bucket that we > own, then have our builds all retrieve it from there. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8219) Apply RedisResponse to all redis string commands
[ https://issues.apache.org/jira/browse/GEODE-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127152#comment-17127152 ] ASF subversion and git services commented on GEODE-8219: Commit 80ad8dd9bb4618faf071cf61ec7ab6dc49436723 in geode's branch refs/heads/mass-test-run from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=80ad8dd ] GEODE-8219: Apply RedisResponse to all redis string commands (#5206) > Apply RedisResponse to all redis string commands > > > Key: GEODE-8219 > URL: https://issues.apache.org/jira/browse/GEODE-8219 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Jens Deppe >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127153#comment-17127153 ] ASF subversion and git services commented on GEODE-8211: Commit 77d4bf8afd7a1c715a84b03dadda6673bc36f3f4 in geode's branch refs/heads/mass-test-run from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=77d4bf8 ] GEODE-8211: Fix flaky test by increasing client timeout (#5213) > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-8230: Summary: run benchmarks in parallel with other CI (was: cut pipeline time from 10hrs to 5hrs by running benchmarks in parallel with other tests) > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Priority: Major > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8229) Experiencing Slowness in operations with any version greater than 1.8
[
https://issues.apache.org/jira/browse/GEODE-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols reassigned GEODE-8229:
---
Assignee: (was: Owen Nichols)
> Experiencing Slowness in operations with any version greater than 1.8
> -
>
> Key: GEODE-8229
> URL: https://issues.apache.org/jira/browse/GEODE-8229
> Project: Geode
> Issue Type: Bug
> Components: configuration
>Reporter: Amit Agrawal
>Priority: Major
>
> Our company uses Geode services for some of our applications, we are making
> use of Geode Member group configurations as well for maintaining different
> regions.
> We have been undergoing an effort of migrating our applications from Geode
> version 1.6 to the latest version 1.12.
> We have seen dramatic performance decrease after the upgrade, if we use the
> older parameters for the server and locator startup scripts, and things work
> fine when we remove those parameters.
> We are now planning to take the route of understanding the parameters
> (earlier used) and available, to determine the most optimal configurations
> for the server and locator to get the best out of the new Geode version.
>
> Below are the configurations for the Geode locator and server startup scripts
> for old and new versions.
>
> h2. Locator startup command
>
> *---Old configurations* ( works great with Geode 1.6 version but not with any
> version after Geode 1.8)
> {{gfsh start locator --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net --initial-heap=2G
> --max-heap=2G --dir=/opt/compnayname/geode/locator
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-locator.xml
> --J=-DCLUSTER=${ECS_CLUSTER}
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-locator.xml'
> --J=-Dgemfire.distributed-system-id=${DISTRIBUTED_SYSTEM_ID}
> --J=-Dgemfire.member-timeout=3 --J=-Dgemfire.max-num-reconnect-tries=0
> --J=-Dgemfire.jmx-manager=true --J=-Dgemfire.jmx-manager-start=true
> --J=-Dgemfire.jmx-manager-port=1099 --J=-Dgemfire.http-service-port=0
> --J=-Dgemfire.log-level=info --J=-Dgemfire.log-file-size-limit=10
> --J=-Dgemfire.log-disk-space-limit=10
> --J=-Dgemfire.disable-auto-reconnect=true}}
>
> *---New configuration* (works great with all versions)
> {{gfsh start locator --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net --J=-Xmx2048m
> --dir=/opt/compnayname/geode/locator
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-locator.xml
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-locator.xml'}}
>
>
> h2. Server Startup command
>
> *---Old configurations* ( works great with Geode 1.6 version but not with any
> version after Geode 1.8)
> {{gfsh start server --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net
> --initial-heap=${GEODE_INIT_HEAP} --max-heap=${GEODE_MAX_HEAP}
> --group=${SERVER_GROUP} --dir=/opt/compnayname/geode/server
> --classpath=/opt/compnayname/geode/services-geode.jar
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-server.xml
> --J=-DCLUSTER=${ECS_CLUSTER}
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-server.xml'
> --J=-Dgemfire.distributed-system-id=${DISTRIBUTED_SYSTEM_ID}
> --J=-Dgemfire.member-timeout=3 --J=-Dgemfire.max-num-reconnect-tries=0
> --J=-Dgemfire.socket-buffer-size=16777215
> --J=-Dgemfire.off-heap-memory-size=${GEODE_OFF_HEAP} --J=-XX:+UseParNewGC
> --J=-XX:+UseConcMarkSweepGC --J=-XX:CMSInitiatingOccupancyFraction=60
> --eviction-heap-percentage=70 --critical-heap-percentage=90
> --J=-Dgemfire.http-service-port=0 --J=-Dgemfire.log-level=info
> --J=-Dgemfire.log-file-size-limit=10 --J=-Dgemfire.log-disk-space-limit=10
> --J=-Dgemfire.disable-auto-reconnect=true $\{ADDTL_GEODE_SERVER_OPTS}}}
>
> *---New configuration* (works great with all versions)
> {{gfsh start server --locators=$locators_str
> --name=${EC2_HOSTNAME}.aws.compnaynamedigital.net --J=-Xmx${GEODE_MAX_HEAP}
> --group=${SERVER_GROUP} --dir=/opt/compnayname/geode/server
> --classpath=/opt/compnayname/geode/services-geode.jar
> --J=-Dlog4j.configurationFile=/opt/compnayname/geode/log4j2-server.xml
> --J='-javaagent:/opt/compnayname/geode/jmxtrans-agent-1.2.6.jar=/opt/compnayname/geode/jmxtrans-agent-server.xml'}}
>
>
> h2. Test Environment Details
> We are using the exact same environment (read AWS) for testing the old and
> new configurations and performing the same test to measure the response time.
> We are using 3 Geode locators and 3 Geode servers for the different member
> groups.
> The only difference is the Geode version
> We
[jira] [Commented] (GEODE-8218) Update docs to reflect changes to default redis-bind-address behavior
[ https://issues.apache.org/jira/browse/GEODE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127150#comment-17127150 ] ASF subversion and git services commented on GEODE-8218: Commit 229fb5486ea5b8b5cb0a967513ae2765adc94d68 in geode's branch refs/heads/mass-test-run from Sarah Abbey [ https://gitbox.apache.org/repos/asf?p=geode.git;h=229fb54 ] GEODE-8218: documentdefault redis-bind-address behavior (#5207) > Update docs to reflect changes to default redis-bind-address behavior > - > > Key: GEODE-8218 > URL: https://issues.apache.org/jira/browse/GEODE-8218 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Priority: Major > Fix For: 1.14.0 > > > Geode Redis API now listens on all local addresses when bind-address is not > specified. The docs should be updated to reflect this change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8159) Cache boost dependency for CI, builds
[ https://issues.apache.org/jira/browse/GEODE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Barrett reassigned GEODE-8159: Assignee: Jacob Barrett > Cache boost dependency for CI, builds > - > > Key: GEODE-8159 > URL: https://issues.apache.org/jira/browse/GEODE-8159 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Blake Bender >Assignee: Jacob Barrett >Priority: Major > > Boost has monthly bandwidth caps for downloads, which means if they hit their > cap we can't run CI again until the first of the month. It would benefit > both us and the boost folks greatly if we were to simply set up a job that > downloads boost, say, once per day and caches it in a storage bucket that we > own, then have our builds all retrieve it from there. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8222) ExpireIntegrationTest.should_passivelyExpireKeys failed in CI
[ https://issues.apache.org/jira/browse/GEODE-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127151#comment-17127151 ] ASF subversion and git services commented on GEODE-8222: Commit ac6c65f1094f08e078cb861ed825de3f366ea8c0 in geode's branch refs/heads/mass-test-run from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ac6c65f ] GEODE-8222: fix flakey passive expiration (#5211) The passive expiration code will no longer become disabled if it throws an exception. It will now also log the exception. > ExpireIntegrationTest.should_passivelyExpireKeys failed in CI > - > > Key: GEODE-8222 > URL: https://issues.apache.org/jira/browse/GEODE-8222 > Project: Geode > Issue Type: Bug >Reporter: Jianxia Chen >Assignee: Darrel Schneider >Priority: Major > Fix For: 1.14.0 > > > org.apache.geode.redis.general.ExpireIntegrationTest > > should_passivelyExpireKeys FAILED > org.awaitility.core.ConditionTimeoutException: Condition with > org.apache.geode.redis.general.ExpireIntegrationTest was not fulfilled within > 5 minutes. > at > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) > at > org.awaitility.core.CallableCondition.await(CallableCondition.java:78) > at > org.awaitility.core.CallableCondition.await(CallableCondition.java:26) > at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) > at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864) > at > org.apache.geode.redis.general.ExpireIntegrationTest.should_passivelyExpireKeys(ExpireIntegrationTest.java:380) > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/228#A > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0105/test-results/integrationTest/1591216814/ > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0105/test-artifacts/1591216814/integrationtestfiles-OpenJDK8-1.14.0-build.0105.tgz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8207) Enforce No Unknown Pragmas as Error
[ https://issues.apache.org/jira/browse/GEODE-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127184#comment-17127184 ] ASF GitHub Bot commented on GEODE-8207: --- moleske commented on pull request #608: URL: https://github.com/apache/geode-native/pull/608#issuecomment-639911919 @pivotal-jbarrett I switched to definitions in config.h, but also spent a little time trying to figure out the correct way in cmake to detect those pragmas. I didn't succeed in the latter, kept ending up in docs for checking compiler flags. The closest I hit to was `get_target_property` but couldn't figure out what target or property I'd really be looking for. If you have thoughts on detection, I can take another try at using cmake to determine if those pragmas exist (as long as folks don't mind waiting a week in between my attempts based on my current schedule) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enforce No Unknown Pragmas as Error > --- > > Key: GEODE-8207 > URL: https://issues.apache.org/jira/browse/GEODE-8207 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > > Given I compile the code without exempting no-unknown-pragmas > Then it should compile > Note - was marked as a todo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127162#comment-17127162
]
ASF subversion and git services commented on GEODE-7414:
Commit 917f4c921c9c9fb3b19687ee67fe0dfe4f885056 in geode's branch
refs/heads/mass-test-run from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=917f4c9 ]
Feature/GEODE-7414_2_redo (#5115)
* GEODE-7414_2: modify init() method argument (#5040)
(cherry picked from commit 5f9800b291d3a11140eb5a1a972459207e07b50c)
* Add exemption for SSLParameterExtension API change
Following feedback on the SSLParameterExtension
Accept a map of as a more definite set of inputs than
'Properties'. Extend as needed.
Authored-by: Robert Houghton
* Applying feedback to use a real class to hold TLS context
* move SSLParameterExtensionContextImpl to an internal package
* prune un-needed value from exception list
* fixup - remove now-internal javadoc from assembly
Co-authored-by: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127156#comment-17127156 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127163#comment-17127163
]
ASF subversion and git services commented on GEODE-7414:
Commit 917f4c921c9c9fb3b19687ee67fe0dfe4f885056 in geode's branch
refs/heads/mass-test-run from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=917f4c9 ]
Feature/GEODE-7414_2_redo (#5115)
* GEODE-7414_2: modify init() method argument (#5040)
(cherry picked from commit 5f9800b291d3a11140eb5a1a972459207e07b50c)
* Add exemption for SSLParameterExtension API change
Following feedback on the SSLParameterExtension
Accept a map of as a more definite set of inputs than
'Properties'. Extend as needed.
Authored-by: Robert Houghton
* Applying feedback to use a real class to hold TLS context
* move SSLParameterExtensionContextImpl to an internal package
* prune un-needed value from exception list
* fixup - remove now-internal javadoc from assembly
Co-authored-by: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127158#comment-17127158 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127157#comment-17127157 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8230) run benchmarks in parallel with other CI
[ https://issues.apache.org/jira/browse/GEODE-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127179#comment-17127179 ] ASF GitHub Bot commented on GEODE-8230: --- onichols-pivotal opened a new pull request #5217: URL: https://github.com/apache/geode/pull/5217 before, we ran Build, then all Test jobs in parallel (which takes ~5 hours), then all Benchmark jobs (which takes ~5 hours). Presumably the benchmarks were run after all tests, on the premise that benchmarks are meaningless if the code is not correct. However, required PR checks now prevent incorrect code from getting into develop in the first place, and the remaining occasional failures are flaky, so it's rather arbitrary to gate benchmarks on a lottery. However, faster feedback has clear benefits, hence this PR to cut our CI pipeline from 10 hours to 5 hours. Also eliminates redundant jobs (ApiCheck and UnitTest are deterministic and already have required JDK11 flavors in the PR pipeline, so JDK8 flavor only is more than sufficient in the develop pipeline) Also decreases benchmarks max_in_flight from 3 to 2, since now that we have support branches, we don't want to max our quota just from develop. Some sort of global "pool" resource might be a more elegant way to manage this resource quota across pipelines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > run benchmarks in parallel with other CI > > > Key: GEODE-8230 > URL: https://issues.apache.org/jira/browse/GEODE-8230 > Project: Geode > Issue Type: Improvement > Components: ci >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > > currently, we run Build, then all Test jobs in parallel (which takes ~5 > hours), then all Benchmark jobs (which takes ~5 hours). > Presumably the benchmarks were run after all tests, on the premise that > benchmarks are meaningless if the code is not correct. However, required PR > checks now prevent incorrect code from getting into develop in the first > place, and the remaining occasional failures are flaky, so it's rather > arbitrary to gate benchmarks on a lottery. > However, faster feedback has clear benefits, and cutting our CI pipeline from > 10 hours to 5 hours seems like low-hanging fruit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127154#comment-17127154 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127155#comment-17127155 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127177#comment-17127177
]
ASF subversion and git services commented on GEODE-7414:
Commit 917f4c921c9c9fb3b19687ee67fe0dfe4f885056 in geode's branch
refs/heads/mass-test-run from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=917f4c9 ]
Feature/GEODE-7414_2_redo (#5115)
* GEODE-7414_2: modify init() method argument (#5040)
(cherry picked from commit 5f9800b291d3a11140eb5a1a972459207e07b50c)
* Add exemption for SSLParameterExtension API change
Following feedback on the SSLParameterExtension
Accept a map of as a more definite set of inputs than
'Properties'. Extend as needed.
Authored-by: Robert Houghton
* Applying feedback to use a real class to hold TLS context
* move SSLParameterExtensionContextImpl to an internal package
* prune un-needed value from exception list
* fixup - remove now-internal javadoc from assembly
Co-authored-by: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8211) ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed failed with java.net.SocketTimeoutException
[ https://issues.apache.org/jira/browse/GEODE-8211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127167#comment-17127167 ] ASF subversion and git services commented on GEODE-8211: Commit 77d4bf8afd7a1c715a84b03dadda6673bc36f3f4 in geode's branch refs/heads/mass-test-run from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=77d4bf8 ] GEODE-8211: Fix flaky test by increasing client timeout (#5213) > ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed > failed with java.net.SocketTimeoutException > -- > > Key: GEODE-8211 > URL: https://issues.apache.org/jira/browse/GEODE-8211 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Xiaojian Zhou >Assignee: Darrel Schneider >Priority: Major > Labels: flaky > Fix For: 1.14.0 > > > IntegrationTestOpenJDK11 #212. This will occasionally happen. > org.apache.geode.redis.general.ShutdownIntegrationTest > > shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed FAILED > redis.clients.jedis.exceptions.JedisConnectionException: > java.net.SocketTimeoutException: Read timed out > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:205) > at > redis.clients.jedis.util.RedisInputStream.readByte(RedisInputStream.java:43) > at redis.clients.jedis.Protocol.process(Protocol.java:155) > at redis.clients.jedis.Protocol.read(Protocol.java:220) > at > redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:318) > at > redis.clients.jedis.Connection.getBinaryMultiBulkReply(Connection.java:270) > at redis.clients.jedis.Jedis.keys(Jedis.java:280) > at > org.apache.geode.redis.general.ShutdownIntegrationTest.shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed(ShutdownIntegrationTest.java:66) > Caused by: > java.net.SocketTimeoutException: Read timed out > at java.net.SocketInputStream.socketRead0(Native Method) > at > java.net.SocketInputStream.socketRead(SocketInputStream.java:115) > at java.net.SocketInputStream.read(SocketInputStream.java:168) > at java.net.SocketInputStream.read(SocketInputStream.java:140) > at java.net.SocketInputStream.read(SocketInputStream.java:126) > at > redis.clients.jedis.util.RedisInputStream.ensureFill(RedisInputStream.java:199) > ... 7 more -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127159#comment-17127159 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127170#comment-17127170 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127172#comment-17127172 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8222) ExpireIntegrationTest.should_passivelyExpireKeys failed in CI
[ https://issues.apache.org/jira/browse/GEODE-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127165#comment-17127165 ] ASF subversion and git services commented on GEODE-8222: Commit ac6c65f1094f08e078cb861ed825de3f366ea8c0 in geode's branch refs/heads/mass-test-run from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=ac6c65f ] GEODE-8222: fix flakey passive expiration (#5211) The passive expiration code will no longer become disabled if it throws an exception. It will now also log the exception. > ExpireIntegrationTest.should_passivelyExpireKeys failed in CI > - > > Key: GEODE-8222 > URL: https://issues.apache.org/jira/browse/GEODE-8222 > Project: Geode > Issue Type: Bug >Reporter: Jianxia Chen >Assignee: Darrel Schneider >Priority: Major > Fix For: 1.14.0 > > > org.apache.geode.redis.general.ExpireIntegrationTest > > should_passivelyExpireKeys FAILED > org.awaitility.core.ConditionTimeoutException: Condition with > org.apache.geode.redis.general.ExpireIntegrationTest was not fulfilled within > 5 minutes. > at > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) > at > org.awaitility.core.CallableCondition.await(CallableCondition.java:78) > at > org.awaitility.core.CallableCondition.await(CallableCondition.java:26) > at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) > at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864) > at > org.apache.geode.redis.general.ExpireIntegrationTest.should_passivelyExpireKeys(ExpireIntegrationTest.java:380) > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/228#A > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0105/test-results/integrationTest/1591216814/ > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0105/test-artifacts/1591216814/integrationtestfiles-OpenJDK8-1.14.0-build.0105.tgz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127169#comment-17127169 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8224) repackage internal redis classes
[ https://issues.apache.org/jira/browse/GEODE-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127160#comment-17127160 ] ASF subversion and git services commented on GEODE-8224: Commit 41f3d4e6b1c8a10eb22940683ccd100ac654432b in geode's branch refs/heads/mass-test-run from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=41f3d4e ] GEODE-8224: repackage redis classes (#5212) > repackage internal redis classes > > > Key: GEODE-8224 > URL: https://issues.apache.org/jira/browse/GEODE-8224 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Fix For: 1.14.0 > > > The internal redis class package organization could use some cleanup. > Some classes are in sub-packages when they should be in a high level shared > package. > Other classes are in high level shared packages but are only used by classes > in a single sub-package. Also some high level packages contain a mix of > classes that could be sub-packaged around certain responsibilities. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8224) repackage internal redis classes
[ https://issues.apache.org/jira/browse/GEODE-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127174#comment-17127174 ] ASF subversion and git services commented on GEODE-8224: Commit 41f3d4e6b1c8a10eb22940683ccd100ac654432b in geode's branch refs/heads/mass-test-run from Darrel Schneider [ https://gitbox.apache.org/repos/asf?p=geode.git;h=41f3d4e ] GEODE-8224: repackage redis classes (#5212) > repackage internal redis classes > > > Key: GEODE-8224 > URL: https://issues.apache.org/jira/browse/GEODE-8224 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Darrel Schneider >Assignee: Darrel Schneider >Priority: Major > Fix For: 1.14.0 > > > The internal redis class package organization could use some cleanup. > Some classes are in sub-packages when they should be in a high level shared > package. > Other classes are in high level shared packages but are only used by classes > in a single sub-package. Also some high level packages contain a mix of > classes that could be sub-packaged around certain responsibilities. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8186) User Guide: add example for gfsh query --member option
[ https://issues.apache.org/jira/browse/GEODE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127175#comment-17127175 ] ASF subversion and git services commented on GEODE-8186: Commit fb45d22d336192f09fdf586cb4512eec9042083b in geode's branch refs/heads/mass-test-run from Alberto Bustamante Reyes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fb45d22 ] GEODE-8186: UG add example for query --member option (#5203) > User Guide: add example for gfsh query --member option > -- > > Key: GEODE-8186 > URL: https://issues.apache.org/jira/browse/GEODE-8186 > Project: Geode > Issue Type: Sub-task > Components: docs >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Major > Fix For: 1.14.0 > > > GEODE-8112 added a --member option to the gfsh query command. > Add a usage example to the User Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127173#comment-17127173 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8186) User Guide: add example for gfsh query --member option
[ https://issues.apache.org/jira/browse/GEODE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127161#comment-17127161 ] ASF subversion and git services commented on GEODE-8186: Commit fb45d22d336192f09fdf586cb4512eec9042083b in geode's branch refs/heads/mass-test-run from Alberto Bustamante Reyes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fb45d22 ] GEODE-8186: UG add example for query --member option (#5203) > User Guide: add example for gfsh query --member option > -- > > Key: GEODE-8186 > URL: https://issues.apache.org/jira/browse/GEODE-8186 > Project: Geode > Issue Type: Sub-task > Components: docs >Reporter: Dave Barnes >Assignee: Alberto Bustamante Reyes >Priority: Major > Fix For: 1.14.0 > > > GEODE-8112 added a --member option to the gfsh query command. > Add a usage example to the User Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7414) SSL ClientHello server_name extension
[
https://issues.apache.org/jira/browse/GEODE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127176#comment-17127176
]
ASF subversion and git services commented on GEODE-7414:
Commit 917f4c921c9c9fb3b19687ee67fe0dfe4f885056 in geode's branch
refs/heads/mass-test-run from Robert Houghton
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=917f4c9 ]
Feature/GEODE-7414_2_redo (#5115)
* GEODE-7414_2: modify init() method argument (#5040)
(cherry picked from commit 5f9800b291d3a11140eb5a1a972459207e07b50c)
* Add exemption for SSLParameterExtension API change
Following feedback on the SSLParameterExtension
Accept a map of as a more definite set of inputs than
'Properties'. Extend as needed.
Authored-by: Robert Houghton
* Applying feedback to use a real class to hold TLS context
* move SSLParameterExtensionContextImpl to an internal package
* prune un-needed value from exception list
* fixup - remove now-internal javadoc from assembly
Co-authored-by: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> SSL ClientHello server_name extension
> -
>
> Key: GEODE-7414
> URL: https://issues.apache.org/jira/browse/GEODE-7414
> Project: Geode
> Issue Type: Improvement
> Components: security
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {color:#172b4d}We propose to add the {color}*server_name extension to the
> ClientHello message*{color:#172b4d}. The extension would hold the distributed
> system ID of the site where the connection originated from.{color}
> {color:#172b4d}This will be used to determine internal geode communication,
> and communication between geode sites.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8173) Add test coverage for PartitionedRegionClear class
[
https://issues.apache.org/jira/browse/GEODE-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127178#comment-17127178
]
ASF GitHub Bot commented on GEODE-8173:
---
DonalEvans commented on a change in pull request #5208:
URL: https://github.com/apache/geode/pull/5208#discussion_r436210405
##
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionClearTest.java
##
@@ -0,0 +1,598 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.catchThrowable;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import org.apache.geode.CancelCriterion;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.distributed.DistributedLockService;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.DistributionManager;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import org.apache.geode.distributed.internal.MembershipListener;
+import
org.apache.geode.distributed.internal.membership.InternalDistributedMember;
+import org.apache.geode.internal.cache.partitioned.RegionAdvisor;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+
+public class PartitionedRegionClearTest {
+
+
+ private PartitionedRegionClear partitionedRegionClear;
+ private DistributionManager distributionManager;
+ private PartitionedRegion partitionedRegion;
+
+ @Before
+ public void setUp() {
+
+partitionedRegion = mock(PartitionedRegion.class);
+distributionManager = mock(DistributionManager.class);
+
+
when(partitionedRegion.getDistributionManager()).thenReturn(distributionManager);
+when(partitionedRegion.getName()).thenReturn("prRegion");
+
+partitionedRegionClear = new PartitionedRegionClear(partitionedRegion);
+ }
+
+ private Set setupBucketRegions(
+ PartitionedRegionDataStore partitionedRegionDataStore,
+ BucketAdvisor bucketAdvisor) {
+final int numBuckets = 2;
+HashSet bucketRegions = new HashSet<>();
+for (int i = 0; i < numBuckets; i++) {
+ BucketRegion bucketRegion = mock(BucketRegion.class);
+ when(bucketRegion.getBucketAdvisor()).thenReturn(bucketAdvisor);
+ when(bucketRegion.size()).thenReturn(1);
+ when(bucketRegion.getId()).thenReturn(i);
+ bucketRegions.add(bucketRegion);
+}
+
+
when(partitionedRegionDataStore.getAllLocalBucketRegions()).thenReturn(bucketRegions);
+
when(partitionedRegionDataStore.getAllLocalPrimaryBucketRegions()).thenReturn(bucketRegions);
+
+return bucketRegions;
+ }
+
+ @Test
+ public void isLockedForListenerAndClientNotificationReturnsTrueWhenLocked() {
+InternalDistributedMember internalDistributedMember =
mock(InternalDistributedMember.class);
+
when(distributionManager.isCurrentMember(internalDistributedMember)).thenReturn(true);
+partitionedRegionClear.obtainClearLockLocal(internalDistributedMember);
+
+
assertThat(partitionedRegionClear.isLockedForListenerAndClientNotification()).isTrue();
+ }
+
+ @Test
+ public void
isLockedForListenerAndClientNotificationReturnsFalseWhenMemberNotInTheSystemRequestsLock()
{
+InternalDistributedMember internalDistributedMember =
mock(InternalDistributedMember.class);
+
when(distributionManager.isCurrentMember(internalDistributedMember)).thenReturn(false);
+
+
assertThat(partitionedRegionClear.isLockedForListenerAndClientNotification()).isFalse();
+ }
+
+ @Test
+ public void
[jira] [Commented] (GEODE-8218) Update docs to reflect changes to default redis-bind-address behavior
[ https://issues.apache.org/jira/browse/GEODE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127164#comment-17127164 ] ASF subversion and git services commented on GEODE-8218: Commit 229fb5486ea5b8b5cb0a967513ae2765adc94d68 in geode's branch refs/heads/mass-test-run from Sarah Abbey [ https://gitbox.apache.org/repos/asf?p=geode.git;h=229fb54 ] GEODE-8218: documentdefault redis-bind-address behavior (#5207) > Update docs to reflect changes to default redis-bind-address behavior > - > > Key: GEODE-8218 > URL: https://issues.apache.org/jira/browse/GEODE-8218 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Priority: Major > Fix For: 1.14.0 > > > Geode Redis API now listens on all local addresses when bind-address is not > specified. The docs should be updated to reflect this change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127171#comment-17127171 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8198) Revise docs to better specify putAll() behavior
[ https://issues.apache.org/jira/browse/GEODE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127168#comment-17127168 ] ASF subversion and git services commented on GEODE-8198: Commit 90980027e8258f112ecd5667ca2f1ea5046f8557 in geode's branch refs/heads/mass-test-run from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9098002 ] GEODE-8198: Revise docs description of putAll() (#5191) * GEODE-8198: Revise docs description of putAll() * GEODE-8198 putAll docs revision to address review comments * GEODE-8198: Final edits on docs for putAll() * GEODE-8198: Fix a last detail on the revision of docs for putAll * GEODE-8198: Revise docs for describing putAll - Revised the code example - Removed putAll prose on internal implementation details - Revised wording to clarify > Revise docs to better specify putAll() behavior > --- > > Key: GEODE-8198 > URL: https://issues.apache.org/jira/browse/GEODE-8198 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Fix For: 1.14.0 > > > [GEODE-8171|https://issues.apache.org/jira/browse/GEODE-8171] updated the > Javadocs for the Region.putAll() method. Our user guide should also specify > the behavior under exceptions and give readers more context such that they > can produce better apps. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8219) Apply RedisResponse to all redis string commands
[ https://issues.apache.org/jira/browse/GEODE-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127166#comment-17127166 ] ASF subversion and git services commented on GEODE-8219: Commit 80ad8dd9bb4618faf071cf61ec7ab6dc49436723 in geode's branch refs/heads/mass-test-run from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=80ad8dd ] GEODE-8219: Apply RedisResponse to all redis string commands (#5206) > Apply RedisResponse to all redis string commands > > > Key: GEODE-8219 > URL: https://issues.apache.org/jira/browse/GEODE-8219 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Jens Deppe >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8099) Make ClusterConfiguration Service thread safe
[
https://issues.apache.org/jira/browse/GEODE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127148#comment-17127148
]
ASF GitHub Bot commented on GEODE-8099:
---
mhansonp commented on a change in pull request #5188:
URL: https://github.com/apache/geode/pull/5188#discussion_r436208620
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorClusterManagementServiceIntegrationTest.java
##
@@ -56,13 +57,38 @@ public void tearDown() {
}
}
+ @Before
+ public void setup() throws URISyntaxException {
+distributionConfig = mock(DistributionConfigImpl.class);
+cache = mock(InternalCacheForClientAccess.class);
+managementService = mock(BaseManagementService.class);
Review comment:
With these changes does this test need to become a unit test rather than
an integration test?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make ClusterConfiguration Service thread safe
> -
>
> Key: GEODE-8099
> URL: https://issues.apache.org/jira/browse/GEODE-8099
> Project: Geode
> Issue Type: Bug
> Components: configuration
>Reporter: Anilkumar Gingade
>Priority: Major
> Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> When multiple cluster configuration clients (multiple rest clients) connects
> and issue configuration commands, the cluster configuration should handle
> concurrent request and modify/save/execute the configuration definition in
> thread safe manner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
