[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135826#comment-16135826
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit f38dff9d217a8808117b6fbb2e5f4021ef9c84ce in geode's branch 
refs/heads/feature/GEODE-3416 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f38dff9 ]

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7

  * Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
  * Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
  * Added session backward compatibility tests
  * Modified aseembly build to download old product installs
  * Minor refactor of VersionManager to reuse property file load code


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.3.0
>
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133813#comment-16133813
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit f38dff9d217a8808117b6fbb2e5f4021ef9c84ce in geode's branch 
refs/heads/feature/GEODE-1279 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f38dff9 ]

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7

  * Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
  * Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
  * Added session backward compatibility tests
  * Modified aseembly build to download old product installs
  * Minor refactor of VersionManager to reuse property file load code


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.3.0
>
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133183#comment-16133183
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/718


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131546#comment-16131546
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit f38dff9d217a8808117b6fbb2e5f4021ef9c84ce in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f38dff9 ]

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7

  * Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
  * Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
  * Added session backward compatibility tests
  * Modified aseembly build to download old product installs
  * Minor refactor of VersionManager to reuse property file load code


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131404#comment-16131404
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/718

GEODE-3434: Allow old tomcat server sessions to be compatible with new 
tomcat session modules

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3434

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/718.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #718


commit 08c29c8df14b8cc315551297477636237e855b48
Author: Jason Huynh 
Date:   2017-08-14T16:02:11Z

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs

commit dfce284c2634ea72e797ad4a9d8c956b8d86211c
Author: Jason Huynh 
Date:   2017-08-14T19:07:08Z

GEODE-3434: Modifications based on review comments

commit be305896685e1b7d4d1f37724f673701277e5a76
Author: Jason Huynh 
Date:   2017-08-15T18:46:16Z

Removed unused import

commit d282ec4470a3993f7b401675bf7eb4161e1fb66e
Author: Jason Huynh 
Date:   2017-08-17T22:04:42Z

updated




> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131397#comment-16131397
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit dfce284c2634ea72e797ad4a9d8c956b8d86211c in geode's branch 
refs/heads/feature/GEODE-3434 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=dfce284 ]

GEODE-3434: Modifications based on review comments


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131395#comment-16131395
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/712


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131394#comment-16131394
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133843663
  
--- Diff: geode-old-versions/build.gradle ---
@@ -65,6 +92,21 @@ task createGeodeClasspathsFile  {
 new FileOutputStream(classpathsFile).withStream { fos ->
   versions.store(fos, '')
 }
+
+installsFile.getParentFile().mkdirs();
+
+new FileOutputStream(installsFile).withStream { fos ->
+  project.ext.installs.store(fos, '')
+}
   }
+
+  // Add sourceSets for backwards compatibility, rolling upgrade, and
+  // pdx testing.
+  addOldVersion('test100', '1.0.0-incubating')
+  addOldVersion('test110', '1.1.0')
+  addOldVersion('test111', '1.1.1')
--- End diff --

Good idea, I'll add a boolean to decide whether to do the product install 
or not


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131391#comment-16131391
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133843558
  
--- Diff: 
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
 ---
@@ -586,6 +610,20 @@ public int getSizeInBytes() {
 return serializedAttributes;
   }
 
+  protected ConcurrentMap getAttributes() {
+try {
+  Field field = getAttributesFieldObject();
+  field.setAccessible(true);
+  Map oldMap = (Map) field.get(this);
+  ConcurrentMap newMap = new ConcurrentHashMap();
--- End diff --

I think you are correct, I believe we wrapped it incase somehow it was not 
a concurrent hash map but I guess that was being overly cautious.  I'll change 
them all to map


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131285#comment-16131285
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133827419
  
--- Diff: 
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
 ---
@@ -586,6 +610,20 @@ public int getSizeInBytes() {
 return serializedAttributes;
   }
 
+  protected ConcurrentMap getAttributes() {
+try {
+  Field field = getAttributesFieldObject();
+  field.setAccessible(true);
+  Map oldMap = (Map) field.get(this);
+  ConcurrentMap newMap = new ConcurrentHashMap();
--- End diff --

Why do we need to copy the map here? I think the attributes field is always 
set to a ConcurrentHashMap, even though in tomcat 6 the field was of type map.


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131286#comment-16131286
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133827666
  
--- Diff: geode-old-versions/build.gradle ---
@@ -65,6 +92,21 @@ task createGeodeClasspathsFile  {
 new FileOutputStream(classpathsFile).withStream { fos ->
   versions.store(fos, '')
 }
+
+installsFile.getParentFile().mkdirs();
+
+new FileOutputStream(installsFile).withStream { fos ->
+  project.ext.installs.store(fos, '')
+}
   }
+
+  // Add sourceSets for backwards compatibility, rolling upgrade, and
+  // pdx testing.
+  addOldVersion('test100', '1.0.0-incubating')
+  addOldVersion('test110', '1.1.0')
+  addOldVersion('test111', '1.1.1')
--- End diff --

Maybe we should only download 1.2.0, if that's all we are testing against?


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131287#comment-16131287
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133827499
  
--- Diff: 
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
 ---
@@ -553,8 +555,30 @@ public void fromData(DataInput in) throws IOException, 
ClassNotFoundException {
 }
   }
 
-  protected Map readInAttributes(final DataInput in) throws IOException, 
ClassNotFoundException {
-return DataSerializer.readObject(in);
+  private void readInAttributes(DataInput in) throws IOException, 
ClassNotFoundException {
+Map map = DataSerializer.readObject(in);
+ConcurrentMap newMap = new ConcurrentHashMap();
+newMap.putAll(map);
+try {
+  Field field = getAttributesFieldObject();
+  field.setAccessible(true);
+  field.set(this, newMap);
+} catch (NoSuchFieldException e) {
+  logError(e);
--- End diff --

I think it would be better to throw an exception than log an error here, so 
it's obvious if something is broken here.


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127632#comment-16127632
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133256792
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/ContainerInstall.java
 ---
@@ -18,6 +18,7 @@
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;
+import java.net.URI;
--- End diff --

I think this is extraneous. It doesn't seem to be used anywhere in this 
file.


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126243#comment-16126243
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit ae570225ed1d53dafd7450b4b4e399eb073f8442 in geode's branch 
refs/heads/feature/GEODE-3434 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=ae57022 ]

GEODE-3434: Modifications based on review comments


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126046#comment-16126046
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133012057
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java 
---
@@ -150,6 +166,66 @@ public TomcatInstall(TomcatVersion version, 
ConnectionType connType, String inst
   }
 
   /**
+   * Copies jars specified by {@link #tomcatRequiredJars} from the {@link 
#getModulePath()} and the
+   * specified other directory passed to the function
+   *
+   * @throws IOException if the {@link #getModulePath()}, installation lib 
directory, or extra
+   * directory passed in contain no files.
+   */
+  private void copyTomcatGeodeReqFiles(String moduleJarDir, String 
extraJarsPath)
--- End diff --

Copy stuff in function into other function


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126040#comment-16126040
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133011336
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java 
---
@@ -131,15 +142,20 @@ public TomcatInstall(TomcatVersion version, 
ConnectionType connType) throws Exce
* within the installation's 'conf' folder, and {@link 
#updateProperties()} to set the jar
* skipping properties needed to speedup container startup.
*/
-  public TomcatInstall(TomcatVersion version, ConnectionType connType, 
String installDir)
-  throws Exception {
+  public TomcatInstall(TomcatVersion version, ConnectionType connType, 
String installDir,
+  String modulesJarLocation, String extraJarsPath) throws Exception {
 // Does download and install from URL
-super(installDir, version.getDownloadURL(), connType, "tomcat");
+super(installDir, version.getDownloadURL(), connType, "tomcat",
--- End diff --

Refactor both "tomcat" and DEFAULT_MODULE_LOCATION pass down/up into other 
constructors


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126037#comment-16126037
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

Github user DivineEnder commented on a diff in the pull request:

https://github.com/apache/geode/pull/712#discussion_r133010884
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java
 ---
@@ -134,6 +134,7 @@ public ServerContainer(ContainerInstall install, File 
containerConfigHome,
 
 // Set cacheXML file
 File installXMLFile = install.getCacheXMLFile();
+String path = logDir.getAbsolutePath() + "/" + 
installXMLFile.getName();
--- End diff --

Probably not needed


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126019#comment-16126019
 ] 

ASF GitHub Bot commented on GEODE-3434:
---

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/712

GEODE-3434: Allow the modules to be interoperable with current and ol…

…der versions of tomcat 7

Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to d...@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3434

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/712.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #712


commit e9ed8a12f6f8cb9dfeedcec5922069bce2e7b7e3
Author: Jason Huynh 
Date:   2017-08-14T16:02:11Z

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase 
an earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs




> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (GEODE-3434) Allow the modules to be interoperable with current and older versions of tomcat 7

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126014#comment-16126014
 ] 

ASF subversion and git services commented on GEODE-3434:


Commit e9ed8a12f6f8cb9dfeedcec5922069bce2e7b7e3 in geode's branch 
refs/heads/feature/GEODE-3434 from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e9ed8a1 ]

GEODE-3434: Allow the modules to be interoperable with current and older 
versions of tomcat 7
Modified DeltaSessions to use reflection to handle attributes fields incase an 
earlier tomcat 7 is used
Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession
Added session backward compatibility tests
Modified aseembly build to download old product installs


> Allow the modules to be interoperable with current and older versions of 
> tomcat 7 
> --
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the 
> necessary changes in geode session modules), but that does not allow our 
> session modules to work with older versions of tomcat 7.  We can probably 
> modify the classes to allow use with of the session module jars across 
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to 
> allow backwards compatibility between a geode server and a session module jar 
> from a previous release.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)