[GitHub] incubator-hawq issue #1384: HAWQ-1628. Add HDFS protocol for external storag...

2018-08-13 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1384 LGTM, +1 ---

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438791 --- Diff: src/include/catalog/pg_exttable.h --- @@ -164,9 +164,12 @@ GetExtTableEntry(Oid relid); extern void RemoveExtTableEntry(Oid relid

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438657 --- Diff: src/include/utils/uri.h --- @@ -52,6 +60,10 @@ typedef enum UriProtocol #define IS_GPFDISTS_URI(uri_str) (pg_strncasecmp(uri_str

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438576 --- Diff: src/include/utils/uri.h --- @@ -41,6 +45,10 @@ typedef enum UriProtocol #define PROTOCOL_GPFDIST "gpfdist://"

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438342 --- Diff: src/include/utils/uri.h --- @@ -32,7 +32,11 @@ typedef enum UriProtocol URI_HTTP, URI_GPFDIST, URI_CUSTOM

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438291 --- Diff: src/include/nodes/parsenodes.h --- @@ -1459,8 +1463,10 @@ typedef struct SharedStorageOpStmt */ typedef enum ExtTableType

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438235 --- Diff: src/include/access/xact.h --- @@ -173,6 +173,33 @@ typedef struct XidBuffer extern XidBuffer subxbuf; extern File subxip_file

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438165 --- Diff: src/include/access/formatter.h --- @@ -36,10 +36,19 @@ typedef enum FmtNotification { FMT_NONE, + FMT_DONE

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437581 --- Diff: src/backend/optimizer/plan/createplan.c --- @@ -1127,6 +1127,20 @@ bool is_pxf_protocol(Uri *uri) return false

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437403 --- Diff: src/backend/commands/tablecmds.c --- @@ -18041,11 +18646,11 @@ static Datum transformFormatOpts(char formattype, List *formatOpts, int

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208437352 --- Diff: src/backend/commands/tablecmds.c --- @@ -17845,14 +18448,16 @@ static Datum transformFormatOpts(char formattype, List *formatOpts, int

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436378 --- Diff: src/backend/commands/tablecmds.c --- @@ -17615,14 +17979,16 @@ static Datum transformLocationUris(List *locs, List* fmtopts, bool isweb

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436303 --- Diff: src/backend/commands/tablecmds.c --- @@ -17528,6 +17845,15 @@ static Datum transformLocationUris(List *locs, List* fmtopts, bool isweb, bool

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436195 --- Diff: src/backend/commands/tablecmds.c --- @@ -1222,20 +1529,24 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436174 --- Diff: src/backend/commands/tablecmds.c --- @@ -1210,6 +1507,16 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt) else

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208436164 --- Diff: src/backend/commands/tablecmds.c --- @@ -1199,6 +1489,13 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435854 --- Diff: src/backend/commands/tablecmds.c --- @@ -1174,6 +1426,44 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435758 --- Diff: src/backend/commands/tablecmds.c --- @@ -1105,53 +1340,70 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435710 --- Diff: src/backend/commands/tablecmds.c --- @@ -939,38 +983,217 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt) char

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435664 --- Diff: src/backend/commands/tablecmds.c --- @@ -939,38 +983,217 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt) char

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435628 --- Diff: src/backend/commands/tablecmds.c --- @@ -939,38 +983,217 @@ DefineExternalRelation(CreateExternalStmt *createExtStmt) char

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435571 --- Diff: src/backend/commands/tablecmds.c --- @@ -632,9 +665,20 @@ DefineRelation_int(CreateStmt *stmt, */ descriptor

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435255 --- Diff: src/backend/commands/analyze.c --- @@ -442,6 +455,17 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int preferred_seg_num

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435117 --- Diff: src/backend/commands/analyze.c --- @@ -442,6 +455,17 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int preferred_seg_num

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435034 --- Diff: src/backend/commands/analyze.c --- @@ -153,9 +160,15 @@ static List*buildExplicitAttributeNames(Oid relationOid, VacuumStmt *stmt

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434847 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation relation, return

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434889 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -4039,6 +4398,9 @@ calculate_planner_segment_num(Query *query, QueryResourceLife resourceLife

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434912 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -4104,6 +4468,12 @@ calculate_planner_segment_num(Query *query, QueryResourceLife resourceLife

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434835 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation relation, return

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434815 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation relation, return

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434723 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -1579,7 +1700,242 @@ static void ParquetGetSegFileDataLocation(Relation relation, return

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434427 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -844,36 +918,17 @@ int64 get_block_locations_and_claculte_table_size(split_to_segment_mapping_conte

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434291 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -193,6 +212,9 @@ typedef struct Relation_Data { List *files; Oid

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434247 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -123,10 +132,20 @@ typedef struct File_Split { int64 logiceof; int host

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208434124 --- Diff: src/backend/cdb/cdbdatalocality.c --- @@ -123,10 +132,20 @@ typedef struct File_Split { int64 logiceof; int host

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433943 --- Diff: src/backend/catalog/heap.c --- @@ -2543,8 +2551,55 @@ heap_drop_with_catalog(Oid relid) /* * External table? If so, delete

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433876 --- Diff: src/backend/catalog/cdb_external_extensions.sql --- @@ -47,3 +47,38 @@ LANGUAGE C STABLE; CREATE OR REPLACE FUNCTION fixedwidth_out

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433762 --- Diff: contrib/exthdfs/exthdfs.c --- @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433663 --- Diff: contrib/exthdfs/exthdfs.c --- @@ -0,0 +1,472 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433613 --- Diff: contrib/exthdfs/common.h --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433457 --- Diff: contrib/extfmtcsv/Makefile --- @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one --- End diff

[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

2018-08-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1384#discussion_r208433287 --- Diff: contrib/Makefile --- @@ -9,7 +9,9 @@ WANTED_DIRS = \ extprotocol \ gp_cancel_query

[GitHub] incubator-hawq issue #1380: HAWQ-1636. Fix compile apache hawq failure due t...

2018-07-04 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1380 +1 ---

[GitHub] incubator-hawq pull request #1343: HAWQ-1590. bump hawq version to 2.3 in co...

2018-02-20 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1343 ---

[GitHub] incubator-hawq pull request #1343: HAWQ-1590. bump hawq version to 2.3 in co...

2018-02-20 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1343 HAWQ-1590. bump hawq version to 2.3 in contrib/hawq-ambari-plugin/build.properties for Apache HAWQ 2.3.0.0-incubating Release @jiny2 @radarwave @ztao1987, please review You can merge

[GitHub] incubator-hawq pull request #1342: HAWQ-1589. bump hawq version to 2.3 in po...

2018-02-20 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1342 HAWQ-1589. bump hawq version to 2.3 in pom.xml for Apache HAWQ 2.3.0.0-incubating Release You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq issue #1338: HAWQ-1586. Update version from 2.2.0.0 to 2.3.0....

2018-02-07 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1338 LGMT +1 for the version bump ---

[GitHub] incubator-hawq issue #1327: HAWQ-1566. Include Pluggable Storage Format Fram...

2018-01-01 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1327 Looks good +1 ---

[GitHub] incubator-hawq issue #1321: HAWQ-1565. Include Pluggable Storage Format Fram...

2017-12-07 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1321 Looks great to have performance gain in pluggable storage framework. +1 Is there any evaluation regarding the performance boost comparing with existing external table framework? ---

[GitHub] incubator-hawq pull request #1320: HAWQ-1564. Add Pluggable Storage Dependen...

2017-12-05 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1320#discussion_r155131160 --- Diff: src/backend/access/external/url.c --- @@ -2318,7 +2321,24 @@ InvokeExtProtocol(void *ptr, extprotocol

[GitHub] incubator-hawq pull request #1320: HAWQ-1564. Add Pluggable Storage Dependen...

2017-12-05 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1320#discussion_r155131380 --- Diff: src/include/access/relscan.h --- @@ -127,6 +132,16 @@ typedef struct FileScanDescData /* custom data formatter

[GitHub] incubator-hawq issue #1314: HAWQ-1555. Add access interfaces for protocol an...

2017-12-01 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1314 Great to wrap up the pluggable storage framework work and start merging the work! +1 ---

[GitHub] incubator-hawq issue #1259: HAWQ-1489. Add LICENSE, DISCLAIMER and NOTICE to...

2017-06-22 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1259 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1259: HAWQ-1489. Add LICENSE, DISCLAIMER and NOTICE to...

2017-06-22 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1259 Seems the pxf package include below binary. However, they are not reflected this change. ``` pxf-hbase-3.2.1.0-1.el6.noarch/usr/lib/pxf-3.2.1.0/pxf-hbase-3.2.1.0.jar pxf-hbase

[GitHub] incubator-hawq pull request #1259: HAWQ-1489. Add LICENSE, DISCLAIMER and NO...

2017-06-22 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1259#discussion_r123662953 --- Diff: pxf/resources/META-INF/LICENSE --- @@ -0,0 +1,380 @@ + Apache License

[GitHub] incubator-hawq issue #1243: HAWQ-1458. Fix share input scan bug for writer p...

2017-06-21 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1243 Merge the fix based on review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request #1257: HAWQ-1487. Fix hang process due to deadlo...

2017-06-21 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-hawq issue #1257: HAWQ-1487. Fix hang process due to deadlock when...

2017-06-19 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1257 @radarwave, @linwen, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hawq pull request #1257: HAWQ-1487. Fix hang process due to deadlo...

2017-06-15 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1257 HAWQ-1487. Fix hang process due to deadlock when it try to process interrupt in error handling You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-06-07 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @edespino, closing the PR. Thanks for the notification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCL...

2017-06-07 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-06-05 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 Thanks @edespino for your feedback. I have bundled the license/* in hawq binary release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-05-31 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @rvs, we have separate rpm packages for hawq c/c++ components, and java components (pxf, ranger). ```hawq_rpm_packages ├── apache-hawq-2.2.0.0-el7.x86_64.rpm ├─â

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-05-30 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @rvs, thanks for the review and feedback. You are right. We expand the LICENSE for source release by adding extra dependency to get that for binary release. Here is the changes

[GitHub] incubator-hawq issue #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER f...

2017-05-27 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1246 @rvs, @edespino, @paul-guo- @radarwave, please review and let us know your feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-hawq pull request #1246: HAWQ-1475. Add LICENSE, NOTICE, and DISCL...

2017-05-27 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1246 HAWQ-1475. Add LICENSE, NOTICE, and DISCLAIMER files for Apache HAWQ binary release This commit includes: 1. The LICENSE, NOTICE, and DISCLAIMER files for Apache HAWQ c/c++ components

[GitHub] incubator-hawq issue #1243: HAWQ-1458. Fix share input scan bug for writer p...

2017-05-24 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1243 +1 for the improvement --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...

2017-05-24 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1243#discussion_r118204222 --- Diff: src/backend/executor/nodeMaterial.c --- @@ -41,14 +41,16 @@ #include "postgres.h" --- End diff -- lock would

[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...

2017-05-21 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1243#discussion_r117661684 --- Diff: src/backend/executor/nodeShareInputScan.c --- @@ -552,11 +551,59 @@ static void sisc_lockname(char* p, int size, int share_id, const char

[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...

2017-05-21 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1243#discussion_r117663096 --- Diff: src/backend/executor/nodeShareInputScan.c --- @@ -666,6 +717,29 @@ static int retry_write(int fd, char *buf, int wsize) return 0

[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...

2017-05-21 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1243#discussion_r117661994 --- Diff: src/backend/executor/nodeShareInputScan.c --- @@ -552,11 +551,59 @@ static void sisc_lockname(char* p, int size, int share_id, const char

[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...

2017-05-21 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1243#discussion_r117663528 --- Diff: src/backend/executor/nodeShareInputScan.c --- @@ -793,15 +877,68 @@ shareinput_reader_waitready(int share_id, PlanGenerator planGen

[GitHub] incubator-hawq pull request #1243: HAWQ-1458. Fix share input scan bug for w...

2017-05-21 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1243#discussion_r117661841 --- Diff: src/backend/executor/nodeShareInputScan.c --- @@ -552,11 +551,59 @@ static void sisc_lockname(char* p, int size, int share_id, const char

[GitHub] incubator-hawq issue #1240: HAWQ-1465. Disable alter schema help doc

2017-05-15 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1240 +1 for the improvement. Thanks @ztao1987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq issue #1232: HAWQ-1455. Wrong results on CTAS query over cata...

2017-05-10 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1232 +1 for the fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1192: HAWQ-1412. Fix inconsistent json file for...

2017-05-07 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-hawq pull request #1190: HAWQ-1411. Fix inconsistent json file for...

2017-05-07 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-hawq pull request #1211: HAWQ-1425. Print error message if ssh con...

2017-04-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1211#discussion_r110327071 --- Diff: tools/bin/hawqpylib/hawqlib.py --- @@ -203,6 +203,13 @@ def check_hostname_equal(remote_host, user = ""): cmd =

[GitHub] incubator-hawq pull request #1211: HAWQ-1425. Print error message if ssh con...

2017-04-07 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1211#discussion_r110323503 --- Diff: tools/bin/hawqpylib/hawqlib.py --- @@ -203,6 +203,13 @@ def check_hostname_equal(remote_host, user = ""): cmd =

[GitHub] incubator-hawq issue #1211: HAWQ-1425. Print error message if ssh connect fa...

2017-04-06 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1211 +1 for the fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...

2017-04-06 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 +1 for the fix as the mock of the verification is not feasible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-hawq issue #1210: HAWQ-1423. cmock framework does not recognize __...

2017-04-05 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1210 +1 for the improving cmock --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-hawq issue #1203: HAWQ-1420: Enable build of Ranger plugin open so...

2017-03-31 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1203 +1 for building ranger rpm for apache hawq --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq issue #1208: HAWQ-1421. PXF rpm updates to make it oss friend...

2017-03-31 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1208 +1 for great effort to building hawq with apache hadoop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...

2017-03-29 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 @liming01, the mock file for analyze is generated. The way to add mock is at: https://github.com/apache/incubator-hawq/blob/master/src/test/unit/README.txt. Please take a look and see

[GitHub] incubator-hawq issue #1198: HAWQ-1417. Fixed crash when ANALYZE after COPY b...

2017-03-28 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1198 The fix looks good. Is it possible to add unit test for it in src/test/unit/mock/backend/commands/analyze_mock.c? --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-hawq pull request #1198: HAWQ-1417. Fixed crash when ANALYZE after...

2017-03-28 Thread huor
Github user huor commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1198#discussion_r108427680 --- Diff: src/backend/commands/analyze.c --- @@ -476,6 +477,11 @@ void analyzeStmt(VacuumStmt *stmt, List *relids, int preferred_seg_num

[GitHub] incubator-hawq pull request #1188: HAWQ-1406. Update HAWQ product version st...

2017-03-27 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-hawq issue #1195: HAWQ-326. Support RPM package for Apache HAWQ.

2017-03-27 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1195 +1 for making the rpm build available for hawq! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-hawq pull request #1193: HAWQ-1406. Update hawq version in pom.xml...

2017-03-27 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1193 HAWQ-1406. Update hawq version in pom.xml for hawq 2.2.0.0 incubating release You can merge this pull request into a Git repository by running: $ git pull https://github.com/huor

[GitHub] incubator-hawq issue #1188: HAWQ-1406. Update HAWQ product version strings f...

2017-03-27 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1188 The json file has been updated based on latest code base. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-hawq pull request #1192: HAWQ-1412. Fix inconsistent json file for...

2017-03-27 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1192 HAWQ-1412. Fix inconsistent json file for catalog of hawq 2.0 The 2.0 json file is created based on hawq 2.0.0.0-incubating code base and instruction at https://cwiki.apache.org/confluence

[GitHub] incubator-hawq pull request #1191: HAWQ-1412. Fix inconsistent json file for...

2017-03-27 Thread huor
Github user huor closed the pull request at: https://github.com/apache/incubator-hawq/pull/1191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-hawq pull request #1191: HAWQ-1412. Fix inconsistent json file for...

2017-03-27 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1191 HAWQ-1412. Fix inconsistent json file for catalog of hawq 2.0 The 2.0 json file is created based on hawq 2.0.0.0-incubating code base and instruction at https://cwiki.apache.org/confluence

[GitHub] incubator-hawq pull request #1190: HAWQ-1411. Fix inconsistent json file for...

2017-03-27 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1190 HAWQ-1411. Fix inconsistent json file for catalog of hawq 2.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/huor/incubator-hawq

[GitHub] incubator-hawq issue #1188: HAWQ-1406. Update HAWQ product version strings f...

2017-03-27 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1188 @stanlyxiang, you are right. The json need to be consistently for corresponding hawq version. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-hawq issue #1188: HAWQ-1406. Update HAWQ product version strings f...

2017-03-24 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1188 @edespino, @shivzone, @denalex, @radarwave, @paul-guo-, please review. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-hawq pull request #1188: HAWQ-1406. Update HAWQ product version st...

2017-03-24 Thread huor
GitHub user huor opened a pull request: https://github.com/apache/incubator-hawq/pull/1188 HAWQ-1406. Update HAWQ product version strings for 2.2.0.0-incubating release Update HAWQ and HAWQ Ambari Plugin version strings for 2.2.0.0-incubating release. You can merge this pull

[GitHub] incubator-hawq issue #1183: HAWQ-1400. An improvement in SQL Util destructor...

2017-03-22 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1183 +1 for the fix. The clarification looks better to have root cause --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.

2017-03-22 Thread huor
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 Great to have the fix for build. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   >