[GitHub] incubator-hawq issue #1256: HAWQ-1485. fix exception of decryptPassword twic...

[interma]

Github user interma commented on the issue:

https://github.com/apache/incubator-hawq/pull/1256
  
@linwen @zhangh43 @stanlyxiang help to review again, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1256: HAWQ-1485. fix exception of decryptPasswo...

[interma]

Github user interma commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1256#discussion_r122109467
  
--- Diff: 
ranger-plugin/admin-plugin/src/main/java/org/apache/hawq/ranger/service/RangerServiceHawq.java
 ---
@@ -112,7 +119,7 @@ private void decryptPassword(Map 
configs) throws Exception {
 // when decrypt failed do nothing
 LOG.warn("decrypt_password failed: " + e);
 }
-configs.put("password", normal_password);
+configs.put("password_jdbc", normal_password);
--- End diff --

put the decrypted password into a new field, so it doesn't influence the 
BaseClient decrypt it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1256: HAWQ-1485. fix exception of decryptPasswo...

[interma]

GitHub user interma opened a pull request:

https://github.com/apache/incubator-hawq/pull/1256

HAWQ-1485. fix exception of decryptPassword twice in lookupResource()

In my earlier PR,  *decryptPassword()* is called in the beginning of 
*lookupResource()*, but *BaseClient* (a ranger lib) also need decrypt password 
in some situation, decrypt twice will cause a exception.

This PR fixed this issue. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/interma/interma-hawq hawq-1485

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1256


commit ee200369c80df50947571fb04b51684ec19f02be
Author: interma 
Date:   2017-06-14T10:22:50Z

HAWQ-1485. fix exception of decryptPassword twice in lookupResource()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1255: HAWQ-1486. Catch error out on NULL condit...

[Quikling]

GitHub user Quikling opened a pull request:

https://github.com/apache/incubator-hawq/pull/1255

HAWQ-1486. Catch error out on NULL condition for churl_init_download

Please review: @sansanichfb & @shivzone 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Quikling/incubator-hawq GPSQL-3370

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1255






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (HAWQ-1486) PANIC accessing PXF HDFS table

[John Gaskin (JIRA)]

John Gaskin created HAWQ-1486:
-

 Summary: PANIC accessing PXF HDFS table
 Key: HAWQ-1486
 URL: https://issues.apache.org/jira/browse/HAWQ-1486
 Project: Apache HAWQ
  Issue Type: Bug
  Components: External Tables, PXF
Reporter: John Gaskin
Assignee: Vineet Goel
 Fix For: 2.3.0.0-incubating


This code doesn't catch the case when churl_init_download() returns NULL. This 
seems to trigger a segfault at libcurl level.
{code}
Looks like we failed to connect to PXF (?).

Piece of code in HAWQ handling cUrl calls (pxfutils.c):

 100 static void process_request(ClientContext* client_context, char *uri)
 101 {
 102 size_t n = 0;
 103 char buffer[RAW_BUF_SIZE];
 104
 105 print_http_headers(client_context->http_headers);
 106 client_context->handle = churl_init_download(uri, 
client_context->http_headers);
 107 memset(buffer, 0, RAW_BUF_SIZE);
 108 resetStringInfo(&(client_context->the_rest_buf));
 109
 110 /*
 111  * This try-catch ensures that in case of an exception during the 
"communication with PXF and the accumulation of
 112  * PXF data in client_context->the_rest_buf", we still get to 
terminate the libcurl connection nicely and avoid
 113  * leaving the PXF server connection hung.
 114  */
 115 PG_TRY();
 116 {
 117 /* read some bytes to make sure the connection is established */
 118 churl_read_check_connectivity(client_context->handle);
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

[outofmem0ry]

Github user outofmem0ry commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
@linwen @stanlyxiang @radarwave - Thank you for the comments and 
suggestions.

@radarwave - Please see the comments inline

1. I think we should keep the legacy command to do reload in case it's hard 
coded in some user cases, print a deprecated message should be fine.

> The change that is committed prints a message as seen below and exits. I 
can change the message and let the command continue.

```
hawq stop cluster -u
To reload GUC values without restarting hawq cluster use 'hawq 
reload-config '
```
2. Make sure all the related help messages and documents are updated.

> This is something that will go into incubator-hawq-docs and am working on 
scoping the change for this.
3. Chose a proper name for this option before user start to use it, 
'reload' or 'reload-config' or something else?

> reload sounds good. Also, am open for any other suggestions

4. Add test for this option.

> Sure, let me see how we plug test into the codebase. Any pointers are 
appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

[radarwave]

Github user radarwave commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
Thanks @outofmem0ry to contribute this, please check below comments.
1. I think we should keep the legacy command to do reload in case it's hard 
coded in some user cases, print a deprecated message should be fine.
2. Make sure all the related help messages and documents are updated.
3. Chose a proper name for this option before user start to use it, 
'reload' or 'reload-config'  or something else?
4. Add test for this option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1253: HAWQ-1485. Use user/password instead of c...

[interma]

Github user interma closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1253


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (HAWQ-1480) Packing a core file in hawq

[Lin Wen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lin Wen resolved HAWQ-1480.
---
   Resolution: Fixed
Fix Version/s: 2.3.0.0-incubating

> Packing a core file in hawq
> ---
>
> Key: HAWQ-1480
> URL: https://issues.apache.org/jira/browse/HAWQ-1480
> Project: Apache HAWQ
>  Issue Type: Improvement
>  Components: Command Line Tools
>Reporter: Shubham Sharma
>Assignee: Radar Lei
> Fix For: 2.3.0.0-incubating
>
>
> Currently there is no way to packing a core file with its context – 
> executable, application and system shared libraries in hawq. This information 
> can be later unpacked on another system and helps in debugging. It is a 
> useful feature to quickly gather all the data needed from a crash/core 
> generated on the system to analyze it later.
> Another open source project, greenplum, uses a script 
> [https://github.com/greenplum-db/gpdb/blob/master/gpMgmt/sbin/packcore] to 
> collect this information. Tested this script against Hawq's installation and 
> it collects the required information needed for debug.
> Can this be merged into Hawq, if yes, I can submit a pull request and test it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

[stanlyxiang]

Github user stanlyxiang commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
If we add "hawq reload-config", I think there is no need for "hawq stop 
cluster -u". 2 commands have same function make me more confused. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1254: HAWQ-1373 - Added feature to reload GUC values u...

[linwen]

Github user linwen commented on the issue:

https://github.com/apache/incubator-hawq/pull/1254
  
Shubham, I think what you've done in this PR is to add a command for hawq, 
which can reload GUC configs without restarting the system. Currently, this is 
done by this command "hawq stop cluster --reload", which is a little bit 
ambiguous in my opinion. So if we all agree on using "hawq reload-config" 
instead, the old codes related to this reloading GUC logic should be removed. 
@radarwave @vVineet 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1253: HAWQ-1485. Use user/password instead of credenti...

[zhangh43]

Github user zhangh43 commented on the issue:

https://github.com/apache/incubator-hawq/pull/1253
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---