[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366513636 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[jira] [Commented] (HBASE-23331) Document HBASE-18095

2020-01-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015306#comment-17015306 ] Bharath Vissapragada commented on HBASE-23331: -- Cool, I'll add it there. > Document

[jira] [Commented] (HBASE-23331) Document HBASE-18095

2020-01-14 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015297#comment-17015297 ] Sean Busbey commented on HBASE-23331: - Over here:

[jira] [Commented] (HBASE-23569) Validate that the log cleaner actually cleans oldWALs as expected

2020-01-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015299#comment-17015299 ] Andrew Kyle Purtell commented on HBASE-23569: - +1 Agree, checking if the expected chores

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366505312 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#issuecomment-574313200 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-23331) Document HBASE-18095

2020-01-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015284#comment-17015284 ] Bharath Vissapragada commented on HBASE-23331: -- [~busbey] Where is this "design doc

[jira] [Commented] (HBASE-23647) Make MasterRegistry the default registry impl

2020-01-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015279#comment-17015279 ] Bharath Vissapragada commented on HBASE-23647: -- Yes. The plan is to back port this into

[jira] [Commented] (HBASE-23647) Make MasterRegistry the default registry impl

2020-01-14 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015276#comment-17015276 ] Sean Busbey commented on HBASE-23647: - This landing in HBase 3.0 should only happen if the feature

[jira] [Commented] (HBASE-23331) Document HBASE-18095

2020-01-14 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015274#comment-17015274 ] Sean Busbey commented on HBASE-23331: - please include the one-pager in the design doc collection >

[jira] [Created] (HBASE-23687) DEBUG logging cleanup

2020-01-14 Thread Michael Stack (Jira)
Michael Stack created HBASE-23687: - Summary: DEBUG logging cleanup Key: HBASE-23687 URL: https://issues.apache.org/jira/browse/HBASE-23687 Project: HBase Issue Type: Bug Affects

[jira] [Work started] (HBASE-23647) Make MasterRegistry the default registry impl

2020-01-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23647 started by Bharath Vissapragada. > Make MasterRegistry the default registry impl >

[GitHub] [hbase] bharathv opened a new pull request #1039: HBASE-23647: Make MasterRegistry the default impl.

2020-01-14 Thread GitBox
bharathv opened a new pull request #1039: HBASE-23647: Make MasterRegistry the default impl. URL: https://github.com/apache/hbase/pull/1039 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015255#comment-17015255 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #241 on

[jira] [Updated] (HBASE-23305) Implement master based AsyncRegistry

2020-01-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-23305: - Fix Version/s: HBASE-18095 Resolution: Fixed Status: Resolved

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366483832 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366483222 ## File path:

[GitHub] [hbase] bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366481436 ## File path:

[GitHub] [hbase] bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366480669 ## File path:

[GitHub] [hbase] bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366480794 ## File path:

[GitHub] [hbase] bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
bharathv commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366481247 ## File path:

[GitHub] [hbase] bharathv commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-14 Thread GitBox
bharathv commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032#issuecomment-574290782 Latest commit should fix the failing tests. This

[GitHub] [hbase] HorizonNet commented on a change in pull request #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils

2020-01-14 Thread GitBox
HorizonNet commented on a change in pull request #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils URL: https://github.com/apache/hbase/pull/1036#discussion_r366479141 ## File path:

[GitHub] [hbase] busbey commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive

2020-01-14 Thread GitBox
busbey commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive URL: https://github.com/apache/hbase/pull/1022#issuecomment-574289502 > On why we put all things on the WAL filesystem, partly because that I want to put all the data under a single

[GitHub] [hbase] busbey commented on a change in pull request #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive URL: https://github.com/apache/hbase/pull/1022#discussion_r366475845 ## File path:

[GitHub] [hbase] Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#issuecomment-574287986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible URL: https://github.com/apache/hbase/pull/1027#issuecomment-574285694 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] busbey commented on a change in pull request #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils URL: https://github.com/apache/hbase/pull/1036#discussion_r366471989 ## File path:

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366468548 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366467988 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366468396 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/MetaBrowser.java ##

[GitHub] [hbase] busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366464295 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java

[GitHub] [hbase] ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366463677 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/hamcrest/BytesMatchers.java

[jira] [Resolved] (HBASE-23383) [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23383. -- Resolution: Fixed Thanks for helping to kick the tires [~stack]. > [hbck2] `fixHoles` should

[GitHub] [hbase] Apache-HBase commented on issue #1037: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1037: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/1037#issuecomment-574273832 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hbase] ndimiduk merged pull request #1038: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread GitBox
ndimiduk merged pull request #1038: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/1038 This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on issue #1038: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1038: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/1038#issuecomment-574273755 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hbase] ndimiduk merged pull request #1037: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread GitBox
ndimiduk merged pull request #1037: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/1037 This is an automated message from the Apache

[jira] [Updated] (HBASE-23383) [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23383: - Fix Version/s: 2.2.4 2.3.0 > [hbck2] `fixHoles` should queue assignment

[GitHub] [hbase] ndimiduk opened a new pull request #1037: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread GitBox
ndimiduk opened a new pull request #1037: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/1037 The current process for an operator, after fixing holes in meta, is to manually disable and enable the

[GitHub] [hbase] ndimiduk opened a new pull request #1038: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread GitBox
ndimiduk opened a new pull request #1038: HBASE-23383 [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing URL: https://github.com/apache/hbase/pull/1038 The current process for an operator, after fixing holes in meta, is to manually disable and enable the

[GitHub] [hbase] HorizonNet opened a new pull request #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils

2020-01-14 Thread GitBox
HorizonNet opened a new pull request #1036: HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils URL: https://github.com/apache/hbase/pull/1036 Based on the feedback from Sean on #1034.

[jira] [Updated] (HBASE-23686) Revert binary incompatible change and remove reflection

2020-01-14 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-23686: -- Status: Patch Available (was: In Progress) > Revert binary incompatible change and remove

[jira] [Created] (HBASE-23686) Revert binary incompatible change and remove reflection

2020-01-14 Thread Jan Hentschel (Jira)
Jan Hentschel created HBASE-23686: - Summary: Revert binary incompatible change and remove reflection Key: HBASE-23686 URL: https://issues.apache.org/jira/browse/HBASE-23686 Project: HBase

[jira] [Work started] (HBASE-23686) Revert binary incompatible change and remove reflection

2020-01-14 Thread Jan Hentschel (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23686 started by Jan Hentschel. - > Revert binary incompatible change and remove reflection >

[GitHub] [hbase] HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366444309 ## File path:

[GitHub] [hbase] HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366443765 ## File path:

[GitHub] [hbase] HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366443618 ## File path:

[GitHub] [hbase] HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366443420 ## File path:

[GitHub] [hbase] HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
HorizonNet commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366443242 ## File path:

[GitHub] [hbase] ndimiduk merged pull request #954: HBASE-23305: Master based registry implementation

2020-01-14 Thread GitBox
ndimiduk merged pull request #954: HBASE-23305: Master based registry implementation URL: https://github.com/apache/hbase/pull/954 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (HBASE-23383) [hbck2] `fixHoles` should queue assignment procedures for any regions its fixing

2020-01-14 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015201#comment-17015201 ] Nick Dimiduk commented on HBASE-23383: -- Let me take it back as far as it'll go. > [hbck2]

[GitHub] [hbase] Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#issuecomment-574254715 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366414161 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366427054 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366428406 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366419293 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366425995 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366421166 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366430071 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366421334 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366431620 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366419982 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366426832 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366431026 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366429809 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366429733 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366430163 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366432164 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TesMobFileCleanerChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366429514 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -0,0

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366426311 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366413888 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366414002 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366418514 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions

2020-01-14 Thread GitBox
busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r366422348 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java ## @@ -0,0 +1,310

[GitHub] [hbase] virajjasani commented on issue #1006: HBASE-23045.currentPath may be stitched in a loop in replication source code.

2020-01-14 Thread GitBox
virajjasani commented on issue #1006: HBASE-23045.currentPath may be stitched in a loop in replication source code. URL: https://github.com/apache/hbase/pull/1006#issuecomment-574241320 Thanks for the fix @G302 Could you please also validate branch-1 patch to ensure if we can get

[GitHub] [hbase] Apache-HBase commented on issue #1035: HBASE-23669 ZNodeClearer#clear() throws IllegalArgumentException

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1035: HBASE-23669 ZNodeClearer#clear() throws IllegalArgumentException URL: https://github.com/apache/hbase/pull/1035#issuecomment-574234031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-23665) TestTableName is both a test class and a TestRule

2020-01-14 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015168#comment-17015168 ] HBase QA commented on HBASE-23665: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test…

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1032: HBASE-23665: Split unit tests from TestTableName into a separate test… URL: https://github.com/apache/hbase/pull/1032#issuecomment-574230749 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366398962 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java

[GitHub] [hbase] busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366385646 ## File path:

[GitHub] [hbase] busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366396488 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java

[GitHub] [hbase] busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366396601 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java

[GitHub] [hbase] busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
busbey commented on a change in pull request #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#discussion_r366382230 ## File path:

[jira] [Commented] (HBASE-23674) Too many rit page Numbers show confusion

2020-01-14 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015153#comment-17015153 ] HBase QA commented on HBASE-23674: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on issue #1033: HBASE-23677 region.jsp returns 500/NPE when provided encoded region name is not online

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1033: HBASE-23677 region.jsp returns 500/NPE when provided encoded region name is not online URL: https://github.com/apache/hbase/pull/1033#issuecomment-574212423 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime |

[GitHub] [hbase] Apache-HBase commented on issue #1020: HBASE-23653 Expose content of meta table in web ui

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#issuecomment-574202556 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] wchevreuil commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible

2020-01-14 Thread GitBox
wchevreuil commented on issue #1027: HBASE-23683 Make HBaseInterClusterReplicationEndpoint more extensible URL: https://github.com/apache/hbase/pull/1027#issuecomment-574199277 Thanks for the reviews @bharathv, @binlijin and @joshelser. > Maybe something we should lift up to an

[jira] [Commented] (HBASE-23684) NPE HFilesOutputSink

2020-01-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015113#comment-17015113 ] Duo Zhang commented on HBASE-23684: --- [~zghao]. PTAL. > NPE HFilesOutputSink > >

[GitHub] [hbase] Apache9 commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive

2020-01-14 Thread GitBox
Apache9 commented on issue #1022: HBASE-23680 RegionProcedureStore missing cleaning of hfile archive URL: https://github.com/apache/hbase/pull/1022#issuecomment-574195642 Ping @saintstack This is an automated message from

[GitHub] [hbase] Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…

2020-01-14 Thread GitBox
Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin… URL: https://github.com/apache/hbase/pull/1018#issuecomment-574195516 Ping @ndimiduk @saintstack This is an automated

[GitHub] [hbase] Apache9 commented on a change in pull request #762: HBASE-23157 WAL unflushed seqId tracking may wrong when Durability.AS…

2020-01-14 Thread GitBox
Apache9 commented on a change in pull request #762: HBASE-23157 WAL unflushed seqId tracking may wrong when Durability.AS… URL: https://github.com/apache/hbase/pull/762#discussion_r366362860 ## File path:

[jira] [Commented] (HBASE-23685) indicates a last flushed sequence id ... that is less than the previous last flushed sequence id

2020-01-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015110#comment-17015110 ] Duo Zhang commented on HBASE-23685: --- HBASE-23157? > indicates a last flushed sequence id ... that is

[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common URL: https://github.com/apache/hbase/pull/1030#issuecomment-574177429 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common

2020-01-14 Thread GitBox
Apache-HBase commented on issue #1034: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/1034#issuecomment-574156111 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] binlijin commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
binlijin commented on issue #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#issuecomment-574142496 > LGTM overall. Can you also add test cases to ensure we don't run into this one again (at least for the

[GitHub] [hbase] binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366300544 ## File path:

[GitHub] [hbase] binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

2020-01-14 Thread GitBox
binlijin commented on a change in pull request #1026: HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore URL: https://github.com/apache/hbase/pull/1026#discussion_r366300595 ## File path:

[GitHub] [hbase] mygood commented on issue #1016: HBASE-23656 [MERGETOOL] HBASE Support Merge region by pattern

2020-01-14 Thread GitBox
mygood commented on issue #1016: HBASE-23656 [MERGETOOL] HBASE Support Merge region by pattern URL: https://github.com/apache/hbase/pull/1016#issuecomment-574135797 @saintstack Thank you review code This is an automated

[GitHub] [hbase] Gkkkk302 commented on issue #1035: HBASE-23669 ZNodeClearer#clear() throws IllegalArgumentException

2020-01-14 Thread GitBox
G302 commented on issue #1035: HBASE-23669 ZNodeClearer#clear() throws IllegalArgumentException URL: https://github.com/apache/hbase/pull/1035#issuecomment-574074050 It looks like hbase-14861 is not fully repaired This

<    1   2   3   >