[GitHub] [hbase] Apache-HBase commented on pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1781: URL: https://github.com/apache/hbase/pull/1781#issuecomment-634445710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-634442764 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-634431891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anoopsjohn commented on a change in pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-26 Thread GitBox
anoopsjohn commented on a change in pull request #1783: URL: https://github.com/apache/hbase/pull/1783#discussion_r430859985 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -695,6 +695,7 @@ void sawNoSuchFamily() { private

[jira] [Commented] (HBASE-24379) CatalogJanitor misreports region holes when there are actually over laps.

2020-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117394#comment-17117394 ] Hudson commented on HBASE-24379: Results for branch branch-2.3 [build #106 on

[jira] [Commented] (HBASE-24416) RegionNormalizer spliting region should not be limited by hbase.normalizer.min.region.count

2020-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117393#comment-17117393 ] Hudson commented on HBASE-24416: Results for branch branch-2.3 [build #106 on

[jira] [Commented] (HBASE-24437) Flaky test, TestLocalRegionOnTwoFileSystems#testFlushAndCompact

2020-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117395#comment-17117395 ] Hudson commented on HBASE-24437: Results for branch branch-2.3 [build #106 on

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-634423961 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634422331 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-connectors] saintstack commented on a change in pull request #68: HBASE-20999 Move hbase-REST to new hbase-connectors repository

2020-05-26 Thread GitBox
saintstack commented on a change in pull request #68: URL: https://github.com/apache/hbase-connectors/pull/68#discussion_r430850242 ## File path: hbase-connectors-protocol-shaded/pom.xml ## @@ -0,0 +1,275 @@ + Review comment: License is missing.

[jira] [Updated] (HBASE-20999) Move hbase-REST to new hbase-connectors repository

2020-05-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20999: -- Fix Version/s: 3.0.0-alpha-1 > Move hbase-REST to new hbase-connectors repository >

[jira] [Updated] (HBASE-20999) Move hbase-REST to new hbase-connectors repository

2020-05-26 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20999: -- Fix Version/s: 2.4.0 > Move hbase-REST to new hbase-connectors repository >

[GitHub] [hbase-connectors] CodingBen opened a new pull request #68: HBASE-20999 Move hbase-REST to new hbase-connectors repository

2020-05-26 Thread GitBox
CodingBen opened a new pull request #68: URL: https://github.com/apache/hbase-connectors/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache9 merged pull request #1787: HBASE-24437 Addendum just start mini dfs cluster, and make the log ro…

2020-05-26 Thread GitBox
Apache9 merged pull request #1787: URL: https://github.com/apache/hbase/pull/1787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 merged pull request #1746: HBASE-24388 Store the locations of meta regions in master local store

2020-05-26 Thread GitBox
Apache9 merged pull request #1746: URL: https://github.com/apache/hbase/pull/1746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on a change in pull request #1746: HBASE-24388 Store the locations of meta regions in master local store

2020-05-26 Thread GitBox
saintstack commented on a change in pull request #1746: URL: https://github.com/apache/hbase/pull/1746#discussion_r430831105 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java ## @@ -1403,6 +1403,21 @@ private static void

[GitHub] [hbase] clarax commented on a change in pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
clarax commented on a change in pull request #1781: URL: https://github.com/apache/hbase/pull/1781#discussion_r430772485 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java ## @@ -592,9 +593,9 @@ public void

[GitHub] [hbase] bharathv commented on a change in pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-26 Thread GitBox
bharathv commented on a change in pull request #1755: URL: https://github.com/apache/hbase/pull/1755#discussion_r430767349 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -1972,6 +1975,13 @@ private void unassign(final

[GitHub] [hbase] VicoWu commented on a change in pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-05-26 Thread GitBox
VicoWu commented on a change in pull request #1764: URL: https://github.com/apache/hbase/pull/1764#discussion_r430826279 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java ## @@ -879,13 +881,21 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #1777: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1777: URL: https://github.com/apache/hbase/pull/1777#issuecomment-633749711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] bharathv merged pull request #1779: HBASE-24423 No need to get lock in canSplit because hasReferences wil…

2020-05-26 Thread GitBox
bharathv merged pull request #1779: URL: https://github.com/apache/hbase/pull/1779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1779: HBASE-24423 No need to get lock in canSplit because hasReferences wil…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1779: URL: https://github.com/apache/hbase/pull/1779#issuecomment-633847000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] pengmq1 commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-05-26 Thread GitBox
pengmq1 commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r430830542 ## File path: dev-support/design-docs/HBASE-24289-Heterogeneous Storage for Date Tiered Compaction.md ## @@ -0,0 +1,122 @@ + + +# Heterogeneous Storage

[GitHub] [hbase] javierluca commented on pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
javierluca commented on pull request #1781: URL: https://github.com/apache/hbase/pull/1781#issuecomment-633963904 I see. Seems line number was not added in the original commit: https://github.com/apache/hbase/commit/71ed7033675149956de855b6782e1e22fc908dc8

[GitHub] [hbase] huaxiangsun commented on a change in pull request #769: HBASE-23202 ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL

2020-05-26 Thread GitBox
huaxiangsun commented on a change in pull request #769: URL: https://github.com/apache/hbase/pull/769#discussion_r430663274 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java ## @@ -251,6 +261,31 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #1771: HBASE-24425 Run hbck_chore_run and catalogjanitor_run on draw of 'HBC…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1771: URL: https://github.com/apache/hbase/pull/1771#issuecomment-634229560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] bsglz commented on pull request #1767: HBASE-24423 No need to get lock in canSplit because hasReferences wil…

2020-05-26 Thread GitBox
bsglz commented on pull request #1767: URL: https://github.com/apache/hbase/pull/1767#issuecomment-633820229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Reidddddd commented on a change in pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
Reidd commented on a change in pull request #1781: URL: https://github.com/apache/hbase/pull/1781#discussion_r430829094 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ## @@ -819,6 +832,16 @@ public long

[GitHub] [hbase] apurtell commented on a change in pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
apurtell commented on a change in pull request #1781: URL: https://github.com/apache/hbase/pull/1781#discussion_r430741232 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ## @@ -40,7 +41,9 @@ import

[GitHub] [hbase] ndimiduk opened a new pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-26 Thread GitBox
ndimiduk opened a new pull request #1786: URL: https://github.com/apache/hbase/pull/1786 Simplify our Normalizer story to have just a single, configurable implementation. * fold the features of `MergeNormalizer` into `SimpleRegionNormalizer`, removing the intermediate

[GitHub] [hbase] mattf-apache commented on pull request #1620: HBASE-23339 Release scripts should use forwarded gpg-agent

2020-05-26 Thread GitBox
mattf-apache commented on pull request #1620: URL: https://github.com/apache/hbase/pull/1620#issuecomment-634270546 Looking... This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hbase] Apache-HBase commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634369412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-05-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r430245575 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java ## @@ -547,6 +553,22 @@ public StoreFileWriter build()

[GitHub] [hbase] Apache-HBase commented on pull request #1785: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1785: URL: https://github.com/apache/hbase/pull/1785#issuecomment-634301027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #1776: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1776: URL: https://github.com/apache/hbase/pull/1776#issuecomment-633750078 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] bharathv merged pull request #1778: HBASE-24423 No need to get lock in canSplit because hasReferences wil…

2020-05-26 Thread GitBox
bharathv merged pull request #1778: URL: https://github.com/apache/hbase/pull/1778 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase-native-client] phrocker commented on a change in pull request #2: HBASE-24400: Fixup cmake infrastructure to allow dependencies to be built locally

2020-05-26 Thread GitBox
phrocker commented on a change in pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r430331425 ## File path: cmake/DownloadFolly.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [hbase] infraio merged pull request #1780: HBASE-24433 Add 2.2.5 to download page

2020-05-26 Thread GitBox
infraio merged pull request #1780: URL: https://github.com/apache/hbase/pull/1780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on pull request #1771: HBASE-24425 Run hbck_chore_run and catalogjanitor_run on draw of 'HBC…

2020-05-26 Thread GitBox
saintstack commented on pull request #1771: URL: https://github.com/apache/hbase/pull/1771#issuecomment-634226756 Address @virajjasani suggestions. @HorizonNet I pushed against branch-2 since that is what I know and its stable will forward port when all is good. Thanks

[GitHub] [hbase] ddupg opened a new pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-05-26 Thread GitBox
ddupg opened a new pull request #1782: URL: https://github.com/apache/hbase/pull/1782 JIRA: https://issues.apache.org/jira/browse/HBASE-24431 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] huaxiangsun opened a new pull request #1776: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
huaxiangsun opened a new pull request #1776: URL: https://github.com/apache/hbase/pull/1776 …ually over laps. (#1741) Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #1748: HBASE-22700 (addendum): Clarify ZK session timeout doc

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1748: URL: https://github.com/apache/hbase/pull/1748#issuecomment-634355041 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] infraio commented on a change in pull request #1746: HBASE-24388 Store the locations of meta regions in master local store

2020-05-26 Thread GitBox
infraio commented on a change in pull request #1746: URL: https://github.com/apache/hbase/pull/1746#discussion_r430349196 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -225,23 +230,52 @@ public void start()

[GitHub] [hbase] huaxiangsun merged pull request #1777: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
huaxiangsun merged pull request #1777: URL: https://github.com/apache/hbase/pull/1777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1746: HBASE-24388 Store the locations of meta regions in master local store

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1746: URL: https://github.com/apache/hbase/pull/1746#issuecomment-633781860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] huaxiangsun merged pull request #1768: Backport: HBASE-24369 Provide more information about merged child regions in Hb…

2020-05-26 Thread GitBox
huaxiangsun merged pull request #1768: URL: https://github.com/apache/hbase/pull/1768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] HorizonNet commented on a change in pull request #1780: HBASE-24433 Add 2.2.5 to download page

2020-05-26 Thread GitBox
HorizonNet commented on a change in pull request #1780: URL: https://github.com/apache/hbase/pull/1780#discussion_r430222936 ## File path: src/site/xdoc/downloads.xml ## @@ -45,24 +45,24 @@ under the License. -2.2.4 +2.2.5 -

[GitHub] [hbase] Apache-HBase commented on pull request #1775: fix building cpp-example DemoClient

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1775: URL: https://github.com/apache/hbase/pull/1775#issuecomment-633683883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1782: URL: https://github.com/apache/hbase/pull/1782#issuecomment-634017992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] bharathv merged pull request #1767: HBASE-24423 No need to get lock in canSplit because hasReferences wil…

2020-05-26 Thread GitBox
bharathv merged pull request #1767: URL: https://github.com/apache/hbase/pull/1767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1711: HBASE-24371 Add more details when print CompactionConfiguration info

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1711: URL: https://github.com/apache/hbase/pull/1711#issuecomment-634090420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] javierluca commented on a change in pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
javierluca commented on a change in pull request #1781: URL: https://github.com/apache/hbase/pull/1781#discussion_r430833826 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ## @@ -819,6 +832,16 @@ public long

[GitHub] [hbase] javierluca edited a comment on pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
javierluca edited a comment on pull request #1781: URL: https://github.com/apache/hbase/pull/1781#issuecomment-633963904 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Apache9 commented on pull request #1787: HBASE-24437 Addendum just start mini dfs cluster, and make the log ro…

2020-05-26 Thread GitBox
Apache9 commented on pull request #1787: URL: https://github.com/apache/hbase/pull/1787#issuecomment-634385918 @saintstack FYI. Anyway, the requestRollAll has been used at some critical places, such as in sync replication, for keeping data consistent between two clusters, so if it

[GitHub] [hbase] apurtell commented on a change in pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-26 Thread GitBox
apurtell commented on a change in pull request #1755: URL: https://github.com/apache/hbase/pull/1755#discussion_r430708920 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -1972,6 +1975,13 @@ private void unassign(final

[GitHub] [hbase] infraio commented on pull request #1770: HBASE-24416 RegionNormalizer spliting region should not be limited by…

2020-05-26 Thread GitBox
infraio commented on pull request #1770: URL: https://github.com/apache/hbase/pull/1770#issuecomment-633788968 https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1770/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt generate a new checkstyle problem?

[GitHub] [hbase] saintstack commented on a change in pull request #1771: HBASE-24425 Run hbck_chore_run and catalogjanitor_run on draw of 'HBC…

2020-05-26 Thread GitBox
saintstack commented on a change in pull request #1771: URL: https://github.com/apache/hbase/pull/1771#discussion_r430649459 ## File path: hbase-server/src/main/resources/hbase-webapps/master/hbck.jsp ## @@ -37,9 +37,17 @@ <%@ page import="org.apache.hadoop.hbase.util.Pair"

[GitHub] [hbase] Apache-HBase commented on pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1781: URL: https://github.com/apache/hbase/pull/1781#issuecomment-634106442 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] ndimiduk commented on pull request #1786: HBASE-24418 Consolidate Normalizer implementations

2020-05-26 Thread GitBox
ndimiduk commented on pull request #1786: URL: https://github.com/apache/hbase/pull/1786#issuecomment-634358652 I intend to backport this at least to branch-2.3. I think branch-2.2 needs some other patches before this would apply. PTAL, @saintstack @Apache9 @infraio @huaxiangsun

[GitHub] [hbase] huaxiangsun merged pull request #1769: Backport: HBASE-24369 Provide more information about merged child regions in Hb…

2020-05-26 Thread GitBox
huaxiangsun merged pull request #1769: URL: https://github.com/apache/hbase/pull/1769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-634393134 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] saintstack merged pull request #1771: HBASE-24425 Run hbck_chore_run and catalogjanitor_run on draw of 'HBC…

2020-05-26 Thread GitBox
saintstack merged pull request #1771: URL: https://github.com/apache/hbase/pull/1771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…

2020-05-26 Thread GitBox
ramkrish86 commented on a change in pull request #1552: URL: https://github.com/apache/hbase/pull/1552#discussion_r430396089 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -2884,4 +2901,41 @@ public int

[GitHub] [hbase] Apache9 commented on a change in pull request #1746: HBASE-24388 Store the locations of meta regions in master local store

2020-05-26 Thread GitBox
Apache9 commented on a change in pull request #1746: URL: https://github.com/apache/hbase/pull/1746#discussion_r430369088 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java ## @@ -225,23 +230,52 @@ public void start()

[GitHub] [hbase] Apache9 opened a new pull request #1787: HBASE-24437 Addendum just start mini dfs cluster, and make the log ro…

2020-05-26 Thread GitBox
Apache9 opened a new pull request #1787: URL: https://github.com/apache/hbase/pull/1787 …ll more robust This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] infraio merged pull request #1770: HBASE-24416 RegionNormalizer spliting region should not be limited by…

2020-05-26 Thread GitBox
infraio merged pull request #1770: URL: https://github.com/apache/hbase/pull/1770 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] huaxiangsun opened a new pull request #1777: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
huaxiangsun opened a new pull request #1777: URL: https://github.com/apache/hbase/pull/1777 …ually over laps. (#1741) Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1783: URL: https://github.com/apache/hbase/pull/1783#issuecomment-634165067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] huaxiangsun opened a new pull request #1785: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
huaxiangsun opened a new pull request #1785: URL: https://github.com/apache/hbase/pull/1785 …ually over laps. (#1741) Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] apurtell commented on a change in pull request #1748: HBASE-22700 (addendum): Clarify ZK session timeout doc

2020-05-26 Thread GitBox
apurtell commented on a change in pull request #1748: URL: https://github.com/apache/hbase/pull/1748#discussion_r430742337 ## File path: src/main/asciidoc/_chapters/schema_design.adoc ## @@ -1142,7 +1142,11 @@ Disable Nagle’s algorithm. Delayed ACKs can add up to ~200ms to

[GitHub] [hbase] Apache9 commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-26 Thread GitBox
Apache9 commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-633619575 Based on #1746 . Still has some problems need to be fixed in this issue and also some problems should be done in follow-on issues. The main problem here is that we

[GitHub] [hbase] huaxiangsun commented on pull request #1776: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
huaxiangsun commented on pull request #1776: URL: https://github.com/apache/hbase/pull/1776#issuecomment-634162602 The test failure is about precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.store.TestLocalRegionOnTwoFileSystems.testFlushAndCompactFailing

[GitHub] [hbase] bharathv opened a new pull request #1778: HBASE-24423 No need to get lock in canSplit because hasReferences wil…

2020-05-26 Thread GitBox
bharathv opened a new pull request #1778: URL: https://github.com/apache/hbase/pull/1778 …l get lock too Signed-off-by: Bharath Vissapragada This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #1787: HBASE-24437 Addendum just start mini dfs cluster, and make the log ro…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1787: URL: https://github.com/apache/hbase/pull/1787#issuecomment-634397535 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-633630473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] bharathv opened a new pull request #1779: HBASE-24423 No need to get lock in canSplit because hasReferences wil…

2020-05-26 Thread GitBox
bharathv opened a new pull request #1779: URL: https://github.com/apache/hbase/pull/1779 …l get lock too Signed-off-by: Bharath Vissapragada This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Joseph295 opened a new pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-26 Thread GitBox
Joseph295 opened a new pull request #1783: URL: https://github.com/apache/hbase/pull/1783 …d at the region level This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] javierluca opened a new pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
javierluca opened a new pull request #1781: URL: https://github.com/apache/hbase/pull/1781 https://issues.apache.org/jira/browse/HBASE-24435 Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java Cherry-picked

[jira] [Resolved] (HBASE-24388) Store the locations of meta regions in master local store

2020-05-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24388. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to branch HBASE-11288.spliitable-meta.

[GitHub] [hbase] bharathv commented on a change in pull request #1775: fix building cpp-example DemoClient

2020-05-26 Thread GitBox
bharathv commented on a change in pull request #1775: URL: https://github.com/apache/hbase/pull/1775#discussion_r430167887 ## File path: hbase-examples/src/main/cpp/DemoClient.cpp ## @@ -79,15 +78,15 @@ main(int argc, char** argv) return -1; } bool isFramed = false;

[GitHub] [hbase] Apache-HBase commented on pull request #1784: HBASE-24428 : Update compaction priority for recently split daughter …

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1784: URL: https://github.com/apache/hbase/pull/1784#issuecomment-634180775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] alexandermyasnikov commented on a change in pull request #1775: fix building cpp-example DemoClient

2020-05-26 Thread GitBox
alexandermyasnikov commented on a change in pull request #1775: URL: https://github.com/apache/hbase/pull/1775#discussion_r430204749 ## File path: hbase-examples/src/main/cpp/DemoClient.cpp ## @@ -79,15 +78,15 @@ main(int argc, char** argv) return -1; } bool

[GitHub] [hbase] sguggilam commented on a change in pull request #1755: HBASE-24069 Provide an ExponentialBackOffPolicy sleep between failed …

2020-05-26 Thread GitBox
sguggilam commented on a change in pull request #1755: URL: https://github.com/apache/hbase/pull/1755#discussion_r430780670 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -1997,80 +2007,76 @@ private void unassign(final

[GitHub] [hbase] Apache-HBase commented on pull request #1770: HBASE-24416 RegionNormalizer spliting region should not be limited by…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1770: URL: https://github.com/apache/hbase/pull/1770#issuecomment-633598752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #1761: HBASE-21406 "status 'replication'" should not show SINK if the cluste…

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1761: URL: https://github.com/apache/hbase/pull/1761#issuecomment-633696141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] ddupg commented on pull request #1770: HBASE-24416 RegionNormalizer spliting region should not be limited by…

2020-05-26 Thread GitBox
ddupg commented on pull request #1770: URL: https://github.com/apache/hbase/pull/1770#issuecomment-633773975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hbase] Apache-HBase commented on pull request #1773: HBASE-24427 HStore.add log format error

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1773: URL: https://github.com/apache/hbase/pull/1773#issuecomment-633609182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] apurtell commented on a change in pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

2020-05-26 Thread GitBox
apurtell commented on a change in pull request #1783: URL: https://github.com/apache/hbase/pull/1783#discussion_r430737665 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -695,6 +695,7 @@ void sawNoSuchFamily() { private

[GitHub] [hbase] virajjasani opened a new pull request #1784: HBASE-24428 : Update compaction priority for recently split daughter …

2020-05-26 Thread GitBox
virajjasani opened a new pull request #1784: URL: https://github.com/apache/hbase/pull/1784 …regions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] HorizonNet commented on pull request #1781: HBASE-24435 Add hedgedReads and hedgedReadWins count metrics

2020-05-26 Thread GitBox
HorizonNet commented on pull request #1781: URL: https://github.com/apache/hbase/pull/1781#issuecomment-633959507 Should the conflicts line be part of the commit message? This is an automated message from the Apache Git

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #2: HBASE-24400: Fixup cmake infrastructure to allow dependencies to be built locally

2020-05-26 Thread GitBox
bharathv commented on a change in pull request #2: URL: https://github.com/apache/hbase-native-client/pull/2#discussion_r430720072 ## File path: cmake/DownloadFolly.cmake ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[jira] [Resolved] (HBASE-24437) Flaky test, TestLocalRegionOnTwoFileSystems#testFlushAndCompact

2020-05-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24437. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed the addendum to branch-2.3+. Thanks [~stack]

[GitHub] [hbase] Apache9 opened a new pull request #1774: HBASE-24389 Introduce a new master rpc service to locate meta region through root region

2020-05-26 Thread GitBox
Apache9 opened a new pull request #1774: URL: https://github.com/apache/hbase/pull/1774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] infraio commented on a change in pull request #1780: HBASE-24433 Add 2.2.5 to download page

2020-05-26 Thread GitBox
infraio commented on a change in pull request #1780: URL: https://github.com/apache/hbase/pull/1780#discussion_r430250350 ## File path: src/site/xdoc/downloads.xml ## @@ -45,24 +45,24 @@ under the License. -2.2.4 +2.2.5 -

[GitHub] [hbase] Apache-HBase commented on pull request #1780: HBASE-24433 Add 2.2.5 to download page

2020-05-26 Thread GitBox
Apache-HBase commented on pull request #1780: URL: https://github.com/apache/hbase/pull/1780#issuecomment-633868485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] huaxiangsun merged pull request #1776: Backport: HBASE-24379 CatalogJanitor misreports region holes when there are act…

2020-05-26 Thread GitBox
huaxiangsun merged pull request #1776: URL: https://github.com/apache/hbase/pull/1776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-24437) Flaky test, TestLocalRegionOnTwoFileSystems#testFlushAndCompact

2020-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117282#comment-17117282 ] Hudson commented on HBASE-24437: Results for branch branch-2 [build #2677 on

[GitHub] [hbase] Apache9 commented on pull request #1746: HBASE-24388 Store the locations of meta regions in master local store

2020-05-26 Thread GitBox
Apache9 commented on pull request #1746: URL: https://github.com/apache/hbase/pull/1746#issuecomment-634105560 OK, good, all green. Any other concerns? This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HBASE-24423) No need to get lock in canSplit because hasReferences will get lock too

2020-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117283#comment-17117283 ] Hudson commented on HBASE-24423: Results for branch branch-2 [build #2677 on

[jira] [Commented] (HBASE-24379) CatalogJanitor misreports region holes when there are actually over laps.

2020-05-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117281#comment-17117281 ] Hudson commented on HBASE-24379: Results for branch branch-2 [build #2677 on

  1   2   >