[GitHub] [hbase] infraio commented on pull request #2008: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-05 Thread GitBox
infraio commented on pull request #2008: URL: https://github.com/apache/hbase/pull/2008#issuecomment-654031282 Can you add more comments to explain "why the fix worked"? And add a UT for this? This is an automated message

[jira] [Updated] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22146: --- Fix Version/s: (was: 2.2.6) 2.2.7 > SpaceQuotaViolationPolicy

[GitHub] [hbase] Apache-HBase commented on pull request #2020: HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2020: URL: https://github.com/apache/hbase/pull/2020#issuecomment-654028817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-05 Thread GitBox
infraio commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-654028642 > HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Namespace level > > When a namespace space quota is deleted, the namespace quota (q:s) row from

[GitHub] [hbase] infraio merged pull request #1900: HBASE-24546 CloneSnapshotProcedure unlimited retry

2020-07-05 Thread GitBox
infraio merged pull request #1900: URL: https://github.com/apache/hbase/pull/1900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio merged pull request #1916: HBASE-24546 CloneSnapshotProcedure unlimited retry

2020-07-05 Thread GitBox
infraio merged pull request #1916: URL: https://github.com/apache/hbase/pull/1916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2019: HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2019: URL: https://github.com/apache/hbase/pull/2019#issuecomment-654022149 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2022: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2022: URL: https://github.com/apache/hbase/pull/2022#issuecomment-654019300 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] WenFeiYi opened a new pull request #2024: HBASE-24615 MutableRangeHistogram#updateSnapshotRangeMetrics doesn't …

2020-07-05 Thread GitBox
WenFeiYi opened a new pull request #2024: URL: https://github.com/apache/hbase/pull/2024 …calculate the distribution for last bucket. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2021: URL: https://github.com/apache/hbase/pull/2021#issuecomment-654008844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] WenFeiYi opened a new pull request #2023: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-05 Thread GitBox
WenFeiYi opened a new pull request #2023: URL: https://github.com/apache/hbase/pull/2023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] WenFeiYi opened a new pull request #2022: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-05 Thread GitBox
WenFeiYi opened a new pull request #2022: URL: https://github.com/apache/hbase/pull/2022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151714#comment-17151714 ] wenfeiyi666 edited comment on HBASE-24665 at 7/6/20, 3:53 AM: -- also 1.x

[jira] [Comment Edited] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151714#comment-17151714 ] wenfeiyi666 edited comment on HBASE-24665 at 7/6/20, 3:51 AM: -- 1.x, 2.3,

[GitHub] [hbase] WenFeiYi opened a new pull request #2021: HBASE-24665 all wal of RegionGroupingProvider together roll

2020-07-05 Thread GitBox
WenFeiYi opened a new pull request #2021: URL: https://github.com/apache/hbase/pull/2021 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-24503) Backport HBASE-24492 to all 2.x branch

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24503: --- Fix Version/s: (was: 2.2.6) 2.2.7 > Backport HBASE-24492 to all 2.x

[jira] [Updated] (HBASE-22348) allow one to actually disable replication svc

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22348: --- Fix Version/s: (was: 2.2.6) 2.2.7 > allow one to actually disable

[jira] [Updated] (HBASE-22917) Proc-WAL roll fails always saying someone else has already created log

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-22917: --- Fix Version/s: (was: 2.2.6) 2.2.7 > Proc-WAL roll fails always

[jira] [Updated] (HBASE-24403) FsDelegationToken should cache Token

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24403: --- Fix Version/s: (was: 2.2.6) 2.2.7 > FsDelegationToken should cache

[GitHub] [hbase] Apache-HBase commented on pull request #2020: HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2020: URL: https://github.com/apache/hbase/pull/2020#issuecomment-653999426 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1900: HBASE-24546 CloneSnapshotProcedure unlimited retry

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #1900: URL: https://github.com/apache/hbase/pull/1900#issuecomment-653999308 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24671) Add excludefile and designatedfile options to graceful_stop.sh

2020-07-05 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151740#comment-17151740 ] Anoop Sam John commented on HBASE-24671: Release notes pls. Thanks for the patch [~DeanZ] >

[jira] [Updated] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24665: Fix Version/s: 1.4.14 > all wal of RegionGroupingProvider together roll >

[jira] [Updated] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24665: Fix Version/s: 2.1.10 2.3.0 3.0.0-alpha-1 > all wal of

[jira] [Updated] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24665: Affects Version/s: 2.2.6 1.4.14 2.1.10

[jira] [Updated] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-24665: Affects Version/s: (was: 2.2.6) master > all wal of

[GitHub] [hbase] Reidddddd merged pull request #1923: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

2020-07-05 Thread GitBox
Reidd merged pull request #1923: URL: https://github.com/apache/hbase/pull/1923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (HBASE-24682) Refactor ReplicationSource#addHFileRefs method: move it to ReplicationSourceManager

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24682: -- Assignee: Guanghao Zhang > Refactor ReplicationSource#addHFileRefs method: move it

[GitHub] [hbase] Apache-HBase commented on pull request #2019: HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2019: URL: https://github.com/apache/hbase/pull/2019#issuecomment-653993464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio opened a new pull request #2020: HBASE-24682 Refactor ReplicationSource#addHFileRefs method: move it t…

2020-07-05 Thread GitBox
infraio opened a new pull request #2020: URL: https://github.com/apache/hbase/pull/2020 …o ReplicationSourceManager This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HBASE-24546) CloneSnapshotProcedure unlimited retry

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151724#comment-17151724 ] wenfeiyi666 commented on HBASE-24546: - ping [~zghao] > CloneSnapshotProcedure unlimited retry >

[GitHub] [hbase] WenFeiYi commented on a change in pull request #1916: HBASE-24546 CloneSnapshotProcedure unlimited retry

2020-07-05 Thread GitBox
WenFeiYi commented on a change in pull request #1916: URL: https://github.com/apache/hbase/pull/1916#discussion_r442743034 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CloneSnapshotProcedure.java ## @@ -457,6 +457,10 @@ private void

[jira] [Assigned] (HBASE-24681) Remove the "cache" walsById/walsByIdRecoveredQueues from ReplicationSourceManager

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24681: -- Assignee: Guanghao Zhang > Remove the "cache" walsById/walsByIdRecoveredQueues from

[jira] [Commented] (HBASE-24671) Add excludefile and designatedfile options to graceful_stop.sh

2020-07-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151720#comment-17151720 ] Hudson commented on HBASE-24671: Results for branch branch-2 [build #2734 on

[GitHub] [hbase] infraio commented on a change in pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

2020-07-05 Thread GitBox
infraio commented on a change in pull request #2016: URL: https://github.com/apache/hbase/pull/2016#discussion_r449958060 ## File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon ## @@ -673,6 +675,8 @@ AssignmentManager

[GitHub] [hbase] infraio opened a new pull request #2019: HBASE-24681 Remove the cache walsById/walsByIdRecoveredQueues from Re…

2020-07-05 Thread GitBox
infraio opened a new pull request #2019: URL: https://github.com/apache/hbase/pull/2019 …plicationSourceManager This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (HBASE-24665) all wal of RegionGroupingProvider together roll

2020-07-05 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151714#comment-17151714 ] wenfeiyi666 commented on HBASE-24665: - and branch-1.x > all wal of RegionGroupingProvider together

[jira] [Commented] (HBASE-24671) Add excludefile and designatedfile options to graceful_stop.sh

2020-07-05 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151700#comment-17151700 ] Baiqiang Zhao commented on HBASE-24671: --- Thank you [~vjasani] > Add excludefile and

[jira] [Created] (HBASE-24682) Refactor ReplicationSource#addHFileRefs method: move it to ReplicationSourceManager

2020-07-05 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24682: -- Summary: Refactor ReplicationSource#addHFileRefs method: move it to ReplicationSourceManager Key: HBASE-24682 URL: https://issues.apache.org/jira/browse/HBASE-24682

[jira] [Created] (HBASE-24681) Remove the "cache" walsById/walsByIdRecoveredQueues from ReplicationSourceManager

2020-07-05 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24681: -- Summary: Remove the "cache" walsById/walsByIdRecoveredQueues from ReplicationSourceManager Key: HBASE-24681 URL: https://issues.apache.org/jira/browse/HBASE-24681

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-05 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151688#comment-17151688 ] Guanghao Zhang commented on HBASE-23634: {quote}Now to make these file are official HFiles (move

[GitHub] [hbase] Apache-HBase commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-653948591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-653939159 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-653926487 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #1991: URL: https://github.com/apache/hbase/pull/1991#issuecomment-653911439 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #1991: URL: https://github.com/apache/hbase/pull/1991#issuecomment-653910812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24625) AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-07-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151601#comment-17151601 ] Hudson commented on HBASE-24625: Results for branch master [build #1777 on

[GitHub] [hbase] HorizonNet commented on a change in pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

2020-07-05 Thread GitBox
HorizonNet commented on a change in pull request #2016: URL: https://github.com/apache/hbase/pull/2016#discussion_r449887464 ## File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon ## @@ -673,6 +675,8 @@ AssignmentManager

[jira] [Commented] (HBASE-24678) Add Bulk load param details into its responseTooSlow log

2020-07-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151584#comment-17151584 ] Viraj Jasani commented on HBASE-24678: -- {quote}At least for bulk load kind of ops, it might need

[jira] [Resolved] (HBASE-24671) Add excludefile and designatedfile options to graceful_stop.sh

2020-07-05 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24671. -- Fix Version/s: 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed

[GitHub] [hbase] Apache-HBase commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-653893247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani closed pull request #2013: HBASE-24671 Add excludefile and designatedfile options to graceful_stop.sh

2020-07-05 Thread GitBox
virajjasani closed pull request #2013: URL: https://github.com/apache/hbase/pull/2013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #1991: URL: https://github.com/apache/hbase/pull/1991#issuecomment-653889258 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24526) Deadlock executing assign meta procedure

2020-07-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151574#comment-17151574 ] Duo Zhang commented on HBASE-24526: --- In general there are two problems. 1. The updating meta is a

[GitHub] [hbase] Apache-HBase commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-653880419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24669) Logging of ppid should be consistent across all occurrences

2020-07-05 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151548#comment-17151548 ] niuyulin commented on HBASE-24669: -- hi, [~ndimiduk] , I submit a PR, could you help review it  >

[GitHub] [hbase] nyl3532016 opened a new pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-05 Thread GitBox
nyl3532016 opened a new pull request #2018: URL: https://github.com/apache/hbase/pull/2018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-653875553 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2009: HBASE-21596 Delete for a specific cell version can bring back version…

2020-07-05 Thread GitBox
virajjasani commented on a change in pull request #2009: URL: https://github.com/apache/hbase/pull/2009#discussion_r449863611 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3170,37 +3171,87 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-653869842 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] brfrn169 commented on a change in pull request #1991: HBASE-24650 Change the return types of the new checkAndMutate methods…

2020-07-05 Thread GitBox
brfrn169 commented on a change in pull request #1991: URL: https://github.com/apache/hbase/pull/1991#discussion_r449854459 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java ## @@ -497,7 +497,7 @@ public void run(MultiResponse resp)

[GitHub] [hbase] Apache-HBase commented on pull request #1814: HBASE-20904 Prometheus /metrics http endpoint for monitoring

2020-07-05 Thread GitBox
Apache-HBase commented on pull request #1814: URL: https://github.com/apache/hbase/pull/1814#issuecomment-653849751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m