[GitHub] [hbase] Apache-HBase commented on pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

Apache-HBase commented on pull request #2071: URL: https://github.com/apache/hbase/pull/2071#issuecomment-659164148 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-11288) Splittable Meta

[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158891#comment-17158891 ] Michael Stack commented on HBASE-11288: --- I put up a discussion doc on distributing ROOT load:

[jira] [Commented] (HBASE-24723) Distributing ROOT Region load

[ https://issues.apache.org/jira/browse/HBASE-24723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158884#comment-17158884 ] Michael Stack commented on HBASE-24723: --- Discussion doc. Looks at distributing ROOT Region load.

[GitHub] [hbase] Apache-HBase commented on pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

Apache-HBase commented on pull request #2071: URL: https://github.com/apache/hbase/pull/2071#issuecomment-659153641 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

Apache-HBase commented on pull request #2071: URL: https://github.com/apache/hbase/pull/2071#issuecomment-659152126 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

Apache-HBase commented on pull request #2077: URL: https://github.com/apache/hbase/pull/2077#issuecomment-659147815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2073: HBASE-24467 Backport HBASE-23963: Split TestFromClientSide; it takes …

Apache-HBase commented on pull request #2073: URL: https://github.com/apache/hbase/pull/2073#issuecomment-659147610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] infraio commented on a change in pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

infraio commented on a change in pull request #2077: URL: https://github.com/apache/hbase/pull/2077#discussion_r455496591 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -148,27 +149,30 @@ public boolean

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-659140171 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-659138591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ddupg opened a new pull request #2077: HBASE-24684 Fetch ReplicationSink servers list from HMaster instead o…

ddupg opened a new pull request #2077: URL: https://github.com/apache/hbase/pull/2077 …f ZooKeeper This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.

[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] star updated HBASE-24298: - Attachment: HBASE-24298.patch > Reduce cpu load of locating region especially in batch mode. >

[jira] [Updated] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.

[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] star updated HBASE-24298: - Fix Version/s: 1.2.12 Affects Version/s: 1.2.12 Status: Patch Available (was: Open) >

[jira] [Updated] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.

[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] star updated HBASE-24298: - Attachment: (was: HBASE-24298.patch) > Reduce cpu load of locating region especially in batch mode. >

[jira] [Comment Edited] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.

[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158851#comment-17158851 ] star edited comment on HBASE-24298 at 7/16/20, 3:08 AM: A prototype

[GitHub] [hbase] Reidddddd commented on pull request #2063: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

Reidd commented on pull request #2063: URL: https://github.com/apache/hbase/pull/2063#issuecomment-659127335 By adding a space or something to trigger the QA, if it works, you can change back This is an automated

[GitHub] [hbase] Reidddddd commented on pull request #2063: HBASE-24578 [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count

Reidd commented on pull request #2063: URL: https://github.com/apache/hbase/pull/2063#issuecomment-659127024 @WenFeiYi you can try again This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.

[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158851#comment-17158851 ] star commented on HBASE-24298: -- A prototype implementation for review. It is a configurable feature in

[GitHub] [hbase] Reidddddd merged pull request #2065: HBASE-24739 [Build] branch-1's build seems broken because of pylint

Reidd merged pull request #2065: URL: https://github.com/apache/hbase/pull/2065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158847#comment-17158847 ] Hudson commented on HBASE-24615: Results for branch branch-2.3 [build #184 on

[jira] [Commented] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158848#comment-17158848 ] Hudson commented on HBASE-24721: Results for branch branch-2.3 [build #184 on

[jira] [Updated] (HBASE-24298) Reduce cpu load of locating region especially in batch mode.

[ https://issues.apache.org/jira/browse/HBASE-24298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] star updated HBASE-24298: - Attachment: HBASE-24298.patch > Reduce cpu load of locating region especially in batch mode. >

[GitHub] [hbase] bharathv commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

bharathv commented on a change in pull request #2076: URL: https://github.com/apache/hbase/pull/2076#discussion_r455459886 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java ## @@ -624,14 +623,16 @@ private void

[GitHub] [hbase] infraio commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

infraio commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455463816 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -501,6 +511,32 @@ private void

[GitHub] [hbase] infraio commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

infraio commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455463882 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -501,6 +511,32 @@ private void

[GitHub] [hbase] infraio commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

infraio commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455463412 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -337,25 +347,21 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2065: HBASE-24739 [Build] branch-1's build seems broken because of pylint

Apache-HBase commented on pull request #2065: URL: https://github.com/apache/hbase/pull/2065#issuecomment-659106884 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] bharathv commented on a change in pull request #2064: HBASE-24735: Refactor ReplicationSourceManager: move logPositionAndCl…

bharathv commented on a change in pull request #2064: URL: https://github.com/apache/hbase/pull/2064#discussion_r455459283 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java ## @@ -926,7 +799,8 @@ public

[GitHub] [hbase] bharathv commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

bharathv commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455457366 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -337,26 +347,26 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2065: HBASE-24739 [Build] branch-1's build seems broken because of pylint

Apache-HBase commented on pull request #2065: URL: https://github.com/apache/hbase/pull/2065#issuecomment-659104362 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Updated] (HBASE-24739) [Build] branch-1's build seems broken because of pylint

[ https://issues.apache.org/jira/browse/HBASE-24739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24739: -- Priority: Blocker (was: Major) > [Build] branch-1's build seems broken because of pylint >

[jira] [Commented] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158817#comment-17158817 ] Guanghao Zhang commented on HBASE-24721: +1 for branch-2.2. Let me cherry-pick it. >

[jira] [Updated] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24721: --- Fix Version/s: 2.2.6 > rename_rsgroup overwriting the existing rsgroup. >

[GitHub] [hbase] infraio commented on a change in pull request #2064: HBASE-24735: Refactor ReplicationSourceManager: move logPositionAndCl…

infraio commented on a change in pull request #2064: URL: https://github.com/apache/hbase/pull/2064#discussion_r455448586 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java ## @@ -926,7 +799,8 @@ public void

[GitHub] [hbase] infraio commented on a change in pull request #2064: HBASE-24735: Refactor ReplicationSourceManager: move logPositionAndCl…

infraio commented on a change in pull request #2064: URL: https://github.com/apache/hbase/pull/2064#discussion_r455448274 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -139,17 +144,16 @@ *

[jira] [Updated] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24615: --- Fix Version/s: 2.2.6 > MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate

[GitHub] [hbase] Apache-HBase commented on pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

Apache-HBase commented on pull request #2071: URL: https://github.com/apache/hbase/pull/2071#issuecomment-659090238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

Apache-HBase commented on pull request #2076: URL: https://github.com/apache/hbase/pull/2076#issuecomment-659089050 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sguggilam commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

sguggilam commented on pull request #2076: URL: https://github.com/apache/hbase/pull/2076#issuecomment-659087056 @apurtell @bharathv @virajjasani Can you please review ? This is an automated message from the Apache Git

[GitHub] [hbase] sguggilam commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

sguggilam commented on pull request #2076: URL: https://github.com/apache/hbase/pull/2076#issuecomment-659086947 Sample Journal entry: Table snapshot journal : Running FLUSH table snapshot test_snapshot C_M_SNAPSHOT_TABLE on table test at 1594859523584 Consolidate snapshot:

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158810#comment-17158810 ] Guanghao Zhang commented on HBASE-24615: {quote}The snippet you shared is for overflow bucket

[GitHub] [hbase] sguggilam opened a new pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

sguggilam opened a new pull request #2076: URL: https://github.com/apache/hbase/pull/2076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158807#comment-17158807 ] Rushabh Shah commented on HBASE-24615: -- [~zghao] The snippet you shared is for overflow bucket (for

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158799#comment-17158799 ] Guanghao Zhang commented on HBASE-24615: {code:java} long val = snapshot.getCount(); if

[jira] [Commented] (HBASE-24705) MetaFixer#fixHoles() does not include the case for read replicas (i.e, replica regions are not created)

[ https://issues.apache.org/jira/browse/HBASE-24705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158795#comment-17158795 ] Hudson commented on HBASE-24705: Results for branch branch-2 [build #2746 on

[jira] [Commented] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158797#comment-17158797 ] Hudson commented on HBASE-24721: Results for branch branch-2 [build #2746 on

[jira] [Commented] (HBASE-24615) MutableRangeHistogram#updateSnapshotRangeMetrics doesn't calculate the distribution for last bucket.

[ https://issues.apache.org/jira/browse/HBASE-24615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158796#comment-17158796 ] Hudson commented on HBASE-24615: Results for branch branch-2 [build #2746 on

[GitHub] [hbase] infraio commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

infraio commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455434266 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -493,12 +499,35 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-659077939 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

Apache-HBase commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-659077993 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] lhofhansl edited a comment on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

lhofhansl edited a comment on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-659076398 In unit tests StoreScanner.store might be null. Fixed. Thanks @bharathv for pointing that out. This

[GitHub] [hbase] lhofhansl commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

lhofhansl commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-659076398 In unit tests StoreScanner.store might be null. Fixed. This is an automated message from the Apache Git

[GitHub] [hbase] infraio commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

infraio commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455430870 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -337,25 +347,21 @@ public void

[GitHub] [hbase] infraio commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

infraio commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455427724 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -493,12 +499,35 @@ private void

[GitHub] [hbase] infraio commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

infraio commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455427867 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -493,12 +499,35 @@ private void

[jira] [Commented] (HBASE-24689) Generate CHANGES.md and RELEASENOTES.md for 2.2.6

[ https://issues.apache.org/jira/browse/HBASE-24689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158787#comment-17158787 ] Hudson commented on HBASE-24689: Results for branch branch-2.2 [build #913 on

[jira] [Commented] (HBASE-24690) Set version to 2.2.6 in branch-2.2 for first RC of 2.2.6

[ https://issues.apache.org/jira/browse/HBASE-24690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158788#comment-17158788 ] Hudson commented on HBASE-24690: Results for branch branch-2.2 [build #913 on

[GitHub] [hbase] bharathv commented on a change in pull request #2064: HBASE-24735: Refactor ReplicationSourceManager: move logPositionAndCl…

bharathv commented on a change in pull request #2064: URL: https://github.com/apache/hbase/pull/2064#discussion_r455417117 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java ## @@ -192,4 +188,8 @@ default

[GitHub] [hbase] lhofhansl commented on pull request #2065: HBASE-24739 [Build] branch-1's build seems broken because of pylint

lhofhansl commented on pull request #2065: URL: https://github.com/apache/hbase/pull/2065#issuecomment-659059419 Let's get it in? It's holding up other changes for branch-1 This is an automated message from the Apache Git

[GitHub] [hbase] bharathv commented on a change in pull request #2071: HBASE-24743 Reject to add a peer which replicate to itself earlier

bharathv commented on a change in pull request #2071: URL: https://github.com/apache/hbase/pull/2071#discussion_r455409660 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -493,12 +499,35 @@ private void

[jira] [Commented] (HBASE-11288) Splittable Meta

[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158755#comment-17158755 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288.splittable-meta [build #16 on

[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-65804 > Just a question: The speed is inline with 1.3? Its within 5-10% bounds based on my preliminary analysis (on my local box, **if this optimization kicks in**). Will have

[jira] [Commented] (HBASE-24115) Relocate test-only REST "client" from src/ to test/ and mark Private

[ https://issues.apache.org/jira/browse/HBASE-24115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158646#comment-17158646 ] Pankaj Kumar commented on HBASE-24115: -- [~apurtell] Sorry for coming late on this, I thought these

[GitHub] [hbase] virajjasani commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

virajjasani commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-658953647 > lgtm. My quick test shows that this shaves off a compare for tables without ROWCOL bfs. Thats a nice speed up. Just a question: The speed is inline with 1.3?

[GitHub] [hbase] virajjasani commented on a change in pull request #2065: HBASE-24739 [Build] branch-1's build seems broken because of pylint

virajjasani commented on a change in pull request #2065: URL: https://github.com/apache/hbase/pull/2065#discussion_r455280866 ## File path: dev-support/docker/Dockerfile ## @@ -114,7 +115,7 @@ ENV FINDBUGS_HOME /opt/findbugs # Install pylint -RUN pip install

[jira] [Commented] (HBASE-24459) Move the locateMeta logic from AsyncMetaRegionTableLocator to ConnectionRegistry

[ https://issues.apache.org/jira/browse/HBASE-24459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158625#comment-17158625 ] Viraj Jasani commented on HBASE-24459: -- Few questions: If we move locateMeta to

[GitHub] [hbase] busbey commented on pull request #2065: HBASE-24739 [Build] branch-1's build seems broken because of pylint

busbey commented on pull request #2065: URL: https://github.com/apache/hbase/pull/2065#issuecomment-658930444 seems reasonable. delete the whole "install pylint via pip" section? maybe put up a test commit on this PR that touches a python file so we can ensure pylint works?

[GitHub] [hbase] busbey commented on pull request #2015: HBASE-24568 do-release need not wait for tag

busbey commented on pull request #2015: URL: https://github.com/apache/hbase/pull/2015#issuecomment-658928752 I mean using `git ls-remote` in place of our current calls to `check_for_tag`; since the latter just calls the former.

[GitHub] [hbase] Apache-HBase commented on pull request #2056: HBASE-24710 Incorrect checksum calculation in saveVersion.sh

Apache-HBase commented on pull request #2056: URL: https://github.com/apache/hbase/pull/2056#issuecomment-658893173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2056: HBASE-24710 Incorrect checksum calculation in saveVersion.sh

Apache-HBase commented on pull request #2056: URL: https://github.com/apache/hbase/pull/2056#issuecomment-658893345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-22046) add precommit check for hbase native client

[ https://issues.apache.org/jira/browse/HBASE-22046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-22046: - Fix Version/s: master Resolution: Fixed Status: Resolved

[GitHub] [hbase] bharathv commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

bharathv commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-658879791 Looks like branch-1 pre-commit is broken. @Reidd has a patch at #2065. Let me take a look at that. This is

[jira] [Commented] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158524#comment-17158524 ] Nick Dimiduk commented on HBASE-20904: -- Apologies for arriving late to the discussion, it appears a

[jira] [Commented] (HBASE-24526) Deadlock executing assign meta procedure

[ https://issues.apache.org/jira/browse/HBASE-24526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158522#comment-17158522 ] Huaxiang Sun commented on HBASE-24526: -- Thanks [~zhangduo] for the detail explain. We traced

[GitHub] [hbase] petersomogyi commented on a change in pull request #2056: HBASE-24710 Incorrect checksum calculation in saveVersion.sh

petersomogyi commented on a change in pull request #2056: URL: https://github.com/apache/hbase/pull/2056#discussion_r455189133 ## File path: hbase-common/src/saveVersion.sh ## @@ -30,34 +30,34 @@ nativeOutputDirectory="$2/native/utils/" pushd . cd .. -user=`whoami | sed -n

[GitHub] [hbase] petersomogyi commented on a change in pull request #2056: HBASE-24710 Incorrect checksum calculation in saveVersion.sh

petersomogyi commented on a change in pull request #2056: URL: https://github.com/apache/hbase/pull/2056#discussion_r455187162 ## File path: hbase-common/src/saveVersion.sh ## @@ -30,34 +30,34 @@ nativeOutputDirectory="$2/native/utils/" pushd . cd .. -user=`whoami | sed -n

[GitHub] [hbase] Apache-HBase commented on pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

Apache-HBase commented on pull request #2075: URL: https://github.com/apache/hbase/pull/2075#issuecomment-658872759 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24376) MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.

[ https://issues.apache.org/jira/browse/HBASE-24376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158517#comment-17158517 ] Huaxiang Sun commented on HBASE-24376: -- Hi [~ruslan.sabitov], last time I checked, for branch-1, it

[GitHub] [hbase] ndimiduk commented on a change in pull request #2056: HBASE-24710 Incorrect checksum calculation in saveVersion.sh

ndimiduk commented on a change in pull request #2056: URL: https://github.com/apache/hbase/pull/2056#discussion_r455181612 ## File path: hbase-common/src/saveVersion.sh ## @@ -30,34 +30,34 @@ nativeOutputDirectory="$2/native/utils/" pushd . cd .. -user=`whoami | sed -n -e

[GitHub] [hbase] ndimiduk commented on a change in pull request #2056: HBASE-24710 Incorrect checksum calculation in saveVersion.sh

ndimiduk commented on a change in pull request #2056: URL: https://github.com/apache/hbase/pull/2056#discussion_r455177715 ## File path: hbase-common/src/saveVersion.sh ## @@ -30,34 +30,34 @@ nativeOutputDirectory="$2/native/utils/" pushd . cd .. -user=`whoami | sed -n -e

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158497#comment-17158497 ] Lars Hofhansl commented on HBASE-24742: --- Created a PR for observation #1 above. > Improve

[GitHub] [hbase] lhofhansl opened a new pull request #2075: HBASE-24742 Improve performance of SKIP vs SEEK logic.

lhofhansl opened a new pull request #2075: URL: https://github.com/apache/hbase/pull/2075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

Apache-HBase commented on pull request #2074: URL: https://github.com/apache/hbase/pull/2074#issuecomment-658824068 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

Apache-HBase commented on pull request #2074: URL: https://github.com/apache/hbase/pull/2074#issuecomment-658822344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

Apache-HBase commented on pull request #2074: URL: https://github.com/apache/hbase/pull/2074#issuecomment-658819998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24705) MetaFixer#fixHoles() does not include the case for read replicas (i.e, replica regions are not created)

[ https://issues.apache.org/jira/browse/HBASE-24705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158229#comment-17158229 ] Hudson commented on HBASE-24705: Results for branch branch-2.3 [build #183 on

[GitHub] [hbase] arshadmohammad opened a new pull request #2074: HBASE-24719: Renaming invalid rsgroup throws NPE instead of proper er…

arshadmohammad opened a new pull request #2074: URL: https://github.com/apache/hbase/pull/2074 …ror message This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (HBASE-24719) Renaming invalid rsgroup throws NPE instead of proper error message

[ https://issues.apache.org/jira/browse/HBASE-24719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad updated HBASE-24719: Summary: Renaming invalid rsgroup throws NPE instead of proper error message (was:

[GitHub] [hbase] Apache-HBase commented on pull request #2073: HBASE-24467 Backport HBASE-23963: Split TestFromClientSide; it takes …

Apache-HBase commented on pull request #2073: URL: https://github.com/apache/hbase/pull/2073#issuecomment-658801828 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-11288) Splittable Meta

[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158180#comment-17158180 ] Duo Zhang commented on HBASE-11288: --- I found a version in one of my local repo and pushed it back to

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158167#comment-17158167 ] Duo Zhang commented on HBASE-24742: --- {quote} I'm not sure how we can avoid passing the fake keys up,

[jira] [Commented] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158155#comment-17158155 ] Viraj Jasani commented on HBASE-24721: -- For now, closing the Jira with patch landing on master,

[jira] [Resolved] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24721. -- Fix Version/s: (was: 2.2.6) Hadoop Flags: Reviewed Resolution: Fixed >

[jira] [Commented] (HBASE-11288) Splittable Meta

[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158152#comment-17158152 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288 [build #2 on

[jira] [Commented] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158141#comment-17158141 ] Viraj Jasani commented on HBASE-24721: -- [~zghao] can we commit this to branch-2.2? Thanks >

[GitHub] [hbase] virajjasani closed pull request #2066: HBASE-24721: rename_rsgroup overwriting the existing rsgroup.

virajjasani closed pull request #2066: URL: https://github.com/apache/hbase/pull/2066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-24720) Meta replicas not cleaned when disabled

[ https://issues.apache.org/jira/browse/HBASE-24720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158112#comment-17158112 ] Hudson commented on HBASE-24720: Results for branch master [build #1786 on

[jira] [Commented] (HBASE-24721) rename_rsgroup overwriting the existing rsgroup.

[ https://issues.apache.org/jira/browse/HBASE-24721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158111#comment-17158111 ] Hudson commented on HBASE-24721: Results for branch master [build #1786 on

[jira] [Commented] (HBASE-24581) Skip compaction request/check for replica regions at the early stage.

[ https://issues.apache.org/jira/browse/HBASE-24581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158118#comment-17158118 ] Hudson commented on HBASE-24581: Results for branch master [build #1786 on

[jira] [Commented] (HBASE-24705) MetaFixer#fixHoles() does not include the case for read replicas (i.e, replica regions are not created)

[ https://issues.apache.org/jira/browse/HBASE-24705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158117#comment-17158117 ] Hudson commented on HBASE-24705: Results for branch master [build #1786 on

  1   2   >