[jira] [Updated] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-24696: -- Attachment: (was: Screen Shot 2020-07-17 at 10.54.09 PM.png) > Include JVM information on

[jira] [Updated] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-24696: -- Attachment: Screen Shot 2020-07-17 at 10.55.56 PM.png > Include JVM information on Web UI

[jira] [Commented] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160339#comment-17160339 ] Mingliang Liu commented on HBASE-24696: --- I filed a simple PR. Not sure if that is towards the

[jira] [Updated] (HBASE-24696) Include JVM information on Web UI under "Software Attributes"

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-24696: -- Attachment: Screen Shot 2020-07-17 at 10.54.09 PM.png > Include JVM information on Web UI

[GitHub] [hbase] liuml07 opened a new pull request #2087: HBASE-24696 Include JVM information on Web UI under "Software Attributes"

2020-07-17 Thread GitBox
liuml07 opened a new pull request #2087: URL: https://github.com/apache/hbase/pull/2087 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] liuml07 commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
liuml07 commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-660431436 > Here need conf also: OffPeakHours.getInstance(conf).isOffPeakHour() Right. Unless we also save `OffPeakHours` instance in constructor...so the value of removing `conf`

[GitHub] [hbase] Apache-HBase commented on pull request #2086: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2086: URL: https://github.com/apache/hbase/pull/2086#issuecomment-660429646 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on a change in pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456751970 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -827,26 +828,34 @@ protected double

[GitHub] [hbase] bsglz commented on a change in pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456751823 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -827,26 +828,34 @@ protected double

[GitHub] [hbase] Apache-HBase commented on pull request #2086: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2086: URL: https://github.com/apache/hbase/pull/2086#issuecomment-660428860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-660427923 > In my last comment, > > > That said, to remove this.conf = conf dependency, we can get two multipliers from config, and call setMultiplier() accordingly here in cost() by

[GitHub] [hbase] liuml07 commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
liuml07 commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-660427619 In my last comment, > That said, to remove this.conf = conf dependency, we can get two multipliers from config, and call setMultiplier() accordingly here in cost() by checking

[GitHub] [hbase] liuml07 commented on a change in pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
liuml07 commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456750615 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -827,26 +828,34 @@ protected double

[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-660427160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on a change in pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456748565 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java ## @@ -284,6 +284,25 @@ public void

[GitHub] [hbase] bsglz commented on a change in pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456748462 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java ## @@ -284,6 +284,25 @@ public void

[jira] [Commented] (HBASE-24708) Flaky Test TestRegionReplicas#testVerifySecondaryAbilityToReadWithOnFiles

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160330#comment-17160330 ] Mingliang Liu commented on HBASE-24708: --- Do you have links to builds / stack trace? > Flaky Test

[GitHub] [hbase] liuml07 commented on a change in pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
liuml07 commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456747846 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java ## @@ -284,6 +284,25 @@ public void

[GitHub] [hbase] bsglz opened a new pull request #2086: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-17 Thread GitBox
bsglz opened a new pull request #2086: URL: https://github.com/apache/hbase/pull/2086 …er than only one store size (cherry picked from commit b434ccaaeaeb08b3088a6a437e5d49ef1fcbb0cb) This is an automated message from

[jira] [Comment Edited] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-17 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160327#comment-17160327 ] Bo Cui edited comment on HBASE-23634 at 7/18/20, 4:01 AM: -- 1、before compaction,

[jira] [Commented] (HBASE-23634) Enable "Split WAL to HFile" by default

2020-07-17 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160327#comment-17160327 ] Bo Cui commented on HBASE-23634: 1、before compaction, large number of small hfiles affect read and write

[GitHub] [hbase] bsglz opened a new pull request #2085: HBASE-24664 Some changing of split region by overall region size rath…

2020-07-17 Thread GitBox
bsglz opened a new pull request #2085: URL: https://github.com/apache/hbase/pull/2085 …er than only one store size (cherry picked from commit b434ccaaeaeb08b3088a6a437e5d49ef1fcbb0cb) This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #2081: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2081: URL: https://github.com/apache/hbase/pull/2081#issuecomment-660418361 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2082: HBASE-24570 connection#close throws NPE

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2082: URL: https://github.com/apache/hbase/pull/2082#issuecomment-660418106 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] cuibo01 opened a new pull request #2084: HBASE-22263 Master creates duplicate ServerCrashProcedure on initiali…

2020-07-17 Thread GitBox
cuibo01 opened a new pull request #2084: URL: https://github.com/apache/hbase/pull/2084 …zation, leading to assignment hanging in region-dense clusters This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache-HBase commented on pull request #2083: HBASE-24395 ServerName#getHostname() is case sensitive

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2083: URL: https://github.com/apache/hbase/pull/2083#issuecomment-660413700 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 opened a new pull request #2083: HBASE-24395 ServerName#getHostname() is case sensitive

2020-07-17 Thread GitBox
cuibo01 opened a new pull request #2083: URL: https://github.com/apache/hbase/pull/2083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2081: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2081: URL: https://github.com/apache/hbase/pull/2081#issuecomment-660411619 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24746) The sort icons overlap the col name in master UI

2020-07-17 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160313#comment-17160313 ] Zheng Wang commented on HBASE-24746: Thanks. [~stack] > The sort icons overlap the col name in

[jira] [Updated] (HBASE-24570) connection#close throws NPE

2020-07-17 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24570: --- Status: Patch Available (was: Open) > connection#close throws NPE > --- > >

[GitHub] [hbase] bsglz commented on pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
bsglz commented on pull request #2044: URL: https://github.com/apache/hbase/pull/2044#issuecomment-660410619 The prob is that here we want change the multiplier everyday when the current hour switch between peak and offpeak, there will not a config changed event. Thanks. @virajjasani

[GitHub] [hbase] cuibo01 opened a new pull request #2082: HBASE-24570 connection#close throws NPE

2020-07-17 Thread GitBox
cuibo01 opened a new pull request #2082: URL: https://github.com/apache/hbase/pull/2082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-24664) Some changing of split region by overall region size rather than only one store size

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160305#comment-17160305 ] Hudson commented on HBASE-24664: Results for branch branch-2 [build #2749 on

[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160306#comment-17160306 ] Hudson commented on HBASE-24718: Results for branch branch-2 [build #2749 on

[jira] [Commented] (HBASE-24746) The sort icons overlap the col name in master UI

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160307#comment-17160307 ] Hudson commented on HBASE-24746: Results for branch branch-2 [build #2749 on

[jira] [Commented] (HBASE-24675) On Master restart all servers are assigned to default rsgroup.

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160308#comment-17160308 ] Hudson commented on HBASE-24675: Results for branch branch-2 [build #2749 on

[jira] [Commented] (HBASE-24382) Flush partial stores of region filtered by seqId when archive wal due to too many wals

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160304#comment-17160304 ] Hudson commented on HBASE-24382: Results for branch branch-2 [build #2749 on

[jira] [Commented] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160292#comment-17160292 ] Mingliang Liu commented on HBASE-24692: --- Yes, that problem is also seen in my Chrome and Safari on

[GitHub] [hbase] Apache-HBase commented on pull request #2081: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2081: URL: https://github.com/apache/hbase/pull/2081#issuecomment-660395593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-07-17 Thread GitBox
ndimiduk commented on a change in pull request #2014: URL: https://github.com/apache/hbase/pull/2014#discussion_r456725385 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -200,14 +200,21 @@ private void

[GitHub] [hbase] ndimiduk commented on a change in pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-07-17 Thread GitBox
ndimiduk commented on a change in pull request #2014: URL: https://github.com/apache/hbase/pull/2014#discussion_r456725385 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -200,14 +200,21 @@ private void

[GitHub] [hbase] ndimiduk commented on a change in pull request #2014: HBASE-24673 TransitionRegionStateProcedure of non-meta regions should…

2020-07-17 Thread GitBox
ndimiduk commented on a change in pull request #2014: URL: https://github.com/apache/hbase/pull/2014#discussion_r456725385 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -200,14 +200,21 @@ private void

[jira] [Commented] (HBASE-20904) Prometheus /metrics http endpoint for monitoring integration

2020-07-17 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160287#comment-17160287 ] Nick Dimiduk commented on HBASE-20904: -- I'm not keen on copying more metrics code from Hadoop in to

[jira] [Commented] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-17 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160277#comment-17160277 ] Nick Dimiduk commented on HBASE-24692: -- Oh I see. Did you try it with a width that's too narrow for

[jira] [Reopened] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-17 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24742: -- Reopen for 2.3 backport, https://github.com/apache/hbase/pull/2081 > Improve performance of SKIP

[GitHub] [hbase] ndimiduk opened a new pull request #2081: HBASE-24742 Improve performance of SKIP vs SEEK logic.

2020-07-17 Thread GitBox
ndimiduk opened a new pull request #2081: URL: https://github.com/apache/hbase/pull/2081 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160274#comment-17160274 ] Mingliang Liu edited comment on HBASE-24692 at 7/17/20, 11:55 PM: --

[jira] [Updated] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HBASE-24692: -- Attachment: 24692-ex4.png > WebUI header bar overlaps page content when window is too narrow

[jira] [Comment Edited] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160274#comment-17160274 ] Mingliang Liu edited comment on HBASE-24692 at 7/17/20, 11:54 PM: --

[jira] [Commented] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160274#comment-17160274 ] Mingliang Liu commented on HBASE-24692: --- [~ndimiduk] I had a look at this, but only find that the

[jira] [Assigned] (HBASE-24692) WebUI header bar overlaps page content when window is too narrow

2020-07-17 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu reassigned HBASE-24692: - Assignee: Mingliang Liu > WebUI header bar overlaps page content when window is too

[jira] [Updated] (HBASE-24698) Turn OFF Canary WebUI as default

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24698: -- Description: See parent issue. There is a CLASSPATH issue when running against hadoop3 that

[jira] [Resolved] (HBASE-24698) Turn OFF Canary WebUI as default

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24698. --- Hadoop Flags: Reviewed Release Note: Flips default for 'HBASE-23994 Add WebUI to

[GitHub] [hbase] saintstack merged pull request #2080: HBASE-24722 Update commands with unintentional return values (#2058)

2020-07-17 Thread GitBox
saintstack merged pull request #2080: URL: https://github.com/apache/hbase/pull/2080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-24742) Improve performance of SKIP vs SEEK logic

2020-07-17 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160250#comment-17160250 ] Hudson commented on HBASE-24742: Results for branch branch-2.2 [build #915 on

[GitHub] [hbase] saintstack commented on pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-17 Thread GitBox
saintstack commented on pull request #2037: URL: https://github.com/apache/hbase/pull/2037#issuecomment-660357609 Merged this. Shout if you not ok @Apache9 ... did 1/2 of what you asked ... other define not used. This is an

[GitHub] [hbase] saintstack merged pull request #2037: HBASE-24698 Turn OFF Canary WebUI as default

2020-07-17 Thread GitBox
saintstack merged pull request #2037: URL: https://github.com/apache/hbase/pull/2037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-24746) The sort icons overlap the col name in master UI

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160232#comment-17160232 ] Michael Stack commented on HBASE-24746: --- Very nice [~filtertip] > The sort icons overlap the col

[jira] [Commented] (HBASE-24745) 'Failed report transition' logs too often

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160231#comment-17160231 ] Michael Stack commented on HBASE-24745: --- What do you see in your unit test [~wenfeiyi666] ?

[jira] [Commented] (HBASE-24745) 'Failed report transition' logs too often

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160227#comment-17160227 ] Michael Stack commented on HBASE-24745: --- Thank you [~wenfeiyi666] for taking a look. I don't

[GitHub] [hbase] Apache-HBase commented on pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2079: URL: https://github.com/apache/hbase/pull/2079#issuecomment-660339511 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24740) Enable journal logging for HBase snapshot operation

2020-07-17 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160195#comment-17160195 ] Bharath Vissapragada commented on HBASE-24740: -- Committed to branch-1, Sandeep is working

[jira] [Updated] (HBASE-24740) Enable journal logging for HBase snapshot operation

2020-07-17 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24740: - Component/s: master > Enable journal logging for HBase snapshot operation >

[jira] [Updated] (HBASE-24740) Enable journal logging for HBase snapshot operation

2020-07-17 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24740: - Fix Version/s: 1.7.0 > Enable journal logging for HBase snapshot operation >

[jira] [Updated] (HBASE-24740) Enable journal logging for HBase snapshot operation

2020-07-17 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24740: - Labels: observability (was: ) > Enable journal logging for HBase snapshot

[jira] [Updated] (HBASE-24740) Enable journal logging for HBase snapshot operation

2020-07-17 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24740: - Affects Version/s: 2.2.7 1.7.0

[GitHub] [hbase] bharathv merged pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

2020-07-17 Thread GitBox
bharathv merged pull request #2076: URL: https://github.com/apache/hbase/pull/2076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2076: URL: https://github.com/apache/hbase/pull/2076#issuecomment-660312944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2079: URL: https://github.com/apache/hbase/pull/2079#issuecomment-660310333 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2080: HBASE-24722 Update commands with unintentional return values (#2058)

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2080: URL: https://github.com/apache/hbase/pull/2080#issuecomment-660294213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-660290461 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-660290158 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2080: HBASE-24722 Update commands with unintentional return values (#2058)

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2080: URL: https://github.com/apache/hbase/pull/2080#issuecomment-660288217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24722) Address hbase-shell commands with unintentional return values

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160144#comment-17160144 ] Michael Stack commented on HBASE-24722: --- Merged to master. Put up PR for backport to branch-2. >

[GitHub] [hbase] saintstack opened a new pull request #2080: HBASE-24722 Update commands with unintentional return values (#2058)

2020-07-17 Thread GitBox
saintstack opened a new pull request #2080: URL: https://github.com/apache/hbase/pull/2080 - Prior to this commit, there were 13 commands that unintentionally return the number of lines they print (usually one). This commit ensures that they return the value documented by the

[GitHub] [hbase] bitoffdev commented on a change in pull request #2058: HBASE-24722 Address hbase-shell commands with unintentional return values

2020-07-17 Thread GitBox
bitoffdev commented on a change in pull request #2058: URL: https://github.com/apache/hbase/pull/2058#discussion_r456618217 ## File path: hbase-shell/src/main/ruby/shell/commands/clear_deadservers.rb ## @@ -35,18 +37,20 @@ def help end # rubocop:disable

[GitHub] [hbase] bitoffdev commented on a change in pull request #2058: HBASE-24722 Address hbase-shell commands with unintentional return values

2020-07-17 Thread GitBox
bitoffdev commented on a change in pull request #2058: URL: https://github.com/apache/hbase/pull/2058#discussion_r456617522 ## File path: hbase-shell/src/main/ruby/shell/commands/clear_block_cache.rb ## @@ -33,6 +33,7 @@ def help def command(table_name)

[GitHub] [hbase] saintstack merged pull request #2058: HBASE-24722 Address hbase-shell commands with unintentional return values

2020-07-17 Thread GitBox
saintstack merged pull request #2058: URL: https://github.com/apache/hbase/pull/2058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on a change in pull request #2058: HBASE-24722 Address hbase-shell commands with unintentional return values

2020-07-17 Thread GitBox
saintstack commented on a change in pull request #2058: URL: https://github.com/apache/hbase/pull/2058#discussion_r456614056 ## File path: hbase-shell/src/test/ruby/hbase/admin_test.rb ## @@ -212,13 +215,182 @@ def teardown

[GitHub] [hbase] Apache-HBase commented on pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #2079: URL: https://github.com/apache/hbase/pull/2079#issuecomment-660256316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil merged pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

2020-07-17 Thread GitBox
wchevreuil merged pull request #2079: URL: https://github.com/apache/hbase/pull/2079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] wchevreuil commented on a change in pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

2020-07-17 Thread GitBox
wchevreuil commented on a change in pull request #2079: URL: https://github.com/apache/hbase/pull/2079#discussion_r456587095 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java ## @@ -348,8 +348,14 @@ public void

[jira] [Resolved] (HBASE-24675) On Master restart all servers are assigned to default rsgroup.

2020-07-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24675. -- Fix Version/s: 2.4.0 2.3.1 3.0.0-alpha-1 Hadoop

[jira] [Created] (HBASE-24747) Log an ERROR if HBaseSaslRpcServer initialisation fails with an uncaught exception

2020-07-17 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-24747: Summary: Log an ERROR if HBaseSaslRpcServer initialisation fails with an uncaught exception Key: HBASE-24747 URL:

[GitHub] [hbase] virajjasani commented on a change in pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

2020-07-17 Thread GitBox
virajjasani commented on a change in pull request #2079: URL: https://github.com/apache/hbase/pull/2079#discussion_r456575593 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java ## @@ -348,8 +348,14 @@ public void

[jira] [Commented] (HBASE-24675) On Master restart all servers are assigned to default rsgroup.

2020-07-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160103#comment-17160103 ] Viraj Jasani commented on HBASE-24675: -- Does this apply to branch-1 by any chance? If it does, can

[GitHub] [hbase] liuml07 commented on a change in pull request #2056: HBASE-24710 Incorrect checksum calculation in saveVersion.sh

2020-07-17 Thread GitBox
liuml07 commented on a change in pull request #2056: URL: https://github.com/apache/hbase/pull/2056#discussion_r456574712 ## File path: hbase-common/src/saveVersion.sh ## @@ -30,34 +30,34 @@ nativeOutputDirectory="$2/native/utils/" pushd . cd .. -user=`whoami | sed -n -e

[GitHub] [hbase] wchevreuil opened a new pull request #2079: HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

2020-07-17 Thread GitBox
wchevreuil opened a new pull request #2079: URL: https://github.com/apache/hbase/pull/2079 …ith an uncaught exception This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] liuml07 commented on pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

2020-07-17 Thread GitBox
liuml07 commented on pull request #2076: URL: https://github.com/apache/hbase/pull/2076#issuecomment-660234327 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] virajjasani closed pull request #2053: HBASE-24675: On Master restart all servers are assigned to default rs…

2020-07-17 Thread GitBox
virajjasani closed pull request #2053: URL: https://github.com/apache/hbase/pull/2053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on a change in pull request #2044: HBASE-24709 Support MoveCostFunction use a lower multiplier in offpea…

2020-07-17 Thread GitBox
virajjasani commented on a change in pull request #2044: URL: https://github.com/apache/hbase/pull/2044#discussion_r456558482 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -827,26 +828,34 @@ protected double

[GitHub] [hbase] virajjasani commented on pull request #2017: HBASE-24669 Logging of ppid should be consistent across all occurrences

2020-07-17 Thread GitBox
virajjasani commented on pull request #2017: URL: https://github.com/apache/hbase/pull/2017#issuecomment-660205076 Nice one. +1 on bringing this to all branches. This is an automated message from the Apache Git Service. To

[jira] [Resolved] (HBASE-24746) The sort icons overlap the col name in master UI

2020-07-17 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24746. -- Fix Version/s: 2.4.0 2.3.1 3.0.0-alpha-1 Hadoop

[GitHub] [hbase] virajjasani closed pull request #2078: HBASE-24746 The sort icons overlap the col name in master UI

2020-07-17 Thread GitBox
virajjasani closed pull request #2078: URL: https://github.com/apache/hbase/pull/2078 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-660185927 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24354) Make it so can make an hbase1 schema and hbase2 schema equate

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159997#comment-17159997 ] Michael Stack commented on HBASE-24354: --- [~zghao] you need this in branch-2.2? It allows

[jira] [Commented] (HBASE-24354) Make it so can make an hbase1 schema and hbase2 schema equate

2020-07-17 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159996#comment-17159996 ] Michael Stack commented on HBASE-24354: --- I did not include the exception seen when we had this

[GitHub] [hbase] skochhar commented on a change in pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-07-17 Thread GitBox
skochhar commented on a change in pull request #1935: URL: https://github.com/apache/hbase/pull/1935#discussion_r456509573 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/quotas/QuotaTableUtil.java ## @@ -628,6 +628,34 @@ static Put

[GitHub] [hbase] Apache-HBase commented on pull request #1895: HBASE-24555 Correct the description of hbase.hregion.max.filesize

2020-07-17 Thread GitBox
Apache-HBase commented on pull request #1895: URL: https://github.com/apache/hbase/pull/1895#issuecomment-660160771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

2020-07-17 Thread GitBox
virajjasani commented on a change in pull request #2076: URL: https://github.com/apache/hbase/pull/2076#discussion_r456480852 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java ## @@ -343,6 +343,13 @@ private void load() throws

  1   2   >