[jira] [Commented] (HBASE-24876) Fix the flaky job url for branch-2.2

2020-08-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176776#comment-17176776 ] Duo Zhang commented on HBASE-24876: --- It is not only for branch-2.2, on master we also have this

[GitHub] [hbase] taklwu edited a comment on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
taklwu edited a comment on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-673253206 first of all, thanks Duo again. > I think for the scenario here, we just need to write the cluster id and other things to zookeeper? Just make sure that the current

[GitHub] [hbase] taklwu edited a comment on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
taklwu edited a comment on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-673253206 first of all, thanks Duo again. > I think for the scenario here, we just need to write the cluster id and other things to zookeeper? Just make sure that the current

[GitHub] [hbase] taklwu commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
taklwu commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-673253206 first of all, thanks Duo again. > I think for the scenario here, we just need to write the cluster id and other things to zookeeper? Just make sure that the current code in

[jira] [Commented] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176759#comment-17176759 ] Hudson commented on HBASE-24750: Results for branch branch-2 [build #6 on

[jira] [Commented] (HBASE-24583) Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176761#comment-17176761 ] Hudson commented on HBASE-24583: Results for branch branch-2 [build #6 on

[jira] [Commented] (HBASE-24844) Exception on standalone (master) shutdown

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176760#comment-17176760 ] Hudson commented on HBASE-24844: Results for branch branch-2 [build #6 on

[jira] [Commented] (HBASE-23035) Retain region to the last RegionServer make the failover slower

2020-08-12 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176744#comment-17176744 ] Bo Cui commented on HBASE-23035: [~zghao] During startup, hbase needs to assign region to previous rs

[GitHub] [hbase] Apache-HBase commented on pull request #2253: HBASE-24876 Fix the flaky job url for branch-2.2

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2253: URL: https://github.com/apache/hbase/pull/2253#issuecomment-673231409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] nyl3532016 commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-12 Thread GitBox
nyl3532016 commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-673228584 > Can you explain a bit more about > `since Reusable PoolType has been removed, no need to check allowedPoolTypes`? Went through the patch, still not clear about the

[GitHub] [hbase] infraio opened a new pull request #2253: HBASE-24876 Fix the flaky job url for branch-2.2

2020-08-12 Thread GitBox
infraio opened a new pull request #2253: URL: https://github.com/apache/hbase/pull/2253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-673221492 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24876) Fix the flaky job url for branch-2.2

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24876: --- Description:   I found that the precommit job of branch-2.2 still used the wrong url. See 

[jira] [Created] (HBASE-24876) Fix the flaky job url for branch-2.2

2020-08-12 Thread Guanghao Zhang (Jira)
Guanghao Zhang created HBASE-24876: -- Summary: Fix the flaky job url for branch-2.2 Key: HBASE-24876 URL: https://issues.apache.org/jira/browse/HBASE-24876 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-673220262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24875) The describe and param for unassign not correct since the implementation changed at server side

2020-08-12 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24875: --- Summary: The describe and param for unassign not correct since the implementation changed at server

[jira] [Created] (HBASE-24875) The describe and param for unassign not correct since the implement changed at server side

2020-08-12 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-24875: -- Summary: The describe and param for unassign not correct since the implement changed at server side Key: HBASE-24875 URL: https://issues.apache.org/jira/browse/HBASE-24875

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-673216860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24874) hbase-shell should not use ModifiableTableDescriptor directly

2020-08-12 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176727#comment-17176727 ] Elliot Miller commented on HBASE-24874: --- [~zhangduo], we do have unit tests for both these cases

[jira] [Commented] (HBASE-24841) Change the jenkins job urls in our jenkinsfile

2020-08-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176712#comment-17176712 ] Duo Zhang commented on HBASE-24841: --- I think it is this line?

[GitHub] [hbase] Apache9 commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
Apache9 commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-673201873 > Thanks @Apache9 , I want to agree with you to have a HBCK option, but one concern I have and keep struggling about making this automated instead of HBCK options. If one HBase

[jira] [Commented] (HBASE-24874) hbase-shell should not use ModifiableTableDescriptor directly

2020-08-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176707#comment-17176707 ] Duo Zhang commented on HBASE-24874: --- We do not have UTs for this two commands? IIRC I did not see any

[jira] [Commented] (HBASE-24841) Change the jenkins job urls in our jenkinsfile

2020-08-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176701#comment-17176701 ] Duo Zhang commented on HBASE-24841: --- Maybe we define the url at another place for branch-2.2? >

[jira] [Commented] (HBASE-24841) Change the jenkins job urls in our jenkinsfile

2020-08-12 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176690#comment-17176690 ] Guanghao Zhang commented on HBASE-24841: EXCLUDE_TESTS_URL =

[jira] [Updated] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-08-12 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24650: - Release Note: HBASE-24650 introduced CheckAndMutateResult class and changed the return

[jira] [Updated] (HBASE-24650) Change the return types of the new checkAndMutate methods introduced in HBASE-8458

2020-08-12 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-24650: - Release Note: HBASE-24650 introduced CheckAndMutateResult class and changed the return

[jira] [Commented] (HBASE-8458) Support for batch version of checkAndMutate()

2020-08-12 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176670#comment-17176670 ] Toshihiro Suzuki commented on HBASE-8458: - [~ndimiduk] Thank you for pointing that out. I just

[jira] [Updated] (HBASE-8458) Support for batch version of checkAndMutate()

2020-08-12 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-8458: Release Note: HBASE-8458 introduced CheckAndMutate class that's used to perform

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176644#comment-17176644 ] Duo Zhang commented on HBASE-11288: --- But you still do not answer my question directly right? Why root

[GitHub] [hbase] huaxiangsun commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-12 Thread GitBox
huaxiangsun commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-673145600 As @infraio said, it will be great to add an UT to show the issue w/o change. Otherwise, looks good to me.

[GitHub] [hbase] taklwu commented on a change in pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
taklwu commented on a change in pull request #2237: URL: https://github.com/apache/hbase/pull/2237#discussion_r469554017 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -915,6 +917,11 @@ private void

[GitHub] [hbase] taklwu commented on a change in pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
taklwu commented on a change in pull request #2237: URL: https://github.com/apache/hbase/pull/2237#discussion_r469554017 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -915,6 +917,11 @@ private void

[jira] [Updated] (HBASE-24568) do-release need not wait for tag

2020-08-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24568: - Fix Version/s: 3.0.0-alpha-1 > do-release need not wait for tag >

[jira] [Resolved] (HBASE-24568) do-release need not wait for tag

2020-08-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24568. -- Resolution: Fixed > do-release need not wait for tag > > >

[jira] [Commented] (HBASE-11554) Remove Reusable poolmap Rpc client type.

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176589#comment-17176589 ] Hudson commented on HBASE-11554: Results for branch master [build #6 on

[jira] [Commented] (HBASE-24827) BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176590#comment-17176590 ] Hudson commented on HBASE-24827: Results for branch master [build #6 on

[GitHub] [hbase] ndimiduk merged pull request #2015: HBASE-24568 do-release need not wait for tag

2020-08-12 Thread GitBox
ndimiduk merged pull request #2015: URL: https://github.com/apache/hbase/pull/2015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ndimiduk commented on pull request #2015: HBASE-24568 do-release need not wait for tag

2020-08-12 Thread GitBox
ndimiduk commented on pull request #2015: URL: https://github.com/apache/hbase/pull/2015#issuecomment-673093342 This is what I used to generate 2.3.1RC0. This is an automated message from the Apache Git Service. To respond

[jira] [Created] (HBASE-24874) hbase-shell should not use ModifiableTableDescriptor directly

2020-08-12 Thread Elliot Miller (Jira)
Elliot Miller created HBASE-24874: - Summary: hbase-shell should not use ModifiableTableDescriptor directly Key: HBASE-24874 URL: https://issues.apache.org/jira/browse/HBASE-24874 Project: HBase

[jira] [Updated] (HBASE-24873) Not able to access Flink 1.7.2 with HBase 2.0.0 included in HDP cluster 3.0.1

2020-08-12 Thread Pasha Shaik (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pasha Shaik updated HBASE-24873: Hadoop Flags: Incompatible change > Not able to access Flink 1.7.2 with HBase 2.0.0 included in

[jira] [Created] (HBASE-24873) Not able to access Flink 1.7.2 with HBase 2.0.0 included in HDP cluster 3.0.1

2020-08-12 Thread Pasha Shaik (Jira)
Pasha Shaik created HBASE-24873: --- Summary: Not able to access Flink 1.7.2 with HBase 2.0.0 included in HDP cluster 3.0.1 Key: HBASE-24873 URL: https://issues.apache.org/jira/browse/HBASE-24873 Project:

[jira] [Commented] (HBASE-24527) Improve region housekeeping status observability

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176551#comment-17176551 ] Viraj Jasani commented on HBASE-24527: -- {quote}at regionserver scope: * listing the current state

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176539#comment-17176539 ] Viraj Jasani commented on HBASE-24528: -- Thanks Josh (y) > Improve balancer decision observability

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-08-12 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176538#comment-17176538 ] Josh Elser commented on HBASE-24528: This JSON looks excellent to me. > Improve balancer decision

[jira] [Comment Edited] (HBASE-24528) Improve balancer decision observability

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176530#comment-17176530 ] Viraj Jasani edited comment on HBASE-24528 at 8/12/20, 6:42 PM: Attached

[jira] [Comment Edited] (HBASE-24528) Improve balancer decision observability

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176530#comment-17176530 ] Viraj Jasani edited comment on HBASE-24528 at 8/12/20, 6:41 PM: Attached

[jira] [Commented] (HBASE-24528) Improve balancer decision observability

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176530#comment-17176530 ] Viraj Jasani commented on HBASE-24528: -- Attached one sample json for balancer decision output,

[jira] [Updated] (HBASE-24528) Improve balancer decision observability

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24528: - Attachment: Screenshot 2020-08-12 at 11.50.43 PM.png > Improve balancer decision observability

[jira] [Updated] (HBASE-24583) Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24583: - Resolution: Fixed Status: Resolved (was: Patch Available) Backported as far as

[GitHub] [hbase] ndimiduk opened a new pull request #2252: Backport "HBASE-24583 Normalizer can't actually merge empty regions..." to branch-2.3

2020-08-12 Thread GitBox
ndimiduk opened a new pull request #2252: URL: https://github.com/apache/hbase/pull/2252 when neighbor is larger than average size * add `testMergeEmptyRegions` to explicitly cover different interleaving of 0-sized regions. * fix bug where merging a 0-size region is skipped

[jira] [Updated] (HBASE-24583) Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24583: - Fix Version/s: 2.3.1 > Normalizer can't actually merge empty regions when neighbor is larger

[GitHub] [hbase] ndimiduk merged pull request #2252: Backport "HBASE-24583 Normalizer can't actually merge empty regions..." to branch-2.3

2020-08-12 Thread GitBox
ndimiduk merged pull request #2252: URL: https://github.com/apache/hbase/pull/2252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-24583) Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24583: - Fix Version/s: 2.4.0 > Normalizer can't actually merge empty regions when neighbor is larger

[GitHub] [hbase] ndimiduk opened a new pull request #2251: Backport "HBASE-24583 Normalizer can't actually merge empty regions..." to branch-2

2020-08-12 Thread GitBox
ndimiduk opened a new pull request #2251: URL: https://github.com/apache/hbase/pull/2251 when neighbor is larger than average size * add `testMergeEmptyRegions` to explicitly cover different interleaving of 0-sized regions. * fix bug where merging a 0-size region is skipped

[GitHub] [hbase] ndimiduk merged pull request #2251: Backport "HBASE-24583 Normalizer can't actually merge empty regions..." to branch-2

2020-08-12 Thread GitBox
ndimiduk merged pull request #2251: URL: https://github.com/apache/hbase/pull/2251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2020-08-12 Thread GitBox
anoopsjohn commented on a change in pull request #2237: URL: https://github.com/apache/hbase/pull/2237#discussion_r469412600 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -915,6 +917,11 @@ private void

[jira] [Updated] (HBASE-24583) Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-24583: - Fix Version/s: 3.0.0-alpha-1 > Normalizer can't actually merge empty regions when neighbor is

[GitHub] [hbase] ndimiduk merged pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread GitBox
ndimiduk merged pull request #1922: URL: https://github.com/apache/hbase/pull/1922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-24844) Exception on standalone (master) shutdown

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176478#comment-17176478 ] Hudson commented on HBASE-24844: Results for branch branch-2.2 [build #4 on

[jira] [Commented] (HBASE-22524) Refactor TestReplicationSyncUpTool

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176477#comment-17176477 ] Hudson commented on HBASE-22524: Results for branch branch-2.2 [build #4 on

[jira] [Resolved] (HBASE-24715) Cleanup RELEASENOTES.md in the wake of HBASE-24711

2020-08-12 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24715. -- Resolution: Fixed > Cleanup RELEASENOTES.md in the wake of HBASE-24711 >

[GitHub] [hbase] ndimiduk commented on pull request #2244: HBASE-24715 Cleanup RELEASENOTES.md in the wake of HBASE-24711

2020-08-12 Thread GitBox
ndimiduk commented on pull request #2244: URL: https://github.com/apache/hbase/pull/2244#issuecomment-672986050 Thanks for the quick reviews. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] joshelser commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-12 Thread GitBox
joshelser commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r469395639 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -309,6 +310,16 @@ public

[GitHub] [hbase] ndimiduk merged pull request #2244: HBASE-24715 Cleanup RELEASENOTES.md in the wake of HBASE-24711

2020-08-12 Thread GitBox
ndimiduk merged pull request #2244: URL: https://github.com/apache/hbase/pull/2244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] wchevreuil commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-12 Thread GitBox
wchevreuil commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r469394487 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -309,6 +310,16 @@

[GitHub] [hbase] wchevreuil commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-12 Thread GitBox
wchevreuil commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r469391760 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -309,6 +310,16 @@

[GitHub] [hbase] wchevreuil commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-12 Thread GitBox
wchevreuil commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r469391582 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -600,6 +600,10 @@ public void

[GitHub] [hbase] huaxiangsun commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-12 Thread GitBox
huaxiangsun commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-672981681 Can you explain a bit more about ```since Reusable PoolType has been removed, no need to check allowedPoolTypes```? Went through the patch, still not clear about the

[GitHub] [hbase] ndimiduk commented on pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread GitBox
ndimiduk commented on pull request #1922: URL: https://github.com/apache/hbase/pull/1922#issuecomment-672980734 > > Can you explain why this change in controversial? > > It's not controversial. I got your thought, while I incline to code case by case to avoid unnecessary codes. So

[jira] [Commented] (HBASE-24844) Exception on standalone (master) shutdown

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176453#comment-17176453 ] Hudson commented on HBASE-24844: Results for branch branch-1 [build #4 on

[GitHub] [hbase] Reidddddd commented on pull request #1922: HBASE-24583 Normalizer can't actually merge empty regions when neighbor is larger than average size

2020-08-12 Thread GitBox
Reidd commented on pull request #1922: URL: https://github.com/apache/hbase/pull/1922#issuecomment-672975747 > Can you explain why this change in controversial? It's not controversial. I got your thought, while I incline to code case by case to avoid unnecessary codes. So

[GitHub] [hbase] wchevreuil commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-12 Thread GitBox
wchevreuil commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r469382747 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -309,6 +310,16 @@

[GitHub] [hbase] joshelser commented on a change in pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-12 Thread GitBox
joshelser commented on a change in pull request #2228: URL: https://github.com/apache/hbase/pull/2228#discussion_r469353813 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3805,6 +3838,196 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
wchevreuil commented on a change in pull request #2241: URL: https://github.com/apache/hbase/pull/2241#discussion_r469354711 ## File path: hbase-shell/src/main/ruby/shell/commands/assign.rb ## @@ -22,8 +22,8 @@ module Commands class Assign < Command def help

[jira] [Commented] (HBASE-24869) migrate website generation to new asf jenkins

2020-08-12 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176392#comment-17176392 ] Sean Busbey commented on HBASE-24869: - merged the PR. disabled the job on builds.a.o. updated the

[GitHub] [hbase] asfgit closed pull request #2246: HBASE-24869 migrate website generation to new asf jenkins

2020-08-12 Thread GitBox
asfgit closed pull request #2246: URL: https://github.com/apache/hbase/pull/2246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2248: HBASE-24870 Ignore TestAsyncTableRSCrashPublish

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2248: URL: https://github.com/apache/hbase/pull/2248#issuecomment-672887463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-672854696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-672854029 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-672848412 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bsglz commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
bsglz commented on a change in pull request #2241: URL: https://github.com/apache/hbase/pull/2241#discussion_r469226122 ## File path: hbase-shell/src/main/ruby/shell/commands/unassign.rb ## @@ -22,8 +22,10 @@ module Commands class Unassign < Command def help

[GitHub] [hbase] bsglz commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
bsglz commented on a change in pull request #2241: URL: https://github.com/apache/hbase/pull/2241#discussion_r469205948 ## File path: hbase-shell/src/main/ruby/shell/commands/unassign.rb ## @@ -22,8 +22,10 @@ module Commands class Unassign < Command def help

[GitHub] [hbase] bsglz commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
bsglz commented on a change in pull request #2241: URL: https://github.com/apache/hbase/pull/2241#discussion_r469205948 ## File path: hbase-shell/src/main/ruby/shell/commands/unassign.rb ## @@ -22,8 +22,10 @@ module Commands class Unassign < Command def help

[jira] [Resolved] (HBASE-24844) Exception on standalone (master) shutdown

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24844. -- Fix Version/s: 2.2.7 2.4.0 1.7.0

[jira] [Commented] (HBASE-24844) Exception on standalone (master) shutdown

2020-08-12 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176284#comment-17176284 ] Viraj Jasani commented on HBASE-24844: -- Thanks [~wenfeiyi666] for the patch. Applied it to master,

[GitHub] [hbase] virajjasani commented on a change in pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
virajjasani commented on a change in pull request #2241: URL: https://github.com/apache/hbase/pull/2241#discussion_r469198506 ## File path: hbase-shell/src/main/ruby/shell/commands/unassign.rb ## @@ -22,8 +22,10 @@ module Commands class Unassign < Command def help

[GitHub] [hbase] virajjasani closed pull request #2239: HBASE-24844 RecoverableZookeeper#close followed by ExecutorService shutdown

2020-08-12 Thread GitBox
virajjasani closed pull request #2239: URL: https://github.com/apache/hbase/pull/2239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-672819894 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-672819190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24843) Sort the constants in `hbase_constants.rb`

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176275#comment-17176275 ] Hudson commented on HBASE-24843: Results for branch master [build #5 on

[jira] [Commented] (HBASE-24750) All executor service should start using guava ThreadFactory

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176274#comment-17176274 ] Hudson commented on HBASE-24750: Results for branch master [build #5 on

[jira] [Commented] (HBASE-24856) Fix error prone error in FlushTableSubprocedure

2020-08-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176276#comment-17176276 ] Hudson commented on HBASE-24856: Results for branch master [build #5 on

[GitHub] [hbase] Apache-HBase commented on pull request #2241: HBASE-24854 Correct the help content of assign and unassign commands …

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2241: URL: https://github.com/apache/hbase/pull/2241#issuecomment-672813572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2239: HBASE-24844 Exception on standalone (master) shutdown

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2239: URL: https://github.com/apache/hbase/pull/2239#issuecomment-672812421 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2239: HBASE-24844 Exception on standalone (master) shutdown

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2239: URL: https://github.com/apache/hbase/pull/2239#issuecomment-672812686 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2239: HBASE-24844 Exception on standalone (master) shutdown

2020-08-12 Thread GitBox
Apache-HBase commented on pull request #2239: URL: https://github.com/apache/hbase/pull/2239#issuecomment-672812142 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on pull request #2239: HBASE-24844 Exception on standalone (master) shutdown

2020-08-12 Thread GitBox
virajjasani commented on pull request #2239: URL: https://github.com/apache/hbase/pull/2239#issuecomment-672809153 Let me keep patch title: "RecoverableZookeeper#close followed by ExecutorService shutdown" This is an

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-12 Thread Francis Christopher Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176265#comment-17176265 ] Francis Christopher Liu commented on HBASE-11288: - The run I mentioned in the previous

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-12 Thread Francis Christopher Liu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176263#comment-17176263 ] Francis Christopher Liu commented on HBASE-11288: - Hi [~zhangduo], there's a lot of code

[GitHub] [hbase] virajjasani commented on pull request #2239: HBASE-24844 Exception on standalone (master) shutdown

2020-08-12 Thread GitBox
virajjasani commented on pull request #2239: URL: https://github.com/apache/hbase/pull/2239#issuecomment-672803045 @WenFeiYi can you update the PR title with what we did? Something that represent threadpool shutdown followed by close of RecoverableZookeeper? With error msg in commit msg,

  1   2   >