[GitHub] [hbase] Apache-HBase commented on pull request #2149: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-682341900 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24776) [hbtop] Support Batch mode

2020-08-27 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186260#comment-17186260 ] Toshihiro Suzuki commented on HBASE-24776: -- Could anyone review this please? > [hbtop] Support

[jira] [Commented] (HBASE-24952) Figure why jdk11/hadoop3 tests on branch-2 are blowing the 9hour limit

2020-08-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186258#comment-17186258 ] Michael Stack commented on HBASE-24952: --- Master seems fine. It doesn't have this branch-2 issue

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-682318041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186247#comment-17186247 ] Hudson commented on HBASE-24898: Results for branch branch-2 [build #25 on

[jira] [Commented] (HBASE-24953) Temporarily up the timeout for branch-2 from 9 hours to 12 for build

2020-08-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186248#comment-17186248 ] Hudson commented on HBASE-24953: Results for branch branch-2 [build #25 on

[GitHub] [hbase] Apache-HBase commented on pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2254: URL: https://github.com/apache/hbase/pull/2254#issuecomment-682313571 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24952) Figure why jdk11/hadoop3 tests on branch-2 are blowing the 9hour limit

2020-08-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186240#comment-17186240 ] Duo Zhang commented on HBASE-24952: --- Actually there are no big difference on branch-2.3... Jdk11 is

[GitHub] [hbase] Apache-HBase commented on pull request #2149: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-682309632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-24760) Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2020-08-27 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24760: Summary: Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature (was: Refactor RSGroup

[GitHub] [hbase] ddupg commented on pull request #2149: HBASE-24760 Refactor RSGroup fallback

2020-08-27 Thread GitBox
ddupg commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-682301639 > How about change the title to "Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature" OK

[GitHub] [hbase] Apache-HBase commented on pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2317: URL: https://github.com/apache/hbase/pull/2317#issuecomment-682303918 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-27 Thread GitBox
bsglz commented on pull request #2254: URL: https://github.com/apache/hbase/pull/2254#issuecomment-682298343 > updated the thread on the hbase shell Admin class having a compatibility issue. Fixed, thanks. @busbey

[GitHub] [hbase] bsglz commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-27 Thread GitBox
bsglz commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r478804228 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -537,8 +537,8 @@ def assign(region_name)

[jira] [Commented] (HBASE-24960) reduce invalid subprocedure task

2020-08-27 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186227#comment-17186227 ] wenfeiyi666 commented on HBASE-24960: - sorry, I have cancelled. > reduce invalid subprocedure task

[jira] [Assigned] (HBASE-24960) reduce invalid subprocedure task

2020-08-27 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-24960: --- Assignee: (was: wenfeiyi666) > reduce invalid subprocedure task >

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-682297344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24958) CompactingMemStore.timeOfOldestEdit error update

2020-08-27 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186226#comment-17186226 ] wenfeiyi666 commented on HBASE-24958: - We have done a comparative test with ycsb, flushInMemory has

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
anoopsjohn commented on a change in pull request #2313: URL: https://github.com/apache/hbase/pull/2313#discussion_r478798975 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java ## @@ -416,13 +416,8 @@ public void

[jira] [Commented] (HBASE-24952) Figure why jdk11/hadoop3 tests on branch-2 are blowing the 9hour limit

2020-08-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186222#comment-17186222 ] Duo Zhang commented on HBASE-24952: --- For build #24, jdk8-hadoop3 is on H19 while jdk11-hadoop3 is on

[jira] [Commented] (HBASE-24952) Figure why jdk11/hadoop3 tests on branch-2 are blowing the 9hour limit

2020-08-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186219#comment-17186219 ] Duo Zhang commented on HBASE-24952: --- For build #11, jdk8-hadoop3 is on H12, and jdk11-hadoop3 is on

[jira] [Commented] (HBASE-24952) Figure why jdk11/hadoop3 tests on branch-2 are blowing the 9hour limit

2020-08-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186214#comment-17186214 ] Duo Zhang commented on HBASE-24952: --- Checked build #11, where jdk8-hadoop3 spend 3:58h and

[GitHub] [hbase] WenFeiYi commented on a change in pull request #2321: HBASE-24958 CompactingMemStore.timeOfOldestEdit error update

2020-08-27 Thread GitBox
WenFeiYi commented on a change in pull request #2321: URL: https://github.com/apache/hbase/pull/2321#discussion_r478791250 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AbstractMemStore.java ## @@ -95,7 +96,10 @@ protected void resetActive() {

[jira] [Commented] (HBASE-24952) Figure why jdk11/hadoop3 tests on branch-2 are blowing the 9hour limit

2020-08-27 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186203#comment-17186203 ] Duo Zhang commented on HBASE-24952: --- I checked the master log, seems jdk11-hadoop3 is much faster than

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-682263818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 commented on a change in pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-27 Thread GitBox
brfrn169 commented on a change in pull request #2228: URL: https://github.com/apache/hbase/pull/2228#discussion_r478770551 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -742,36 +741,35 @@ private Result increment(final

[GitHub] [hbase] Apache-HBase commented on pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2323: URL: https://github.com/apache/hbase/pull/2323#issuecomment-682259838 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 15m

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-682259754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r478767046 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[GitHub] [hbase] infraio commented on pull request #2149: HBASE-24760 Refactor RSGroup fallback

2020-08-27 Thread GitBox
infraio commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-682257839 And please take a look about the Precommit result. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] infraio commented on pull request #2149: HBASE-24760 Refactor RSGroup fallback

2020-08-27 Thread GitBox
infraio commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-682257612 How about change the title to "Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature" This is

[GitHub] [hbase] infraio commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
infraio commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r478762775 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-682252799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682251265 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-682250024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682249409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2304: URL: https://github.com/apache/hbase/pull/2304#issuecomment-682249277 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-682246210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
ankitjain64 commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r478708730 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java ## @@ -450,6 +452,49 @@ public

[GitHub] [hbase-filesystem] joshelser commented on a change in pull request #14: HBASE-24961 [HBOSS] HBaseObjectStoreSemantics.close should call super.close to make sure its own instance always get re

2020-08-27 Thread GitBox
joshelser commented on a change in pull request #14: URL: https://github.com/apache/hbase-filesystem/pull/14#discussion_r478729305 ## File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java ## @@ -180,9 +196,12 @@ protected boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-682220175 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682214238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
ankitjain64 commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r478709945 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java ## @@ -441,6 +442,41 @@ public void

[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
ankitjain64 commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r478708944 ## File path: hbase-replication/src/test/java/org/apache/hadoop/hbase/replication/TestZKReplicationPeerStorage.java ## @@ -215,4 +219,51 @@ public

[GitHub] [hbase] ankitjain64 commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
ankitjain64 commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r478708730 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationPeerConfigUtil.java ## @@ -450,6 +452,49 @@ public

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r478701500 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the Apache

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r478701500 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-682188750 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-682187016 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-27 Thread GitBox
saintstack commented on a change in pull request #2304: URL: https://github.com/apache/hbase/pull/2304#discussion_r478689583 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java ## @@ -644,12 +644,17 @@ private RegionInfo

[GitHub] [hbase] bharathv commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
bharathv commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r478687341 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[GitHub] [hbase] Apache-HBase commented on pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2304: URL: https://github.com/apache/hbase/pull/2304#issuecomment-682183197 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2282: HBASE-24901 Create versatile hbase-shell table formatter

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2282: URL: https://github.com/apache/hbase/pull/2282#issuecomment-682181788 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-682173905 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-682170122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 opened a new pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-27 Thread GitBox
shahrs87 opened a new pull request #2323: URL: https://github.com/apache/hbase/pull/2323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] arshadmohammad commented on a change in pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-27 Thread GitBox
arshadmohammad commented on a change in pull request #2304: URL: https://github.com/apache/hbase/pull/2304#discussion_r478627788 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java ## @@ -644,12 +644,17 @@ private RegionInfo

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682130416 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682123433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-27 Thread GitBox
saintstack commented on pull request #2304: URL: https://github.com/apache/hbase/pull/2304#issuecomment-682123210 Rerunning tests to see if related failures. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] saintstack commented on a change in pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-27 Thread GitBox
saintstack commented on a change in pull request #2304: URL: https://github.com/apache/hbase/pull/2304#discussion_r478618981 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java ## @@ -644,12 +644,17 @@ private RegionInfo

[jira] [Updated] (HBASE-24528) Improve balancer decision observability

2020-08-27 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24528: - Fix Version/s: 2.4.0 1.7.0 3.0.0-alpha-1 > Improve

[GitHub] [hbase] saintstack commented on a change in pull request #2321: HBASE-24958 CompactingMemStore.timeOfOldestEdit error update

2020-08-27 Thread GitBox
saintstack commented on a change in pull request #2321: URL: https://github.com/apache/hbase/pull/2321#discussion_r478614203 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AbstractMemStore.java ## @@ -95,7 +96,10 @@ protected void resetActive()

[jira] [Commented] (HBASE-24958) CompactingMemStore.timeOfOldestEdit error update

2020-08-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186035#comment-17186035 ] Michael Stack commented on HBASE-24958: --- Have you found benefit running with 'flush in memory'

[GitHub] [hbase] saintstack commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
saintstack commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r478612123 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the

[GitHub] [hbase] bharathv commented on a change in pull request #2284: Hbase-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-27 Thread GitBox
bharathv commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r478608776 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMasterReplication.java ## @@ -441,6 +442,41 @@ public void

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-27 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r478595968 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java ## @@ -1543,9 +1544,17 @@ * @param serverNames Server

[jira] [Commented] (HBASE-15549) Undo HMaster carrying regions in master branch as default

2020-08-27 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186005#comment-17186005 ] Michael Stack commented on HBASE-15549: --- {quote}Do we still want HMaster to carry regions now?

[GitHub] [hbase] busbey commented on a change in pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-27 Thread GitBox
busbey commented on a change in pull request #2254: URL: https://github.com/apache/hbase/pull/2254#discussion_r478572332 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -537,8 +537,8 @@ def assign(region_name)

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-682079899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-27 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r478097593 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -2339,9 +2340,16 @@ boolean snapshotCleanupSwitch(final

[jira] [Updated] (HBASE-24957) ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-27 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rushabh Shah updated HBASE-24957: - Affects Version/s: 1.7.0 1.3.6 >

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682060240 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-682057865 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-682051807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24956) ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185942#comment-17185942 ] Bharath Vissapragada commented on HBASE-24956: -- Thanks, updated the "Affects versions"

[jira] [Updated] (HBASE-24956) ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24956: - Affects Version/s: 2.4.0 2.3.3 >

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-682041769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-682041245 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2313: URL: https://github.com/apache/hbase/pull/2313#issuecomment-682035807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682033261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682027720 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-682026914 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 opened a new pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-27 Thread GitBox
shahrs87 opened a new pull request #2322: URL: https://github.com/apache/hbase/pull/2322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2317: URL: https://github.com/apache/hbase/pull/2317#issuecomment-682001089 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24892) config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185877#comment-17185877 ] Hudson commented on HBASE-24892: Results for branch branch-2.3 [build #20 on

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185876#comment-17185876 ] Hudson commented on HBASE-24898: Results for branch branch-2.3 [build #20 on

[GitHub] [hbase] Apache9 commented on a change in pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-27 Thread GitBox
Apache9 commented on a change in pull request #2317: URL: https://github.com/apache/hbase/pull/2317#discussion_r478455231 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java ## @@ -290,35 +272,48 @@ public TableDescriptor get(final

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-681961568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] infraio commented on a change in pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-27 Thread GitBox
infraio commented on a change in pull request #2317: URL: https://github.com/apache/hbase/pull/2317#discussion_r478432991 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java ## @@ -290,35 +272,48 @@ public TableDescriptor get(final

[GitHub] [hbase] Apache-HBase commented on pull request #2149: HBASE-24760 Refactor RSGroup fallback

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-681913021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] cuibo01 commented on a change in pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
cuibo01 commented on a change in pull request #2313: URL: https://github.com/apache/hbase/pull/2313#discussion_r478357545 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java ## @@ -488,6 +496,8 @@ protected boolean

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185801#comment-17185801 ] Hudson commented on HBASE-24898: Results for branch branch-2.2 [build #50 on

[jira] [Commented] (HBASE-24892) config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185802#comment-17185802 ] Hudson commented on HBASE-24892: Results for branch branch-2.2 [build #50 on

[GitHub] [hbase] cuibo01 commented on a change in pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-08-27 Thread GitBox
cuibo01 commented on a change in pull request #2313: URL: https://github.com/apache/hbase/pull/2313#discussion_r478357545 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java ## @@ -488,6 +496,8 @@ protected boolean

[jira] [Created] (HBASE-24962) Optimize BufferNode Lock

2020-08-27 Thread Bo Cui (Jira)
Bo Cui created HBASE-24962: -- Summary: Optimize BufferNode Lock Key: HBASE-24962 URL: https://issues.apache.org/jira/browse/HBASE-24962 Project: HBase Issue Type: Bug Components: MTTR

[GitHub] [hbase] Apache-HBase commented on pull request #2149: HBASE-24760 Refactor RSGroup fallback

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-681896221 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2317: URL: https://github.com/apache/hbase/pull/2317#issuecomment-681879020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Work started] (HBASE-24961) [HBOSS] HBaseObjectStoreSemantics.close should call super.close to make sure its own instance always get removed from FileSystem.CACHE

2020-08-27 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24961 started by Wellington Chevreuil. > [HBOSS] HBaseObjectStoreSemantics.close should call

[GitHub] [hbase] Apache-HBase commented on pull request #2321: HBASE-24958 CompactingMemStore.timeOfOldestEdit error update

2020-08-27 Thread GitBox
Apache-HBase commented on pull request #2321: URL: https://github.com/apache/hbase/pull/2321#issuecomment-681872412 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

  1   2   >