[GitHub] [hbase] Apache-HBase commented on pull request #2469: HBASE-25112 Add new procedure metrics for master UI only

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2469: URL: https://github.com/apache/hbase/pull/2469#issuecomment-705982842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s

[GitHub] [hbase] Apache-HBase commented on pull request #1531: HBASE-24200 Upgrade to Yetus 0.12.0

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #1531: URL: https://github.com/apache/hbase/pull/1531#issuecomment-705970633 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 58

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2501: HBASE-25065 WAL archival can be batched/throttled and also done by a …

2020-10-08 Thread GitBox
ramkrish86 commented on a change in pull request #2501: URL: https://github.com/apache/hbase/pull/2501#discussion_r502191423 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -482,6 +505,8 @@ protected SyncFuture initial

[jira] [Updated] (HBASE-25034) Table regions details on master GUI display slowly.

2020-10-08 Thread DingSheng Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DingSheng Li updated HBASE-25034: - Attachment: The table display after pagination.html > Table regions details on master GUI displa

[GitHub] [hbase] Apache-HBase commented on pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2515: URL: https://github.com/apache/hbase/pull/2515#issuecomment-705957976 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-705950160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 50s

[GitHub] [hbase] Apache-HBase commented on pull request #2469: HBASE-25112 Add new procedure metrics for master UI only

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2469: URL: https://github.com/apache/hbase/pull/2469#issuecomment-705949938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2515: URL: https://github.com/apache/hbase/pull/2515#issuecomment-705943792 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[jira] [Updated] (HBASE-24813) ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination

2020-10-08 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24813: Attachment: image-2020-10-09-10-50-00-372.png > ReplicationSource should clear buffer usage on Replication

[jira] [Commented] (HBASE-24813) ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination

2020-10-08 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210572#comment-17210572 ] Sun Xin commented on HBASE-24813: - Using isActive() instead of isAlive() in this [PR|ht

[GitHub] [hbase] Apache-HBase commented on pull request #2520: Backport "HBASE-24628 Region normalizer now respects a rate limit" to branch-2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2520: URL: https://github.com/apache/hbase/pull/2520#issuecomment-705931960 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705930883 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4

[GitHub] [hbase] Apache-HBase commented on pull request #2520: Backport "HBASE-24628 Region normalizer now respects a rate limit" to branch-2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2520: URL: https://github.com/apache/hbase/pull/2520#issuecomment-705931072 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s

[GitHub] [hbase-operator-tools] VictorZeng commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-08 Thread GitBox
VictorZeng commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-705925637 > > > > There is no `HbckService` in versions of hbase _before 2.0.3 and 2.1.1_. HBCK2 will not work against these versions. If users use Hbase 2.1.0 version, you c

[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-705915243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11

[GitHub] [hbase] ankitsinghal commented on a change in pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
ankitsinghal commented on a change in pull request #2514: URL: https://github.com/apache/hbase/pull/2514#discussion_r502112732 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -84,10 +84,10 @@ public MobFileCompactionChore(

[GitHub] [hbase] Apache-HBase commented on pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2515: URL: https://github.com/apache/hbase/pull/2515#issuecomment-705906411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 11

[GitHub] [hbase] Apache-HBase commented on pull request #1531: HBASE-24200 Upgrade to Yetus 0.12.0

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #1531: URL: https://github.com/apache/hbase/pull/1531#issuecomment-705902959 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 37

[GitHub] [hbase] Apache-HBase commented on pull request #2520: Backport "HBASE-24628 Region normalizer now respects a rate limit" to branch-2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2520: URL: https://github.com/apache/hbase/pull/2520#issuecomment-705896238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] ndimiduk opened a new pull request #2520: Backport "HBASE-24628 Region normalizer now respects a rate limit" to branch-2

2020-10-08 Thread GitBox
ndimiduk opened a new pull request #2520: URL: https://github.com/apache/hbase/pull/2520 Implement a rate limiter for the normalizer. Implemented in terms of MB/sec of affacted region size (the same metrics used to make normalization decisions). Uses Guava `RateLimiter` to perform the

[GitHub] [hbase] ndimiduk commented on pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-08 Thread GitBox
ndimiduk commented on pull request #2454: URL: https://github.com/apache/hbase/pull/2454#issuecomment-705861790 Thanks for the detailed reviews everyone! This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] ndimiduk merged pull request #2454: HBASE-24628 Region normalizer now respects a rate limit

2020-10-08 Thread GitBox
ndimiduk merged pull request #2454: URL: https://github.com/apache/hbase/pull/2454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705859621 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s

[jira] [Updated] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25156: - Resolution: Fixed Status: Resolved (was: Patch Available) Backported to everywhere rele

[GitHub] [hbase] Apache-HBase commented on pull request #2519: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-1

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2519: URL: https://github.com/apache/hbase/pull/2519#issuecomment-705843667 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s

[GitHub] [hbase] ndimiduk merged pull request #2519: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-1

2020-10-08 Thread GitBox
ndimiduk merged pull request #2519: URL: https://github.com/apache/hbase/pull/2519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25156: - Fix Version/s: 1.7.0 > TestMasterFailover.testSimpleMasterFailover is flaky > -

[GitHub] [hbase] ndimiduk opened a new pull request #2519: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-1

2020-10-08 Thread GitBox
ndimiduk opened a new pull request #2519: URL: https://github.com/apache/hbase/pull/2519 Change the test to wait for evidence that the active master has seen that the backup master killed by the test has gone away. This is done before proceeding to validate that the dead backup is corr

[GitHub] [hbase] ndimiduk merged pull request #2518: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-2.2

2020-10-08 Thread GitBox
ndimiduk merged pull request #2518: URL: https://github.com/apache/hbase/pull/2518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25156: - Fix Version/s: 2.2.7 > TestMasterFailover.testSimpleMasterFailover is flaky > -

[GitHub] [hbase] ndimiduk opened a new pull request #2518: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-2.2

2020-10-08 Thread GitBox
ndimiduk opened a new pull request #2518: URL: https://github.com/apache/hbase/pull/2518 Change the test to wait for evidence that the active master has seen that the backup master killed by the test has gone away. This is done before proceeding to validate that the dead backup is corr

[jira] [Updated] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25156: - Fix Version/s: 2.3.3 > TestMasterFailover.testSimpleMasterFailover is flaky > -

[jira] [Updated] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25156: - Fix Version/s: 2.4.0 > TestMasterFailover.testSimpleMasterFailover is flaky > -

[GitHub] [hbase] ndimiduk merged pull request #2517: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-2.3

2020-10-08 Thread GitBox
ndimiduk merged pull request #2517: URL: https://github.com/apache/hbase/pull/2517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] ndimiduk opened a new pull request #2517: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-2.3

2020-10-08 Thread GitBox
ndimiduk opened a new pull request #2517: URL: https://github.com/apache/hbase/pull/2517 Change the test to wait for evidence that the active master has seen that the backup master killed by the test has gone away. This is done before proceeding to validate that the dead backup is corr

[GitHub] [hbase] Apache-HBase commented on pull request #2516: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2516: URL: https://github.com/apache/hbase/pull/2516#issuecomment-705833478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hbase] ndimiduk merged pull request #2516: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-2

2020-10-08 Thread GitBox
ndimiduk merged pull request #2516: URL: https://github.com/apache/hbase/pull/2516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] ndimiduk opened a new pull request #2516: Backport "HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky (#2507)" to branch-2

2020-10-08 Thread GitBox
ndimiduk opened a new pull request #2516: URL: https://github.com/apache/hbase/pull/2516 Change the test to wait for evidence that the active master has seen that the backup master killed by the test has gone away. This is done before proceeding to validate that the dead backup is corr

[jira] [Updated] (HBASE-25156) TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25156: - Fix Version/s: 3.0.0-alpha-1 > TestMasterFailover.testSimpleMasterFailover is flaky > -

[GitHub] [hbase] Apache-HBase commented on pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2515: URL: https://github.com/apache/hbase/pull/2515#issuecomment-705831620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34

[GitHub] [hbase] ndimiduk merged pull request #2507: HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread GitBox
ndimiduk merged pull request #2507: URL: https://github.com/apache/hbase/pull/2507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] ndimiduk commented on pull request #2507: HBASE-25156 TestMasterFailover.testSimpleMasterFailover is flaky

2020-10-08 Thread GitBox
ndimiduk commented on pull request #2507: URL: https://github.com/apache/hbase/pull/2507#issuecomment-705831185 Failure in TestBucketCache is a known flaky. Thanks for the review @saintstack . This is an automated message fr

[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-705828453 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32

[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-705820837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28

[GitHub] [hbase] busbey commented on pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-08 Thread GitBox
busbey commented on pull request #2515: URL: https://github.com/apache/hbase/pull/2515#issuecomment-705820578 pushed an addendum after testing running the shell directly from a source build instead of a binary tarball. had a stale reference from when I was first testing running from source

[jira] [Updated] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-08 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14067: Hadoop Flags: Incompatible change Release Note: The `hbase-shell` artifact now contains the r

[jira] [Updated] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-08 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14067: Fix Version/s: 2.4.0 3.0.0-alpha-1 > bundle ruby files for hbase shell into a j

[jira] [Updated] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-08 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14067: Status: In Progress (was: Patch Available) > bundle ruby files for hbase shell into a jar. >

[jira] [Updated] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-08 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-14067: Status: Patch Available (was: In Progress) > bundle ruby files for hbase shell into a jar. >

[GitHub] [hbase] busbey opened a new pull request #2515: HBASE-14067 bundle ruby files for hbase shell into a jar.

2020-10-08 Thread GitBox
busbey opened a new pull request #2515: URL: https://github.com/apache/hbase/pull/2515 * removes some cruft from the hbase-shell pom that appears to be from coping the hbase-server pom long ago * puts the ruby scripts into the hbase-shell jar following the guide from jruby for packaging

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705794917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10

[GitHub] [hbase] Apache-HBase commented on pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2504: URL: https://github.com/apache/hbase/pull/2504#issuecomment-705785314 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705780603 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s

[GitHub] [hbase] joshelser commented on a change in pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
joshelser commented on a change in pull request #2514: URL: https://github.com/apache/hbase/pull/2514#discussion_r501958247 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -84,10 +84,10 @@ public MobFileCompactionChore(Con

[jira] [Commented] (HBASE-11747) ClusterStatus (heartbeat) is too bulky

2020-10-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210408#comment-17210408 ] Michael Stack commented on HBASE-11747: --- Looking at a running cluster where server

[GitHub] [hbase] busbey commented on a change in pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
busbey commented on a change in pull request #2514: URL: https://github.com/apache/hbase/pull/2514#discussion_r501955660 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -84,10 +84,10 @@ public MobFileCompactionChore(Config

[GitHub] [hbase] Apache-HBase commented on pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2514: URL: https://github.com/apache/hbase/pull/2514#issuecomment-705767061 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 32

[GitHub] [hbase] busbey commented on a change in pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
busbey commented on a change in pull request #2514: URL: https://github.com/apache/hbase/pull/2514#discussion_r501949568 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -84,10 +84,10 @@ public MobFileCompactionChore(Config

[GitHub] [hbase] joshelser commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
joshelser commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705757460 > If 'main' or the session name are of no value, just exclude? Yeah, if we're consciously making that change, I can get behind it, too. Something as simple as: `hbase:%03n

[GitHub] [hbase] joshelser commented on a change in pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
joshelser commented on a change in pull request #2514: URL: https://github.com/apache/hbase/pull/2514#discussion_r501930509 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCompactionChore.java ## @@ -84,10 +84,10 @@ public MobFileCompactionChore(Con

[GitHub] [hbase] ankitsinghal opened a new pull request #2514: HBASE-25166 MobFileCompactionChore is closing the master's shared clu…

2020-10-08 Thread GitBox
ankitsinghal opened a new pull request #2514: URL: https://github.com/apache/hbase/pull/2514 …ster connection This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [hbase] saintstack commented on pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-08 Thread GitBox
saintstack commented on pull request #1727: URL: https://github.com/apache/hbase/pull/1727#issuecomment-705743040 Putting aside for now until more interest. There is the reporter tool over in hbase-operator-tools that does table/region basis. --

[GitHub] [hbase] saintstack closed pull request #1727: HBASE-17756 We should have better introspection of HFiles

2020-10-08 Thread GitBox
saintstack closed pull request #1727: URL: https://github.com/apache/hbase/pull/1727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2504: URL: https://github.com/apache/hbase/pull/2504#issuecomment-705727349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37

[jira] [Commented] (HBASE-23959) Fix javadoc for JDK11

2020-10-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210353#comment-17210353 ] Hudson commented on HBASE-23959: Results for branch branch-2 [build #72 on buil

[jira] [Commented] (HBASE-25160) Refactor AccessController and VisibilityController

2020-10-08 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210354#comment-17210354 ] Hudson commented on HBASE-25160: Results for branch branch-2 [build #72 on buil

[GitHub] [hbase] saintstack merged pull request #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API

2020-10-08 Thread GitBox
saintstack merged pull request #1549: URL: https://github.com/apache/hbase/pull/1549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-24025) Improve performance of move_servers_rsgroup and move_tables_rsgroup by using async region move API

2020-10-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24025. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[GitHub] [hbase] saintstack commented on pull request #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API

2020-10-08 Thread GitBox
saintstack commented on pull request #1549: URL: https://github.com/apache/hbase/pull/1549#issuecomment-705716803 Hmm... the build passed: `03:46:34 +1 overall 03:46:34 03:46:34 | Vote | Subsystem | Runtime | Comment 03:46:34

[jira] [Updated] (HBASE-25034) Table regions details on master GUI display slowly.

2020-10-08 Thread DingSheng Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DingSheng Li updated HBASE-25034: - Attachment: 1.txt > Table regions details on master GUI display slowly. > --

[jira] [Updated] (HBASE-25034) Table regions details on master GUI display slowly.

2020-10-08 Thread DingSheng Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DingSheng Li updated HBASE-25034: - Attachment: (was: 1.txt) > Table regions details on master GUI display slowly. > ---

[GitHub] [hbase] Apache-HBase commented on pull request #2513: HBASE-25164 Make ModifyTableProcedure support changing meta replica c…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2513: URL: https://github.com/apache/hbase/pull/2513#issuecomment-705714983 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] saintstack commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
saintstack commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705714198 If 'main' or the session name are of no value, just exclude? Any progress on the @busbey list of items from JIRA on doc'ing diffs, license changes, etc.? Thanks

[GitHub] [hbase] Apache-HBase commented on pull request #2513: HBASE-25164 Make ModifyTableProcedure support changing meta replica c…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2513: URL: https://github.com/apache/hbase/pull/2513#issuecomment-705711328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29

[GitHub] [hbase] saintstack commented on a change in pull request #2501: HBASE-25065 WAL archival can be batched/throttled and also done by a …

2020-10-08 Thread GitBox
saintstack commented on a change in pull request #2501: URL: https://github.com/apache/hbase/pull/2501#discussion_r501871589 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java ## @@ -715,11 +740,39 @@ private void cleanOldLogs(

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705702661 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s

[GitHub] [hbase] saintstack commented on a change in pull request #2513: HBASE-25164 Make ModifyTableProcedure support changing meta replica c…

2020-10-08 Thread GitBox
saintstack commented on a change in pull request #2513: URL: https://github.com/apache/hbase/pull/2513#discussion_r501856397 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ## @@ -1131,7 +1131,20 @@ /** Conf key for enabling meta replication

[jira] [Created] (HBASE-25166) MobFileCompactionChore is closing the master's shared cluster connection

2020-10-08 Thread Ankit Singhal (Jira)
Ankit Singhal created HBASE-25166: - Summary: MobFileCompactionChore is closing the master's shared cluster connection Key: HBASE-25166 URL: https://issues.apache.org/jira/browse/HBASE-25166 Project: H

[GitHub] [hbase] saintstack closed pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-08 Thread GitBox
saintstack closed pull request #2496: URL: https://github.com/apache/hbase/pull/2496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] saintstack commented on pull request #2496: HBASE-25151 warmupRegion frustrates registering WALs on the catalog r…

2020-10-08 Thread GitBox
saintstack commented on pull request #2496: URL: https://github.com/apache/hbase/pull/2496#issuecomment-705682156 Thanks @Apache9 Closing. Merged manually to HBASE-18070 This is an automated message from the Apache Gi

[GitHub] [hbase] saintstack commented on pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-08 Thread GitBox
saintstack commented on pull request #2504: URL: https://github.com/apache/hbase/pull/2504#issuecomment-705680049 Addressed @wchevreuil review. No plans to move WALPlayer to hbck2. I'd added the hbck2 prefix since it tooling to do fixup (though it core). Thanks @wchevreuil

[GitHub] [hbase] saintstack commented on a change in pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-08 Thread GitBox
saintstack commented on a change in pull request #2504: URL: https://github.com/apache/hbase/pull/2504#discussion_r501849460 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALInputFormat.java ## @@ -301,40 +303,56 @@ public WALKey getCurrentKey()

[GitHub] [hbase] saintstack commented on a change in pull request #2504: HBASE-22976 [HBCK2] Add RecoveredEditsPlayer

2020-10-08 Thread GitBox
saintstack commented on a change in pull request #2504: URL: https://github.com/apache/hbase/pull/2504#discussion_r501849236 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALInputFormat.java ## @@ -301,40 +303,56 @@ public WALKey getCurrentKey()

[jira] [Resolved] (HBASE-25165) Change 'State time' in UI so sorts

2020-10-08 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25165. --- Fix Version/s: 2.4.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Releas

[GitHub] [hbase] saintstack merged pull request #2508: HBASE-25165 Change 'State time' in UI so sorts

2020-10-08 Thread GitBox
saintstack merged pull request #2508: URL: https://github.com/apache/hbase/pull/2508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase-operator-tools] wchevreuil commented on pull request #77: HBASE-25161 [hbase-meta-repair] Add tool for repairing metadata.

2020-10-08 Thread GitBox
wchevreuil commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-705666452 > > > There is no `HbckService` in versions of hbase _before 2.0.3 and 2.1.1_. HBCK2 will not work against these versions. If users use Hbase 2.1.0 version, you can

[GitHub] [hbase] Apache-HBase commented on pull request #2513: HBASE-25164 Make ModifyTableProcedure support changing meta replica c…

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2513: URL: https://github.com/apache/hbase/pull/2513#issuecomment-705641388 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] nkalmar commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
nkalmar commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705638394 Okay, I set the session name back to main. But I cheated. Basically I hardcoded the session name to be main. Is this ok? with the patch it changed how it gets the session name. Ho

[GitHub] [hbase] nkalmar commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
nkalmar commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705630401 I only found a way to change the format, I didn't see any way to give a name myself. It gets it's workspace name from the underlying object. I don't know why this changed from mai

[GitHub] [hbase] Apache-HBase commented on pull request #2501: HBASE-25065 WAL archival can be batched/throttled and also done by a …

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2501: URL: https://github.com/apache/hbase/pull/2501#issuecomment-705629909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35

[GitHub] [hbase] Apache-HBase commented on pull request #2501: HBASE-25065 WAL archival can be batched/throttled and also done by a …

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2501: URL: https://github.com/apache/hbase/pull/2501#issuecomment-705624687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7

[GitHub] [hbase] Apache9 commented on pull request #2513: HBASE-25164 Make ModifyTableProcedure support changing meta replica c…

2020-10-08 Thread GitBox
Apache9 commented on pull request #2513: URL: https://github.com/apache/hbase/pull/2513#issuecomment-705614132 This is the final piece of HBASE-25099, after this PR gets merged, we could use alter table to change the meta replica count.

[GitHub] [hbase] Apache9 opened a new pull request #2513: HBASE-25164 Make ModifyTableProcedure support changing meta replica c…

2020-10-08 Thread GitBox
Apache9 opened a new pull request #2513: URL: https://github.com/apache/hbase/pull/2513 …ount This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705605412 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 17

[jira] [Updated] (HBASE-25124) Support changing region replica count without disabling table

2020-10-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25124: -- Fix Version/s: 2.4.0 3.0.0-alpha-1 > Support changing region replica count without

[jira] [Resolved] (HBASE-25124) Support changing region replica count without disabling table

2020-10-08 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25124. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~stack] for r

[GitHub] [hbase] nkalmar edited a comment on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
nkalmar edited a comment on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705580405 Cancel that, this is not working, this config not only changes session name but the object as well, it's no longer hbase but basically a "main" string... reverting --

[GitHub] [hbase] nkalmar edited a comment on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
nkalmar edited a comment on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705580405 I found a config that sets session name. It should have no impact on the prompt, I tested with my usual process (create/list/put/scan commands). I didn't see any issue.

[GitHub] [hbase] nkalmar commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-10-08 Thread GitBox
nkalmar commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-705580405 I found a config that sets session name. It should have no impact on the prompt, I tested with my usual process (create/list/put/scan commands). I didn't see any issue.

[jira] [Assigned] (HBASE-14067) bundle ruby files for hbase shell into a jar.

2020-10-08 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-14067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey reassigned HBASE-14067: --- Assignee: Sean Busbey > bundle ruby files for hbase shell into a jar. > ---

  1   2   >