[GitHub] [hbase] Apache9 commented on a change in pull request #2587: HBASE-25213 Should request Compaction when bulkLoadHFile is done

2020-11-09 Thread GitBox
Apache9 commented on a change in pull request #2587: URL: https://github.com/apache/hbase/pull/2587#discussion_r520353341 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkloadBase.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2638: URL: https://github.com/apache/hbase/pull/2638#issuecomment-724526771 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #38: HBASE-25262. Update jetty version in hbase-thirdparty.

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #38: URL: https://github.com/apache/hbase-thirdparty/pull/38#issuecomment-724525519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-thirdparty] jojochuang opened a new pull request #38: HBASE-25262. Update jetty version in hbase-thirdparty.

2020-11-09 Thread GitBox
jojochuang opened a new pull request #38: URL: https://github.com/apache/hbase-thirdparty/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache9 commented on a change in pull request #2630: HBASE-25242 Add Increment/Append support to RowMutations

2020-11-09 Thread GitBox
Apache9 commented on a change in pull request #2630: URL: https://github.com/apache/hbase/pull/2630#discussion_r520340151 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java ## @@ -3657,9 +3657,10 @@ public static CheckAndMutate

[jira] [Created] (HBASE-25262) Update jetty version in hbase-thirdparty

2020-11-09 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HBASE-25262: --- Summary: Update jetty version in hbase-thirdparty Key: HBASE-25262 URL: https://issues.apache.org/jira/browse/HBASE-25262 Project: HBase Issue Type:

[jira] [Created] (HBASE-25261) Upgrade Bootstrap to 3.4.1

2020-11-09 Thread Mate Szalay-Beko (Jira)
Mate Szalay-Beko created HBASE-25261: Summary: Upgrade Bootstrap to 3.4.1 Key: HBASE-25261 URL: https://issues.apache.org/jira/browse/HBASE-25261 Project: HBase Issue Type: Improvement

[GitHub] [hbase] nyl3532016 commented on pull request #2587: HBASE-25213 Should request Compaction when bulkLoadHFile is done

2020-11-09 Thread GitBox
nyl3532016 commented on pull request #2587: URL: https://github.com/apache/hbase/pull/2587#issuecomment-724516737 > Can we add a UT here? add a UT shouldRequestCompactionAfterBulkLoad This is an automated message from

[GitHub] [hbase] brfrn169 commented on pull request #2641: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
brfrn169 commented on pull request #2641: URL: https://github.com/apache/hbase/pull/2641#issuecomment-724506415 Not sure why the QA is failing.. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2638: URL: https://github.com/apache/hbase/pull/2638#issuecomment-724505178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25213) Should request Compaction when bulkLoadHFiles is done

2020-11-09 Thread niuyulin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] niuyulin updated HBASE-25213: - Summary: Should request Compaction when bulkLoadHFiles is done (was: Should request Compaction after

[GitHub] [hbase] Apache-HBase commented on pull request #2587: HBASE-25213 Should request Compaction when bulkLoadHFile is done

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2587: URL: https://github.com/apache/hbase/pull/2587#issuecomment-724500905 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25260) upgrading hbase from 2.0.6 to 2.1.1, HMaster failed to become active because it cannot find hbase:namespace table

2020-11-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228995#comment-17228995 ] Michael Stack commented on HBASE-25260: --- Would be good to see all of the log since startup, not

[GitHub] [hbase] Apache-HBase commented on pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2638: URL: https://github.com/apache/hbase/pull/2638#issuecomment-724468240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2635: HBASE-25253 Deprecated master carrys regions related methods and configs

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2635: URL: https://github.com/apache/hbase/pull/2635#issuecomment-724466990 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-724462049 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2641: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2641: URL: https://github.com/apache/hbase/pull/2641#issuecomment-724454255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2587: HBASE-25213 Should request Compaction when bulkLoadHFile is done

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2587: URL: https://github.com/apache/hbase/pull/2587#issuecomment-724453108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] brfrn169 opened a new pull request #2641: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
brfrn169 opened a new pull request #2641: URL: https://github.com/apache/hbase/pull/2641 …ch-1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] brfrn169 closed pull request #2637: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
brfrn169 closed pull request #2637: URL: https://github.com/apache/hbase/pull/2637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2637: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2637: URL: https://github.com/apache/hbase/pull/2637#issuecomment-724449179 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-724443186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2637: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2637: URL: https://github.com/apache/hbase/pull/2637#issuecomment-724441721 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2635: HBASE-25253 Deprecated master carrys regions related methods and configs

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2635: URL: https://github.com/apache/hbase/pull/2635#issuecomment-724430580 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2638: URL: https://github.com/apache/hbase/pull/2638#issuecomment-724429320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache9 commented on a change in pull request #2640: URL: https://github.com/apache/hbase/pull/2640#discussion_r520255266 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -161,7 +165,11 @@ private final boolean

[jira] [Commented] (HBASE-25065) WAL archival to be done by a separate thread

2020-11-09 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228932#comment-17228932 ] Anoop Sam John commented on HBASE-25065: [~ram_krish] pls add RN to highlight the configs > WAL

[GitHub] [hbase] Apache-HBase commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-724404122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25260) upgrading hbase from 2.0.6 to 2.1.1, HMaster failed to become active because it cannot find hbase:namespace table

2020-11-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228905#comment-17228905 ] Duo Zhang commented on HBASE-25260: --- Have you started at least one region server when upgrading to

[GitHub] [hbase] Apache9 commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache9 commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-724395906 We do not support scan on a specific replica on branch-2? I think this should be a bug? We can set replica id on a Scan object?

[GitHub] [hbase] huaxiangsun commented on pull request #2640: Backport: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
huaxiangsun commented on pull request #2640: URL: https://github.com/apache/hbase/pull/2640#issuecomment-724392322 Hi @Apache9 and @saintstack, please review the changes for branch-2. The scan over a specific replica region is not supported in branch-2, so I added ReverseScan over a

[GitHub] [hbase] huaxiangsun opened a new pull request #2640: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
huaxiangsun opened a new pull request #2640: URL: https://github.com/apache/hbase/pull/2640 … load over meta replica regions It adds load balance support for meta lookup in AsyncTableRegionLocator. The existing meta replica mode is renamed as "HedgedRead", client sends scan

[GitHub] [hbase] huaxiangsun merged pull request #2639: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
huaxiangsun merged pull request #2639: URL: https://github.com/apache/hbase/pull/2639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-724386248 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25260) upgrading hbase from 2.0.6 to 2.1.1, HMaster failed to become active because it cannot find hbase:namespace table

2020-11-09 Thread Yongle Zhang (Jira)
Yongle Zhang created HBASE-25260: Summary: upgrading hbase from 2.0.6 to 2.1.1, HMaster failed to become active because it cannot find hbase:namespace table Key: HBASE-25260 URL:

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-724359367 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25259) After upgrading HBase from 2.1.1 to 2.2.0, table cannot be read and HMaster crashes

2020-11-09 Thread Yongle Zhang (Jira)
Yongle Zhang created HBASE-25259: Summary: After upgrading HBase from 2.1.1 to 2.2.0, table cannot be read and HMaster crashes Key: HBASE-25259 URL: https://issues.apache.org/jira/browse/HBASE-25259

[GitHub] [hbase] Apache-HBase commented on pull request #2639: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2639: URL: https://github.com/apache/hbase/pull/2639#issuecomment-724331471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2639: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2639: URL: https://github.com/apache/hbase/pull/2639#issuecomment-724327142 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-20598) Upgrade to JRuby 9.2

2020-11-09 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-20598. - Hadoop Flags: Incompatible change Release Note: The HBase shell now relies on JRuby 9.2.

[jira] [Commented] (HBASE-24941) Forward port HBASE-22492 "HBase server doesn't preserve SASL sequence number on the network" to branch-2+

2020-11-09 Thread Robert Kerek (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228843#comment-17228843 ] Robert Kerek commented on HBASE-24941: -- Of course [~busbey] > Forward port HBASE-22492 "HBase

[GitHub] [hbase] asfgit closed pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-11-09 Thread GitBox
asfgit closed pull request #2308: URL: https://github.com/apache/hbase/pull/2308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-20598) Upgrade to JRuby 9.2

2020-11-09 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-20598: Fix Version/s: 2.4.0 > Upgrade to JRuby 9.2 > > > Key:

[jira] [Updated] (HBASE-25181) Add options for disabling column family encryption and choosing hash algorithm for wrapped encryption keys.

2020-11-09 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25181: Component/s: encryption > Add options for disabling column family encryption and choosing hash >

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-724309080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24941) Forward port HBASE-22492 "HBase server doesn't preserve SASL sequence number on the network" to branch-2+

2020-11-09 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228812#comment-17228812 ] Sean Busbey commented on HBASE-24941: - [~Robert Kerek] you okay with me taking this issue on? >

[jira] [Commented] (HBASE-24667) Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-11-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228810#comment-17228810 ] Hudson commented on HBASE-24667: Results for branch master [build #121 on

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724272813 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724272027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25181) Add options for disabling column family encryption and choosing hash algorithm for wrapped encryption keys.

2020-11-09 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-25181. - Fix Version/s: 2.4.0 3.0.0-alpha-1 Release Note: This change adds

[GitHub] [hbase] asfgit closed pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
asfgit closed pull request #2539: URL: https://github.com/apache/hbase/pull/2539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-724239558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25181) Add options for disabling column family encryption and choosing hash algorithm for wrapped encryption keys.

2020-11-09 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25181: Summary: Add options for disabling column family encryption and choosing hash algorithm for

[GitHub] [hbase] Apache-HBase commented on pull request #2639: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2639: URL: https://github.com/apache/hbase/pull/2639#issuecomment-724226369 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724199951 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun opened a new pull request #2639: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-11-09 Thread GitBox
huaxiangsun opened a new pull request #2639: URL: https://github.com/apache/hbase/pull/2639 … load over meta replica regions (addendum) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache-HBase commented on pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2638: URL: https://github.com/apache/hbase/pull/2638#issuecomment-724193734 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] esteban commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
esteban commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r520025893 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -215,7 +215,7 @@ public static boolean

[GitHub] [hbase] esteban commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
esteban commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r520024311 ## File path: hbase-protocol-shaded/src/main/protobuf/client/Encryption.proto ## @@ -31,4 +31,5 @@ message WrappedKey { required bytes data = 3;

[jira] [Commented] (HBASE-25254) Rewrite TestMultiLogThreshold to remove the LogDelegate in RSRpcServices

2020-11-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228744#comment-17228744 ] Hudson commented on HBASE-25254: Results for branch branch-2 [build #97 on

[GitHub] [hbase] busbey commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
busbey commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r520006189 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -215,7 +215,7 @@ public static boolean

[jira] [Commented] (HBASE-24667) Rename configs that support atypical DNS set ups to put them in hbase.unsafe

2020-11-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17228745#comment-17228745 ] Hudson commented on HBASE-24667: Results for branch branch-2 [build #97 on

[GitHub] [hbase] symat commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
symat commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r520005148 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -215,7 +215,7 @@ public static boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724172257 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724171427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] esteban commented on a change in pull request #2546: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-11-09 Thread GitBox
esteban commented on a change in pull request #2546: URL: https://github.com/apache/hbase/pull/2546#discussion_r520003482 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java ## @@ -325,4 +327,53 @@ void

[GitHub] [hbase] busbey commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
busbey commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r519996581 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionDisabled.java ## @@ -0,0 +1,110 @@ +/** + * Licensed to the

[GitHub] [hbase] esteban commented on a change in pull request #2546: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-11-09 Thread GitBox
esteban commented on a change in pull request #2546: URL: https://github.com/apache/hbase/pull/2546#discussion_r519998847 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java ## @@ -325,4 +327,53 @@ void

[GitHub] [hbase] esteban commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
esteban commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r519993772 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -229,7 +229,7 @@ public static boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2638: URL: https://github.com/apache/hbase/pull/2638#issuecomment-724162599 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] esteban commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
esteban commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r519993772 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -229,7 +229,7 @@ public static boolean

[GitHub] [hbase] esteban commented on a change in pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-11-09 Thread GitBox
esteban commented on a change in pull request #2539: URL: https://github.com/apache/hbase/pull/2539#discussion_r519993514 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java ## @@ -215,7 +215,7 @@ public static boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-724130015 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-724100483 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724090736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2638: URL: https://github.com/apache/hbase/pull/2638#issuecomment-724081403 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-724058714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724057070 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-724055592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 opened a new pull request #2638: HBASE-25255 Master fails to initialize when creating rs group table

2020-11-09 Thread GitBox
Apache9 opened a new pull request #2638: URL: https://github.com/apache/hbase/pull/2638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (HBASE-25256) Do not use round robin assignment when processing offline regions

2020-11-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25256. --- Resolution: Implemented Finally I found a way to work both for master and branch-2.x and include

[GitHub] [hbase] Apache-HBase commented on pull request #2637: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2637: URL: https://github.com/apache/hbase/pull/2637#issuecomment-724039525 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 opened a new pull request #2637: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to bran…

2020-11-09 Thread GitBox
brfrn169 opened a new pull request #2637: URL: https://github.com/apache/hbase/pull/2637 …ch-1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] brfrn169 closed pull request #2636: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to branch-1

2020-11-09 Thread GitBox
brfrn169 closed pull request #2636: URL: https://github.com/apache/hbase/pull/2636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on pull request #2635: HBASE-25253 Deprecated master carrys regions related methods and configs

2020-11-09 Thread GitBox
Apache9 commented on pull request #2635: URL: https://github.com/apache/hbase/pull/2635#issuecomment-724019341 The plan here is to deprecated them started from 2.4.0, and remove them in 3.0.0. This is a bit aggressive which breaks our compatibility rule, but since it never works well,

[jira] [Resolved] (HBASE-25257) Remove MirroringTableStateManager

2020-11-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25257. --- Hadoop Flags: Reviewed Resolution: Fixed Merged to master. Thanks [~zghao] for reviewing. >

[GitHub] [hbase] Apache9 merged pull request #2634: HBASE-25257 Remove MirroringTableStateManager

2020-11-09 Thread GitBox
Apache9 merged pull request #2634: URL: https://github.com/apache/hbase/pull/2634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2636: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to branch-1

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2636: URL: https://github.com/apache/hbase/pull/2636#issuecomment-724016551 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2636: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to branch-1

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2636: URL: https://github.com/apache/hbase/pull/2636#issuecomment-724012370 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2636: HBASE-25258 Backport HBASE-24776 "[hbtop] Support Batch mode" to branch-1

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2636: URL: https://github.com/apache/hbase/pull/2636#issuecomment-724011443 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 opened a new pull request #2636: HBASE-24776 [hbtop] Support Batch mode

2020-11-09 Thread GitBox
brfrn169 opened a new pull request #2636: URL: https://github.com/apache/hbase/pull/2636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-723986844 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2582: URL: https://github.com/apache/hbase/pull/2582#issuecomment-723986947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2635: HBASE-25253 Deprecated master carrys regions related methods and configs

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2635: URL: https://github.com/apache/hbase/pull/2635#issuecomment-723975297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2582: HBASE-25187 Improve SizeCachedKV variants initialization

2020-11-09 Thread GitBox
ramkrish86 commented on a change in pull request #2582: URL: https://github.com/apache/hbase/pull/2582#discussion_r519709637 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java ## @@ -554,8 +559,10 @@ protected int blockSeek(Cell

[GitHub] [hbase] Apache-HBase commented on pull request #2635: HBASE-25253 Deprecated master carrys regions related methods and configs

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2635: URL: https://github.com/apache/hbase/pull/2635#issuecomment-723911705 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25240) gson format of RpcServer.logResponse is abnormal

2020-11-09 Thread wenfeiyi666 (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 updated HBASE-25240: Description: It will turn ‘=’ into ‘\u003d’. ipc.RpcServer(550): (responseTooSlow):

[GitHub] [hbase] WenFeiYi opened a new pull request #2635: HBASE-25253 Deprecated master carrys regions related methods and configs

2020-11-09 Thread GitBox
WenFeiYi opened a new pull request #2635: URL: https://github.com/apache/hbase/pull/2635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache9 commented on a change in pull request #2627: HBASE-25251 Enable configuration based enable/disable of Unsafe packa…

2020-11-09 Thread GitBox
Apache9 commented on a change in pull request #2627: URL: https://github.com/apache/hbase/pull/2627#discussion_r519660030 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAvailChecker.java ## @@ -33,12 +35,16 @@ private static final Logger LOG =

[GitHub] [hbase] Apache-HBase commented on pull request #2634: HBASE-25257 Remove MirroringTableStateManager

2020-11-09 Thread GitBox
Apache-HBase commented on pull request #2634: URL: https://github.com/apache/hbase/pull/2634#issuecomment-723864177 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

  1   2   >