[GitHub] [hbase] Apache-HBase commented on pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2741: URL: https://github.com/apache/hbase/pull/2741#issuecomment-739466574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2675: URL: https://github.com/apache/hbase/pull/2675#issuecomment-739462570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2741: URL: https://github.com/apache/hbase/pull/2741#issuecomment-739461777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2741: URL: https://github.com/apache/hbase/pull/2741#issuecomment-739452013 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] nyl3532016 commented on pull request #2738: HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit…

2020-12-05 Thread GitBox
nyl3532016 commented on pull request #2738: URL: https://github.com/apache/hbase/pull/2738#issuecomment-739450510 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HBASE-23811) [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty

2020-12-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244636#comment-17244636 ] Duo Zhang commented on HBASE-23811: --- I wonder whether we should do this. The tracing system needs a

[GitHub] [hbase] GeorryHuang opened a new pull request #2741: HBASE-25364 Redo the getMidPoint() in HFileWriterImpl to get rid of t…

2020-12-05 Thread GitBox
GeorryHuang opened a new pull request #2741: URL: https://github.com/apache/hbase/pull/2741 …he double comparison process There is a TODO like this "TODO: Redo so only a single pass over the arrays rather than one to compare and then a second composing midpoint." in

[jira] [Commented] (HBASE-22120) Replace HTrace with OpenTracing

2020-12-05 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244634#comment-17244634 ] Duo Zhang commented on HBASE-22120: --- My concern is that whether the API in OpenTelemetry is stable

[jira] [Updated] (HBASE-25364) Redo the getMidPoint() in HFileWriterImpl to get rid of the double comparison process

2020-12-05 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuoyue Huang updated HBASE-25364: -- Description: There is a TODO like this "TODO: Redo so only a single pass over the arrays

[jira] [Created] (HBASE-25364) Redo the getMidPoint() in HFileWriterImpl to get rid of the double comparison process

2020-12-05 Thread Zhuoyue Huang (Jira)
Zhuoyue Huang created HBASE-25364: - Summary: Redo the getMidPoint() in HFileWriterImpl to get rid of the double comparison process Key: HBASE-25364 URL: https://issues.apache.org/jira/browse/HBASE-25364

[jira] [Commented] (HBASE-25361) [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations

2020-12-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244622#comment-17244622 ] Hudson commented on HBASE-25361: Results for branch branch-2 [build #122 on

[jira] [Commented] (HBASE-25361) [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations

2020-12-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244616#comment-17244616 ] Hudson commented on HBASE-25361: Results for branch branch-2.4 [build #2 on

[GitHub] [hbase] Apache-HBase commented on pull request #2740: Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2740: URL: https://github.com/apache/hbase/pull/2740#issuecomment-739436968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #2740: Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2740: URL: https://github.com/apache/hbase/pull/2740#issuecomment-739435887 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2740: Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2740: URL: https://github.com/apache/hbase/pull/2740#issuecomment-739435801 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2733: URL: https://github.com/apache/hbase/pull/2733#issuecomment-739434495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2733: URL: https://github.com/apache/hbase/pull/2733#issuecomment-739434364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] hsiangawang opened a new pull request #2740: Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage

2020-12-05 Thread GitBox
hsiangawang opened a new pull request #2740: URL: https://github.com/apache/hbase/pull/2740 The test `TestClassFinder#testClassFinderDefaultsToOwnPackage` compares two sets from `allClassesFinder.findClasses`. However, the function `allClassesFinder.findClasses` does not return the

[jira] [Updated] (HBASE-25242) Add Increment/Append support to RowMutations

2020-12-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25242: Release Note: After HBASE-25242, we can add Increment/Append operations to RowMutations and

[jira] [Updated] (HBASE-25361) [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations

2020-12-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-25361: -- Fix Version/s: 2.5.0 > [Flakey Tests] branch-2

[jira] [Commented] (HBASE-25353) [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244592#comment-17244592 ] Michael Stack commented on HBASE-25353: --- Oh, thanks for the helpful review [~huaxiangsun] >

[jira] [Resolved] (HBASE-25353) [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25353. --- Fix Version/s: 2.5.0 2.3.4 Hadoop Flags: Reviewed Resolution:

[GitHub] [hbase] saintstack commented on pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
saintstack commented on pull request #2733: URL: https://github.com/apache/hbase/pull/2733#issuecomment-739424492 Closing. Merged by hand. Thanks for the helpful review @huaxiangsun This is an automated message from the

[jira] [Updated] (HBASE-25242) Add Increment/Append support to RowMutations

2020-12-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25242: Release Note: After HBASE-25242, we can add Increment/Append operations to RowMutations and

[jira] [Updated] (HBASE-25242) Add Increment/Append support to RowMutations

2020-12-05 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-25242: Release Note: After HBASE-25242, we can add Increment/Append operations to RowMutations and

[jira] [Resolved] (HBASE-25361) [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations

2020-12-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25361. --- Resolution: Fixed Re-resovling. Pushed the addendum to 2.3+ (doesn't go to 2.2) > [Flakey

[jira] [Reopened] (HBASE-25361) [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations

2020-12-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-25361: --- Reopen to apply addendum. Test just failed on me. Looking at my PR again, I'm missing reset of

[GitHub] [hbase] Apache-HBase commented on pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2733: URL: https://github.com/apache/hbase/pull/2733#issuecomment-739422519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2733: URL: https://github.com/apache/hbase/pull/2733#issuecomment-739417938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2733: URL: https://github.com/apache/hbase/pull/2733#issuecomment-739389252 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2739: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2739: URL: https://github.com/apache/hbase/pull/2739#issuecomment-739344951 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2739: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2739: URL: https://github.com/apache/hbase/pull/2739#issuecomment-739336473 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-22120) Replace HTrace with OpenTracing

2020-12-05 Thread Yuri (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244558#comment-17244558 ] Yuri commented on HBASE-22120: -- At this point I am comfortable recommending OpenTelemetry for Java instead

[jira] [Commented] (HBASE-25292) Improve InetSocketAddress usage discipline

2020-12-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244555#comment-17244555 ] Hudson commented on HBASE-25292: Results for branch branch-2 [build #121 on

[GitHub] [hbase] Apache-HBase commented on pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2733: URL: https://github.com/apache/hbase/pull/2733#issuecomment-739328239 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2738: HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2738: URL: https://github.com/apache/hbase/pull/2738#issuecomment-739325776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #2733: HBASE-25353 [Flakey Tests] branch-2 TestShutdownBackupMaster

2020-12-05 Thread GitBox
saintstack commented on a change in pull request #2733: URL: https://github.com/apache/hbase/pull/2733#discussion_r536826539 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -627,7 +628,16 @@ public Configuration

[GitHub] [hbase] Apache-HBase commented on pull request #2739: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2739: URL: https://github.com/apache/hbase/pull/2739#issuecomment-739322392 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25361) [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations

2020-12-05 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25361. --- Fix Version/s: 2.4.1 2.3.4 3.0.0-alpha-1 Hadoop

[GitHub] [hbase] saintstack merged pull request #2736: HBASE-25361 [Flakey Tests] branch-2 TestMetaRegionLocationCache.testS…

2020-12-05 Thread GitBox
saintstack merged pull request #2736: URL: https://github.com/apache/hbase/pull/2736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-22120) Replace HTrace with OpenTracing

2020-12-05 Thread ramkrishna.s.vasudevan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244539#comment-17244539 ] ramkrishna.s.vasudevan commented on HBASE-22120: We did a small POC with open telemetry

[GitHub] [hbase] Apache-HBase commented on pull request #2738: HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2738: URL: https://github.com/apache/hbase/pull/2738#issuecomment-739318389 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] cuibo01 opened a new pull request #2739: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2020-12-05 Thread GitBox
cuibo01 opened a new pull request #2739: URL: https://github.com/apache/hbase/pull/2739 …ication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWALs too large (more than 2TB)

[GitHub] [hbase] Apache-HBase commented on pull request #2738: HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit…

2020-12-05 Thread GitBox
Apache-HBase commented on pull request #2738: URL: https://github.com/apache/hbase/pull/2738#issuecomment-739258944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Commented] (HBASE-25322) Redundant Reference file in bottom region of split

2020-12-05 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244501#comment-17244501 ] Xiaolin Ha commented on HBASE-25322: Ping [~zhangduo] [~zghao], could you help to review this PR?

[jira] [Commented] (HBASE-25363) Improve performance of HFileLinkCleaner by using ReadWriteLock instead of synchronize

2020-12-05 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244498#comment-17244498 ] Xiaolin Ha commented on HBASE-25363:  HFileLinkCleaner is a required  cleaner for almost all the

[GitHub] [hbase] sunhelly opened a new pull request #2738: HBASE-25363 Improve performance of HFileLinkCleaner by using ReadWrit…

2020-12-05 Thread GitBox
sunhelly opened a new pull request #2738: URL: https://github.com/apache/hbase/pull/2738 …eLock instead of synchronize This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (HBASE-25363) Improve performance of HFileLinkCleaner by using ReadWriteLock instead of synchronize

2020-12-05 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-25363: -- Summary: Improve performance of HFileLinkCleaner by using ReadWriteLock instead of synchronize Key: HBASE-25363 URL: https://issues.apache.org/jira/browse/HBASE-25363

[jira] [Commented] (HBASE-25354) Update create-release scripts; rotted

2020-12-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244483#comment-17244483 ] Hudson commented on HBASE-25354: Results for branch master [build #149 on

[jira] [Commented] (HBASE-25292) Improve InetSocketAddress usage discipline

2020-12-05 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244473#comment-17244473 ] Hudson commented on HBASE-25292: Results for branch branch-1 [build #64 on