YutSean edited a comment on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878793678
Have changed to a less ugly way to update the metric in the latest commit.
Hope it can pass the UTs.
--
This is an automated message from the Apache Git Service.
To
YutSean commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878793678
Have changed a less ugly way to update the metric in the latest commit. Hope
it can pass the UTs.
--
This is an automated message from the Apache Git Service.
To respond to the
YutSean commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878789492
Added metric update into containsBlock, but it looks ugly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/HBASE-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379592#comment-17379592
]
Hudson commented on HBASE-25973:
Results for branch master
[build #342 on
YutSean removed a comment on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878785277
> > In the master branch, in ComebinedBlockCache getBlock method, it will
check if the block is metablock or not and check it in L1 or L2. This will make
the metric work
YutSean closed pull request #3473:
URL: https://github.com/apache/hbase/pull/3473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
YutSean commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878785277
> > In the master branch, in ComebinedBlockCache getBlock method, it will
check if the block is metablock or not and check it in L1 or L2. This will make
the metric work normal.
anoopsjohn edited a comment on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878772448
>In the master branch, in ComebinedBlockCache getBlock method, it will check
if the block is metablock or not and check it in L1 or L2. This will make the
metric work
anoopsjohn commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878772448
>In the master branch, in ComebinedBlockCache getBlock method, it will check
if the block is metablock or not and check it in L1 or L2. This will make the
metric work normal.
Apache-HBase commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878761479
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m
Apache-HBase commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878758943
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
YutSean commented on a change in pull request #3474:
URL: https://github.com/apache/hbase/pull/3474#discussion_r668398494
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##
@@ -79,7 +79,7 @@ public Cacheable
YutSean commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878746927
In the master branch, in ComebinedBlockCache getBlock method, it will check
if the block is metablock or not and check it in L1 or L2. This will make the
metric work normal.
--
Apache-HBase commented on pull request #3475:
URL: https://github.com/apache/hbase/pull/3475#issuecomment-878741655
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3475:
URL: https://github.com/apache/hbase/pull/3475#issuecomment-878740168
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
rda3mon commented on pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#issuecomment-878731850
@Apache9 Gentle reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Apache-HBase commented on pull request #3475:
URL: https://github.com/apache/hbase/pull/3475#issuecomment-878695629
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#issuecomment-878684561
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#issuecomment-878683303
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#issuecomment-878682359
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
clarax opened a new pull request #3475:
URL: https://github.com/apache/hbase/pull/3475
…backport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#issuecomment-878647304
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
Apache-HBase commented on pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#issuecomment-878644743
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#issuecomment-878634330
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
clarax commented on a change in pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#discussion_r668248743
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/DoubleArrayCost.java
##
@@ -72,31 +72,13 @@ private static double
clarax commented on a change in pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#discussion_r668248743
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/DoubleArrayCost.java
##
@@ -72,31 +72,13 @@ private static double
busbey commented on pull request #3356:
URL: https://github.com/apache/hbase/pull/3356#issuecomment-878491162
thanks for the merge Stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Apache-HBase commented on pull request #3472:
URL: https://github.com/apache/hbase/pull/3472#issuecomment-878128495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
saintstack commented on a change in pull request #3415:
URL: https://github.com/apache/hbase/pull/3415#discussion_r668073537
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java
##
@@ -290,7 +294,9 @@ public String
jojochuang commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878234536
I don't understand this part of code. But I'm curious: does it mean the bug
no longer exist in the master branch?
--
This is an automated message from the Apache Git
Apache-HBase commented on pull request #3473:
URL: https://github.com/apache/hbase/pull/3473#issuecomment-878131806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
saintstack merged pull request #3356:
URL: https://github.com/apache/hbase/pull/3356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HBASE-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379371#comment-17379371
]
Hudson commented on HBASE-25700:
Results for branch master
[build #341 on
jojochuang commented on a change in pull request #3444:
URL: https://github.com/apache/hbase/pull/3444#discussion_r668066189
##
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
##
@@ -1070,7 +1072,13 @@ boolean
clarax commented on a change in pull request #3356:
URL: https://github.com/apache/hbase/pull/3356#discussion_r668099448
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##
@@ -303,54 +303,55 @@ private String
Apache-HBase commented on pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#issuecomment-878137367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on pull request #3444:
URL: https://github.com/apache/hbase/pull/3444#issuecomment-878270562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
saintstack commented on a change in pull request #3356:
URL: https://github.com/apache/hbase/pull/3356#discussion_r668085556
##
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##
@@ -303,54 +303,55 @@ private String
Apache9 commented on a change in pull request #3444:
URL: https://github.com/apache/hbase/pull/3444#discussion_r667967586
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##
@@ -54,7 +51,8 @@
*
Apache9 commented on pull request #3447:
URL: https://github.com/apache/hbase/pull/3447#issuecomment-878319143
> @Apache9 @virajjasani Sorry, I was out for the holiday. I understand that
this is a special region and it does not have a corresponding table/namespace
created for it. We do
anoopsjohn commented on a change in pull request #3474:
URL: https://github.com/apache/hbase/pull/3474#discussion_r668025441
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
##
@@ -79,7 +79,7 @@ public Cacheable
Apache9 commented on pull request #3471:
URL: https://github.com/apache/hbase/pull/3471#issuecomment-878292239
Thanks @nyl3532016 and @pankaj72981 .
Let's wait for one more day to see if there are any other concerns.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/HBASE-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379318#comment-17379318
]
Hudson commented on HBASE-25700:
Results for branch branch-2
[build #297 on
[
https://issues.apache.org/jira/browse/HBASE-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379294#comment-17379294
]
Michael Stack commented on HBASE-25973:
---
I merged the PR to master branch but it does not go back
[
https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379276#comment-17379276
]
Clara Xiong commented on HBASE-25739:
-
Yes. addressed by having both [~ndimiduk]
>
[
https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379222#comment-17379222
]
Anoop Sam John commented on HBASE-26083:
Ah.. !! Good catch
> In branch-2 & branch-1 L1 miss
[
https://issues.apache.org/jira/browse/HBASE-26080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26080:
--
Release Note:
Introduce a new TestingHBaseCluster for end users to start a mini hbase cluster
in
YutSean opened a new pull request #3473:
URL: https://github.com/apache/hbase/pull/3473
https://issues.apache.org/jira/browse/HBASE-26083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
YutSean closed pull request #3472:
URL: https://github.com/apache/hbase/pull/3472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
YutSean opened a new pull request #3472:
URL: https://github.com/apache/hbase/pull/3472
https://issues.apache.org/jira/browse/HBASE-26083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yutong Xiao updated HBASE-26083:
Summary: In branch-2 & branch-1 L1 miss metric is always 0 when using
CombinedBlockCache (was:
Yutong Xiao created HBASE-26083:
---
Summary: When CombinedBlockCache L1 miss metric is always 0
Key: HBASE-26083
URL: https://issues.apache.org/jira/browse/HBASE-26083
Project: HBase
Issue Type:
Apache-HBase commented on pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#issuecomment-878057665
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-23242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378982#comment-17378982
]
andy xie commented on HBASE-23242:
--
Using the latest checkstyle.xml file in master branch
54 matches
Mail list logo