[GitHub] [hbase] YutSean edited a comment on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean edited a comment on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878793678 Have changed to a less ugly way to update the metric in the latest commit. Hope it can pass the UTs. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] YutSean commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878793678 Have changed a less ugly way to update the metric in the latest commit. Hope it can pass the UTs. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] YutSean commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878789492 Added metric update into containsBlock, but it looks ugly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (HBASE-25973) Balancer should explain progress in a better way in log

2021-07-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379592#comment-17379592 ] Hudson commented on HBASE-25973: Results for branch master [build #342 on

[GitHub] [hbase] YutSean removed a comment on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean removed a comment on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878785277 > > In the master branch, in ComebinedBlockCache getBlock method, it will check if the block is metablock or not and check it in L1 or L2. This will make the metric work

[GitHub] [hbase] YutSean closed pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean closed pull request #3473: URL: https://github.com/apache/hbase/pull/3473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] YutSean commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878785277 > > In the master branch, in ComebinedBlockCache getBlock method, it will check if the block is metablock or not and check it in L1 or L2. This will make the metric work normal.

[GitHub] [hbase] anoopsjohn edited a comment on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
anoopsjohn edited a comment on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878772448 >In the master branch, in ComebinedBlockCache getBlock method, it will check if the block is metablock or not and check it in L1 or L2. This will make the metric work

[GitHub] [hbase] anoopsjohn commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
anoopsjohn commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878772448 >In the master branch, in ComebinedBlockCache getBlock method, it will check if the block is metablock or not and check it in L1 or L2. This will make the metric work normal.

[GitHub] [hbase] Apache-HBase commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878761479 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878758943 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] YutSean commented on a change in pull request #3474: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean commented on a change in pull request #3474: URL: https://github.com/apache/hbase/pull/3474#discussion_r668398494 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -79,7 +79,7 @@ public Cacheable

[GitHub] [hbase] YutSean commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878746927 In the master branch, in ComebinedBlockCache getBlock method, it will check if the block is metablock or not and check it in L1 or L2. This will make the metric work normal. --

[GitHub] [hbase] Apache-HBase commented on pull request #3475: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3475: URL: https://github.com/apache/hbase/pull/3475#issuecomment-878741655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3475: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3475: URL: https://github.com/apache/hbase/pull/3475#issuecomment-878740168 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] rda3mon commented on pull request #3359: HBASE-25891 remove dependence storing wal filenames for backup

2021-07-12 Thread GitBox
rda3mon commented on pull request #3359: URL: https://github.com/apache/hbase/pull/3359#issuecomment-878731850 @Apache9 Gentle reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Apache-HBase commented on pull request #3475: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3475: URL: https://github.com/apache/hbase/pull/3475#issuecomment-878695629 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3415: URL: https://github.com/apache/hbase/pull/3415#issuecomment-878684561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3415: URL: https://github.com/apache/hbase/pull/3415#issuecomment-878683303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3415: URL: https://github.com/apache/hbase/pull/3415#issuecomment-878682359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] clarax opened a new pull request #3475: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-12 Thread GitBox
clarax opened a new pull request #3475: URL: https://github.com/apache/hbase/pull/3475 …backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3415: URL: https://github.com/apache/hbase/pull/3415#issuecomment-878647304 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3415: URL: https://github.com/apache/hbase/pull/3415#issuecomment-878644743 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3415: URL: https://github.com/apache/hbase/pull/3415#issuecomment-878634330 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] clarax commented on a change in pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
clarax commented on a change in pull request #3415: URL: https://github.com/apache/hbase/pull/3415#discussion_r668248743 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/DoubleArrayCost.java ## @@ -72,31 +72,13 @@ private static double

[GitHub] [hbase] clarax commented on a change in pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
clarax commented on a change in pull request #3415: URL: https://github.com/apache/hbase/pull/3415#discussion_r668248743 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/DoubleArrayCost.java ## @@ -72,31 +72,13 @@ private static double

[GitHub] [hbase] busbey commented on pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-07-12 Thread GitBox
busbey commented on pull request #3356: URL: https://github.com/apache/hbase/pull/3356#issuecomment-878491162 thanks for the merge Stack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] Apache-HBase commented on pull request #3472: In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3472: URL: https://github.com/apache/hbase/pull/3472#issuecomment-878128495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] saintstack commented on a change in pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread GitBox
saintstack commented on a change in pull request #3415: URL: https://github.com/apache/hbase/pull/3415#discussion_r668073537 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java ## @@ -290,7 +294,9 @@ public String

[GitHub] [hbase] jojochuang commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
jojochuang commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878234536 I don't understand this part of code. But I'm curious: does it mean the bug no longer exist in the master branch? -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878131806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] saintstack merged pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-07-12 Thread GitBox
saintstack merged pull request #3356: URL: https://github.com/apache/hbase/pull/3356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-25700) Enhance znode parent validation when add_peer

2021-07-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379371#comment-17379371 ] Hudson commented on HBASE-25700: Results for branch master [build #341 on

[GitHub] [hbase] jojochuang commented on a change in pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-12 Thread GitBox
jojochuang commented on a change in pull request #3444: URL: https://github.com/apache/hbase/pull/3444#discussion_r668066189 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java ## @@ -1070,7 +1072,13 @@ boolean

[GitHub] [hbase] clarax commented on a change in pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-07-12 Thread GitBox
clarax commented on a change in pull request #3356: URL: https://github.com/apache/hbase/pull/3356#discussion_r668099448 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -303,54 +303,55 @@ private String

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-878137367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3444: URL: https://github.com/apache/hbase/pull/3444#issuecomment-878270562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] saintstack commented on a change in pull request #3356: HBASE-25973 Balancer should explain progress in a better way in log

2021-07-12 Thread GitBox
saintstack commented on a change in pull request #3356: URL: https://github.com/apache/hbase/pull/3356#discussion_r668085556 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -303,54 +303,55 @@ private String

[GitHub] [hbase] Apache9 commented on a change in pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-12 Thread GitBox
Apache9 commented on a change in pull request #3444: URL: https://github.com/apache/hbase/pull/3444#discussion_r667967586 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java ## @@ -54,7 +51,8 @@ *

[GitHub] [hbase] Apache9 commented on pull request #3447: HBASE-26055 Master local region "table" should be considered a system…

2021-07-12 Thread GitBox
Apache9 commented on pull request #3447: URL: https://github.com/apache/hbase/pull/3447#issuecomment-878319143 > @Apache9 @virajjasani Sorry, I was out for the holiday. I understand that this is a special region and it does not have a corresponding table/namespace created for it. We do

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3474: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
anoopsjohn commented on a change in pull request #3474: URL: https://github.com/apache/hbase/pull/3474#discussion_r668025441 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -79,7 +79,7 @@ public Cacheable

[GitHub] [hbase] Apache9 commented on pull request #3471: HBASE-26082 Mark LocalHBaseCluster as IA.Private

2021-07-12 Thread GitBox
Apache9 commented on pull request #3471: URL: https://github.com/apache/hbase/pull/3471#issuecomment-878292239 Thanks @nyl3532016 and @pankaj72981 . Let's wait for one more day to see if there are any other concerns. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-25700) Enhance znode parent validation when add_peer

2021-07-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379318#comment-17379318 ] Hudson commented on HBASE-25700: Results for branch branch-2 [build #297 on

[jira] [Commented] (HBASE-25973) Balancer should explain progress in a better way in log

2021-07-12 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379294#comment-17379294 ] Michael Stack commented on HBASE-25973: --- I merged the PR to master branch but it does not go back

[jira] [Commented] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation

2021-07-12 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379276#comment-17379276 ] Clara Xiong commented on HBASE-25739: - Yes. addressed by having both [~ndimiduk] >

[jira] [Commented] (HBASE-26083) In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379222#comment-17379222 ] Anoop Sam John commented on HBASE-26083: Ah.. !! Good catch > In branch-2 & branch-1 L1 miss

[jira] [Updated] (HBASE-26080) Implement a new mini cluster class for end users

2021-07-12 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26080: -- Release Note: Introduce a new TestingHBaseCluster for end users to start a mini hbase cluster in

[GitHub] [hbase] YutSean opened a new pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean opened a new pull request #3473: URL: https://github.com/apache/hbase/pull/3473 https://issues.apache.org/jira/browse/HBASE-26083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] YutSean closed pull request #3472: In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean closed pull request #3472: URL: https://github.com/apache/hbase/pull/3472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] YutSean opened a new pull request #3472: In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread GitBox
YutSean opened a new pull request #3472: URL: https://github.com/apache/hbase/pull/3472 https://issues.apache.org/jira/browse/HBASE-26083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (HBASE-26083) In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-12 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26083: Summary: In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache (was:

[jira] [Created] (HBASE-26083) When CombinedBlockCache L1 miss metric is always 0

2021-07-12 Thread Yutong Xiao (Jira)
Yutong Xiao created HBASE-26083: --- Summary: When CombinedBlockCache L1 miss metric is always 0 Key: HBASE-26083 URL: https://issues.apache.org/jira/browse/HBASE-26083 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

2021-07-12 Thread GitBox
Apache-HBase commented on pull request #3372: URL: https://github.com/apache/hbase/pull/3372#issuecomment-878057665 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-23242) Check style incorrectly formatted - Intellij complains

2021-07-12 Thread andy xie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378982#comment-17378982 ] andy xie commented on HBASE-23242: -- Using the latest checkstyle.xml file in master branch