[GitHub] [hbase] Apache-HBase commented on pull request #3481: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3481: URL: https://github.com/apache/hbase/pull/3481#issuecomment-879614438 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-879607973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #3482: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3482: URL: https://github.com/apache/hbase/pull/3482#issuecomment-879603973 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25700) Enhance znode parent validation when add_peer

2021-07-13 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-25700: - Fix Version/s: 2.5.0 3.0.0-alpha-1 > Enhance znode parent validation when

[GitHub] [hbase] sunhelly opened a new pull request #3486: HBASE-26036 DBB released too early in HRegion.get() and dirty data fo…

2021-07-13 Thread GitBox
sunhelly opened a new pull request #3486: URL: https://github.com/apache/hbase/pull/3486 …r some operations (#3436) Signed-off-by: Michael Stack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache9 commented on a change in pull request #3444: HBASE-26049 Remove DfsBuilderUtility

2021-07-13 Thread GitBox
Apache9 commented on a change in pull request #3444: URL: https://github.com/apache/hbase/pull/3444#discussion_r669294478 ## File path: hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java ## @@ -1070,7 +1072,13 @@ boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-879588256 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] YutSean commented on a change in pull request #3474: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
YutSean commented on a change in pull request #3474: URL: https://github.com/apache/hbase/pull/3474#discussion_r669275641 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -79,7 +79,13 @@ public Cacheable

[GitHub] [hbase] Apache-HBase commented on pull request #3482: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3482: URL: https://github.com/apache/hbase/pull/3482#issuecomment-879577262 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-879567136 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Reidddddd commented on a change in pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
Reidd commented on a change in pull request #3473: URL: https://github.com/apache/hbase/pull/3473#discussion_r669262896 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -78,7 +78,13 @@ public Cacheable

[GitHub] [hbase] Reidddddd commented on a change in pull request #3474: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
Reidd commented on a change in pull request #3474: URL: https://github.com/apache/hbase/pull/3474#discussion_r669262526 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -79,7 +79,13 @@ public Cacheable

[jira] [Updated] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-13 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26083: Affects Version/s: (was: 2.4.4) (was: 1.7.0) > L1 miss metric is

[jira] [Updated] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-13 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26083: Component/s: BlockCache > L1 miss metric is incorrect when using CombinedBlockCache >

[jira] [Updated] (HBASE-26083) L1 miss metric is incorrect when using CombinedBlockCache

2021-07-13 Thread Yutong Xiao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yutong Xiao updated HBASE-26083: Summary: L1 miss metric is incorrect when using CombinedBlockCache (was: In branch-2 & branch-1

[jira] [Commented] (HBASE-26086) TestHRegionReplayEvents do not pass in branch-2 and throws NullPointerException

2021-07-13 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380284#comment-17380284 ] Lijin Bin commented on HBASE-26086: --- merge to branch-2. can not access to

[GitHub] [hbase] binlijin commented on pull request #3480: HBASE-26086 TestHRegionReplayEvents do not pass in branch-2 and throw…

2021-07-13 Thread GitBox
binlijin commented on pull request #3480: URL: https://github.com/apache/hbase/pull/3480#issuecomment-879561923 Thanks all for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] YutSean commented on a change in pull request #3474: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
YutSean commented on a change in pull request #3474: URL: https://github.com/apache/hbase/pull/3474#discussion_r669257177 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -79,7 +79,7 @@ public Cacheable

[GitHub] [hbase] binlijin merged pull request #3480: HBASE-26086 TestHRegionReplayEvents do not pass in branch-2 and throw…

2021-07-13 Thread GitBox
binlijin merged pull request #3480: URL: https://github.com/apache/hbase/pull/3480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] sunhelly merged pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
sunhelly merged pull request #3436: URL: https://github.com/apache/hbase/pull/3436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] sunhelly commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
sunhelly commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-879556099 The failed UT is not related to this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Reidddddd commented on pull request #3480: HBASE-26086 TestHRegionReplayEvents do not pass in branch-2 and throw…

2021-07-13 Thread GitBox
Reidd commented on pull request #3480: URL: https://github.com/apache/hbase/pull/3480#issuecomment-879549981 > Oh this was fixed in master only? I thought its fixed in branch-2 as well. +1 there was oversight in that branch-2 pr, missed this null check. -- This is an

[GitHub] [hbase] YutSean commented on a change in pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
YutSean commented on a change in pull request #3473: URL: https://github.com/apache/hbase/pull/3473#discussion_r669247097 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -78,7 +78,13 @@ public Cacheable

[GitHub] [hbase] YutSean commented on a change in pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
YutSean commented on a change in pull request #3473: URL: https://github.com/apache/hbase/pull/3473#discussion_r669238774 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -78,7 +78,13 @@ public Cacheable

[GitHub] [hbase] Reidddddd commented on a change in pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
Reidd commented on a change in pull request #3473: URL: https://github.com/apache/hbase/pull/3473#discussion_r669233258 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java ## @@ -78,7 +78,13 @@ public Cacheable

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-879533197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-879503801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-879502496 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3482: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3482: URL: https://github.com/apache/hbase/pull/3482#issuecomment-879498506 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-879490913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3485: URL: https://github.com/apache/hbase/pull/3485#issuecomment-879489922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-879485354 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3483: URL: https://github.com/apache/hbase/pull/3483#issuecomment-879471951 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3481: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3481: URL: https://github.com/apache/hbase/pull/3481#issuecomment-879458004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3484: URL: https://github.com/apache/hbase/pull/3484#issuecomment-879432107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] clarax opened a new pull request #3485: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
clarax opened a new pull request #3485: URL: https://github.com/apache/hbase/pull/3485 … backport branch-2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache-HBase commented on pull request #3482: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3482: URL: https://github.com/apache/hbase/pull/3482#issuecomment-879419230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3481: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3481: URL: https://github.com/apache/hbase/pull/3481#issuecomment-879413680 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] clarax opened a new pull request #3484: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
clarax opened a new pull request #3484: URL: https://github.com/apache/hbase/pull/3484 … backport branch-2.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] clarax opened a new pull request #3483: HBASE-25973 Balancer should explain progress in a better way in log -…

2021-07-13 Thread GitBox
clarax opened a new pull request #3483: URL: https://github.com/apache/hbase/pull/3483 … backport branch-2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-879354884 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3482: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3482: URL: https://github.com/apache/hbase/pull/3482#issuecomment-879349276 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26080) Implement a new mini cluster class for end users

2021-07-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380124#comment-17380124 ] Hudson commented on HBASE-26080: Results for branch branch-2 [build #299 on

[GitHub] [hbase] clarax opened a new pull request #3482: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
clarax opened a new pull request #3482: URL: https://github.com/apache/hbase/pull/3482 …backport 2.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] clarax opened a new pull request #3481: HBASE-25739 TableSkewCostFunction need to use aggregated deviation - …

2021-07-13 Thread GitBox
clarax opened a new pull request #3481: URL: https://github.com/apache/hbase/pull/3481 …backport 2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hbase] Apache-HBase commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-879268699 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] anoopsjohn commented on pull request #3480: HBASE-26086 TestHRegionReplayEvents do not pass in branch-2 and throw…

2021-07-13 Thread GitBox
anoopsjohn commented on pull request #3480: URL: https://github.com/apache/hbase/pull/3480#issuecomment-879256365 Oh this was fixed in master only? I thought its fixed in branch-2 as well. +1 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] saintstack commented on a change in pull request #3407: HBASE-26018 Perf improvement in L1 cache - Optimistic call to buffer.retain()

2021-07-13 Thread GitBox
saintstack commented on a change in pull request #3407: URL: https://github.com/apache/hbase/pull/3407#discussion_r668917910 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -646,14 +639,16 @@ private long

[GitHub] [hbase] Apache-HBase commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-879222314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-879220505 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3460: HBASE-26064 Introduce a StoreFileTracker to abstract the stor…

2021-07-13 Thread GitBox
Apache9 commented on pull request #3460: URL: https://github.com/apache/hbase/pull/3460#issuecomment-879196037 Moved StoreFileTracker to StoreEngine, per @z-york and @saintstack 's suggestion on the design doc. And the root reason is I found that there is already a DateTieredStoreEngine,

[GitHub] [hbase] Apache-HBase commented on pull request #3480: HBASE-26086 TestHRegionReplayEvents do not pass in branch-2 and throw…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3480: URL: https://github.com/apache/hbase/pull/3480#issuecomment-879189437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25739) TableSkewCostFunction need to use aggregated deviation

2021-07-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379967#comment-17379967 ] Michael Stack commented on HBASE-25739: --- Merged to master. Want to make PRs for branch-2

[GitHub] [hbase] saintstack commented on pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-13 Thread GitBox
saintstack commented on pull request #3415: URL: https://github.com/apache/hbase/pull/3415#issuecomment-879184162 Merged. All unit tests passed. The complaint was from cleanup post-build messaging H2 machine. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] saintstack merged pull request #3415: HBASE-25739 TableSkewCostFunction need to use aggregated deviation

2021-07-13 Thread GitBox
saintstack merged pull request #3415: URL: https://github.com/apache/hbase/pull/3415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3479: HBASE-26085 Support MOB when do compaction offload

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3479: URL: https://github.com/apache/hbase/pull/3479#issuecomment-879162767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-879111252 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-879094845 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3480: HBASE-26086 TestHRegionReplayEvents do not pass in branch-2 and throw…

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3480: URL: https://github.com/apache/hbase/pull/3480#issuecomment-879084941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-879083146 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3479: HBASE-26085 Support MOB when do compaction offload

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3479: URL: https://github.com/apache/hbase/pull/3479#issuecomment-879052154 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] binlijin opened a new pull request #3480: HBASE-26086 TestHRegionReplayEvents do not pass in branch-2 and throw…

2021-07-13 Thread GitBox
binlijin opened a new pull request #3480: URL: https://github.com/apache/hbase/pull/3480 …s NullPointerException -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3477: HBASE-26084 Add owner of replication queue for ReplicationQueueInfo

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3477: URL: https://github.com/apache/hbase/pull/3477#issuecomment-879046366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-879044656 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3477: HBASE-26084 Add owner of replication queue for ReplicationQueueInfo

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3477: URL: https://github.com/apache/hbase/pull/3477#issuecomment-879042502 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-26086) TestHRegionReplayEvents do not pass in branch-2 and throws NullPointerException

2021-07-13 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin reassigned HBASE-26086: - Fix Version/s: 2.4.5 Affects Version/s: 2.4.4 Assignee: Lijin Bin >

[jira] [Updated] (HBASE-26086) TestHRegionReplayEvents do not pass in branch-2 and throws NullPointerException

2021-07-13 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-26086: -- Description: HBASE-26013 the patch checked in in branch-2 is different with master. There is no

[jira] [Created] (HBASE-26086) TestHRegionReplayEvents do not pass in branch-2 and throws NullPointerException

2021-07-13 Thread Lijin Bin (Jira)
Lijin Bin created HBASE-26086: - Summary: TestHRegionReplayEvents do not pass in branch-2 and throws NullPointerException Key: HBASE-26086 URL: https://issues.apache.org/jira/browse/HBASE-26086 Project:

[jira] [Commented] (HBASE-26013) Get operations readRows metrics becomes zero after HBASE-25677

2021-07-13 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379851#comment-17379851 ] Lijin Bin commented on HBASE-26013: --- The patch for branch-2 is different with master. > Get

[GitHub] [hbase] nyl3532016 opened a new pull request #3479: HBASE-26085 Support MOB when do compaction offload

2021-07-13 Thread GitBox
nyl3532016 opened a new pull request #3479: URL: https://github.com/apache/hbase/pull/3479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-879012429 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-26085) Support MOB when do compaction offload

2021-07-13 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-26085: - Summary: Support MOB when do compaction offload Key: HBASE-26085 URL: https://issues.apache.org/jira/browse/HBASE-26085 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache9 commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-13 Thread GitBox
Apache9 commented on pull request #3478: URL: https://github.com/apache/hbase/pull/3478#issuecomment-879004187 This is a very big change. The classes in the new package, org.apache.hadoop.hbase.testing, are all the classes we want to hide from end users, including HBTU and its

[GitHub] [hbase] Apache9 opened a new pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

2021-07-13 Thread GitBox
Apache9 opened a new pull request #3478: URL: https://github.com/apache/hbase/pull/3478 …classes in hbase-server and mark them as IA.LimitedPrivate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (HBASE-26081) Copy HBTU to hbase-testing-util, rename the HBTU related classes in hbase-server and mark them as IA.LimitedPrivate

2021-07-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26081: -- Summary: Copy HBTU to hbase-testing-util, rename the HBTU related classes in hbase-server and mark

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-878977481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3476: HBASE-25986 set default value of normalization enabled from hbase site

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3476: URL: https://github.com/apache/hbase/pull/3476#issuecomment-878972739 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3476: HBASE-25986 set default value of normalization enabled from hbase site

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3476: URL: https://github.com/apache/hbase/pull/3476#issuecomment-878972924 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-878972097 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3477: HBASE-26084 Add owner of replication queue for ReplicationQueueInfo

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3477: URL: https://github.com/apache/hbase/pull/3477#issuecomment-878955003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878924849 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ddupg closed pull request #3010: HBASE-25110 Add heartbeat for ReplicationServer and dispatch replicat…

2021-07-13 Thread GitBox
ddupg closed pull request #3010: URL: https://github.com/apache/hbase/pull/3010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ddupg commented on pull request #3010: HBASE-25110 Add heartbeat for ReplicationServer and dispatch replicat…

2021-07-13 Thread GitBox
ddupg commented on pull request #3010: URL: https://github.com/apache/hbase/pull/3010#issuecomment-878923798 Too many code changes in this issue, so close this PR and divide this issue into multiple to complete. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] ddupg opened a new pull request #3477: HBASE-26084 Add owner of replication queue for ReplicationQueueInfo

2021-07-13 Thread GitBox
ddupg opened a new pull request #3477: URL: https://github.com/apache/hbase/pull/3477 The current `ReplicationQueueInfo` only has `queueId`, which is not enough to distinguish queues in ReplicationServer, so we need to add the RS holding the queue for `ReplicationQueueInfo`. -- This

[jira] [Created] (HBASE-26084) Add owner of replication queue for ReplicationQueueInfo

2021-07-13 Thread Sun Xin (Jira)
Sun Xin created HBASE-26084: --- Summary: Add owner of replication queue for ReplicationQueueInfo Key: HBASE-26084 URL: https://issues.apache.org/jira/browse/HBASE-26084 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-878886246 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3476: HBASE-25986 set default value of normalization enabled from hbase site

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3476: URL: https://github.com/apache/hbase/pull/3476#issuecomment-878882827 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3473: HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache

2021-07-13 Thread GitBox
Apache-HBase commented on pull request #3473: URL: https://github.com/apache/hbase/pull/3473#issuecomment-878870688 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-26082) Mark LocalHBaseCluster as IA.Private

2021-07-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26082. --- Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change) Release Note:

[GitHub] [hbase] mnpoonia opened a new pull request #3476: HBASE-25986 set default value of normalization enabled from hbase site

2021-07-13 Thread GitBox
mnpoonia opened a new pull request #3476: URL: https://github.com/apache/hbase/pull/3476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] sunhelly commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

2021-07-13 Thread GitBox
sunhelly commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r668504310 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -7541,6 +7554,9 @@ void prepareGet(final Get get) throws

[jira] [Resolved] (HBASE-26080) Implement a new mini cluster class for end users

2021-07-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26080. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~niuyulin]

[GitHub] [hbase] Apache9 merged pull request #3471: HBASE-26082 Mark LocalHBaseCluster as IA.Private

2021-07-13 Thread GitBox
Apache9 merged pull request #3471: URL: https://github.com/apache/hbase/pull/3471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 merged pull request #3470: HBASE-26080 Implement a new mini cluster class for end users

2021-07-13 Thread GitBox
Apache9 merged pull request #3470: URL: https://github.com/apache/hbase/pull/3470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: