[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901615227 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901612275 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-901609610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33

[GitHub] [hbase] jojochuang commented on a change in pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
jojochuang commented on a change in pull request #3596: URL: https://github.com/apache/hbase/pull/3596#discussion_r691768859 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java ## @@ -163,22 +168,57 @@ private StoreFileInfo(final Co

[jira] [Commented] (HBASE-23584) Decrease rpc getFileStatus count when open a storefile (cache filestatus in storefileinfo rather than load each time)

2021-08-18 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401448#comment-17401448 ] Anoop Sam John commented on HBASE-23584: I came across such a need recently. Th

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901578100 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35

[jira] [Commented] (HBASE-26087) JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401439#comment-17401439 ] Hudson commented on HBASE-26087: Results for branch branch-2.4 [build #183 on b

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901529963 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901526010 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901525231 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s

[jira] [Created] (HBASE-26207) config hbase.regions.slop is used for stochastic load balancer.

2021-08-18 Thread Clara Xiong (Jira)
Clara Xiong created HBASE-26207: --- Summary: config hbase.regions.slop is used for stochastic load balancer. Key: HBASE-26207 URL: https://issues.apache.org/jira/browse/HBASE-26207 Project: HBase

[GitHub] [hbase-native-client] Apache-HBase commented on pull request #14: HBASE-23105: Download lib double conversion, fizz, update folly

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #14: URL: https://github.com/apache/hbase-native-client/pull/14#issuecomment-901495420 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 305 |

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-901494938 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-901492361 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37

[GitHub] [hbase-native-client] Apache-HBase commented on pull request #14: HBASE-23105: Download lib double conversion, fizz, update folly

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #14: URL: https://github.com/apache/hbase-native-client/pull/14#issuecomment-901482700 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-h

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901427001 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-901422726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901419935 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901419003 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901399705 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901387879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-901373398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-901366882 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35

[jira] [Commented] (HBASE-26187) Write straight into the store directory when Splitting and Merging

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401297#comment-17401297 ] Hudson commented on HBASE-26187: Results for branch branch-2 [build #326 on bui

[jira] [Commented] (HBASE-26193) Do not store meta region location as permanent state on zookeeper

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401295#comment-17401295 ] Hudson commented on HBASE-26193: Results for branch branch-2 [build #326 on bui

[jira] [Commented] (HBASE-26087) JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401296#comment-17401296 ] Hudson commented on HBASE-26087: Results for branch branch-2 [build #326 on bui

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-901321341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 47

[jira] [Commented] (HBASE-26087) JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401272#comment-17401272 ] Hudson commented on HBASE-26087: Results for branch branch-2.3 [build #278 on b

[jira] [Resolved] (HBASE-24337) Backport HBASE-23968 to branch-2

2021-08-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24337. --- Fix Version/s: 2.5.0 Hadoop Flags: Reviewed Resolution: Fixed Backported to bran

[GitHub] [hbase] saintstack closed pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-18 Thread GitBox
saintstack closed pull request #1670: URL: https://github.com/apache/hbase/pull/1670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] saintstack commented on pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-18 Thread GitBox
saintstack commented on pull request #1670: URL: https://github.com/apache/hbase/pull/1670#issuecomment-901291882 Really close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [hbase] saintstack commented on pull request #1670: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-18 Thread GitBox
saintstack commented on pull request #1670: URL: https://github.com/apache/hbase/pull/1670#issuecomment-901291791 Closing. HBASE-24337 #3588 was merged to branch-2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] saintstack merged pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-18 Thread GitBox
saintstack merged pull request #3588: URL: https://github.com/apache/hbase/pull/3588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-901272101 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40

[GitHub] [hbase] Apache-HBase commented on pull request #3592: HBASE-26205 Use specified cluster conf for UserProvider in TableMRUtil#initCredentialsForCluster

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3592: URL: https://github.com/apache/hbase/pull/3592#issuecomment-901106209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] wchevreuil commented on pull request #3598: Amend HBASE-26187 UTs, adding a check for Split procedure completion …

2021-08-18 Thread GitBox
wchevreuil commented on pull request #3598: URL: https://github.com/apache/hbase/pull/3598#issuecomment-901113325 The failed tests are passing, locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #3572: HBASE-26184 TestTableSnapshotScanner.testMergeRegion error message is…

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3572: URL: https://github.com/apache/hbase/pull/3572#issuecomment-901029809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] Apache-HBase commented on pull request #3590: HBASE-26186 jenkins script for caching artifacts should verify cached file before relying on it.

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3590: URL: https://github.com/apache/hbase/pull/3590#issuecomment-900609198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] saintstack edited a comment on pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread GitBox
saintstack edited a comment on pull request #3489: URL: https://github.com/apache/hbase/pull/3489#issuecomment-901174072 Where is the spotbugs fix @sunhelly ? Do it in a new PR? ^^ NVM, I see it now. Thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] saintstack closed pull request #1370: HBASE-24053 Correct some errors to make it available in hbase2

2021-08-18 Thread GitBox
saintstack closed pull request #1370: URL: https://github.com/apache/hbase/pull/1370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] Apache-HBase commented on pull request #3595: HBASE-26187 Write straight into the store directory when Splitting an…

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3595: URL: https://github.com/apache/hbase/pull/3595#issuecomment-900625283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #72: [HBASE-25357] allow specifying binary row key range to pre-split regions

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #72: URL: https://github.com/apache/hbase-connectors/pull/72#issuecomment-901053011 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] bitterfox commented on pull request #3592: HBASE-26205 Use specified cluster conf for UserProvider in TableMRUtil#initCredentialsForCluster

2021-08-18 Thread GitBox
bitterfox commented on pull request #3592: URL: https://github.com/apache/hbase/pull/3592#issuecomment-901081687 Thanks for the comment. Added test case that this PR want to fix. Confirmed that testInitCredentialsForCluster3 and testInitCredentialsForCluster4 will be failed without this

[GitHub] [hbase] Apache9 commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry

2021-08-18 Thread GitBox
Apache9 commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-900828430 @bharathv I've removed the configuration. Will only return region servers in getBootstrapNodes now. Thanks. -- This is an automated message from the Apache Git Service. T

[GitHub] [hbase] shahrs87 commented on a change in pull request #3592: HBASE-26205 Use specified cluster conf for UserProvider in TableMRUtil#initCredentialsForCluster

2021-08-18 Thread GitBox
shahrs87 commented on a change in pull request #3592: URL: https://github.com/apache/hbase/pull/3592#discussion_r691218394 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceUtil.java ## @@ -104,4 +130,147 @@ public void testInitTab

[GitHub] [hbase] Apache-HBase commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-900808356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] sunhelly merged pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread GitBox
sunhelly merged pull request #3489: URL: https://github.com/apache/hbase/pull/3489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [hbase] saintstack commented on pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread GitBox
saintstack commented on pull request #3489: URL: https://github.com/apache/hbase/pull/3489#issuecomment-900814853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [hbase] saintstack commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile

2021-08-18 Thread GitBox
saintstack commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-900807919 Closing. Replacing w/ refresh #3596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack closed pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile

2021-08-18 Thread GitBox
saintstack closed pull request #1380: URL: https://github.com/apache/hbase/pull/1380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] taklwu merged pull request #3594: HBASE-26130 Backport HBASE-25455 "Add trace support for HRegion read/…

2021-08-18 Thread GitBox
taklwu merged pull request #3594: URL: https://github.com/apache/hbase/pull/3594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [hbase] sunhelly commented on pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread GitBox
sunhelly commented on pull request #3489: URL: https://github.com/apache/hbase/pull/3489#issuecomment-900877357 Sorry for finding the spotbugs after merged to master. I have added an addendum to master, and branch2.3+ are with the fixed patch. -- This is an automated message from the Apa

[GitHub] [hbase] bitterfox edited a comment on pull request #3592: HBASE-26205 Use specified cluster conf for UserProvider in TableMRUtil#initCredentialsForCluster

2021-08-18 Thread GitBox
bitterfox edited a comment on pull request #3592: URL: https://github.com/apache/hbase/pull/3592#issuecomment-901081687 Thanks for the comment. Added test cases that this PR want to fix. Confirmed that testInitCredentialsForCluster3 and testInitCredentialsForCluster4 will be failed witho

[GitHub] [hbase] Apache-HBase commented on pull request #3588: HBASE-24337 Backport HBASE-23968 to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3588: URL: https://github.com/apache/hbase/pull/3588#issuecomment-900824080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] shahrs87 commented on a change in pull request #3591: HBASE-26204 Obtain credential for VerifyReplication with peerQuorumAddress

2021-08-18 Thread GitBox
shahrs87 commented on a change in pull request #3591: URL: https://github.com/apache/hbase/pull/3591#discussion_r691241668 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java ## @@ -736,6 +740,40 @@ private static vo

[GitHub] [hbase] saintstack commented on pull request #1370: HBASE-24053 Correct some errors to make it available in hbase2

2021-08-18 Thread GitBox
saintstack commented on pull request #1370: URL: https://github.com/apache/hbase/pull/1370#issuecomment-900793298 PR fails w/ the below -- maybe new? `NoMethodError: undefined method `allTableRegions' for Java::OrgApacheHadoopHbase::MetaTableAccessor:Class Did you mean? getAllReg

[GitHub] [hbase] Apache-HBase commented on pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3489: URL: https://github.com/apache/hbase/pull/3489#issuecomment-900832156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] Apache-HBase commented on pull request #3566: HBASE-26172 Deprecated MasterRegistry

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3566: URL: https://github.com/apache/hbase/pull/3566#issuecomment-900814995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] saintstack commented on pull request #1231: HBASE-23917 [SimpleRpcServer] Subsequent requests will have no response in case of request IO mess up

2021-08-18 Thread GitBox
saintstack commented on pull request #1231: URL: https://github.com/apache/hbase/pull/1231#issuecomment-900811287 Closing. Most of patch is for code not used anymore (though a nice refactoring). -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hbase] jojochuang commented on a change in pull request #3562: HBASE-26169 Fix MapReduceBackupCopyJob.BackupDistCp.getKey() concatenates strings

2021-08-18 Thread GitBox
jojochuang commented on a change in pull request #3562: URL: https://github.com/apache/hbase/pull/3562#discussion_r691085220 ## File path: hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java ## @@ -331,12 +331,12 @@ protected Path cr

[GitHub] [hbase] Apache-HBase commented on pull request #3594: HBASE-26130 Backport HBASE-25455 "Add trace support for HRegion read/…

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3594: URL: https://github.com/apache/hbase/pull/3594#issuecomment-900531461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] Apache-HBase commented on pull request #3598: Amend HBASE-26187 UTs, adding a check for Split procedure completion …

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3598: URL: https://github.com/apache/hbase/pull/3598#issuecomment-901020396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] bitterfox commented on pull request #3591: HBASE-26204 Obtain credential for VerifyReplication with peerQuorumAddress

2021-08-18 Thread GitBox
bitterfox commented on pull request #3591: URL: https://github.com/apache/hbase/pull/3591#issuecomment-900802340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [hbase] Apache-HBase commented on pull request #3597: HBASE-26131 Backport HBASE-25484 "Add trace support for WAL sync" to branch-2

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3597: URL: https://github.com/apache/hbase/pull/3597#issuecomment-900856196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] wchevreuil merged pull request #3595: HBASE-26187 Write straight into the store directory when Splitting an…

2021-08-18 Thread GitBox
wchevreuil merged pull request #3595: URL: https://github.com/apache/hbase/pull/3595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] wchevreuil merged pull request #3598: Amend HBASE-26187 UTs, adding a check for Split procedure completion …

2021-08-18 Thread GitBox
wchevreuil merged pull request #3598: URL: https://github.com/apache/hbase/pull/3598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] caroliney14 commented on pull request #3581: HBASE-25849 Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to bra

2021-08-18 Thread GitBox
caroliney14 commented on pull request #3581: URL: https://github.com/apache/hbase/pull/3581#issuecomment-900482370 thanks @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [hbase] busbey commented on pull request #3590: HBASE-26186 jenkins script for caching artifacts should verify cached file before relying on it.

2021-08-18 Thread GitBox
busbey commented on pull request #3590: URL: https://github.com/apache/hbase/pull/3590#issuecomment-900607490 the failure was caused by one of the jenkins workers falling over with a read only filesystem. I'll go restart it. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HBASE-26206) Add UT for masterless mode

2021-08-18 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401194#comment-17401194 ] Michael Stack commented on HBASE-26206: --- {quote}[~stack] Could you please provide

[GitHub] [hbase] wchevreuil commented on a change in pull request #3598: Amend HBASE-26187 UTs, adding a check for Split procedure completion …

2021-08-18 Thread GitBox
wchevreuil commented on a change in pull request #3598: URL: https://github.com/apache/hbase/pull/3598#discussion_r691103851 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDirectStoreSplitsMerges.java ## @@ -202,6 +207,22 @@ public void testC

[GitHub] [hbase] taklwu commented on pull request #3594: HBASE-26130 Backport HBASE-25455 "Add trace support for HRegion read/…

2021-08-18 Thread GitBox
taklwu commented on pull request #3594: URL: https://github.com/apache/hbase/pull/3594#issuecomment-900825272 thanks for reviewing it @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-900824988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hbase] saintstack closed pull request #1231: HBASE-23917 [SimpleRpcServer] Subsequent requests will have no response in case of request IO mess up

2021-08-18 Thread GitBox
saintstack closed pull request #1231: URL: https://github.com/apache/hbase/pull/1231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] taklwu merged pull request #3589: HBASE-26129 Backport HBASE-25481 "Add host and port attribute when tr…

2021-08-18 Thread GitBox
taklwu merged pull request #3589: URL: https://github.com/apache/hbase/pull/3589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [hbase] wchevreuil commented on a change in pull request #3572: HBASE-26184 TestTableSnapshotScanner.testMergeRegion error message is…

2021-08-18 Thread GitBox
wchevreuil commented on a change in pull request #3572: URL: https://github.com/apache/hbase/pull/3572#discussion_r691107003 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java ## @@ -460,7 +460,7 @@ public void testMergeRegion

[GitHub] [hbase] Apache-HBase commented on pull request #3591: HBASE-26204 Obtain credential for VerifyReplication with peerQuorumAddress

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3591: URL: https://github.com/apache/hbase/pull/3591#issuecomment-900812334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[jira] [Resolved] (HBASE-26187) Write straight into the store directory when Splitting and Merging

2021-08-18 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-26187. -- Resolution: Fixed Amended UTs to check for split proc completion before moving

[jira] [Commented] (HBASE-25298) hbase.rsgroup.fallback.enable should support dynamic configuration

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401158#comment-17401158 ] Hudson commented on HBASE-25298: Results for branch branch-1 [build #161 on bui

[jira] [Commented] (HBASE-22738) Fallback to default group to choose RS when there are no RS in current group

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401156#comment-17401156 ] Hudson commented on HBASE-22738: Results for branch branch-1 [build #161 on bui

[jira] [Commented] (HBASE-24760) Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401157#comment-17401157 ] Hudson commented on HBASE-24760: Results for branch branch-1 [build #161 on bui

[jira] [Commented] (HBASE-25849) Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401155#comment-17401155 ] Hudson commented on HBASE-25849: Results for branch branch-1 [build #161 on bui

[jira] [Updated] (HBASE-26187) Write straight into the store directory when Splitting and Merging

2021-08-18 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26187: - Fix Version/s: 2.5.0 > Write straight into the store directory when Splitting an

[jira] [Updated] (HBASE-26206) Add UT for masterless mode

2021-08-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26206: -- Description: It is not used in code any more and there is no UT to make sure it works. Let's just rem

[jira] [Updated] (HBASE-26206) Add UT for masterless mode

2021-08-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26206: -- Summary: Add UT for masterless mode (was: Remove masterless related code in HRegionServer) > Add UT

[GitHub] [hbase] saintstack edited a comment on pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread GitBox
saintstack edited a comment on pull request #3489: URL: https://github.com/apache/hbase/pull/3489#issuecomment-901174072 Where is the spotbugs fix @sunhelly ? Do it in a new PR? ^^ NVM, I see it now. Thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] saintstack commented on pull request #3489: HBASE-26087 JVM crash when displaying RPC params by MonitoredRPCHandler

2021-08-18 Thread GitBox
saintstack commented on pull request #3489: URL: https://github.com/apache/hbase/pull/3489#issuecomment-901174072 Where is the spotbugs fix @sunhelly ? Do it in a new PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [hbase] wchevreuil merged pull request #3598: Amend HBASE-26187 UTs, adding a check for Split procedure completion …

2021-08-18 Thread GitBox
wchevreuil merged pull request #3598: URL: https://github.com/apache/hbase/pull/3598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [hbase] Apache-HBase commented on pull request #3598: Amend HBASE-26187 UTs, adding a check for Split procedure completion …

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3598: URL: https://github.com/apache/hbase/pull/3598#issuecomment-901155781 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19

[jira] [Commented] (HBASE-26187) Write straight into the store directory when Splitting and Merging

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401069#comment-17401069 ] Hudson commented on HBASE-26187: Results for branch master [build #370 on build

[jira] [Commented] (HBASE-26193) Do not store meta region location as permanent state on zookeeper

2021-08-18 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401068#comment-17401068 ] Hudson commented on HBASE-26193: Results for branch master [build #370 on build

[GitHub] [hbase] shahrs87 commented on a change in pull request #3592: HBASE-26205 Use specified cluster conf for UserProvider in TableMRUtil#initCredentialsForCluster

2021-08-18 Thread GitBox
shahrs87 commented on a change in pull request #3592: URL: https://github.com/apache/hbase/pull/3592#discussion_r691218394 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceUtil.java ## @@ -104,4 +130,147 @@ public void testInitTab

[GitHub] [hbase] shahrs87 commented on a change in pull request #3591: HBASE-26204 Obtain credential for VerifyReplication with peerQuorumAddress

2021-08-18 Thread GitBox
shahrs87 commented on a change in pull request #3591: URL: https://github.com/apache/hbase/pull/3591#discussion_r691245709 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java ## @@ -736,6 +740,40 @@ private static vo

[GitHub] [hbase] shahrs87 commented on a change in pull request #3591: HBASE-26204 Obtain credential for VerifyReplication with peerQuorumAddress

2021-08-18 Thread GitBox
shahrs87 commented on a change in pull request #3591: URL: https://github.com/apache/hbase/pull/3591#discussion_r691243088 ## File path: hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplicationSecureClusterCredentials.java ## @@ -0,0 +1,166 @@ +/

[GitHub] [hbase] shahrs87 commented on a change in pull request #3591: HBASE-26204 Obtain credential for VerifyReplication with peerQuorumAddress

2021-08-18 Thread GitBox
shahrs87 commented on a change in pull request #3591: URL: https://github.com/apache/hbase/pull/3591#discussion_r691242020 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java ## @@ -755,7 +793,8 @@ public int run(Str

[GitHub] [hbase] Apache-HBase commented on pull request #3592: HBASE-26205 Use specified cluster conf for UserProvider in TableMRUtil#initCredentialsForCluster

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3592: URL: https://github.com/apache/hbase/pull/3592#issuecomment-901117973 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 9s

[GitHub] [hbase] Apache-HBase commented on pull request #3592: HBASE-26205 Use specified cluster conf for UserProvider in TableMRUtil#initCredentialsForCluster

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3592: URL: https://github.com/apache/hbase/pull/3592#issuecomment-901117213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 10

[GitHub] [hbase] shahrs87 commented on a change in pull request #3591: HBASE-26204 Obtain credential for VerifyReplication with peerQuorumAddress

2021-08-18 Thread GitBox
shahrs87 commented on a change in pull request #3591: URL: https://github.com/apache/hbase/pull/3591#discussion_r691241668 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java ## @@ -736,6 +740,40 @@ private static vo

[GitHub] [hbase] wchevreuil commented on pull request #3598: Amend HBASE-26187 UTs, adding a check for Split procedure completion …

2021-08-18 Thread GitBox
wchevreuil commented on pull request #3598: URL: https://github.com/apache/hbase/pull/3598#issuecomment-901113325 The failed tests are passing, locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #3572: HBASE-26184 TestTableSnapshotScanner.testMergeRegion error message is…

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3572: URL: https://github.com/apache/hbase/pull/3572#issuecomment-901110207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27

[GitHub] [hbase] Apache-HBase commented on pull request #3572: HBASE-26184 TestTableSnapshotScanner.testMergeRegion error message is…

2021-08-18 Thread GitBox
Apache-HBase commented on pull request #3572: URL: https://github.com/apache/hbase/pull/3572#issuecomment-901109810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3

  1   2   >