[jira] [Commented] (HBASE-26197) Fix some obvious bugs in MultiByteBuff.put

2021-09-07 Thread chenglei (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411655#comment-17411655 ] chenglei commented on HBASE-26197: -- [~zhangduo],thank you very much for code review. > Fix some

[jira] [Commented] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411654#comment-17411654 ] Andrew Kyle Purtell commented on HBASE-26258: - For certain I will take measurements. These

[jira] [Updated] (HBASE-26258) Universal SNAPPY and ZSTD compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26258: Description: Some Hadoop compression codecs became more available in recent

[jira] [Commented] (HBASE-26197) Fix some obvious bugs in MultiByteBuff.put

2021-09-07 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411645#comment-17411645 ] Hudson commented on HBASE-26197: Results for branch branch-2.4 [build #194 on

[jira] [Commented] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411643#comment-17411643 ] Duo Zhang commented on HBASE-26258: --- Yes, I agree that after JIT the java code could have the same

[jira] [Comment Edited] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411637#comment-17411637 ] Andrew Kyle Purtell edited comment on HBASE-26258 at 9/8/21, 2:40 AM:

[jira] [Comment Edited] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411637#comment-17411637 ] Andrew Kyle Purtell edited comment on HBASE-26258 at 9/8/21, 2:40 AM:

[jira] [Comment Edited] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411637#comment-17411637 ] Andrew Kyle Purtell edited comment on HBASE-26258 at 9/8/21, 2:39 AM:

[jira] [Commented] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411637#comment-17411637 ] Andrew Kyle Purtell commented on HBASE-26258: - bq. Just curious how could a pure java

[GitHub] [hbase] Apache-HBase commented on pull request #3660: HBASE-26252: Add option to reload balancer configs when invoking the balancer

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3660: URL: https://github.com/apache/hbase/pull/3660#issuecomment-914839145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3660: HBASE-26252: Add option to reload balancer configs when invoking the balancer

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3660: URL: https://github.com/apache/hbase/pull/3660#issuecomment-914837633 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411628#comment-17411628 ] Duo Zhang commented on HBASE-26258: --- Just curious how could a pure java compression implementation

[jira] [Updated] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26258: Component/s: Operability > Universal gzip, lz4, lzo, snappy, and zstd compression

[jira] [Created] (HBASE-26260) Update default compression codec for WAL value compression to SNAPPY

2021-09-07 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-26260: --- Summary: Update default compression codec for WAL value compression to SNAPPY Key: HBASE-26260 URL: https://issues.apache.org/jira/browse/HBASE-26260

[jira] [Created] (HBASE-26259) Fallback support to pure Java compression via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-26259: --- Summary: Fallback support to pure Java compression via aircompressor Key: HBASE-26259 URL: https://issues.apache.org/jira/browse/HBASE-26259 Project:

[jira] [Updated] (HBASE-26258) Universal gzip, lz4, lzo, snappy, and zstd compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26258: Summary: Universal gzip, lz4, lzo, snappy, and zstd compression support via

[jira] [Commented] (HBASE-26258) Universal SNAPPY and ZSTD compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411622#comment-17411622 ] Andrew Kyle Purtell commented on HBASE-26258: - Also, wherever this change is made available,

[jira] [Updated] (HBASE-26258) Universal SNAPPY and ZSTD compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26258: Description: Some Hadoop compression codecs became more available in recent

[jira] [Commented] (HBASE-26258) Universal SNAPPY and ZSTD compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411621#comment-17411621 ] Andrew Kyle Purtell commented on HBASE-26258: - [~stack] > Universal SNAPPY and ZSTD

[jira] [Updated] (HBASE-26258) Universal SNAPPY and ZSTD compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26258: Description: Some Hadoop compression codecs became more available in recent

[jira] [Updated] (HBASE-26258) Universal SNAPPY and ZSTD compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26258: Description: Some Hadoop compression codecs became more available in recent

[jira] [Created] (HBASE-26258) Universal SNAPPY and ZSTD compression support via aircompressor

2021-09-07 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-26258: --- Summary: Universal SNAPPY and ZSTD compression support via aircompressor Key: HBASE-26258 URL: https://issues.apache.org/jira/browse/HBASE-26258

[GitHub] [hbase] Apache-HBase commented on pull request #3660: HBASE-26252: Add option to reload balancer configs when invoking the balancer

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3660: URL: https://github.com/apache/hbase/pull/3660#issuecomment-914716900 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-914712749 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24833) Bootstrap should not delete the META table directory if it's not partial

2021-09-07 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411588#comment-17411588 ] Zach York commented on HBASE-24833: --- Give me a day to review please. I was working with this on this

[jira] [Commented] (HBASE-26245) Store region server list in master local region

2021-09-07 Thread Zach York (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411587#comment-17411587 ] Zach York commented on HBASE-26245: --- This looks promising... Let me know if you want any help

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #92: HBASE-26257 Improve Performance of HBCK when specifying a subset of t…

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #92: URL: https://github.com/apache/hbase-operator-tools/pull/92#issuecomment-914697230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #92: HBASE-26257 Improve Performance of HBCK when specifying a subset of t…

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #92: URL: https://github.com/apache/hbase-operator-tools/pull/92#issuecomment-914689086 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: |

[GitHub] [hbase-operator-tools] z-york opened a new pull request #92: HBASE-26257 Improve Performance of HBCK when specifying a subset of t…

2021-09-07 Thread GitBox
z-york opened a new pull request #92: URL: https://github.com/apache/hbase-operator-tools/pull/92 …ables On clusters with a large number of tables, listing all table directories from the filesystem can take a lot of time (especially on S3). We should avoid listing all the

[jira] [Created] (HBASE-26257) Improve Performance of HBCK when specifying a subset of tables

2021-09-07 Thread Zach York (Jira)
Zach York created HBASE-26257: - Summary: Improve Performance of HBCK when specifying a subset of tables Key: HBASE-26257 URL: https://issues.apache.org/jira/browse/HBASE-26257 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-914657578 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-26252) Add support for reloading balancer configs with BalanceRequest

2021-09-07 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411557#comment-17411557 ] Bryan Beaudreault commented on HBASE-26252: --- Thanks for looking it over Clara. Sorry, I'm not

[jira] [Commented] (HBASE-26252) Add support for reloading balancer configs with BalanceRequest

2021-09-07 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411552#comment-17411552 ] Clara Xiong commented on HBASE-26252: - Looking over the pr. do you plan to ask operator and update

[GitHub] [hbase] clarax commented on a change in pull request #3660: HBASE-26252: Add option to reload balancer configs when invoking the balancer

2021-09-07 Thread GitBox
clarax commented on a change in pull request #3660: URL: https://github.com/apache/hbase/pull/3660#discussion_r703867575 ## File path: hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java ## @@ -206,13 +219,13 @@ protected float

[GitHub] [hbase] Apache-HBase commented on pull request #3661: HBASE-26255 Add an option to use region location from meta table in T…

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3661: URL: https://github.com/apache/hbase/pull/3661#issuecomment-914631140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-914630067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 9m

[GitHub] [hbase] Apache-HBase commented on pull request #3661: HBASE-26255 Add an option to use region location from meta table in T…

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3661: URL: https://github.com/apache/hbase/pull/3661#issuecomment-914628543 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914626463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3661: HBASE-26255 Add an option to use region location from meta table in T…

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3661: URL: https://github.com/apache/hbase/pull/3661#issuecomment-914624749 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914622673 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-914608446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #3661: HBASE-26255 Add an option to use region location from meta table in T…

2021-09-07 Thread GitBox
huaxiangsun commented on a change in pull request #3661: URL: https://github.com/apache/hbase/pull/3661#discussion_r703800462 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java ## @@ -392,17 +405,41 @@ public static

[GitHub] [hbase] Apache-HBase commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-914593891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-914581390 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-914577903 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-914572572 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #2237: URL: https://github.com/apache/hbase/pull/2237#issuecomment-914528088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914498489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3655: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3655: URL: https://github.com/apache/hbase/pull/3655#issuecomment-914497018 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3596: URL: https://github.com/apache/hbase/pull/3596#issuecomment-914494432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] taklwu commented on a change in pull request #2237: HBASE-24833: Bootstrap should not delete the META table directory if …

2021-09-07 Thread GitBox
taklwu commented on a change in pull request #2237: URL: https://github.com/apache/hbase/pull/2237#discussion_r703703740 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java ## @@ -166,4 +170,35 @@ protected void

[GitHub] [hbase] saintstack commented on a change in pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
saintstack commented on a change in pull request #3596: URL: https://github.com/apache/hbase/pull/3596#discussion_r703674995 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java ## @@ -333,76 +331,76 @@ ReaderContext

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914460565 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m

[GitHub] [hbase] Apache-HBase commented on pull request #3660: HBASE-26252: Add option to reload balancer configs when invoking the balancer

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3660: URL: https://github.com/apache/hbase/pull/3660#issuecomment-914443474 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[jira] [Updated] (HBASE-26197) Fix some obvious bugs in MultiByteBuff.put

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26197: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Updated] (HBASE-26197) Fix some obvious bugs in MultiByteBuff.put

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26197: -- Fix Version/s: 2.4.7 2.3.7 3.0.0-alpha-2

[GitHub] [hbase] saintstack commented on a change in pull request #3596: HBASE-23584 cache filestatus in storefileinfo

2021-09-07 Thread GitBox
saintstack commented on a change in pull request #3596: URL: https://github.com/apache/hbase/pull/3596#discussion_r703630434 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java ## @@ -303,17 +302,16 @@ ReaderContext

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703622941 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,68 @@ */

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703621630 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,58 @@ */

[GitHub] [hbase] wchevreuil commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
wchevreuil commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703618559 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,58 @@ */

[jira] [Commented] (HBASE-23834) HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jetty version mismatch

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411303#comment-17411303 ] Duo Zhang commented on HBASE-23834: --- IIRC, we marked it as incompatible change because we changed the

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914403782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
wchevreuil commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703598292 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,58 @@ */

[GitHub] [hbase] Apache9 merged pull request #3586: HBASE-26197 Fix some obvious bugs in MultiByteBuff.put

2021-09-07 Thread GitBox
Apache9 merged pull request #3586: URL: https://github.com/apache/hbase/pull/3586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-26163) Better logging in RSGroupInfoManagerImpl

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26163. --- Fix Version/s: 3.0.0-alpha-2 Hadoop Flags: Reviewed Resolution: Fixed Merged to master.

[jira] [Updated] (HBASE-26163) Better logging in RSGroupInfoManagerImpl

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26163: -- Component/s: rsgroup logging > Better logging in RSGroupInfoManagerImpl >

[GitHub] [hbase] Apache9 merged pull request #3610: HBASE-26163 Better logging in RSGroupInfoManagerImpl

2021-09-07 Thread GitBox
Apache9 merged pull request #3610: URL: https://github.com/apache/hbase/pull/3610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26228) updateRSGroupConfig operation should be authorized by AccessController

2021-09-07 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26228: -- Hadoop Flags: Reviewed Resolution: Fixed Status: Resolved (was: Patch Available)

[GitHub] [hbase] Apache9 merged pull request #3633: HBASE-26228 updateRSGroupConfig operation should be authorized by AccessController

2021-09-07 Thread GitBox
Apache9 merged pull request #3633: URL: https://github.com/apache/hbase/pull/3633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3663: HBASE-26240 Set InterfaceAudience to Private for BalanceRequest$Builder

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3663: URL: https://github.com/apache/hbase/pull/3663#issuecomment-914339737 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3660: HBASE-26252: Add option to reload balancer configs when invoking the balancer

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3660: URL: https://github.com/apache/hbase/pull/3660#issuecomment-914327821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3663: HBASE-26240 Set InterfaceAudience to Private for BalanceRequest$Builder

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3663: URL: https://github.com/apache/hbase/pull/3663#issuecomment-91432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3663: HBASE-26240 Set InterfaceAudience to Private for BalanceRequest$Builder

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3663: URL: https://github.com/apache/hbase/pull/3663#issuecomment-914323087 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…

2021-09-07 Thread GitBox
Apache9 commented on pull request #3656: URL: https://github.com/apache/hbase/pull/3656#issuecomment-914305724 Or another way, is to add some restrictions when users want to change the StoreFileTracker implementation. For example, if users want to change the implementation, first

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914301209 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache9 commented on pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…

2021-09-07 Thread GitBox
Apache9 commented on pull request #3656: URL: https://github.com/apache/hbase/pull/3656#issuecomment-914300760 > Overall, looks good. Have some minor remarks. > > Additionally, would it be a good idea to provide a tool that allows for setting the the migration tracker on sets of

[GitHub] [hbase] Apache-HBase commented on pull request #3663: HBASE-26240 Set InterfaceAudience to Private for BalanceRequest$Builder

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3663: URL: https://github.com/apache/hbase/pull/3663#issuecomment-914298147 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914295943 Only a few places need to polish, first is how to merge configurations, second is that I do not think we need to catch the exception for ReflectionUtils.newInstance and rethrow

[GitHub] [hbase] Apache-HBase commented on pull request #3663: HBASE-26240 Set InterfaceAudience to Private for BalanceRequest$Builder

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3663: URL: https://github.com/apache/hbase/pull/3663#issuecomment-914295109 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703497189 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,68 @@ */

[GitHub] [hbase] Apache-HBase commented on pull request #3663: HBASE-26240 Set InterfaceAudience to Private for BalanceRequest$Builder

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3663: URL: https://github.com/apache/hbase/pull/3663#issuecomment-914293212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] wchevreuil commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
wchevreuil commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914292656 Latest test failure seems unrelated, have TestSnapshotScannerHDFSAclController passing, locally. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703489223 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,58 @@ */

[GitHub] [hbase] bbeaudreault opened a new pull request #3663: HBASE-26240 Set InterfaceAudience to Private for BalanceRequest$Builder

2021-09-07 Thread GitBox
bbeaudreault opened a new pull request #3663: URL: https://github.com/apache/hbase/pull/3663 @joshelser @ndimiduk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] wchevreuil commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…

2021-09-07 Thread GitBox
wchevreuil commented on a change in pull request #3656: URL: https://github.com/apache/hbase/pull/3656#discussion_r703465822 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/storefiletracker/TestMigrationStoreFileTracker.java ## @@ -0,0 +1,179 @@

[GitHub] [hbase] Apache-HBase commented on pull request #3652: HBASE-26242 Region never split when store file count larger than the …

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-914241575 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914237037 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703433083 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java ## @@ -67,6 +67,7 @@ public void

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703431296 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerFactory.java ## @@ -17,23 +17,58 @@ */

[GitHub] [hbase] wchevreuil commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
wchevreuil commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703424543 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultStoreEngine.java ## @@ -67,6 +67,7 @@ public void

[GitHub] [hbase] Apache9 commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3656: URL: https://github.com/apache/hbase/pull/3656#discussion_r703416594 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/storefiletracker/TestMigrationStoreFileTracker.java ## @@ -0,0 +1,179 @@

[GitHub] [hbase] Apache9 commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3656: URL: https://github.com/apache/hbase/pull/3656#discussion_r703416310 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/storefiletracker/TestMigrationStoreFileTracker.java ## @@ -0,0 +1,179 @@

[GitHub] [hbase] Apache9 commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3656: URL: https://github.com/apache/hbase/pull/3656#discussion_r703416005 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/MigrationStoreFileTracker.java ## @@ -0,0 +1,91 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3656: HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin…

2021-09-07 Thread GitBox
wchevreuil commented on a change in pull request #3656: URL: https://github.com/apache/hbase/pull/3656#discussion_r703389965 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/storefiletracker/TestMigrationStoreFileTracker.java ## @@ -0,0 +1,179 @@

[GitHub] [hbase] Apache-HBase commented on pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3617: URL: https://github.com/apache/hbase/pull/3617#issuecomment-914197563 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3658: HBASE-26249 Request split and compact after bulkLoad files

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3658: URL: https://github.com/apache/hbase/pull/3658#issuecomment-914194655 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3652: HBASE-26242 Region never split when store file count larger than the …

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3652: URL: https://github.com/apache/hbase/pull/3652#issuecomment-914193459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #3617: HBASE-26079 Use StoreFileTracker when splitting and merging

2021-09-07 Thread GitBox
Apache9 commented on a change in pull request #3617: URL: https://github.com/apache/hbase/pull/3617#discussion_r703328286 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java ## @@ -744,14 +749,18 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3662: HBASE-26253 Backport HBASE-23834 to branch 2.3

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3662: URL: https://github.com/apache/hbase/pull/3662#issuecomment-914116962 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3662: HBASE-26253 Backport HBASE-23834 to branch 2.3

2021-09-07 Thread GitBox
Apache-HBase commented on pull request #3662: URL: https://github.com/apache/hbase/pull/3662#issuecomment-914113787 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

  1   2   >