Reidd commented on pull request #3720:
URL: https://github.com/apache/hbase/pull/3720#issuecomment-934023508
Have you rebased your codes on latest branch-1? @YutSean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Apache-HBase commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-933999490
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-26327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clara Xiong reassigned HBASE-26327:
---
Assignee: Clara Xiong
> Replicas cohosted on a rack shouldn't keep triggering Balancer
>
Apache-HBase commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-93396
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Clara Xiong created HBASE-26327:
---
Summary: Replicas cohosted on a rack shouldn't keep triggering
Balancer
Key: HBASE-26327
URL: https://issues.apache.org/jira/browse/HBASE-26327
Project: HBase
Apache-HBase commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-933850982
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-26318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424110#comment-17424110
]
Hudson commented on HBASE-26318:
Results for branch HBASE-26318
[build #3 on
Apache-HBase commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-933759086
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-933758872
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m
pankaj72981 commented on a change in pull request #3712:
URL: https://github.com/apache/hbase/pull/3712#discussion_r721614194
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/DirScanPool.java
##
@@ -39,21 +39,28 @@
private final
frostruan commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r721610922
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotProcedure.java
##
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the
frostruan commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r721605975
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotRegionProcedure.java
##
@@ -0,0 +1,258 @@
+/*
+ * Licensed to
frostruan commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r721605752
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotProcedure.java
##
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/HBASE-26320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424087#comment-17424087
]
Pankaj Kumar commented on HBASE-26320:
--
Thanks [~zyork] for bringing this, recently we faced this
Apache-HBase commented on pull request #3693:
URL: https://github.com/apache/hbase/pull/3693#issuecomment-933718099
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
apurtell commented on a change in pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#discussion_r721586555
##
File path:
hbase-compression/hbase-compression-aircompressor/src/main/java/org/apache/hadoop/hbase/io/compress/aircompressor/SnappyCodec.java
##
@@
apurtell commented on a change in pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#discussion_r721576597
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java
##
@@ -471,4 +485,57 @@ public static byte toByte(ByteBuffer buf,
apurtell commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-933695763
I am making a final pass now to address remaining review comments and
checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HBASE-26321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424010#comment-17424010
]
Peter Somogyi commented on HBASE-26321:
---
This is very interesting [~stack] and [~huaxiangsun]!
Apache-HBase commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-933599139
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-933592090
> In general I do not like that we introduce a new init method but do not
call it when verifying...
It's a mean to separate instantiation of SFT impls, from actual init
[
https://issues.apache.org/jira/browse/HBASE-26326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-26326:
-
Description:
CreateTableProcedure tries to instantiate SFT impl in its
frostruan commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r721457699
##
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##
@@ -277,6 +284,7 @@ message ExecuteProceduresRequest {
repeated
Apache9 edited a comment on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-933571085
In general I do not like that we introduce a new init method but do not call
it when verifying...
I think we should try to provide more things when constructing the
Apache9 commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-933571085
In general I do not like that we introduce a new init method but do not call
it when verifying...
I think we should try to provide more things when constructing the
frostruan commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r721440890
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -1870,50 +1870,62 @@ public void onComplete() {
frostruan commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r721434067
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotProcedure.java
##
@@ -0,0 +1,408 @@
+/*
+ * Licensed to the
Apache9 commented on a change in pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#discussion_r721428211
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/UnsafeAccess.java
##
@@ -471,4 +485,57 @@ public static byte toByte(ByteBuffer buf,
[
https://issues.apache.org/jira/browse/HBASE-26326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-26326 started by Wellington Chevreuil.
> CreateTableProcedure fails when FileBasedStoreFileTracker is
[
https://issues.apache.org/jira/browse/HBASE-26326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-26326:
-
Status: Patch Available (was: In Progress)
> CreateTableProcedure fails when
wchevreuil opened a new pull request #3721:
URL: https://github.com/apache/hbase/pull/3721
… is set in global config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Wellington Chevreuil created HBASE-26326:
Summary: CreateTableProcedure fails when FileBasedStoreFileTracker
is set in global config
Key: HBASE-26326
URL: https://issues.apache.org/jira/browse/HBASE-26326
[
https://issues.apache.org/jira/browse/HBASE-26323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26323:
--
Priority: Major (was: Minor)
> Introduce a SnapshotProcedure
> -
>
>
[
https://issues.apache.org/jira/browse/HBASE-26323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26323:
--
Summary: Introduce a SnapshotProcedure (was: introduce a SnapshotProcedure)
> Introduce a
[
https://issues.apache.org/jira/browse/HBASE-19529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423972#comment-17423972
]
Duo Zhang commented on HBASE-19529:
---
Will resolve this later if no other concerns.
Thanks~
> Handle
[
https://issues.apache.org/jira/browse/HBASE-24639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423971#comment-17423971
]
Duo Zhang commented on HBASE-24639:
---
Any updates here? HBASE-22120 has been resolved and the backport
Apache9 commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r721369546
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -1870,50 +1870,62 @@ public void onComplete() {
Apache-HBase commented on pull request #3693:
URL: https://github.com/apache/hbase/pull/3693#issuecomment-933515185
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-26323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423950#comment-17423950
]
ruanhui commented on HBASE-26323:
-
Thanks for taking a look on this [~zhangduo] . Some unit tests
[
https://issues.apache.org/jira/browse/HBASE-26323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423942#comment-17423942
]
Duo Zhang commented on HBASE-26323:
---
Link with HBASE-21488.
Thanks for taking this up [~frostruan].
[
https://issues.apache.org/jira/browse/HBASE-19264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-19264.
---
Resolution: Implemented
Can not remember the context but looking at the current code base,
[
https://issues.apache.org/jira/browse/HBASE-21471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-21471.
---
Resolution: Not A Problem
WALProcedureStore has been deprecated. Resolve.
> Add more comments
[
https://issues.apache.org/jira/browse/HBASE-21236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-21236.
---
Resolution: Not A Problem
WALProcedure has been deprecated. Resolve as Not A Problem.
> Load
[
https://issues.apache.org/jira/browse/HBASE-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423932#comment-17423932
]
Duo Zhang commented on HBASE-17537:
---
Any updates here? Is this still valid?
> Remove
[
https://issues.apache.org/jira/browse/HBASE-14619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423930#comment-17423930
]
Duo Zhang commented on HBASE-14619:
---
[~syuanjiang] Any updates here? In general I can not follow as I
[
https://issues.apache.org/jira/browse/HBASE-14240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-14240.
---
Resolution: Won't Fix
WALProcedureStore has been deprecated. Resolve as won't fix.
> Unactionable
[
https://issues.apache.org/jira/browse/HBASE-19632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-19632.
---
Fix Version/s: (was: 1.2.0)
Resolution: Won't Fix
1.2.0 has been EOL for a long time.
[
https://issues.apache.org/jira/browse/HBASE-19807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-19807.
---
Fix Version/s: (was: 1.2.0)
Resolution: Won't Fix
1.2.x has been EOL for a long time.
[
https://issues.apache.org/jira/browse/HBASE-21274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-21274.
---
Resolution: Won't Fix
I think this is for the WALProcedureStore. With RegionProcedureStore, we do
[
https://issues.apache.org/jira/browse/HBASE-26167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-26167:
--
Component/s: test
> Allow users to not start zookeeper and dfs cluster when using
>
[
https://issues.apache.org/jira/browse/HBASE-26312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423919#comment-17423919
]
Anoop Sam John commented on HBASE-26312:
Can u pls raise a Pull request for the fix?
> scan
nkalmar commented on pull request #3693:
URL: https://github.com/apache/hbase/pull/3693#issuecomment-933351458
Saw previous commits having thrift modification included the generated
classes as well. This way we won't have the new API in sync with the committed
generated code. (Although
[
https://issues.apache.org/jira/browse/HBASE-26323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ruanhui updated HBASE-26323:
Comment: was deleted
(was: sorry. I don't know why the pull request didn't link, can I just put it
here
Apache-HBase commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-933215579
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
virajjasani commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-933179895
@apurtell I am done with the review rounds at least for now and have done
little bit of testing as well locally.
--
This is an automated message from the Apache Git
Apache-HBase commented on pull request #3691:
URL: https://github.com/apache/hbase/pull/3691#issuecomment-933170417
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
56 matches
Mail list logo
