[GitHub] [hbase] Apache9 commented on pull request #4349: HBASE-26955 Improvement of the pause time between retries in Rpc caller

2022-04-14 Thread GitBox
Apache9 commented on PR #4349: URL: https://github.com/apache/hbase/pull/4349#issuecomment-1099894306 In general I do not think we should use the same logic in RemoteProcedureResultReporter. At region server side we know the procedure result is very important so we sould try to send the res

[jira] [Updated] (HBASE-26944) Possible resource leak while creating new region scanner

2022-04-14 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-26944: - Fix Version/s: 2.5.0 2.6.0 2.4.12 Resolution: Fixed

[GitHub] [hbase] pankaj72981 merged pull request #4339: HBASE-26944 Possible resource leak while creating new region scanner

2022-04-14 Thread GitBox
pankaj72981 merged PR #4339: URL: https://github.com/apache/hbase/pull/4339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apa

[GitHub] [hbase] pankaj72981 commented on pull request #4339: HBASE-26944 Possible resource leak while creating new region scanner

2022-04-14 Thread GitBox
pankaj72981 commented on PR #4339: URL: https://github.com/apache/hbase/pull/4339#issuecomment-1099878915 UT failures are not relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522619#comment-17522619 ] Andrew Kyle Purtell commented on HBASE-26938: - Yes but we like it better eve

[GitHub] [hbase] Apache-HBase commented on pull request #4349: HBASE-26955 Improvement of the pause time between retries in Rpc caller

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4349: URL: https://github.com/apache/hbase/pull/4349#issuecomment-1099792290 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4349: HBASE-26955 Improvement of the pause time between retries in Rpc caller

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4349: URL: https://github.com/apache/hbase/pull/4349#issuecomment-1099790622 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 53s | Docke

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522614#comment-17522614 ] Duo Zhang commented on HBASE-26938: --- So you've been testing the POC already... As I s

[GitHub] [hbase] Apache-HBase commented on pull request #4349: HBASE-26955 Improvement of the pause time between retries in Rpc caller

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4349: URL: https://github.com/apache/hbase/pull/4349#issuecomment-1099788419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docke

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522612#comment-17522612 ] Andrew Kyle Purtell commented on HBASE-26938: - Stress test with the ITLCC sc

[GitHub] [hbase] functioner opened a new pull request, #4349: HBASE-26955 Improvement of the pause time between retries in Rpc caller

2022-04-14 Thread GitBox
functioner opened a new pull request, #4349: URL: https://github.com/apache/hbase/pull/4349 Propose a patch for [HBASE-26955](https://issues.apache.org/jira/browse/HBASE-26955) Probably this patch should be further improved, because it ignores the backoff factor when not encountering exc

[jira] [Updated] (HBASE-26955) Improvement of the pause time between retries in Rpc caller

2022-04-14 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated HBASE-26955: - Description: We were using the HBase version 2.4.2 and had clients submitting requests to a HBase clust

[jira] [Created] (HBASE-26955) Improvement of the pause time between retries in Rpc caller

2022-04-14 Thread Haoze Wu (Jira)
Haoze Wu created HBASE-26955: Summary: Improvement of the pause time between retries in Rpc caller Key: HBASE-26955 URL: https://issues.apache.org/jira/browse/HBASE-26955 Project: HBase Issue Ty

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 1:23 AM:

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 1:12 AM:

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 1:10 AM:

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 1:10 AM:

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 1:09 AM:

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 1:08 AM:

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell commented on HBASE-26938: - Stress test with the ITLCC sc

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 12:59 AM: ---

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522600#comment-17522600 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/15/22 12:59 AM: ---

[GitHub] [hbase] Apache9 commented on pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
Apache9 commented on PR #4338: URL: https://github.com/apache/hbase/pull/4338#issuecomment-1099736811 > Let @Apache9 propose a PR for his solution that moves the scope of where this state is tracked, makes sense to me. No hard feelings. Need to conserve my time. We shouldn't be pursuing two

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522590#comment-17522590 ] Andrew Kyle Purtell commented on HBASE-26938: - That PoC commit is missing on

[jira] [Commented] (HBASE-22349) Stochastic Load Balancer skips balancing when node is replaced in cluster

2022-04-14 Thread David Manning (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522585#comment-17522585 ] David Manning commented on HBASE-22349: --- The scenario as originally described is f

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522582#comment-17522582 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/14/22 11:16 PM: ---

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522582#comment-17522582 ] Andrew Kyle Purtell commented on HBASE-26938: - Yeah I tried to be clear with

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522581#comment-17522581 ] Andrew Kyle Purtell commented on HBASE-26938: - Administrivia: After this is

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522580#comment-17522580 ] Josh Elser edited comment on HBASE-26938 at 4/14/22 11:10 PM:

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522580#comment-17522580 ] Josh Elser commented on HBASE-26938: I hope I didn't push you to abandon your PR wit

[jira] [Comment Edited] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522577#comment-17522577 ] Andrew Kyle Purtell edited comment on HBASE-26938 at 4/14/22 11:09 PM: ---

[jira] [Commented] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522577#comment-17522577 ] Andrew Kyle Purtell commented on HBASE-26938: - Reassigned to [~zhangduo] as

[jira] [Updated] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-26938: Status: Open (was: Patch Available) > Compaction failures after StoreFileTracker

[jira] [Assigned] (HBASE-26938) Compaction failures after StoreFileTracker integration

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-26938: --- Assignee: Duo Zhang (was: Andrew Kyle Purtell) > Compaction failures after

[GitHub] [hbase] apurtell commented on a diff in pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
apurtell commented on code in PR #4338: URL: https://github.com/apache/hbase/pull/4338#discussion_r850876906 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java: ## @@ -344,6 +340,9 @@ protected final List compact(final CompactionReques

[GitHub] [hbase] apurtell commented on pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
apurtell commented on PR #4338: URL: https://github.com/apache/hbase/pull/4338#issuecomment-1099701991 One thing I will note is I also tried to clean up progress reporting, which will need to be separately addressed. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] apurtell commented on pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
apurtell commented on PR #4338: URL: https://github.com/apache/hbase/pull/4338#issuecomment-1099700342 Let @Apache9 propose a PR for his solution. No hard feelings. Need to conserve my time. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hbase] apurtell closed pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
apurtell closed pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration URL: https://github.com/apache/hbase/pull/4338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] apurtell commented on pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
apurtell commented on PR #4338: URL: https://github.com/apache/hbase/pull/4338#issuecomment-1099699638 I don't see how we can collaborate here when pursuing two different solutions @Apache9 . I am happy to cut my losses and close this and review your solution instead. -- This is an auto

[GitHub] [hbase] joshelser commented on a diff in pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
joshelser commented on code in PR #4338: URL: https://github.com/apache/hbase/pull/4338#discussion_r850866084 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java: ## @@ -550,22 +551,63 @@ protected InternalScanner createScanner(HStore st

[jira] [Comment Edited] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522539#comment-17522539 ] Andrew Kyle Purtell edited comment on HBASE-26766 at 4/14/22 10:00 PM: ---

[jira] [Comment Edited] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522539#comment-17522539 ] Andrew Kyle Purtell edited comment on HBASE-26766 at 4/14/22 9:57 PM:

[jira] [Comment Edited] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522539#comment-17522539 ] Andrew Kyle Purtell edited comment on HBASE-26766 at 4/14/22 9:56 PM:

[jira] [Comment Edited] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522539#comment-17522539 ] Andrew Kyle Purtell edited comment on HBASE-26766 at 4/14/22 9:55 PM:

[jira] [Comment Edited] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522539#comment-17522539 ] Andrew Kyle Purtell edited comment on HBASE-26766 at 4/14/22 9:49 PM:

[jira] [Comment Edited] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522539#comment-17522539 ] Andrew Kyle Purtell edited comment on HBASE-26766 at 4/14/22 9:48 PM:

[jira] [Commented] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522539#comment-17522539 ] Andrew Kyle Purtell commented on HBASE-26766: - Proposals and patches are to

[jira] [Commented] (HBASE-26943) HMaster page style display confusion

2022-04-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522498#comment-17522498 ] Hudson commented on HBASE-26943: Results for branch master [build #564 on build

[jira] [Commented] (HBASE-26954) Compilation of master vs hadoop-3.3.2 fails

2022-04-14 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522449#comment-17522449 ] Sean Busbey commented on HBASE-26954: - whoever works on this please figure out why o

[jira] [Commented] (HBASE-26954) Compilation of master vs hadoop-3.3.2 fails

2022-04-14 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522447#comment-17522447 ] Sean Busbey commented on HBASE-26954: - master doesn't have our noop htrace implement

[GitHub] [hbase] Apache9 commented on pull request #4338: HBASE-26938 Compaction failures after StoreFileTracker integration

2022-04-14 Thread GitBox
Apache9 commented on PR #4338: URL: https://github.com/apache/hbase/pull/4338#issuecomment-1099396712 Please see if this POC could make things better... I've introduced a a StoreFileWriterCreationTracker(actually in most places it is just a Consumer), for recording the creation of a S

[GitHub] [hbase] Apache-HBase commented on pull request #4339: HBASE-26944 Possible resource leak while creating new region scanner

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4339: URL: https://github.com/apache/hbase/pull/4339#issuecomment-1099241969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 39s | Docker

[GitHub] [hbase] briaugenreich commented on pull request #4347: HBASE-26581 Add metrics for failed replication edits

2022-04-14 Thread GitBox
briaugenreich commented on PR #4347: URL: https://github.com/apache/hbase/pull/4347#issuecomment-1099201576 Im going to be working on fixing this spot bugs error and adding tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hbase] Apache-HBase commented on pull request #4339: HBASE-26944 Possible resource leak while creating new region scanner

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4339: URL: https://github.com/apache/hbase/pull/4339#issuecomment-1099149428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 32s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4340: HBASE-26947 Implement a special TestAppender to limit the size of tes…

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4340: URL: https://github.com/apache/hbase/pull/4340#issuecomment-1098957828 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 54s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #4339: HBASE-26944 Possible resource leak while creating new region scanner

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4339: URL: https://github.com/apache/hbase/pull/4339#issuecomment-1098953194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docke

[jira] [Commented] (HBASE-26766) Introduce custom attributes to threads

2022-04-14 Thread Pola Sairam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522166#comment-17522166 ] Pola Sairam commented on HBASE-26766: - Hi [~ndimiduk]  Thank you for the feedback. I

[GitHub] [hbase] Apache-HBase commented on pull request #4348: HBASE-26766 Introduce custom attributes to threads

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4348: URL: https://github.com/apache/hbase/pull/4348#issuecomment-1098808092 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4340: HBASE-26947 Implement a special TestAppender to limit the size of tes…

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4340: URL: https://github.com/apache/hbase/pull/4340#issuecomment-1098777403 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #4348: HBASE-26766 Introduce custom attributes to threads

2022-04-14 Thread GitBox
Apache-HBase commented on PR #4348: URL: https://github.com/apache/hbase/pull/4348#issuecomment-1098774134 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker