[GitHub] [hbase] frostruan commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-01-28 Thread via GitHub
frostruan commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407590603 Thanks for the invitation Duo @Apache9 I think it depends on whether we want to keep the old metric information when refresh replication source. If so, then I think this is a

[GitHub] [hbase] Apache-HBase commented on pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4967: URL: https://github.com/apache/hbase/pull/4967#issuecomment-1407587638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4967: URL: https://github.com/apache/hbase/pull/4967#issuecomment-1407580802 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 36s |

[jira] [Commented] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681680#comment-17681680 ] Tak-Lon (Stephen) Wu commented on HBASE-27547: -- added Addendum

[GitHub] [hbase] Apache9 commented on pull request #4942: HBASE-27547 Close store file readers after region warmup

2023-01-28 Thread via GitHub
Apache9 commented on PR #4942: URL: https://github.com/apache/hbase/pull/4942#issuecomment-1407566862 Just do it, when applying HBASE-27598 to branch-2 I also found the problem and include the fix when cherry-picking HBASE-27598, so you just need to fix branch-2.5. Sorry for that.

[GitHub] [hbase] Apache-HBase commented on pull request #4732: HBASE-27333 Abort RS when the hostname is different from master seen

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4732: URL: https://github.com/apache/hbase/pull/4732#issuecomment-1407564408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[jira] [Resolved] (HBASE-27598) Upgrade mockito to 4.x

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27598. --- Hadoop Flags: Reviewed Assignee: Duo Zhang Resolution: Fixed Pushed to master and

[GitHub] [hbase] taklwu commented on pull request #4942: HBASE-27547 Close store file readers after region warmup

2023-01-28 Thread via GitHub
taklwu commented on PR #4942: URL: https://github.com/apache/hbase/pull/4942#issuecomment-1407557858 patch to branch-2.5 is failing the build , it would need a import line for TableDescriptor in hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestWarmupRegion.java. I

[jira] [Commented] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681677#comment-17681677 ] Hudson commented on HBASE-27547: Results for branch branch-2.4 [build #503 on

[jira] [Commented] (HBASE-27585) Bump up jruby to 9.3.9.0 and related joni and jcodings to 2.1.43 and 1.0.57 respectively

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681676#comment-17681676 ] Hudson commented on HBASE-27585: Results for branch branch-2.4 [build #503 on

[jira] [Updated] (HBASE-27586) Bump up commons-codec to 1.15

2023-01-28 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27586: - Fix Version/s: 2.5.3 (was: 2.5.4) > Bump up

[jira] [Updated] (HBASE-27588) "Instantiating StoreFileTracker impl" INFO level logging is too chatty

2023-01-28 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27588: - Fix Version/s: 2.5.3 (was: 2.5.4) > "Instantiating

[jira] [Updated] (HBASE-27591) [JDK17] Fix failure TestImmutableScan#testScanCopyConstructor

2023-01-28 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27591: - Fix Version/s: 2.5.3 (was: 2.5.4) > [JDK17] Fix failure

[jira] [Updated] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27547: - Fix Version/s: 2.5.3 (was: 2.5.4) > Close store file

[jira] [Updated] (HBASE-27585) Bump up jruby to 9.3.9.0 and related joni and jcodings to 2.1.43 and 1.0.57 respectively

2023-01-28 Thread Tak-Lon (Stephen) Wu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-27585: - Fix Version/s: 2.5.3 (was: 2.5.4) > Bump up jruby to

[GitHub] [hbase] Apache-HBase commented on pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4967: URL: https://github.com/apache/hbase/pull/4967#issuecomment-1407551482 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[GitHub] [hbase] Apache9 merged pull request #4998: HBASE-27598 Upgrade mockito to 4.x

2023-01-28 Thread via GitHub
Apache9 merged PR #4998: URL: https://github.com/apache/hbase/pull/4998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on pull request #4991: HBASE-27581 [JDK17] Fix failure TestHBaseTestingUtil#testResolvePortConflict

2023-01-28 Thread via GitHub
Apache9 commented on PR #4991: URL: https://github.com/apache/hbase/pull/4991#issuecomment-1407550489 Please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-28 Thread via GitHub
bbeaudreault commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1089854145 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## @@ -3616,8 +3620,9 @@ public ScanResponse scan(final RpcController

[jira] [Updated] (HBASE-27560) CatalogJanitor consistencyCheck cannot report the hole on last region if next table is disabled in meta

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27560: -- Fix Version/s: 2.4.16 (was: 2.4.17) > CatalogJanitor consistencyCheck cannot

[jira] [Updated] (HBASE-27382) Cluster completely down due to WAL splitting failing for hbase:meta table.

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27382: -- Fix Version/s: 2.4.16 (was: 2.4.17) > Cluster completely down due to WAL

[jira] [Updated] (HBASE-27548) Bump jettison from 1.5.1 to 1.5.2

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27548: -- Fix Version/s: 2.4.16 (was: 2.4.17) > Bump jettison from 1.5.1 to 1.5.2 >

[jira] [Updated] (HBASE-27243) Fix TestQuotaThrottle after HBASE-27046

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27243: -- Fix Version/s: 2.4.16 (was: 2.4.17) > Fix TestQuotaThrottle after HBASE-27046

[jira] [Updated] (HBASE-27583) Remove -X option when building protoc check in nightly and pre commit job

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27583: -- Fix Version/s: 2.4.16 (was: 2.4.17) > Remove -X option when building protoc

[jira] [Updated] (HBASE-27585) Bump up jruby to 9.3.9.0 and related joni and jcodings to 2.1.43 and 1.0.57 respectively

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27585: -- Fix Version/s: 2.4.16 (was: 2.4.17) > Bump up jruby to 9.3.9.0 and related

[jira] [Updated] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27547: -- Fix Version/s: 2.4.16 (was: 2.4.17) > Close store file readers after region

[jira] [Updated] (HBASE-27586) Bump up commons-codec to 1.15

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27586: -- Fix Version/s: 2.4.16 (was: 2.4.17) > Bump up commons-codec to 1.15 >

[jira] [Updated] (HBASE-25516) [JDK17] reflective access Field.class.getDeclaredField("modifiers") not supported

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25516: -- Fix Version/s: 2.4.16 (was: 2.4.17) > [JDK17] reflective access

[jira] [Updated] (HBASE-27591) [JDK17] Fix failure TestImmutableScan#testScanCopyConstructor

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27591: -- Fix Version/s: 2.4.16 (was: 2.4.17) > [JDK17] Fix failure

[jira] [Updated] (HBASE-27548) Bump jettison from 1.5.1 to 1.5.2

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27548: -- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.5.3

[jira] [Updated] (HBASE-27583) Remove -X option when building protoc check in nightly and pre commit job

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27583: -- Fix Version/s: 2.5.3 (was: 2.5.4) > Remove -X option when building protoc

[jira] [Updated] (HBASE-27560) CatalogJanitor consistencyCheck cannot report the hole on last region if next table is disabled in meta

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27560: -- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.5.3

[jira] [Updated] (HBASE-25516) [JDK17] reflective access Field.class.getDeclaredField("modifiers") not supported

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25516: -- Fix Version/s: 2.5.3 (was: 2.5.4) > [JDK17] reflective access

[jira] [Commented] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681633#comment-17681633 ] Hudson commented on HBASE-27547: Results for branch branch-2 [build #729 on

[jira] [Commented] (HBASE-27585) Bump up jruby to 9.3.9.0 and related joni and jcodings to 2.1.43 and 1.0.57 respectively

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681632#comment-17681632 ] Hudson commented on HBASE-27585: Results for branch branch-2 [build #729 on

[jira] [Commented] (HBASE-27585) Bump up jruby to 9.3.9.0 and related joni and jcodings to 2.1.43 and 1.0.57 respectively

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681628#comment-17681628 ] Hudson commented on HBASE-27585: Results for branch branch-2.5 [build #287 on

[jira] [Commented] (HBASE-27591) [JDK17] Fix failure TestImmutableScan#testScanCopyConstructor

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681627#comment-17681627 ] Hudson commented on HBASE-27591: Results for branch branch-2.5 [build #287 on

[jira] [Commented] (HBASE-27586) Bump up commons-codec to 1.15

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681626#comment-17681626 ] Hudson commented on HBASE-27586: Results for branch branch-2.5 [build #287 on

[jira] [Commented] (HBASE-27585) Bump up jruby to 9.3.9.0 and related joni and jcodings to 2.1.43 and 1.0.57 respectively

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681621#comment-17681621 ] Hudson commented on HBASE-27585: Results for branch master [build #763 on

[jira] [Commented] (HBASE-27586) Bump up commons-codec to 1.15

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681619#comment-17681619 ] Hudson commented on HBASE-27586: Results for branch master [build #763 on

[jira] [Commented] (HBASE-27591) [JDK17] Fix failure TestImmutableScan#testScanCopyConstructor

2023-01-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681620#comment-17681620 ] Hudson commented on HBASE-27591: Results for branch master [build #763 on

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1407459957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1407457396 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache-HBase commented on pull request #4998: HBASE-27598 Upgrade mockito to 4.x

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4998: URL: https://github.com/apache/hbase/pull/4998#issuecomment-1407426847 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

[jira] [Resolved] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-27547. --- Fix Version/s: 2.6.0 3.0.0-alpha-4 2.4.17

[jira] [Updated] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-27547: -- Component/s: regionserver > Close store file readers after region warmup >

[jira] [Assigned] (HBASE-27547) Close store file readers after region warmup

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-27547: - Assignee: Eungsop Yoo > Close store file readers after region warmup >

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1407422718 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 21s |

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1407412088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1407409905 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache9 merged pull request #4942: HBASE-27547 Close store file readers after region warmup

2023-01-28 Thread via GitHub
Apache9 merged PR #4942: URL: https://github.com/apache/hbase/pull/4942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #4998: HBASE-27598 Upgrade mockito to 4.x

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4998: URL: https://github.com/apache/hbase/pull/4998#issuecomment-1407406956 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s |

[GitHub] [hbase] Apache-HBase commented on pull request #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4820: URL: https://github.com/apache/hbase/pull/4820#issuecomment-1407379250 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

[jira] [Commented] (HBASE-26967) FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681557#comment-17681557 ] Duo Zhang commented on HBASE-26967: --- Ah, actually I'm not very familiar with FuzzyRowFilter in the

[GitHub] [hbase] chaijunjie0101 opened a new pull request, #4820: HBASE-26967 FilterList with FuzzyRowFilter and SingleColumnValueFilte…

2023-01-28 Thread via GitHub
chaijunjie0101 opened a new pull request, #4820: URL: https://github.com/apache/hbase/pull/4820 …r evaluated with operator MUST_PASS_ONE doesn't work as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache9 commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-01-28 Thread via GitHub
Apache9 commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407367499 @frostruan Mind taking a look at this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache-HBase commented on pull request #4998: HBASE-27598 Upgrade mockito to 4.x

2023-01-28 Thread via GitHub
Apache-HBase commented on PR #4998: URL: https://github.com/apache/hbase/pull/4998#issuecomment-1407365701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] mosmeh commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-01-28 Thread via GitHub
mosmeh commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407357024 Thank you, I was not aware of [HBASE-27463](https://issues.apache.org/jira/browse/HBASE-27463). The PR https://github.com/apache/hbase/pull/4863 does seem to address

[jira] [Commented] (HBASE-27523) Add BulkLoad bandwidth throttling

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681547#comment-17681547 ] Duo Zhang commented on HBASE-27523: --- This should be a new feature? Please fill the description about

[GitHub] [hbase] Apache9 commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-01-28 Thread via GitHub
Apache9 commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407347523 HBASE-27463 is not enough to fix the metrics problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HBASE-27461) Add multiWAL support for Replication Observability framework.

2023-01-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681546#comment-17681546 ] Duo Zhang commented on HBASE-27461: --- Do we have any plan to implement this? > Add multiWAL support

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-28 Thread via GitHub
bbeaudreault commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1089688575 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## @@ -3616,8 +3620,9 @@ public ScanResponse scan(final RpcController

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4967: HBASE-27558 Scan quotas and limits should account for total block IO

2023-01-28 Thread via GitHub
bbeaudreault commented on code in PR #4967: URL: https://github.com/apache/hbase/pull/4967#discussion_r1089687483 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java: ## @@ -140,4 +141,11 @@ public interface HFileScanner extends Shipper, Closeable {

[jira] [Created] (HBASE-27598) Upgrade mockito to 4.x

2023-01-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-27598: - Summary: Upgrade mockito to 4.x Key: HBASE-27598 URL: https://issues.apache.org/jira/browse/HBASE-27598 Project: HBase Issue Type: Improvement