[GitHub] [hbase-connectors] Reidddddd commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
Reidd commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1665063231 >> then tsNow - x._2.timestamp > timeout will never be triggered. it is a wrong if your sayings is correct. and in fact what it does it just same to yours, to close t

[GitHub] [hbase-connectors] wForget commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
wForget commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1665056202 > sounds like this logic is wrong I prefer that they are different logics. > can we just update the timestamp logic here instead of introducing a new para Do yo

[GitHub] [hbase-connectors] Reidddddd commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
Reidd commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1665032080 >> is updated when the connection is closed hmm, sounds like this logic is wrong, can we just update the timestamp logic here instead of introducing a new para -

[GitHub] [hbase-connectors] wForget commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
wForget commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1665010315 > it also has a `timeout` para, also remove from connectionMap. > > why still need to introduce max live limit. As in the previous example, `SmartConnection.timestamp`

[jira] [Resolved] (HBASE-27625) Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to support jdk11

2023-08-03 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-27625. --- Fix Version/s: hbase-connectors-1.0.1 Hadoop Flags: Reviewed Resolution: Fixed > Bump co

[GitHub] [hbase-connectors] Reidddddd merged pull request #116: HBASE-27625 Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to support jdk11

2023-08-03 Thread via GitHub
Reidd merged PR #116: URL: https://github.com/apache/hbase-connectors/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hb

[jira] [Updated] (HBASE-27625) Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to support jdk11

2023-08-03 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-27625: -- Summary: Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to s

[GitHub] [hbase-connectors] stoty commented on pull request #116: HBASE-27625 Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to support jdk11

2023-08-03 Thread via GitHub
stoty commented on PR #116: URL: https://github.com/apache/hbase-connectors/pull/116#issuecomment-1664986789 Thank you @Reidd . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [hbase-connectors] Reidddddd commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
Reidd commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1664950132 not really understand and still confused what's the difference with this block ``` if(forceClean || ((x._2.refCount <= 0) && (tsNow - x._2.timestamp > timeo

[GitHub] [hbase-connectors] Reidddddd commented on pull request #116: HBASE-27625 Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to support jdk11

2023-08-03 Thread via GitHub
Reidd commented on PR #116: URL: https://github.com/apache/hbase-connectors/pull/116#issuecomment-1664917677 @stoty sir, is it good to go, waiting for your approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Resolved] (HBASE-26863) Rowkey pushdown does not work with complex conditions

2023-08-03 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-26863. --- Fix Version/s: hbase-connectors-1.0.1 Hadoop Flags: Reviewed Resolution: Fixed > Rowkey

[GitHub] [hbase-connectors] Reidddddd merged pull request #95: HBASE-26863 fix incorrect rowkey pushdown

2023-08-03 Thread via GitHub
Reidd merged PR #95: URL: https://github.com/apache/hbase-connectors/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbas

[jira] [Commented] (HBASE-26494) Using RefCnt to fix the flawed MemStoreLABImpl

2023-08-03 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750932#comment-17750932 ] Duo Zhang commented on HBASE-26494: --- Maybe it just exposed an old bug… > Using RefCnt

[jira] [Commented] (HBASE-26494) Using RefCnt to fix the flawed MemStoreLABImpl

2023-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750929#comment-17750929 ] Viraj Jasani commented on HBASE-26494: -- probable cause for HBASE-27941? > Using Re

[jira] [Comment Edited] (HBASE-27941) Possible memory leak in MemStoreLAB implementation

2023-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750913#comment-17750913 ] Viraj Jasani edited comment on HBASE-27941 at 8/4/23 12:48 AM: ---

[jira] [Comment Edited] (HBASE-27941) Possible memory leak in MemStoreLAB implementation

2023-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750913#comment-17750913 ] Viraj Jasani edited comment on HBASE-27941 at 8/4/23 12:45 AM: ---

[jira] [Comment Edited] (HBASE-27941) Possible memory leak in MemStoreLAB implementation

2023-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750913#comment-17750913 ] Viraj Jasani edited comment on HBASE-27941 at 8/4/23 12:43 AM: ---

[jira] [Commented] (HBASE-27941) Possible memory leak in MemStoreLAB implementation

2023-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750913#comment-17750913 ] Viraj Jasani commented on HBASE-27941: -- [~zhangduo] i came across this today on lat

[jira] [Commented] (HBASE-27896) Disable hdfs readahead for pread reads

2023-08-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750873#comment-17750873 ] Hudson commented on HBASE-27896: Results for branch branch-3 [build #25 on buil

[jira] [Commented] (HBASE-27896) Disable hdfs readahead for pread reads

2023-08-03 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750871#comment-17750871 ] Hudson commented on HBASE-27896: Results for branch master [build #881 on build

[GitHub] [hbase] Apache-HBase commented on pull request #5341: HBASE-28004 Persistent cache map can get corrupt if crash happens midway through the write

2023-08-03 Thread via GitHub
Apache-HBase commented on PR #5341: URL: https://github.com/apache/hbase/pull/5341#issuecomment-1663972707 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker

[GitHub] [hbase] Apache-HBase commented on pull request #5341: HBASE-28004 Persistent cache map can get corrupt if crash happens midway through the write

2023-08-03 Thread via GitHub
Apache-HBase commented on PR #5341: URL: https://github.com/apache/hbase/pull/5341#issuecomment-1663958797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #95: HBASE-26863 fix incorrect rowkey pushdown

2023-08-03 Thread via GitHub
Apache-HBase commented on PR #95: URL: https://github.com/apache/hbase-connectors/pull/95#issuecomment-1663903346 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[jira] [Commented] (HBASE-27996) Remove InterfaceStability.Stable from HTable

2023-08-03 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750719#comment-17750719 ] Bryan Beaudreault commented on HBASE-27996: --- Thanks for the input. I submitted

[GitHub] [hbase-connectors] Reidddddd commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
Reidd commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1663694316 > > so with this patch, even live connections will be cleaned up? > > isn't the purpose to clean the token expired connections? > > The connections that are being referen

[jira] [Resolved] (HBASE-27997) Enhance prefetch executor to record region prefetch information along with the list of hfiles prefetched

2023-08-03 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-27997. -- Resolution: Done > Enhance prefetch executor to record region prefetch informa

[jira] [Updated] (HBASE-27997) Enhance prefetch executor to record region prefetch information along with the list of hfiles prefetched

2023-08-03 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27997: - Affects Version/s: 3.0.0-alpha-4 2.6.0 > Enhance prefetch

[GitHub] [hbase-connectors] wForget commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
wForget commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1663640355 > so with this patch, even live connections will be cleaned up? > > isn't the purpose to clean the token expired connections? The connections that are being referenced

[GitHub] [hbase] Apache-HBase commented on pull request #5342: HBASE-27998 Enhance region metrics to include prefetch ratio for each…

2023-08-03 Thread via GitHub
Apache-HBase commented on PR #5342: URL: https://github.com/apache/hbase/pull/5342#issuecomment-1663596523 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker

[jira] [Updated] (HBASE-27997) Enhance prefetch executor to record region prefetch information along with the list of hfiles prefetched

2023-08-03 Thread Rahul Agarkar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Agarkar updated HBASE-27997: -- Description: HBASE-27313 implemented the prefetch persistence feature where it persists the l

[GitHub] [hbase] Apache-HBase commented on pull request #5341: HBASE-28004 Persistent cache map can get corrupt if crash happens midway through the write

2023-08-03 Thread via GitHub
Apache-HBase commented on PR #5341: URL: https://github.com/apache/hbase/pull/5341#issuecomment-1663582786 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docke

[GitHub] [hbase] Apache-HBase commented on pull request #5342: HBASE-27998 Enhance region metrics to include prefetch ratio for each…

2023-08-03 Thread via GitHub
Apache-HBase commented on PR #5342: URL: https://github.com/apache/hbase/pull/5342#issuecomment-1663582334 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #118: HBASE-27658: Add max live time limit for cached connections

2023-08-03 Thread via GitHub
Apache-HBase commented on PR #118: URL: https://github.com/apache/hbase-connectors/pull/118#issuecomment-1663506318 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s