Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951871696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

[jira] [Commented] (HBASE-27949) [JDK17] Add JDK17 compilation and unit test support to nightly job

2024-02-18 Thread tianhang tang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818363#comment-17818363 ] tianhang tang commented on HBASE-27949: --- Hi [~rajeshbabu] I'm sorry I haven't started working on

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-1951846434 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-1951833326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[jira] [Commented] (HBASE-28238) rpcservice should perform some important admin operation to priority ADMIN_QOS

2024-02-18 Thread Rajeshbabu Chintaguntla (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818341#comment-17818341 ] Rajeshbabu Chintaguntla commented on HBASE-28238: - [~selina.yan] Pushed the changes to

[jira] [Comment Edited] (HBASE-28238) rpcservice should perform some important admin operation to priority ADMIN_QOS

2024-02-18 Thread Rajeshbabu Chintaguntla (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818341#comment-17818341 ] Rajeshbabu Chintaguntla edited comment on HBASE-28238 at 2/19/24 4:46 AM:

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s |

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951670031 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Updated] (HBASE-28238) rpcservice should perform some important admin operation to priority ADMIN_QOS

2024-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28238: --- Labels: pull-request-available (was: ) > rpcservice should perform some important admin

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951668916 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951668899 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951669618 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5689: URL: https://github.com/apache/hbase/pull/5689#issuecomment-1951669151 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

Re: [PR] HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS [hbase]

2024-02-18 Thread via GitHub
chrajeshbabu merged PR #5558: URL: https://github.com/apache/hbase/pull/5558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
chrajeshbabu commented on code in PR #5689: URL: https://github.com/apache/hbase/pull/5689#discussion_r1493988246 ## dev-support/Jenkinsfile: ## @@ -628,6 +630,118 @@ pipeline { } } } + +stage ('yetus jdk17 hadoop3 checks') { Review

[jira] [Updated] (HBASE-27949) [JDK17] Add JDK17 compilation and unit test support to nightly job

2024-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-27949: --- Labels: pull-request-available (was: ) > [JDK17] Add JDK17 compilation and unit test

Re: [PR] HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to ni… [hbase]

2024-02-18 Thread via GitHub
chrajeshbabu commented on code in PR #5689: URL: https://github.com/apache/hbase/pull/5689#discussion_r1493987791 ## dev-support/docker/Dockerfile: ## @@ -110,6 +110,13 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"] RUN curl --location --fail --silent --show-error --output

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951657370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28183 It's impossible to re-enable the quota table if it gets d… [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5691: URL: https://github.com/apache/hbase/pull/5691#issuecomment-1951632917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951621133 Let me fix the failed UT, seems we could also have other types of exceptions when server close the connection. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (HBASE-28183) It's impossible to re-enable the quota table if it gets disabled

2024-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28183: --- Labels: pull-request-available (was: ) > It's impossible to re-enable the quota table if

[jira] [Assigned] (HBASE-28183) It's impossible to re-enable the quota table if it gets disabled

2024-02-18 Thread Chandra Sekhar K (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandra Sekhar K reassigned HBASE-28183: Assignee: Chandra Sekhar K > It's impossible to re-enable the quota table if it

[jira] [Updated] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28142: --- Priority: Minor (was: Major) > Region Server Logs getting spammed with warning when storefile has

[jira] [Resolved] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain resolved HBASE-28142. Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.6+. Thanks for the PR

[jira] [Updated] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28142: --- Fix Version/s: 2.6.0 2.7.0 3.0.0-beta-2 > Region Server Logs

[jira] [Updated] (HBASE-28142) Region Server Logs getting spammed with warning when storefile has no reader

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28142: --- Summary: Region Server Logs getting spammed with warning when storefile has no reader (was:

[jira] [Commented] (HBASE-25749) Improved logging when interrupting active RPC handlers holding the region close lock (HBASE-25212 hbase.regionserver.close.wait.abort)

2024-02-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818311#comment-17818311 ] Viraj Jasani commented on HBASE-25749: -- [~umesh9414] granted you with the contributor access, you

[jira] [Assigned] (HBASE-25749) Improved logging when interrupting active RPC handlers holding the region close lock (HBASE-25212 hbase.regionserver.close.wait.abort)

2024-02-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-25749: Assignee: Umesh Kumar Kumawat > Improved logging when interrupting active RPC handlers

[jira] [Commented] (HBASE-28366) Mis-order of SCP and regionServerReport results into region inconsistencies

2024-02-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818310#comment-17818310 ] Viraj Jasani commented on HBASE-28366: -- {quote}And for regionServerReport, we used to make use of

[jira] [Comment Edited] (HBASE-28366) Mis-order of SCP and regionServerReport results into region inconsistencies

2024-02-18 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818310#comment-17818310 ] Viraj Jasani edited comment on HBASE-28366 at 2/18/24 8:21 PM: --- {quote}And

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951429766 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] [HBASE-28142] Region Server Logs getting spammed with warning when st… [hbase]

2024-02-18 Thread via GitHub
NihalJain merged PR #5685: URL: https://github.com/apache/hbase/pull/5685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818308#comment-17818308 ] Nihal Jain commented on HBASE-28367: Pushed to branch-2.6 and branch-2. Thanks for the review

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5683: URL: https://github.com/apache/hbase/pull/5683#issuecomment-1951427201 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[jira] [Updated] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28367: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Backport "HBASE-27811 Enable

[jira] [Updated] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28367: --- Fix Version/s: 2.7.0 > Backport "HBASE-27811 Enable cache control for logs endpoint and set max

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5683: URL: https://github.com/apache/hbase/pull/5683#issuecomment-1951426877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951427028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[jira] [Updated] (HBASE-28367) Backport "HBASE-27811 Enable cache control for logs endpoint and set max age as 0" to branch-2

2024-02-18 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28367: --- Fix Version/s: 2.6.0 > Backport "HBASE-27811 Enable cache control for logs endpoint and set max

Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951425569 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951425250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28367 Backport "HBASE-27811 Enable cache control for logs endpo… [hbase]

2024-02-18 Thread via GitHub
NihalJain merged PR #5679: URL: https://github.com/apache/hbase/pull/5679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
rmdmattingly commented on code in PR #5683: URL: https://github.com/apache/hbase/pull/5683#discussion_r1493805682 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java: ## @@ -131,7 +131,8 @@ public void close() { @Override public long

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951372283 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
bbeaudreault commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951371107 I'm not an expert on sasl. It makes some sense that if we fallback to simple, we don't need a saslRpcClient. But can you explain a little more what the issue was and why this change

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5683: URL: https://github.com/apache/hbase/pull/5683#issuecomment-1951371002 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951370799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951359539 @bbeaudreault We need to fix this before landing HBASE-28321. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951359301 The fix itself is very simple, just set `saslRpcClient` to `null` when we want to fallback to simple auth at client side. The most important changes are the newly added tests in

[jira] [Updated] (HBASE-28377) Fallback to simple is broken for blocking rpc client

2024-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28377: --- Labels: pull-request-available (was: ) > Fallback to simple is broken for blocking rpc

[PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 opened a new pull request, #5690: URL: https://github.com/apache/hbase/pull/5690 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2

2024-02-18 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28376: -- Priority: Blocker (was: Major) > Column family ns does not exist in region during

[jira] [Updated] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2

2024-02-18 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28376: -- Affects Version/s: 3.0.0-beta-1 > Column family ns does not exist in region during

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
bbeaudreault commented on code in PR #5683: URL: https://github.com/apache/hbase/pull/5683#discussion_r1493789446 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java: ## @@ -131,7 +131,8 @@ public void close() { @Override public long

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
rmdmattingly commented on code in PR #5683: URL: https://github.com/apache/hbase/pull/5683#discussion_r1493788632 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java: ## @@ -131,7 +131,8 @@ public void close() { @Override public long

Re: [PR] HBASE-28370 Set `updateTs` on default UserQuotaState [hbase]

2024-02-18 Thread via GitHub
rmdmattingly commented on PR #5686: URL: https://github.com/apache/hbase/pull/5686#issuecomment-1951356592 Oh, I just forgot the @ClassRule. Pushing a fix now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on code in PR #5683: URL: https://github.com/apache/hbase/pull/5683#discussion_r1493787434 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java: ## @@ -131,7 +131,8 @@ public void close() { @Override public long

[jira] [Commented] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2

2024-02-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818297#comment-17818297 ] Duo Zhang commented on HBASE-28376: --- It should be a blocker. Will take a look soon, after fixing

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
bbeaudreault commented on code in PR #5683: URL: https://github.com/apache/hbase/pull/5683#discussion_r1493785086 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java: ## @@ -131,7 +131,8 @@ public void close() { @Override public long

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
rmdmattingly commented on code in PR #5683: URL: https://github.com/apache/hbase/pull/5683#discussion_r1493784706 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java: ## @@ -131,7 +131,8 @@ public void close() { @Override public long

[jira] [Commented] (HBASE-28376) Column family ns does not exist in region during upgrade to 3.0.0-beta-2

2024-02-18 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818293#comment-17818293 ] Bryan Beaudreault commented on HBASE-28376: --- [~zhangduo] this should probably be a blocker for

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5688: URL: https://github.com/apache/hbase/pull/5688#issuecomment-1951262986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

[jira] [Updated] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server

2024-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28321: --- Labels: pull-request-available (was: ) > RpcConnectionRegistry is broken when security is

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5688: URL: https://github.com/apache/hbase/pull/5688#issuecomment-1951244869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic… [hbase]

2024-02-18 Thread via GitHub
NihalJain commented on PR #5680: URL: https://github.com/apache/hbase/pull/5680#issuecomment-1951156370 Yes I have checked the test failures ate related. There's more changes needed for hadoop2. In hadoop 2 the version of directory services used is different from what we are importing for

Re: [PR] HBASE-28368 Backport "HBASE-27693 Support for Hadoop's LDAP Authentic… [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on PR #5680: URL: https://github.com/apache/hbase/pull/5680#issuecomment-1951108254 The failure for jdk8 hadoop2 is related? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (HBASE-28378) Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit

2024-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28378: --- Labels: pull-request-available (was: ) > Bump cryptography from 42.0.0 to 42.0.2 in

[jira] [Resolved] (HBASE-28378) Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit

2024-02-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28378. --- Fix Version/s: 4.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed > Bump

[jira] [Created] (HBASE-28378) Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit

2024-02-18 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28378: - Summary: Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit Key: HBASE-28378 URL: https://issues.apache.org/jira/browse/HBASE-28378 Project:

Re: [PR] HBASE-28378 Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit [hbase]

2024-02-18 Thread via GitHub
Apache9 merged PR #5687: URL: https://github.com/apache/hbase/pull/5687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28359 Improve quota RateLimiter synchronization [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on code in PR #5683: URL: https://github.com/apache/hbase/pull/5683#discussion_r1493729696 ## hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RateLimiter.java: ## @@ -135,18 +135,31 @@ protected synchronized long getTimeUnitInMillis() { /**

[jira] [Commented] (HBASE-28366) Mis-order of SCP and regionServerReport results into region inconsistencies

2024-02-18 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818267#comment-17818267 ] Duo Zhang commented on HBASE-28366: --- If the new server has already bound to the same port, how could