[jira] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2024-02-28 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048 ] Andrew Kyle Purtell deleted comment on HBASE-28048: - was (Author: apurtell): Moving out of 2.5.6 > RSProcedureDispatcher to abort executing request after configurable retries >

[jira] [Commented] (HBASE-28048) RSProcedureDispatcher to abort executing request after configurable retries

2024-02-28 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821980#comment-17821980 ] Andrew Kyle Purtell commented on HBASE-28048: - {quote}When Master recognizes that the

[jira] [Resolved] (HBASE-28313) StorefileRefresherChore should not refresh readonly table

2024-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28313. --- Fix Version/s: 2.6.0 2.4.18 2.5.8

Re: [PR] HBASE-28394 Attach the design doc for preamble call to our code base [hbase]

2024-02-28 Thread via GitHub
Apache9 merged PR #5716: URL: https://github.com/apache/hbase/pull/5716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-28342) Decommissioned hosts should be rejected by the HMaster

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821961#comment-17821961 ] Hudson commented on HBASE-28342: Results for branch branch-2 [build #999 on

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821962#comment-17821962 ] Hudson commented on HBASE-28384: Results for branch branch-2 [build #999 on

[jira] [Commented] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821963#comment-17821963 ] Hudson commented on HBASE-28321: Results for branch branch-2 [build #999 on

[jira] [Updated] (HBASE-28313) StorefileRefresherChore should not refresh readonly table

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28313: --- Labels: pull-request-available (was: ) > StorefileRefresherChore should not refresh

[jira] [Assigned] (HBASE-28313) StorefileRefresherChore should not refresh readonly table

2024-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28313: - Assignee: Hao Sun > StorefileRefresherChore should not refresh readonly table >

[jira] [Updated] (HBASE-28313) StorefileRefresherChore should not refresh readonly table

2024-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28313: -- Fix Version/s: (was: 2.4.17) > StorefileRefresherChore should not refresh readonly table >

Re: [PR] HBASE-28313 StorefileRefresherChore should not refresh readonly table [hbase]

2024-02-28 Thread via GitHub
Apache9 merged PR #5641: URL: https://github.com/apache/hbase/pull/5641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28350 [JDK17] Unable to run hbase-it tests with JDK 17 [hbase]

2024-02-28 Thread via GitHub
chrajeshbabu commented on code in PR #5712: URL: https://github.com/apache/hbase/pull/5712#discussion_r1507045268 ## hbase-it/pom.xml: ## @@ -336,6 +338,11 @@ [1.11,) + + Review Comment: Thanks @ndimiduk. It's good suggestion. Will

Re: [PR] HBASE-28350 [JDK17] Unable to run hbase-it tests with JDK 17 [hbase]

2024-02-28 Thread via GitHub
chrajeshbabu commented on code in PR #5712: URL: https://github.com/apache/hbase/pull/5712#discussion_r1507044859 ## hbase-it/pom.xml: ## @@ -282,9 +287,6 @@ 1800 - -enableassertions -Xmx${failsafe.Xmx} Review Comment: @Apache9 it's working.

Re: [PR] HBASE-28381 Support building hbase-operator-tools with JDK17 [hbase-operator-tools]

2024-02-28 Thread via GitHub
NihalJain commented on PR #141: URL: https://github.com/apache/hbase-operator-tools/pull/141#issuecomment-1970417890 Added support to build against JDK11, JDK17 here while making sure we can still build with JDK8. The flags are added as tests fail without them. Tested locally by running

[jira] [Commented] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821928#comment-17821928 ] Hudson commented on HBASE-28391: Results for branch branch-2.6 [build #64 on

[jira] [Commented] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821931#comment-17821931 ] Hudson commented on HBASE-28321: Results for branch branch-2.6 [build #64 on

[jira] [Commented] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821930#comment-17821930 ] Hudson commented on HBASE-28384: Results for branch branch-2.6 [build #64 on

[jira] [Commented] (HBASE-28342) Decommissioned hosts should be rejected by the HMaster

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821929#comment-17821929 ] Hudson commented on HBASE-28342: Results for branch branch-2.6 [build #64 on

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-28 Thread via GitHub
chrajeshbabu commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1506974092 ## pom.xml: ## @@ -1531,21 +1530,30 @@ -org.glassfish.web -javax.servlet.jsp -${glassfish.jsp.version} +

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1970103084 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1970090047 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5713: URL: https://github.com/apache/hbase/pull/5713#issuecomment-1970069089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 10s |

Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5713: URL: https://github.com/apache/hbase/pull/5713#issuecomment-1970053765 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28342 changes to DecommissionedHostRejectedException interface (addendum) [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5717: URL: https://github.com/apache/hbase/pull/5717#issuecomment-1969952136 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28342 changes to DecommissionedHostRejectedException interface (addendum) [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5717: URL: https://github.com/apache/hbase/pull/5717#issuecomment-1969896260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[jira] [Commented] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821863#comment-17821863 ] Hudson commented on HBASE-28391: Results for branch branch-3 [build #157 on

[jira] [Commented] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821862#comment-17821862 ] Hudson commented on HBASE-28391: Results for branch master [build #1022 on

Re: [PR] HBASE-28381 Support building hbase-operator-tools with JDK17 [hbase-operator-tools]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #141: URL: https://github.com/apache/hbase-operator-tools/pull/141#issuecomment-1969808660 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Commented] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821856#comment-17821856 ] Hudson commented on HBASE-28391: Results for branch branch-2.5 [build #487 on

Re: [PR] HBASE-28381 Support building hbase-operator-tools with JDK17 [hbase-operator-tools]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #141: URL: https://github.com/apache/hbase-operator-tools/pull/141#issuecomment-1969755385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[jira] [Updated] (HBASE-28381) Support building hbase-operator-tools with JDK17

2024-02-28 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28381: --- Summary: Support building hbase-operator-tools with JDK17 (was: Allow building

[jira] [Updated] (HBASE-28381) Allow building hbase-operator-tools with JDK17

2024-02-28 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28381: --- Summary: Allow building hbase-operator-tools with JDK17 (was: Build hbase-operator-tools with

[PR] HBASE-28381 Build hbase-operator-tools with JDK17 [hbase-operator-tools]

2024-02-28 Thread via GitHub
NihalJain opened a new pull request, #141: URL: https://github.com/apache/hbase-operator-tools/pull/141 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HBASE-28391) Remove the need for ADMIN permissions for listDecommissionedRegionServers

2024-02-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821823#comment-17821823 ] Hudson commented on HBASE-28391: Results for branch branch-2 [build #998 on

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5607: URL: https://github.com/apache/hbase/pull/5607#issuecomment-1969565681 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[jira] [Commented] (HBASE-28409) Cleanup / Resurrect hbase-table-reporter

2024-02-28 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821794#comment-17821794 ] Nihal Jain commented on HBASE-28409: Thank you so much for the help [~stoty] :) > Cleanup /

[jira] [Updated] (HBASE-28409) Cleanup / Resurrect hbase-table-reporter

2024-02-28 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28409: --- Component/s: hbase-operator-tools > Cleanup / Resurrect hbase-table-reporter >

Re: [PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5718: URL: https://github.com/apache/hbase/pull/5718#issuecomment-1969528857 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5718: URL: https://github.com/apache/hbase/pull/5718#issuecomment-1969526269 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[jira] [Comment Edited] (HBASE-28409) Cleanup / Resurrect hbase-table-reporter

2024-02-28 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821793#comment-17821793 ] Istvan Toth edited comment on HBASE-28409 at 2/28/24 5:45 PM: -- I have moved

[jira] [Commented] (HBASE-28409) Cleanup / Resurrect hbase-table-reporter

2024-02-28 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821793#comment-17821793 ] Istvan Toth commented on HBASE-28409: - Done. > Cleanup / Resurrect hbase-table-reporter >

[jira] [Moved] (HBASE-28409) Cleanup / Resurrect hbase-table-reporter

2024-02-28 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth moved PHOENIX-7242 to HBASE-28409: -- Key: HBASE-28409 (was: PHOENIX-7242) Project: HBase (was:

Re: [PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5718: URL: https://github.com/apache/hbase/pull/5718#issuecomment-1969513991 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[jira] [Work started] (HBASE-28381) Build hbase-operator-tools with JDK17

2024-02-28 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28381 started by Nihal Jain. -- > Build hbase-operator-tools with JDK17 > - >

Re: [PR] HBASE-28385 make Scan estimates more realistic [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5713: URL: https://github.com/apache/hbase/pull/5713#issuecomment-1969496229 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-28 Thread via GitHub
NihalJain commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1506311515 ## pom.xml: ## @@ -1531,21 +1530,30 @@ -org.glassfish.web -javax.servlet.jsp -${glassfish.jsp.version} +

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-28 Thread via GitHub
NihalJain commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1506311515 ## pom.xml: ## @@ -1531,21 +1530,30 @@ -org.glassfish.web -javax.servlet.jsp -${glassfish.jsp.version} +

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
frostruan commented on code in PR #5699: URL: https://github.com/apache/hbase/pull/5699#discussion_r1506303056 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -115,7 +116,7 @@ public long getRegionSize(byte[] regionId) {

[jira] [Updated] (HBASE-28408) Confusing logging during backup restore

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28408: --- Labels: pull-request-available (was: ) > Confusing logging during backup restore >

[PR] HBASE-28408 Rephrase confusing log message [hbase]

2024-02-28 Thread via GitHub
DieterDP-ng opened a new pull request, #5718: URL: https://github.com/apache/hbase/pull/5718 Assume a user has a series of backups: Full1, Inc2, Inc3, where a table has not changed between Full1 and Inc3, but has changed after Inc3. When restoring that table to Inc3, a log warning was

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
frostruan commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1969449215 > Out of curiosity, what remaining problems do you see that need attention? Can we write a quick ticket describing them? I'll see if there's appetite in the team

Re: [PR] HBASE-28070 Replace javax.servlet.jsp dependency with tomcat-jasper [hbase]

2024-02-28 Thread via GitHub
NihalJain commented on code in PR #5607: URL: https://github.com/apache/hbase/pull/5607#discussion_r1506297773 ## pom.xml: ## @@ -1531,21 +1530,30 @@ -org.glassfish.web -javax.servlet.jsp -${glassfish.jsp.version} +

Re: [PR] HBASE-28342 changes to DecommissionedHostRejectedException interface (addendum) [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5717: URL: https://github.com/apache/hbase/pull/5717#issuecomment-1969445910 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-28 Thread via GitHub
frostruan commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1506288550 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-28 Thread via GitHub
frostruan commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1506288199 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

[jira] [Created] (HBASE-28408) Confusing logging during backup restore

2024-02-28 Thread Dieter De Paepe (Jira)
Dieter De Paepe created HBASE-28408: --- Summary: Confusing logging during backup restore Key: HBASE-28408 URL: https://issues.apache.org/jira/browse/HBASE-28408 Project: HBase Issue Type:

[jira] [Commented] (HBASE-28399) region size can be wrong from RegionSizeCalculator

2024-02-28 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821761#comment-17821761 ] ruanhui commented on HBASE-28399: - [~zhangduo] HBASE-26609 fixed the precision problem for storefiles.

[jira] [Commented] (HBASE-28399) region size can be wrong from RegionSizeCalculator

2024-02-28 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821756#comment-17821756 ] ruanhui commented on HBASE-28399: - [~ndimiduk] Yes, it is easy to miss data with

Re: [PR] HBASE-28342 changes to DecommissionedHostRejectedException interface (addendum) [hbase]

2024-02-28 Thread via GitHub
aalhour commented on PR #5717: URL: https://github.com/apache/hbase/pull/5717#issuecomment-1969365404 Cool, thanks for taking care of this, I was going to message you about doing this tomorrow  -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] HBASE-28342 changes to DecommissionedHostRejectedException interface (addendum) [hbase]

2024-02-28 Thread via GitHub
ndimiduk opened a new pull request, #5717: URL: https://github.com/apache/hbase/pull/5717 Addendum to #5681. FYI @aalhour -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HBASE-28394 Attach the design doc for preamble call to our code base [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5716: URL: https://github.com/apache/hbase/pull/5716#issuecomment-1969287338 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28394 Attach the design doc for preamble call to our code base [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5716: URL: https://github.com/apache/hbase/pull/5716#issuecomment-1969281818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28394 Attach the design doc for preamble call to our code base [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5716: URL: https://github.com/apache/hbase/pull/5716#issuecomment-1969281260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28350 [JDK17] Unable to run hbase-it tests with JDK 17 [hbase]

2024-02-28 Thread via GitHub
Apache9 commented on code in PR #5712: URL: https://github.com/apache/hbase/pull/5712#discussion_r1506170361 ## hbase-it/pom.xml: ## @@ -282,9 +287,6 @@ 1800 - -enableassertions -Xmx${failsafe.Xmx} Review Comment: Does this really work if we

[jira] [Updated] (HBASE-28394) Attach the design doc for preamble call to our code base

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28394: --- Labels: pull-request-available (was: ) > Attach the design doc for preamble call to our

[PR] HBASE-28394 Attach the design doc for preamble call to our code base [hbase]

2024-02-28 Thread via GitHub
Apache9 opened a new pull request, #5716: URL: https://github.com/apache/hbase/pull/5716 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Assigned] (HBASE-28394) Attach the design doc for preamble call to our code base

2024-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28394: - Assignee: Duo Zhang > Attach the design doc for preamble call to our code base >

[jira] [Work started] (HBASE-28394) Attach the design doc for preamble call to our code base

2024-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28394 started by Duo Zhang. - > Attach the design doc for preamble call to our code base >

[jira] [Reopened] (HBASE-28342) Decommissioned hosts should be rejected by the HMaster

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-28342: -- Sorry, I missed something in review. Looking more closely at the other exceptions thrown, I

[jira] [Resolved] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server

2024-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28321. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Hadoop Flags: Reviewed Release Note:

[jira] [Commented] (HBASE-28342) Decommissioned hosts should be rejected by the HMaster

2024-02-28 Thread Ahmad Alhour (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821708#comment-17821708 ] Ahmad Alhour commented on HBASE-28342: -- Thanks for helping me finish this out [~ndimiduk]. >

Re: [PR] HBASE-28401 Introduce a close method for memstore for release active … [hbase]

2024-02-28 Thread via GitHub
Apache9 commented on PR #5705: URL: https://github.com/apache/hbase/pull/5705#issuecomment-1969181077 With this patch in place, there is no leak report in TestHRegion's log output now. I think we can apply this first, and then check whether there are still memory leak report in

[jira] [Updated] (HBASE-28342) Decommissioned hosts should be rejected by the HMaster

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28342: - Release Note: This change introduces the configuration

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-28 Thread via GitHub
Apache9 merged PR #5707: URL: https://github.com/apache/hbase/pull/5707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-28384) Client ingegration tests fails for branch-2/branch-2.6

2024-02-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28384. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Hadoop Flags: Reviewed Resolution:

Re: [PR] HBASE-28321 RpcConnectionRegistry is broken when security is enabled … [hbase]

2024-02-28 Thread via GitHub
Apache9 commented on PR #5707: URL: https://github.com/apache/hbase/pull/5707#issuecomment-1969168163 Tried several times, the failed UTs kept changing, and seems are all not related to the PR here. Let me merge. -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-28342) Decommissioned hosts should be rejected by the HMaster

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28342: - Component/s: master > Decommissioned hosts should be rejected by the HMaster >

Re: [PR] HBASE-28384 Client ingegration tests fails for branch-2/branch-2.6 [hbase]

2024-02-28 Thread via GitHub
Apache9 merged PR #5714: URL: https://github.com/apache/hbase/pull/5714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-28342) Decommissioned hosts should be rejected by the HMaster

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-28342: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed to master,

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2.6 [hbase]

2024-02-28 Thread via GitHub
ndimiduk merged PR #5704: URL: https://github.com/apache/hbase/pull/5704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2 [hbase]

2024-02-28 Thread via GitHub
ndimiduk merged PR #5703: URL: https://github.com/apache/hbase/pull/5703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2.6 [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5704: URL: https://github.com/apache/hbase/pull/5704#issuecomment-1969138511 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
ndimiduk commented on code in PR #5699: URL: https://github.com/apache/hbase/pull/5699#discussion_r1506076104 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -115,7 +116,7 @@ public long getRegionSize(byte[] regionId) {

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1969078658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1969066409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1969055381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2 [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5703: URL: https://github.com/apache/hbase/pull/5703#issuecomment-1969041821 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

[jira] [Commented] (HBASE-28399) region size can be wrong from RegionSizeCalculator

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821677#comment-17821677 ] Nick Dimiduk commented on HBASE-28399: -- spark.hadoopRDD.ignoreEmptySplits seems like a dangerous

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2.6 [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5704: URL: https://github.com/apache/hbase/pull/5704#issuecomment-1969032249 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28399 region size can be wrong from RegionSizeCalculator [hbase]

2024-02-28 Thread via GitHub
ndimiduk commented on code in PR #5700: URL: https://github.com/apache/hbase/pull/5700#discussion_r1505999650 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java: ## @@ -82,8 +81,8 @@ private void init(RegionLocator regionLocator, Admin

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2 [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5703: URL: https://github.com/apache/hbase/pull/5703#issuecomment-1969030899 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
aalhour commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1968994818 Awesome, thanks a lot @frostruan. I just pinged @ndimiduk to help me merge it. Out of curiosity, what remaining problems do you see that need attention? Can we write a quick ticket

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
frostruan commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1968846003 I think this PR is good enough to solve the problem it intends to solve. +1 ! I think there is still some room for optimization here, but this is another problem. We can

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1968754231 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 10s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1968753080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1968740262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2 [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5703: URL: https://github.com/apache/hbase/pull/5703#issuecomment-1968687820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] Backport "HBASE-28342 Decommissioned hosts should be rejected by the HMaster (#5681)" to branch-2.6 [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5704: URL: https://github.com/apache/hbase/pull/5704#issuecomment-1968684828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
aalhour commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1968675456 Hello @frostruan, thanks for clarifying, yeah that's in line with my previous thoughts, I was confused as to why we want to specify a byte and return it from a method that returns longs.

Re: [PR] HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition [hbase]

2024-02-28 Thread via GitHub
Apache-HBase commented on PR #5699: URL: https://github.com/apache/hbase/pull/5699#issuecomment-1968663119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

  1   2   >