Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116761057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[jira] [Updated] (HBASE-25972) Dual File Compaction

2024-05-16 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25972: - Fix Version/s: 2.7.0 3.0.0-beta-2 > Dual File Compaction >

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116695949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116690161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[jira] [Commented] (HBASE-28597) Support native Cell format in REST server and client

2024-05-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847154#comment-17847154 ] Istvan Toth commented on HBASE-28597: - I poked around in the code a bit. Looks like

[jira] [Updated] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted

2024-05-16 Thread Robin Infant A (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Infant A updated HBASE-28599: --- Environment: (was: hbase 2.5.5) > RowTooBigException is thrown when duplicate increment

[jira] [Updated] (HBASE-28561) Add separate fields for column family and qualifier in REST message formats

2024-05-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-28561: Issue Type: Wish (was: Improvement) > Add separate fields for column family and qualifier in

[jira] [Commented] (HBASE-28501) Support non-SPNEGO authentication methods and implement session handling in REST java client library

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847150#comment-17847150 ] Hudson commented on HBASE-28501: Results for branch branch-3 [build #206 on

[jira] (HBASE-28553) SSLContext not used for Kerberos auth negotiation in rest client

2024-05-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28553 ] Istvan Toth deleted comment on HBASE-28553: - was (Author: stoty): The fix is part of HBASE-28501 . > SSLContext not used for Kerberos auth negotiation in rest client >

[jira] [Commented] (HBASE-26625) ExportSnapshot tool failed to copy data files for tables with merge region

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847149#comment-17847149 ] Hudson commented on HBASE-26625: Results for branch branch-2.5 [build #529 on

[jira] [Commented] (HBASE-28501) Support non-SPNEGO authentication methods and implement session handling in REST java client library

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847148#comment-17847148 ] Hudson commented on HBASE-28501: Results for branch branch-2.5 [build #529 on

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
kadirozde commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116606679 > @kadirozde Looks like this needs spotless:apply too. I did run for the last commit. I will do it again if necessary. -- This is an automated message from the Apache Git

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

2024-05-16 Thread via GitHub
Apache9 commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1604318505 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName)

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116577923 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache9 commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116573873 Could you please provide more details about how it could be null when calling doShutdown? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

2024-05-16 Thread via GitHub
Apache9 commented on code in PR #5910: URL: https://github.com/apache/hbase/pull/5910#discussion_r1604312448 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## @@ -3787,7 +3798,7 @@ private void closeScanner(HRegion region, RegionScanner

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
apurtell commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116555259 @kadirozde Checkstyle nit fix and spotless:apply needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache9 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2116555130 Please run `mvn spotless:apply` before committing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116554682 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
apurtell commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116554565 @kadirozde Looks like this needs spotless:apply too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2116553080 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
apurtell merged PR #5545: URL: https://github.com/apache/hbase/pull/5545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116540777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604284847 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116510269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604229161 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604229161 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116437408 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116413160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116399777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116387909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116386243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116380266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116372709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116368238 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116366437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
kadirozde opened a new pull request, #5912: URL: https://github.com/apache/hbase/pull/5912 branch-3 PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] HBASE-25972 Dual File Compactor [hbase]

2024-05-16 Thread via GitHub
kadirozde opened a new pull request, #5911: URL: https://github.com/apache/hbase/pull/5911 branch-2 PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116324245 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2116289948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2116170934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2116161208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2116151131 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2116099063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[jira] [Commented] (HBASE-27938) Enable PE to load any custom implementation of tests at runtime

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847084#comment-17847084 ] Hudson commented on HBASE-27938: Results for branch master [build #1072 on

[jira] [Commented] (HBASE-28502) Backup manifest of full backup contains incomplete table list

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847083#comment-17847083 ] Hudson commented on HBASE-28502: Results for branch master [build #1072 on

[jira] [Commented] (HBASE-28501) Support non-SPNEGO authentication methods and implement session handling in REST java client library

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847085#comment-17847085 ] Hudson commented on HBASE-28501: Results for branch master [build #1072 on

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2116058076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116053675 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[jira] [Commented] (HBASE-27938) Enable PE to load any custom implementation of tests at runtime

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847077#comment-17847077 ] Hudson commented on HBASE-27938: Results for branch branch-2.6 [build #117 on

[jira] [Commented] (HBASE-28502) Backup manifest of full backup contains incomplete table list

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847078#comment-17847078 ] Hudson commented on HBASE-28502: Results for branch branch-2.6 [build #117 on

[jira] [Commented] (HBASE-27938) Enable PE to load any custom implementation of tests at runtime

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847074#comment-17847074 ] Hudson commented on HBASE-27938: Results for branch branch-2 [build #1055 on

[jira] [Commented] (HBASE-28502) Backup manifest of full backup contains incomplete table list

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847075#comment-17847075 ] Hudson commented on HBASE-28502: Results for branch branch-2 [build #1055 on

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116013173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s |

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-16 Thread via GitHub
csringhofer commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2115977393 Uploaded a server side fix for master: https://github.com/apache/hbase/pull/5910 Created a test that seemed consistent so far but had to modify RemoteWithExtrasException to

[PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
vineet4008 opened a new pull request, #5909: URL: https://github.com/apache/hbase/pull/5909 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (HBASE-27938) Enable PE to load any custom implementation of tests at runtime

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847053#comment-17847053 ] Hudson commented on HBASE-27938: Results for branch branch-2.5 [build #528 on

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2115727176 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

[jira] [Commented] (HBASE-28502) Backup manifest of full backup contains incomplete table list

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847031#comment-17847031 ] Hudson commented on HBASE-28502: Results for branch branch-3 [build #205 on

[jira] [Commented] (HBASE-27938) Enable PE to load any custom implementation of tests at runtime

2024-05-16 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847030#comment-17847030 ] Hudson commented on HBASE-27938: Results for branch branch-3 [build #205 on

[jira] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-16 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595 ] Michael Smith deleted comment on HBASE-28595: --- was (Author: JIRAUSER288956): I saw the OutOfOrderScannerException while working on various iterations of reproduction. I think it would

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-16 Thread Michael Smith (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847021#comment-17847021 ] Michael Smith commented on HBASE-28595: --- I saw the OutOfOrderScannerException while working on

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
wchevreuil commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1603657884 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2115619829 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[jira] [Commented] (HBASE-28522) UNASSIGN proc indefinitely stuck on dead rs

2024-05-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847004#comment-17847004 ] Duo Zhang commented on HBASE-28522: --- The PR for HBASE-28582 is ready, I also created a test for it to

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
vineet4008 commented on PR #5907: URL: https://github.com/apache/hbase/pull/5907#issuecomment-2115521657 @bbeaudreault @pankaj72981 Please review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HBASE-28469: Changes for enabling data-tiering checks during cacheOnWrite (compaction codepaths) [hbase]

2024-05-16 Thread via GitHub
wchevreuil commented on code in PR #5908: URL: https://github.com/apache/hbase/pull/5908#discussion_r1603543226 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java: ## @@ -57,6 +61,7 @@ import org.apache.yetus.audience.InterfaceAudience; import

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

2024-05-16 Thread via GitHub
csringhofer commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2115369059 I am working on creating unit tests for this - after that creating a server side fix doesn't seem hard. >I know that in impala, you want a client which can work with any HBase

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2115366847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2115325617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2115318057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115317652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115235512 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[jira] [Resolved] (HBASE-26625) ExportSnapshot tool failed to copy data files for tables with merge region

2024-05-16 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-26625. --- Resolution: Fixed I've merged the backport to branch-2.5 and added the next

[jira] [Updated] (HBASE-26625) ExportSnapshot tool failed to copy data files for tables with merge region

2024-05-16 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-26625: -- Fix Version/s: 2.5.9 > ExportSnapshot tool failed to copy data files for tables with

Re: [PR] HBASE-26625 ExportSnapshot tool failed to copy data files for tables with merge region [hbase]

2024-05-16 Thread via GitHub
bbeaudreault merged PR #5897: URL: https://github.com/apache/hbase/pull/5897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28469: Changes for enabling data-tiering checks during cacheOnWrite (compaction codepaths) [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5908: URL: https://github.com/apache/hbase/pull/5908#issuecomment-2115149273 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2115125977 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28469: Changes for enabling data-tiering checks during cacheOnWrite (compaction codepaths) [hbase]

2024-05-16 Thread via GitHub
jhungund commented on code in PR #5908: URL: https://github.com/apache/hbase/pull/5908#discussion_r1603223519 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java: ## @@ -553,16 +565,26 @@ private void writeInlineBlocks(boolean closing) throws

[jira] [Updated] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted

2024-05-16 Thread Robin Infant A (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Infant A updated HBASE-28599: --- Environment: hbase 2.5.5 > RowTooBigException is thrown when duplicate increment RPC call

[jira] [Created] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted

2024-05-16 Thread Robin Infant A (Jira)
Robin Infant A created HBASE-28599: -- Summary: RowTooBigException is thrown when duplicate increment RPC call is attempted Key: HBASE-28599 URL: https://issues.apache.org/jira/browse/HBASE-28599

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5907: URL: https://github.com/apache/hbase/pull/5907#issuecomment-2115005224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5907: URL: https://github.com/apache/hbase/pull/5907#issuecomment-2114941818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114890243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114854114 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114812889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

[jira] [Work started] (HBASE-28467) Integration of time-based priority caching into write and read code paths.

2024-05-16 Thread Janardhan Hungund (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28467 started by Janardhan Hungund. - > Integration of time-based priority caching into write and read

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

2024-05-16 Thread via GitHub
jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1602908275 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long

[jira] [Commented] (HBASE-28553) SSLContext not used for Kerberos auth negotiation in rest client

2024-05-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846878#comment-17846878 ] Istvan Toth commented on HBASE-28553: - The fix is part of HBASE-28501 . > SSLContext not used for

[jira] [Resolved] (HBASE-28553) SSLContext not used for Kerberos auth negotiation in rest client

2024-05-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth resolved HBASE-28553. - Resolution: Duplicate Fix included in HBASE-28501 > SSLContext not used for Kerberos auth

[jira] [Updated] (HBASE-28501) Support non-SPNEGO authentication methods and implement session handling in REST java client library

2024-05-16 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-28501: Fix Version/s: 2.4.18 2.7.0 3.0.0-beta-2

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2114510060 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

[jira] [Commented] (HBASE-28595) Losing exception from scan RPC can lead to partial results

2024-05-16 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846860#comment-17846860 ] Duo Zhang commented on HBASE-28595: --- The server side logic is for keep compatibility with some old

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5907: URL: https://github.com/apache/hbase/pull/5907#issuecomment-2114252818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114231887 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114226964 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-16 Thread via GitHub
stoty commented on PR #5881: URL: https://github.com/apache/hbase/pull/5881#issuecomment-2114199403 I have forgot to add the signed-off header. I will add it for the backports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-16 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2114199013 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28501 Support non-SPNEGO authentication methods and implement s… [hbase]

2024-05-16 Thread via GitHub
stoty merged PR #5881: URL: https://github.com/apache/hbase/pull/5881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-28598) NPE for writer object access in AsyncFSWAL#closeWriter

2024-05-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28598: --- Labels: pull-request-available (was: ) > NPE for writer object access in

  1   2   >