[jira] [Commented] (HBASE-20952) Re-visit the WAL API

[ https://issues.apache.org/jira/browse/HBASE-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558661#comment-16558661 ] Zach York commented on HBASE-20952: --- I definitely have some thoughts on this. I'll try to summarize

[jira] [Commented] (HBASE-20856) PITA having to set WAL provider in two places

[ https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553326#comment-16553326 ] Zach York commented on HBASE-20856: --- [~stack], [~busbey], or [~elserj] have any further comments? If

[jira] [Updated] (HBASE-20558) Backport HBASE-17854 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20558: -- Resolution: Fixed Fix Version/s: 1.4.6 1.5.0 Status: Resolved

[jira] [Commented] (HBASE-20558) Backport HBASE-17854 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551421#comment-16551421 ] Zach York commented on HBASE-20558: --- Ah! Perfect, thanks! > Backport HBASE-17854 to branch-1 >

[jira] [Commented] (HBASE-20558) Backport HBASE-17854 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551385#comment-16551385 ] Zach York commented on HBASE-20558: --- Note, this was done on branch-1. I was planning on doing the same

[jira] [Updated] (HBASE-20558) Backport HBASE-17854 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20558: -- Attachment: report.html > Backport HBASE-17854 to branch-1 > > >

[jira] [Commented] (HBASE-20558) Backport HBASE-17854 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551383#comment-16551383 ] Zach York commented on HBASE-20558: --- [~apurtell] I ran the compat-checker and it generated errors,

[jira] [Commented] (HBASE-20555) Backport HBASE-18083 and related changes in branch-1

[ https://issues.apache.org/jira/browse/HBASE-20555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551268#comment-16551268 ] Zach York commented on HBASE-20555: --- [~apurtell] FYI, I'd like to get the remaining two backports in

[jira] [Commented] (HBASE-20558) Backport HBASE-17854 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551260#comment-16551260 ] Zach York commented on HBASE-20558: --- +1 I will commit in an hour if no objections. > Backport

[jira] [Commented] (HBASE-20856) PITA having to set WAL provider in two places

[ https://issues.apache.org/jira/browse/HBASE-20856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549684#comment-16549684 ] Zach York commented on HBASE-20856: --- +1 Although that wrapped provider stuff is kinda ugly (not your

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542259#comment-16542259 ] Zach York commented on HBASE-20734: --- Thanks for reviewing [~yuzhih...@gmail.com]. I am trying to

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540796#comment-16540796 ] Zach York commented on HBASE-20734: --- Yep, I'll work on getting a patch for master branch. It was just

[jira] [Updated] (HBASE-18840) Add functionality to refresh meta table at master startup

[ https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-18840: -- Attachment: HBASE-18840.HBASE-18477.007.patch > Add functionality to refresh meta table at master

[jira] [Updated] (HBASE-20868) Fix TestCheckTestClasses on HBASE-18477

[ https://issues.apache.org/jira/browse/HBASE-20868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20868: -- Resolution: Fixed Status: Resolved (was: Patch Available) pushed to HBASE-18477 > Fix

[jira] [Updated] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20734: -- Status: Patch Available (was: Open) > Colocate recovered edits directory with hbase.wal.dir >

[jira] [Updated] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20734: -- Attachment: HBASE-20734.branch-1.001.patch > Colocate recovered edits directory with hbase.wal.dir >

[jira] [Commented] (HBASE-20649) Validate HFiles do not have PREFIX_TREE DataBlockEncoding

[ https://issues.apache.org/jira/browse/HBASE-20649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539329#comment-16539329 ] Zach York commented on HBASE-20649: --- Trying to get up to speed on this all. Overall looks like a handy

[jira] [Commented] (HBASE-20868) Fix TestCheckTestClasses on HBASE-18477

[ https://issues.apache.org/jira/browse/HBASE-20868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539278#comment-16539278 ] Zach York commented on HBASE-20868: --- [~yuzhih...@gmail.com] Can you take a look when you get a chance?

[jira] [Updated] (HBASE-20868) Fix TestCheckTestClasses on HBASE-18477

[ https://issues.apache.org/jira/browse/HBASE-20868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20868: -- Attachment: HBASE-20868.HBASE-18477.002.patch > Fix TestCheckTestClasses on HBASE-18477 >

[jira] [Updated] (HBASE-20868) Fix TestCheckTestClasses on HBASE-18477

[ https://issues.apache.org/jira/browse/HBASE-20868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20868: -- Status: Patch Available (was: Open) > Fix TestCheckTestClasses on HBASE-18477 >

[jira] [Updated] (HBASE-20868) Fix TestCheckTestClasses on HBASE-18477

[ https://issues.apache.org/jira/browse/HBASE-20868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20868: -- Attachment: HBASE-20868.HBASE-18477.001.patch > Fix TestCheckTestClasses on HBASE-18477 >

[jira] [Created] (HBASE-20868) Fix TestCheckTestClasses on HBASE-18477

Zach York created HBASE-20868: - Summary: Fix TestCheckTestClasses on HBASE-18477 Key: HBASE-20868 URL: https://issues.apache.org/jira/browse/HBASE-20868 Project: HBase Issue Type: Sub-task

[jira] [Updated] (HBASE-18840) Add functionality to refresh meta table at master startup

[ https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-18840: -- Attachment: HBASE-18840.HBASE-18477.006.patch > Add functionality to refresh meta table at master

[jira] [Resolved] (HBASE-20787) Rebase the HBASE-18477 onto the current master to continue dev

[ https://issues.apache.org/jira/browse/HBASE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York resolved HBASE-20787. --- Resolution: Fixed > Rebase the HBASE-18477 onto the current master to continue dev >

[jira] [Reopened] (HBASE-20787) Rebase the HBASE-18477 onto the current master to continue dev

[ https://issues.apache.org/jira/browse/HBASE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York reopened HBASE-20787: --- Rebasing again to pull in fixes for unit tests. > Rebase the HBASE-18477 onto the current master to

[jira] [Commented] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537664#comment-16537664 ] Zach York commented on HBASE-20836: --- Pushed, thanks [~yuzhih...@gmail.com] > Add Yetus annotation for

[jira] [Updated] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20836: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Add Yetus annotation for

[jira] [Updated] (HBASE-18840) Add functionality to refresh meta table at master startup

[ https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-18840: -- Attachment: HBASE-18840.HBASE-18477.005.patch > Add functionality to refresh meta table at master

[jira] [Commented] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537540#comment-16537540 ] Zach York commented on HBASE-20836: --- It looks like that did the trick. Can you commit when you get the

[jira] [Updated] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20836: -- Attachment: HBASE-20836.HBASE-18477.003.patch > Add Yetus annotation for

[jira] [Updated] (HBASE-20557) Backport HBASE-17215 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20557: -- Resolution: Fixed Fix Version/s: 1.4.6 1.5.0 Status: Resolved

[jira] [Commented] (HBASE-20557) Backport HBASE-17215 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537442#comment-16537442 ] Zach York commented on HBASE-20557: --- Pushed to branch-1 and branch-1.4. Checkcompatibility didn't

[jira] [Commented] (HBASE-20837) Make IDE configuration for import order match that in our checkstyle module

[ https://issues.apache.org/jira/browse/HBASE-20837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537342#comment-16537342 ] Zach York commented on HBASE-20837: --- [~taklwu] as mentioned in the email thread, this is a best effort

[jira] [Commented] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530569#comment-16530569 ] Zach York commented on HBASE-20836: --- [~yuzhih...@gmail.com] I'm not sure why the mvninstall and

[jira] [Commented] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530565#comment-16530565 ] Zach York commented on HBASE-20836: --- Added a new patch to add a private constructor. > Add Yetus

[jira] [Updated] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20836: -- Attachment: HBASE-20836.HBASE-18477.002.patch > Add Yetus annotation for

[jira] [Commented] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530488#comment-16530488 ] Zach York commented on HBASE-20836: --- FYI [~te...@apache.org] > Add Yetus annotation for

[jira] [Updated] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20836: -- Status: Patch Available (was: Open) > Add Yetus annotation for ReadReplicaClustersTableNameUtil >

[jira] [Updated] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

[ https://issues.apache.org/jira/browse/HBASE-20836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20836: -- Attachment: HBASE-20836.HBASE-18477.001.patch > Add Yetus annotation for

[jira] [Created] (HBASE-20836) Add Yetus annotation for ReadReplicaClustersTableNameUtil

Zach York created HBASE-20836: - Summary: Add Yetus annotation for ReadReplicaClustersTableNameUtil Key: HBASE-20836 URL: https://issues.apache.org/jira/browse/HBASE-20836 Project: HBase Issue

[jira] [Commented] (HBASE-18477) Umbrella JIRA for HBase Read Replica clusters

[ https://issues.apache.org/jira/browse/HBASE-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16530432#comment-16530432 ] Zach York commented on HBASE-18477: --- [~yuzhih...@gmail.com] Thanks for pointing out. I will address

[jira] [Commented] (HBASE-20557) Backport HBASE-17215 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526983#comment-16526983 ] Zach York commented on HBASE-20557: --- Ah you probably mean this:

[jira] [Commented] (HBASE-20557) Backport HBASE-17215 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526976#comment-16526976 ] Zach York commented on HBASE-20557: --- [~apurtell] I'm leaning towards not including this on branch-1.4

[jira] [Commented] (HBASE-20557) Backport HBASE-17215 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526889#comment-16526889 ] Zach York commented on HBASE-20557: --- +1, reviewed on PR. > Backport HBASE-17215 to branch-1 >

[jira] [Commented] (HBASE-20789) TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky

[ https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526844#comment-16526844 ] Zach York commented on HBASE-20789: --- [~openinx] {quote}bq. If the existingBlock has

[jira] [Comment Edited] (HBASE-18840) Add functionality to refresh meta table at master startup

[ https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525571#comment-16525571 ] Zach York edited comment on HBASE-18840 at 6/27/18 8:38 PM: Trying to rebase

[jira] [Commented] (HBASE-18840) Add functionality to refresh meta table at master startup

[ https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525571#comment-16525571 ] Zach York commented on HBASE-18840: --- Trying to rebase this patch on the latest master and it looks

[jira] [Commented] (HBASE-20789) TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky

[ https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525381#comment-16525381 ] Zach York commented on HBASE-20789: --- [~openinx] Ah... I see that putIfAbsent now. I wonder why my

[jira] [Commented] (HBASE-20799) TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky

[ https://issues.apache.org/jira/browse/HBASE-20799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525321#comment-16525321 ] Zach York commented on HBASE-20799: --- [~apurtell] see HBASE-20789. This is already being tracked there.

[jira] [Updated] (HBASE-18840) Add functionality to refresh meta table at master startup

[ https://issues.apache.org/jira/browse/HBASE-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-18840: -- Attachment: HBASE-18840.HBASE-18477.004.patch > Add functionality to refresh meta table at master

[jira] [Commented] (HBASE-18477) Umbrella JIRA for HBase Read Replica clusters

[ https://issues.apache.org/jira/browse/HBASE-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524199#comment-16524199 ] Zach York commented on HBASE-18477: --- [~busbey] I'm going to pick up this work again as I'd like to

[jira] [Commented] (HBASE-20789) TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky

[ https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524195#comment-16524195 ] Zach York commented on HBASE-20789: --- [~yuzhih...@gmail.com] None of those build links actually load

[jira] [Resolved] (HBASE-20787) Rebase the HBASE-18477 onto the current master to continue dev

[ https://issues.apache.org/jira/browse/HBASE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York resolved HBASE-20787. --- Resolution: Fixed > Rebase the HBASE-18477 onto the current master to continue dev >

[jira] [Commented] (HBASE-20787) Rebase the HBASE-18477 onto the current master to continue dev

[ https://issues.apache.org/jira/browse/HBASE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524187#comment-16524187 ] Zach York commented on HBASE-20787: --- Did a force push to clean the branch up. > Rebase the

[jira] [Commented] (HBASE-20789) TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky

[ https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524184#comment-16524184 ] Zach York commented on HBASE-20789: --- Sorry the comment wasn't updated, I think I had updated the

[jira] [Commented] (HBASE-20787) Rebase the HBASE-18477 onto the current master to continue dev

[ https://issues.apache.org/jira/browse/HBASE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522979#comment-16522979 ] Zach York commented on HBASE-20787: --- I will also remove the various commits/reverts of the initial

[jira] [Updated] (HBASE-20787) Rebase the HBASE-18477 onto the current master to continue dev

[ https://issues.apache.org/jira/browse/HBASE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20787: -- Issue Type: Sub-task (was: Task) Parent: HBASE-18477 > Rebase the HBASE-18477 onto the

[jira] [Created] (HBASE-20787) Rebase the HBASE-18477 onto the current master to continue dev

Zach York created HBASE-20787: - Summary: Rebase the HBASE-18477 onto the current master to continue dev Key: HBASE-20787 URL: https://issues.apache.org/jira/browse/HBASE-20787 Project: HBase

[jira] [Assigned] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York reassigned HBASE-20734: - Assignee: Zach York > Colocate recovered edits directory with hbase.wal.dir >

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514190#comment-16514190 ] Zach York commented on HBASE-20734: --- I looked into the code for this and the challenge is that Region

[jira] [Commented] (HBASE-20723) Custom hbase.wal.dir results in dataloss because we write recovered edits into a different place than where the recovering region server looks for them.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514187#comment-16514187 ] Zach York commented on HBASE-20723: --- +1 on the patch once the checkstyle is fixed. I'll push tonight

[jira] [Updated] (HBASE-20723) Custom hbase.wal.dir results in dataloss because we write recovered edits into a different place than where the recovering region server looks for them.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20723: -- Description: Description: When custom hbase.wal.dir is configured the recovery system uses it in

[jira] [Updated] (HBASE-20723) Custom hbase.wal.dir results in dataloss because we write recovered edits into a different place than where the recovering region server looks for them.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20723: -- Summary: Custom hbase.wal.dir results in dataloss because we write recovered edits into a different

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the recovered edits root path

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514172#comment-16514172 ] Zach York commented on HBASE-20723: --- Thanks for the summary [~busbey], one minor tweak: {quote}which

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513169#comment-16513169 ] Zach York commented on HBASE-20734: --- Before HBASE-20723 goes in, there is no chance of this happening,

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513113#comment-16513113 ] Zach York commented on HBASE-20723: --- Removed 1.1.2 from affects since the backport isn't in the public

[jira] [Updated] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20723: -- Affects Version/s: (was: 1.1.2) 1.4.0 1.4.1

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513107#comment-16513107 ] Zach York commented on HBASE-20723: --- [~yuzhih...@gmail.com] The patch looks good to me. Let's see what

[jira] [Commented] (HBASE-20734) Colocate recovered edits directory with hbase.wal.dir

[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513097#comment-16513097 ] Zach York commented on HBASE-20734: --- doesn't split log only run before region opening so shouldn't

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513067#comment-16513067 ] Zach York commented on HBASE-20723: --- Okay, let's do the quick fix here and look to HBASE-20734 for the

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513048#comment-16513048 ] Zach York commented on HBASE-20723: --- It's great that we have these JMX values, but unless an admin

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513019#comment-16513019 ] Zach York commented on HBASE-20723: --- [~yuzhih...@gmail.com] I did reproduce the issue on my side as

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511807#comment-16511807 ] Zach York commented on HBASE-20723: --- [~yuzhih...@gmail.com] I think I'm starting to see your point.

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511758#comment-16511758 ] Zach York commented on HBASE-20723: --- [~taklwu] Yes hbase.wal.dir is set in your experiments.   >

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511647#comment-16511647 ] Zach York commented on HBASE-20723: --- [~busbey] That's what I expected, but Stephen's experiment seems

[jira] [Commented] (HBASE-20723) WALSplitter uses the rootDir, which is walDir, as the tableDir root path.

[ https://issues.apache.org/jira/browse/HBASE-20723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510654#comment-16510654 ] Zach York commented on HBASE-20723: --- [~yuzhih...@gmail.com] you're welcome to try that change, but as

[jira] [Commented] (HBASE-17437) Support specifying a WAL directory outside of the root directory

[ https://issues.apache.org/jira/browse/HBASE-17437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510471#comment-16510471 ] Zach York commented on HBASE-17437: --- Looking briefly at the code it seems that rootdir should be

[jira] [Commented] (HBASE-17437) Support specifying a WAL directory outside of the root directory

[ https://issues.apache.org/jira/browse/HBASE-17437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510454#comment-16510454 ] Zach York commented on HBASE-17437: --- Yeah please open a new issue. Feel free to assign it to me and I

[jira] [Commented] (HBASE-20556) Backport HBASE-16490 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510084#comment-16510084 ] Zach York commented on HBASE-20556: --- Pushed to branch-1 and branch-1.4. I reran the modified tests to

[jira] [Updated] (HBASE-20556) Backport HBASE-16490 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20556: -- Resolution: Fixed Fix Version/s: 1.4.6 1.5.0 Status: Resolved

[jira] [Commented] (HBASE-20555) Backport HBASE-18083 and related changes in branch-1

[ https://issues.apache.org/jira/browse/HBASE-20555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497235#comment-16497235 ] Zach York commented on HBASE-20555: --- Thanks! I'll make sure to keep the default comment in mind while

[jira] [Commented] (HBASE-20555) Backport HBASE-18083 and related changes in branch-1

[ https://issues.apache.org/jira/browse/HBASE-20555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497189#comment-16497189 ] Zach York commented on HBASE-20555: --- [~apurtell] Any concerns with any of these backports being

[jira] [Commented] (HBASE-20665) "Already cached block XXX" message should be DEBUG

[ https://issues.apache.org/jira/browse/HBASE-20665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496949#comment-16496949 ] Zach York commented on HBASE-20665: --- I swore I fixed this in a recent commit, but I guess I must have

[jira] [Commented] (HBASE-20556) Backport HBASE-16490 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491358#comment-16491358 ] Zach York commented on HBASE-20556: --- +1 I will commit if nobody has anymore comments. > Backport

[jira] [Commented] (HBASE-20608) Remove build option of error prone profile for branch-1 after HBASE-12350

[ https://issues.apache.org/jira/browse/HBASE-20608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484722#comment-16484722 ] Zach York commented on HBASE-20608: --- LGTM Andrew, also thanks for pointing out where these configs are

[jira] [Commented] (HBASE-20608) Remove build option of error prone profile for branch-1 after HBASE-12350

[ https://issues.apache.org/jira/browse/HBASE-20608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484678#comment-16484678 ] Zach York commented on HBASE-20608: --- Can we remove/revert this change in branch-1 until we come up with

[jira] [Commented] (HBASE-20556) Backport HBASE-16490 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16484340#comment-16484340 ] Zach York commented on HBASE-20556: --- [~mdrob] and [~busbey] do we want *HBASE-20608* to go in before

[jira] [Commented] (HBASE-20556) Backport HBASE-16490 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477728#comment-16477728 ] Zach York commented on HBASE-20556: --- [~taklwu] can you retrigger the unit tests (reattach the patch)?

[jira] [Updated] (HBASE-20556) Backport HBASE-16490 to branch-1

[ https://issues.apache.org/jira/browse/HBASE-20556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20556: -- Status: Patch Available (was: Open) > Backport HBASE-16490 to branch-1 >

[jira] [Updated] (HBASE-20447) Only fail cacheBlock if block collisions aren't related to next block metadata

[ https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20447: -- Attachment: HBASE-20447.master.004.patch > Only fail cacheBlock if block collisions aren't related to

[jira] [Updated] (HBASE-20447) Only fail cacheBlock if block collisions aren't related to next block metadata

[ https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20447: -- Attachment: HBASE-20447.master.003.patch > Only fail cacheBlock if block collisions aren't related to

[jira] [Updated] (HBASE-20447) Only fail cacheBlock if block collisions aren't related to next block metadata

[ https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20447: -- Attachment: HBASE-20447.branch-1.006.patch > Only fail cacheBlock if block collisions aren't related

[jira] [Updated] (HBASE-20204) Add locking to RefreshFileConnections in BucketCache

[ https://issues.apache.org/jira/browse/HBASE-20204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20204: -- Fix Version/s: 1.4.5 1.5.0 2.1.0 3.0.0 > Add

[jira] [Updated] (HBASE-20204) Add locking to RefreshFileConnections in BucketCache

[ https://issues.apache.org/jira/browse/HBASE-20204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20204: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Add locking to

[jira] [Commented] (HBASE-20204) Add locking to RefreshFileConnections in BucketCache

[ https://issues.apache.org/jira/browse/HBASE-20204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469542#comment-16469542 ] Zach York commented on HBASE-20204: --- Pushed to master, branch-2, branch-1, branch-1.4. I didn't push

[jira] [Updated] (HBASE-20204) Add locking to RefreshFileConnections in BucketCache

[ https://issues.apache.org/jira/browse/HBASE-20204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20204: -- Attachment: HBASE-20204.master.004.patch > Add locking to RefreshFileConnections in BucketCache >

[jira] [Updated] (HBASE-20447) Only fail cacheBlock if block collisions aren't related to next block metadata

[ https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20447: -- Attachment: HBASE-20447.branch-1.005.patch > Only fail cacheBlock if block collisions aren't related

[jira] [Commented] (HBASE-20447) Only fail cacheBlock if block collisions aren't related to next block metadata

[ https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453171#comment-16453171 ] Zach York commented on HBASE-20447: --- I have attached a new patch that fixes the master patch. I figured

[jira] [Updated] (HBASE-20447) Only fail cacheBlock if block collisions aren't related to next block metadata

[ https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-20447: -- Attachment: HBASE-20447.master.002.patch > Only fail cacheBlock if block collisions aren't related to

[jira] [Commented] (HBASE-20447) Only fail cacheBlock if block collisions aren't related to next block metadata

[ https://issues.apache.org/jira/browse/HBASE-20447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451373#comment-16451373 ] Zach York commented on HBASE-20447: --- TestBucketCache passes locally. Reattaching to retry. > Only fail

<    1   2   3   4   5   6   7   8   >