Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-18 Thread via GitHub
frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2065709792 > Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.0:test (secondPartTestsExecution) on project hbase-server: There was a timeout in the fork -> [Help 1]

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-18 Thread via GitHub
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2065214976 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-18 Thread via GitHub
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2065029801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-18 Thread via GitHub
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2064904249 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-18 Thread via GitHub
Apache-HBase commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2064110471 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-18 Thread via GitHub
frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2063901626 A new commit has been added. Let's wait for the UT result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-17 Thread via GitHub
frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2060558485 Will push the newest code as soon as possible. Thanks Duo ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2024-04-17 Thread via GitHub
Apache9 commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-2060519013 Any updates here? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-12 Thread via GitHub
frostruan commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1357033196 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java: ## @@ -762,4 +773,30 @@ public static String findMostRecentBackupId(String[]

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-12 Thread via GitHub
frostruan commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1357032646 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/LogRollProcedure.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-12 Thread via GitHub
Apache9 commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1356848506 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java: ## @@ -762,4 +773,30 @@ public static String findMostRecentBackupId(String[]

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-12 Thread via GitHub
Apache9 commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1356843363 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/LogRollProcedure.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-12 Thread via GitHub
Apache9 commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1356842065 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/LogRollProcedure.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-07 Thread via GitHub
frostruan commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1349529689 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java: ## @@ -762,4 +773,30 @@ public static String findMostRecentBackupId(String[]

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-07 Thread via GitHub
frostruan commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1349529534 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/LogRollProcedure.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-07 Thread via GitHub
frostruan commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1349529481 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/LogRollProcedure.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-07 Thread via GitHub
frostruan commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1349529366 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/LogRollProcedure.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-07 Thread via GitHub
frostruan commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1349529307 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java: ## @@ -701,6 +701,26 @@ public HashMap

Re: [PR] HBASE-26974 Introduce a LogRollProcedure [hbase]

2023-10-07 Thread via GitHub
Apache9 commented on code in PR #5408: URL: https://github.com/apache/hbase/pull/5408#discussion_r1349486354 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java: ## @@ -701,6 +701,26 @@ public HashMap