petersomogyi merged PR #5605:
URL: https://github.com/apache/hbase/pull/5605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
petersomogyi commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2058965578
> Any other concerns @petersomogyi , or would you think this is good to go
now?
Looks good to me!
--
This is an automated message from the Apache Git Service.
To respond to
wchevreuil commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2056208974
Any other concerns @petersomogyi , or would you think this is good to go now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2049471103
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2049463533
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2049389628
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2049050559
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
petersomogyi commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1559594087
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -41,23 +44,30 @@
public final class PrefetchExecutor {
private
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2045162732
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2045129715
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2045104808
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-208351
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2043319729
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2043233488
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2043190919
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2042745968
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1555630761
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
ragarkar commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1555623367
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1555616907
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1555616907
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
ragarkar commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1555615766
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r167693
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1553937551
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1553921169
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1551380210
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1551378020
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1551344684
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1551312368
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1549633573
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1549631943
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1549385862
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -336,6 +337,62 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2023836713
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2023833512
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2023812040
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2023131527
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2023051168
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2023048975
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2023030601
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2022553752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2022410821
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2022408739
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 1s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2022390876
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2022059673
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1540512005
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -295,10 +302,23 @@ private void readStoreFile(Path storeFilePath,
throws
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1537538033
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -295,10 +302,23 @@ private void readStoreFile(Path storeFilePath,
throws
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2014757277
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2014741085
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2014736127
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-2014448472
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1524702737
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -115,23 +132,89 @@ public static void cancel(Path path) {
// ok to
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1979349907
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1979337248
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1979332486
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1978891373
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1978824183
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 17s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1978802637
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1978790823
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1978389067
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1504055111
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -78,7 +85,10 @@ public Thread newThread(Runnable r) {
+
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1939367304
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1939365875
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1938877688
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 1s |
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1486303302
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -31,23 +31,28 @@
import org.apache.hadoop.fs.Path;
import
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1486302985
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -298,6 +299,44 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1486302702
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -298,6 +299,44 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1486302386
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -134,4 +139,25 @@ private PrefetchExecutor() {
static
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1486301747
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -298,6 +299,44 @@ public void testPrefetchDoesntSkipRefs() throws Exception {
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1486301146
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -134,4 +139,25 @@ private PrefetchExecutor() {
static
ankitsinghal commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1479243204
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -134,4 +139,25 @@ private PrefetchExecutor() {
static
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1445999734
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -134,4 +139,25 @@ private PrefetchExecutor() {
static
wchevreuil commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1463134561
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -31,23 +31,28 @@
import org.apache.hadoop.fs.Path;
import
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1446052640
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -134,4 +139,25 @@ private PrefetchExecutor() {
static
kabhishek4 commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1445999734
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java:
##
@@ -134,4 +139,25 @@ private PrefetchExecutor() {
static
petersomogyi commented on code in PR #5605:
URL: https://github.com/apache/hbase/pull/5605#discussion_r1444797348
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestPrefetch.java:
##
@@ -20,6 +20,7 @@
import static
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1878426688
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1878424696
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5605:
URL: https://github.com/apache/hbase/pull/5605#issuecomment-1878189702
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
kabhishek4 opened a new pull request, #5605:
URL: https://github.com/apache/hbase/pull/5605
Problem :
Rolling restart triggers region movement on the cluster while the
RegionServers are getting restarted. During this time, the temporary
RegionServers will start prefetching
78 matches
Mail list logo
