Apache9 merged PR #5847:
URL: https://github.com/apache/hbase/pull/5847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5847:
URL: https://github.com/apache/hbase/pull/5847#issuecomment-2073293335
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5847:
URL: https://github.com/apache/hbase/pull/5847#issuecomment-2073287394
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5847:
URL: https://github.com/apache/hbase/pull/5847#issuecomment-2072804871
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5847:
URL: https://github.com/apache/hbase/pull/5847#issuecomment-2072468446
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5847:
URL: https://github.com/apache/hbase/pull/5847#issuecomment-2072458120
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5847:
URL: https://github.com/apache/hbase/pull/5847#issuecomment-2071984192
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache9 opened a new pull request, #5847:
URL: https://github.com/apache/hbase/pull/5847
…ormation (#5770)
Signed-off-by: Istvan Toth
Signed-off-by: Nick Dimiduk
Reviewed-by: Bryan Beaudreault
(cherry picked from commit e3761baec1158d617c46bbdf54725206544717e9)
--
This
Apache9 merged PR #5770:
URL: https://github.com/apache/hbase/pull/5770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2069590363
> Given there is more work to do here, might as well keep it to 2.7.0+
Got it.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
bbeaudreault commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2069584184
Given there is more work to do here, might as well keep it to 2.7.0+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2069567572
Thanks @ndimiduk . Will merge recently if no other concerns.
@bbeaudreault My plan is to apply this to branch-2+, i.e, 2.7.0+, since
there are still other under going works to make
ndimiduk commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1574542917
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryFactory.java:
##
@@ -17,27 +17,75 @@
*/
package org.apache.hadoop.hbase.client;
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2068819984
> I was referring to the email thread on
https://lists.apache.org/thread/ksw4tb8h22ojwmbn7pqwc7gox70vgzgr
>
> In my reading the conclusion was that we should not remove the ZK
stoty commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2068629529
I was referring to the email thread on
https://lists.apache.org/thread/ksw4tb8h22ojwmbn7pqwc7gox70vgzgr
In my reading the conclusion was that we should not remove the ZK connection
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2068557401
Ah, maybe I misguided you...
I do not mean we want to completely remove zookeeper in 3.0.0 release, we
just want to provide a way to hide zookeeper inside HBase, beside the zookeeper
stoty commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2068494940
I don't think our compatibility policy allows limiting zookeeper to internal
use only in 3.0 , @Apache9.
IIRC we need to have a feature deprecated for a whole major release before
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2067682075
Gently ping again...
This is very important for the final 3.0.0 release, as we want to limit
zookeeper in internal use only.
@bbeaudreault @ndimiduk
Thanks.
--
This
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2053677022
Any other concerns?
@ndimiduk @bbeaudreault
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2046831978
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 47s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2046813773
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2046770473
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2046512941
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 53s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2045606862
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2045506821
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 51s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2045456991
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2044819227
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2044439200
If no other feedbacks, I will move forward to update the PR to address the
review comments.
The basic direction is still the same as beginning, we use `hbase+zk` and
`hbase+rpc` as
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2040980945
Let me conclude a bit.
Finally we focus on the scheme part of the URI.
@ndimiduk thought the second part should be communication protocol when
connecting to hbase cluster, so
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1554530171
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
stoty commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1547668236
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
stoty commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1547661938
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
bbeaudreault commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1547584133
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1547533182
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1547527258
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
ndimiduk commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1547514519
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryCreator.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation
ndimiduk commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1547505922
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
bbeaudreault commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1545831401
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software
bbeaudreault commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1545831401
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1543164434
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryCreator.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1543160075
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryCreator.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1543158151
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryCreator.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1543157348
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryFactory.java:
##
@@ -17,27 +17,75 @@
*/
package org.apache.hadoop.hbase.client;
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1543155196
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryFactory.java:
##
@@ -17,27 +17,75 @@
*/
package org.apache.hadoop.hbase.client;
ndimiduk commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1542616380
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryFactory.java:
##
@@ -17,27 +17,75 @@
*/
package org.apache.hadoop.hbase.client;
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2017744432
Ping @ndimiduk . Could you please take a look at this?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2015984393
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2015884974
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 47s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2015813014
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2015470645
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2015360356
@stoty I named it ConnectionRegistryCreator in the new PR, and added a test
in hbase-client for testing URI parsing and fallback.
--
This is an automated message from the Apache Git
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535392965
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistries.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535392433
##
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestBasicReadWriteWithDifferentConnectionRegistries.java:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the
stoty commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535299925
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistries.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
stoty commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535292470
##
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestBasicReadWriteWithDifferentConnectionRegistries.java:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535267447
##
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestBasicReadWriteWithDifferentConnectionRegistries.java:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535263968
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistries.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Apache9 commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535258176
##
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestBasicReadWriteWithDifferentConnectionRegistries.java:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the
stoty commented on code in PR #5770:
URL: https://github.com/apache/hbase/pull/5770#discussion_r1535217842
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistries.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2014410707
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2014396728
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2014395329
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2014191755
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 52s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2013607363
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2013576815
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2012883032
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2012656493
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2012088346
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 0s |
Apache9 commented on PR #5770:
URL: https://github.com/apache/hbase/pull/5770#issuecomment-2011965780
@stoty FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache9 opened a new pull request, #5770:
URL: https://github.com/apache/hbase/pull/5770
…ormation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
70 matches
Mail list logo
