Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-07 Thread via GitHub
Apache9 merged PR #5849: URL: https://github.com/apache/hbase/pull/5849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152842865 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152841933 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152841623 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152830551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152708041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152708008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152702546 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-06-06 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2152670524 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-25 Thread via GitHub
junegunn commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2078633144 I believe the test failure is unrelated to the patch. It also fails on master. ```sh mvn test '-Dtest=org.apache.hadoop.hbase.client.TestAdminShell' ``` The rest of the

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-24 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2074461690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-24 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2074459958 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-24 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2074458866 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-24 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2074452391 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-24 Thread via GitHub
junegunn commented on code in PR #5849: URL: https://github.com/apache/hbase/pull/5849#discussion_r1577521472 ## hbase-shell/src/main/ruby/hbase/table.rb: ## @@ -833,16 +833,16 @@ def convert_bytes(bytes, converter_class = nil, converter_method = nil)

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-23 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2073987627 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-23 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2073984596 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-23 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2073983591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28549 Make shell commands support column qualifiers with colons [hbase]

2024-04-23 Thread via GitHub
Apache-HBase commented on PR #5849: URL: https://github.com/apache/hbase/pull/5849#issuecomment-2073979381 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |