ndimiduk commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1605200912
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDelete.java:
##
@@ -30,6 +31,7 @@
import org.apache.hadoop.hbase.testclassification.LargeTests;
ndimiduk commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1605158834
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDelete.java:
##
@@ -30,6 +31,7 @@
import org.apache.hadoop.hbase.testclassification.LargeTests;
ndimiduk commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1605146791
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDelete.java:
##
@@ -30,6 +31,7 @@
import org.apache.hadoop.hbase.testclassification.LargeTests;
ndimiduk merged PR #5876:
URL: https://github.com/apache/hbase/pull/5876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ndimiduk commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1604754534
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java:
##
@@ -129,20 +128,15 @@ public int deleteBackups(String[] backupIds) throws
ndimiduk commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2117281426
> I don't know if there's an existing ticket for them, and haven't done any
investigation for it.
@DieterDP-ng I filed this as
https://issues.apache.org/jira/browse/HBASE-28602
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108325553
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108323241
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108321888
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108300478
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 15s |
DieterDP-ng commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1598758193
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java:
##
@@ -129,20 +128,15 @@ public int deleteBackups(String[] backupIds) throws
DieterDP-ng commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2108155158
> Test failure looks like a failure of the backup system. It's attempting to
take an incremental backup, which assumes the existence of a WAL that no longer
exists. The test harness
ndimiduk commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2104339577
```
java.io.IOException: java.io.FileNotFoundException: File
ndimiduk commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2104337779
Test failure looks like a failure of the backup system. It's attempting to
take an incremental backup, which assumes the existence of a WAL that no longer
exists. The test harness ran the
ndimiduk commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1596546774
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java:
##
@@ -129,20 +128,15 @@ public int deleteBackups(String[] backupIds) throws
rmdmattingly commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2103196047
The test failure looks relevant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100866036
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100863875
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100861426
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100850624
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
DieterDP-ng commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1594179764
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDelete.java:
##
@@ -158,4 +160,27 @@ public long currentTime() {
rmdmattingly commented on code in PR #5876:
URL: https://github.com/apache/hbase/pull/5876#discussion_r1594113045
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDelete.java:
##
@@ -158,4 +160,27 @@ public long currentTime() {
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100631395
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100629569
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100627058
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100620463
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
DieterDP-ng commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2100535212
@rmdmattingly added a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2096293487
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 23s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2096291617
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2096291126
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5876:
URL: https://github.com/apache/hbase/pull/5876#issuecomment-2096280725
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
DieterDP-ng opened a new pull request, #5876:
URL: https://github.com/apache/hbase/pull/5876
The incremental backup set is the set of tables included when an incremental
backup is created, it is managed per backup root dir and contains all tables
that are present in at least one backup (in
32 matches
Mail list logo
