[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443088#comment-15443088
]
Anastasia Braginsky commented on HBASE-14921:
-
[~anoop.hbase], [~ram_krish], [~stack],
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434264#comment-15434264
]
Hudson commented on HBASE-14921:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1471 (See
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434222#comment-15434222
]
stack commented on HBASE-14921:
---
Thanks [~anoop.hbase] I've not reviewed yet. Will raise new issues if
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434220#comment-15434220
]
Edward Bortnikov commented on HBASE-14921:
--
Fantastic. Thanks, all, for helping out. Let's move
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432618#comment-15432618
]
Anoop Sam John commented on HBASE-14921:
Will commit tonight my time unless obejctions.
> Memory
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432202#comment-15432202
]
ramkrishna.s.vasudevan commented on HBASE-14921:
+1 to commit.
[~devaraj]
I think it is
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432102#comment-15432102
]
Anoop Sam John commented on HBASE-14921:
[~ram_krish], [~saint@gmail.com] You good with
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432100#comment-15432100
]
Anoop Sam John commented on HBASE-14921:
These patches as such do not touch the existing memstore
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431686#comment-15431686
]
Devaraj Das commented on HBASE-14921:
-
I am trying to get hold of a rig for running itbll. But that
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431348#comment-15431348
]
Edward Bortnikov commented on HBASE-14921:
--
Thanks for suggesting, [~devaraj]. We are actually
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431204#comment-15431204
]
Devaraj Das commented on HBASE-14921:
-
Great work, [~anastas]. I'd like to know whether you ran ITBLL
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430659#comment-15430659
]
Anastasia Braginsky commented on HBASE-14921:
-
To get this in, this week, would be just
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430237#comment-15430237
]
Anoop Sam John commented on HBASE-14921:
Only very few minor comments left for this over in RB I
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426934#comment-15426934
]
Hadoop QA commented on HBASE-14921:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426647#comment-15426647
]
Edward Bortnikov commented on HBASE-14921:
--
Agree with Anoop - the CellChunkMap implementation
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426640#comment-15426640
]
Anastasia Braginsky commented on HBASE-14921:
-
Published yet another patch with recent code
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424938#comment-15424938
]
Anoop Sam John commented on HBASE-14921:
What we observed in our tests with G1GC is that the
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424881#comment-15424881
]
Lars Hofhansl commented on HBASE-14921:
---
MSLAB forces another copy of the data backing each Cell
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424799#comment-15424799
]
ramkrishna.s.vasudevan commented on HBASE-14921:
As I said I won't block the commit here.
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424793#comment-15424793
]
Hadoop QA commented on HBASE-14921:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424540#comment-15424540
]
Edward Bortnikov commented on HBASE-14921:
--
Hate to be pushy - but next week we might be short
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424523#comment-15424523
]
Anastasia Braginsky commented on HBASE-14921:
-
Hey,
Thank for taking the look!
The recent
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424310#comment-15424310
]
Anoop Sam John commented on HBASE-14921:
Ya for YCSB test, what is the load? per row size and
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424241#comment-15424241
]
ramkrishna.s.vasudevan commented on HBASE-14921:
I did a test with the latest patch - V10
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422577#comment-15422577
]
Anastasia Braginsky commented on HBASE-14921:
-
I created HBASE-16421 to continue with the
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422571#comment-15422571
]
Anastasia Braginsky commented on HBASE-14921:
-
This would be amazing, if we could get this in
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422361#comment-15422361
]
ramkrishna.s.vasudevan commented on HBASE-14921:
May be I can apply the patch and test
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420875#comment-15420875
]
Edward Bortnikov commented on HBASE-14921:
--
Indeed let's defer this discussion to the new JIRA.
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420825#comment-15420825
]
Anastasia Braginsky commented on HBASE-14921:
-
I created HBASE-16417 to follow this JIRA and
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420787#comment-15420787
]
Anastasia Braginsky commented on HBASE-14921:
-
Hi Guys!
I have published the patch that
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420309#comment-15420309
]
Anastasia Braginsky commented on HBASE-14921:
-
bq. Makes sense. So were you able to observe
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418386#comment-15418386
]
ramkrishna.s.vasudevan commented on HBASE-14921:
bq.1. Size arithmetic. I'll be
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417149#comment-15417149
]
Hadoop QA commented on HBASE-14921:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417138#comment-15417138
]
Anastasia Braginsky commented on HBASE-14921:
-
The current patch includes fixes to all
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416955#comment-15416955
]
Anastasia Braginsky commented on HBASE-14921:
-
Submitted another patch that fixes some
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416941#comment-15416941
]
Hadoop QA commented on HBASE-14921:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416924#comment-15416924
]
Anastasia Braginsky commented on HBASE-14921:
-
All done according to your requests :) , will
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416904#comment-15416904
]
Anoop Sam John commented on HBASE-14921:
Pls update the RB link with latest patch
> Memory
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416542#comment-15416542
]
ramkrishna.s.vasudevan commented on HBASE-14921:
[~anastas], [~eshcar]
Any
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403568#comment-15403568
]
Anastasia Braginsky commented on HBASE-14921:
-
THANK YOU SO MUCH !!!
> Memory optimizations
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403504#comment-15403504
]
Hadoop QA commented on HBASE-14921:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403444#comment-15403444
]
ramkrishna.s.vasudevan commented on HBASE-14921:
[~anastas] - JFYI.
> Memory
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403357#comment-15403357
]
ramkrishna.s.vasudevan commented on HBASE-14921:
[~eshcar]
With default memstore impl
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403355#comment-15403355
]
ramkrishna.s.vasudevan commented on HBASE-14921:
Ok. I will paste that UT in some time
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402087#comment-15402087
]
Eshcar Hillel commented on HBASE-14921:
---
Hi [~anoop.hbase], [~ram_krish],
Did you use ssd machines
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401503#comment-15401503
]
ramkrishna.s.vasudevan commented on HBASE-14921:
[~anastas]
My UT was very simple. I
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401099#comment-15401099
]
Anoop Sam John commented on HBASE-14921:
1. Ours is a write only workload. So BC size not that
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401076#comment-15401076
]
Eshcar Hillel commented on HBASE-14921:
---
Questions on PE tests:
1. you set
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401013#comment-15401013
]
Anastasia Braginsky commented on HBASE-14921:
-
Hey [~ram_krish], thank you for your comment
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395945#comment-15395945
]
ramkrishna.s.vasudevan commented on HBASE-14921:
bq.. What is the exact cluster
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395836#comment-15395836
]
Anastasia Braginsky commented on HBASE-14921:
-
Indeed, no SQM, both in ppt and in the code
>
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395835#comment-15395835
]
Anastasia Braginsky commented on HBASE-14921:
-
The ppt is meant for those unfamiliar with
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395713#comment-15395713
]
Eshcar Hillel commented on HBASE-14921:
---
We are trying to reproduce the PE results you reported
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395408#comment-15395408
]
Anoop Sam John commented on HBASE-14921:
I read it again. I think it is fine.
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395371#comment-15395371
]
Anoop Sam John commented on HBASE-14921:
The ppt says in case of flatten, we scan the cells in
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395368#comment-15395368
]
Anoop Sam John commented on HBASE-14921:
Thanks for the ppt.. It is a very clear explanation.
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395276#comment-15395276
]
Anastasia Braginsky commented on HBASE-14921:
-
[~stack], I attached a presentation explaining
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394006#comment-15394006
]
stack commented on HBASE-14921:
---
Let me do some more review of the posted patch. It is a bit messy.
St.Ack
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394004#comment-15394004
]
Anoop Sam John commented on HBASE-14921:
+1
> Memory optimizations
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393993#comment-15393993
]
Edward Bortnikov commented on HBASE-14921:
--
Thanks, all, for the last round ... Seems like we
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393386#comment-15393386
]
Anoop Sam John commented on HBASE-14921:
Am fine with committing the other jira first.. I can
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393204#comment-15393204
]
stack commented on HBASE-14921:
---
[~anoop.hbase] What you think of the [~ebortnik] proposal.
I just want to
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393193#comment-15393193
]
Anoop Sam John commented on HBASE-14921:
Ya [~anastas] the 2 points I raised are those.. I
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392671#comment-15392671
]
Edward Bortnikov commented on HBASE-14921:
--
Let me re-iterate we are respectful of everyone's
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392669#comment-15392669
]
stack commented on HBASE-14921:
---
Ok. Left some notes on the review but any chance of a high-level overview
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392580#comment-15392580
]
Anastasia Braginsky commented on HBASE-14921:
-
All code review comments from review board
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392571#comment-15392571
]
Anastasia Braginsky commented on HBASE-14921:
-
First, I agree that the sizing issue is ugly
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392525#comment-15392525
]
stack commented on HBASE-14921:
---
Oh, and with [~ebortnik], what is shortest path to commit of this patch.
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392497#comment-15392497
]
stack commented on HBASE-14921:
---
Just did a reread of this whole issue.
First, what is going on in here is
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392425#comment-15392425
]
stack commented on HBASE-14921:
---
[~anastas] I like this reasoning. You've done this a few times in this
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392298#comment-15392298
]
Anoop Sam John commented on HBASE-14921:
HBASE-16229 trying to just make the size accounting in a
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392213#comment-15392213
]
Edward Bortnikov commented on HBASE-14921:
--
Suggest we install some order in this discussion,
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389678#comment-15389678
]
Edward Bortnikov commented on HBASE-14921:
--
Agreed. We all need more benchmarking. Let's proceed
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389649#comment-15389649
]
Anoop Sam John commented on HBASE-14921:
Thanks Ram
[~anastas] Suggest you people also test this
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388051#comment-15388051
]
ramkrishna.s.vasudevan commented on HBASE-14921:
bq. to move on to CellChunkMap (the real
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388017#comment-15388017
]
Anoop Sam John commented on HBASE-14921:
When the compaction of 3 or more segments can not really
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387999#comment-15387999
]
Edward Bortnikov commented on HBASE-14921:
--
Appreciate if we could get the new patch reviewed
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387993#comment-15387993
]
Edward Bortnikov commented on HBASE-14921:
--
[~ram_krish], thanks for all the feedback so far. My
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387517#comment-15387517
]
Anastasia Braginsky commented on HBASE-14921:
-
The recent patch is in RB now
> Memory
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387509#comment-15387509
]
ramkrishna.s.vasudevan commented on HBASE-14921:
bq.We can do it when we have like e.g.
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387470#comment-15387470
]
Anastasia Braginsky commented on HBASE-14921:
-
Thank you [~anoop.hbase] for your very
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387315#comment-15387315
]
Anastasia Braginsky commented on HBASE-14921:
-
I think I set it all correct now. Please take
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387309#comment-15387309
]
Anastasia Braginsky commented on HBASE-14921:
-
I have re-based everything for now. Reapplied
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387231#comment-15387231
]
Hadoop QA commented on HBASE-14921:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387229#comment-15387229
]
Anoop Sam John commented on HBASE-14921:
I see your latest rebased patch. Pls see HBASE-16229.
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387214#comment-15387214
]
Anoop Sam John commented on HBASE-14921:
[~anastas] So you got the comment abt the heap sizing
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387050#comment-15387050
]
Anoop Sam John commented on HBASE-14921:
I got your argument abt dynamic decision making for
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387034#comment-15387034
]
Hadoop QA commented on HBASE-14921:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385794#comment-15385794
]
Anastasia Braginsky commented on HBASE-14921:
-
Hi Guys,
I really wanted to publish the patch
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385748#comment-15385748
]
Edward Bortnikov commented on HBASE-14921:
--
[~ramkrishna], I'd suggest to review the upcoming
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385690#comment-15385690
]
Anastasia Braginsky commented on HBASE-14921:
-
bq. Am not very sure on this. You mean most of
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385649#comment-15385649
]
ramkrishna.s.vasudevan commented on HBASE-14921:
[~anastas]
Thanks for your consolidated
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385639#comment-15385639
]
Anastasia Braginsky commented on HBASE-14921:
-
Thank you [~anoop.hbase] and [~ram_krish]! You
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385330#comment-15385330
]
ramkrishna.s.vasudevan commented on HBASE-14921:
bq.Can we do anything better? It looks
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384110#comment-15384110
]
Anastasia Braginsky commented on HBASE-14921:
-
First, thanks everybody for the code review
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383748#comment-15383748
]
Anastasia Braginsky commented on HBASE-14921:
-
What is the default case, where we are sure we
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383727#comment-15383727
]
Anastasia Braginsky commented on HBASE-14921:
-
Got it. Removed the double counting.
> Memory
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383595#comment-15383595
]
ramkrishna.s.vasudevan commented on HBASE-14921:
bq.but I suggest first to proof this
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383594#comment-15383594
]
ramkrishna.s.vasudevan commented on HBASE-14921:
I now got to which comment are you
[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382953#comment-15382953
]
Anastasia Braginsky commented on HBASE-14921:
-
Also, got a comment saying that scan (being
1 - 100 of 192 matches
Mail list logo