[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202885#comment-15202885
]
Yu Li commented on HBASE-14969:
---
Thank you for the double check sir [~ghelmling]
bq. If the change wasn't
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202229#comment-15202229
]
Gary Helmling commented on HBASE-14969:
---
This change switches the default compaction throughput
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202854#comment-15202854
]
Gary Helmling commented on HBASE-14969:
---
[~carp84], the part I'm looking at is in
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202707#comment-15202707
]
Yu Li commented on HBASE-14969:
---
bq. This change switches the default compaction throughput controller to
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126854#comment-15126854
]
Hudson commented on HBASE-14969:
FAILURE: Integrated in HBase-Trunk_matrix #673 (See
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126829#comment-15126829
]
Hudson commented on HBASE-14969:
SUCCESS: Integrated in HBase-1.3-IT #469 (See
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127517#comment-15127517
]
Yu Li commented on HBASE-14969:
---
bq. so where is the actual failure that we can see?
[~ram_krish] I saw the
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125915#comment-15125915
]
Duo Zhang commented on HBASE-14969:
---
[~stack] Yes, {{testFlushThroughputTuning}} fails consistently
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125931#comment-15125931
]
Duo Zhang commented on HBASE-14969:
---
The problem here is that {{hbase:meta}} is assigned to the RS so
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125993#comment-15125993
]
Yu Li commented on HBASE-14969:
---
It was my fault not making the test robust enough, sorry sir [~stack].
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126042#comment-15126042
]
Yu Li commented on HBASE-14969:
---
The addendum patch lgtm, thanks Duo!
> Add throughput controller for
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126273#comment-15126273
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126518#comment-15126518
]
ramkrishna.s.vasudevan commented on HBASE-14969:
In this report -
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127622#comment-15127622
]
ramkrishna.s.vasudevan commented on HBASE-14969:
[~carp84]
Thanks for the info. Let me
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126746#comment-15126746
]
Hudson commented on HBASE-14969:
FAILURE: Integrated in HBase-1.3 #526 (See
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126301#comment-15126301
]
Yu Li commented on HBASE-14969:
---
Checking the UT result, everything looks ok except for those known flaky
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123148#comment-15123148
]
Hudson commented on HBASE-14969:
SUCCESS: Integrated in HBase-Trunk_matrix #667 (See
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123068#comment-15123068
]
Hudson commented on HBASE-14969:
FAILURE: Integrated in HBase-1.3 #522 (See
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122759#comment-15122759
]
Yu Li commented on HBASE-14969:
---
Thanks [~tedyu] for review and thanks [~Apache9] for review and help
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122845#comment-15122845
]
Hudson commented on HBASE-14969:
SUCCESS: Integrated in HBase-1.3-IT #467 (See
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116786#comment-15116786
]
Duo Zhang commented on HBASE-14969:
---
OK, Let's finish this...
Will push to master and branch-1 later
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112243#comment-15112243
]
Yu Li commented on HBASE-14969:
---
Checking UT failures:
* TestImportExport.testDurability:
{noformat}
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1511#comment-1511
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112438#comment-15112438
]
Duo Zhang commented on HBASE-14969:
---
[~apurtell] In this patch we move and remove some classes marked
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105285#comment-15105285
]
Yu Li commented on HBASE-14969:
---
The two findbugs issues don't need to handle as mentioned before.
The
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105036#comment-15105036
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105566#comment-15105566
]
Yu Li commented on HBASE-14969:
---
The latest HadoopQA run looks good.
> Add throughput controller for flush
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15105521#comment-15105521
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104134#comment-15104134
]
Yu Li commented on HBASE-14969:
---
Thanks Duo, I've updated the patch in rb according to your review comments
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103724#comment-15103724
]
Duo Zhang commented on HBASE-14969:
---
{quote}
My only concern is that this will require user to modify
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15103274#comment-15103274
]
Yu Li commented on HBASE-14969:
---
Thanks for the review [~Apache9]
bq. upload the newest patch to review
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101868#comment-15101868
]
Yu Li commented on HBASE-14969:
---
Checked and confirmed the UT failures and findbugs issues are not
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101822#comment-15101822
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102063#comment-15102063
]
Ted Yu commented on HBASE-14969:
lgtm
> Add throughput controller for flush
>
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102910#comment-15102910
]
Duo Zhang commented on HBASE-14969:
---
In general, since we have a new package 'controller' and flush
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15102889#comment-15102889
]
Duo Zhang commented on HBASE-14969:
---
[~liyu] Could you please upload the newest patch to review board?
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101427#comment-15101427
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101436#comment-15101436
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101549#comment-15101549
]
Yu Li commented on HBASE-14969:
---
Checking the UT result: the failure is on TestAsyncSecureIPC and caused by
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098530#comment-15098530
]
Ted Yu commented on HBASE-14969:
Performance numbers above are impressive.
> Add throughput controller
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098476#comment-15098476
]
Yu Li commented on HBASE-14969:
---
[~tedyu] and [~Apache9],
Sorry for the lag, here are the testing results:
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101144#comment-15101144
]
Ted Yu commented on HBASE-14969:
Can you fix the new checkstyle warnings ?
> Add throughput controller
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101141#comment-15101141
]
Yu Li commented on HBASE-14969:
---
Checking the findbugs warning, none is introduced by the patch here.
For
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101226#comment-15101226
]
Yu Li commented on HBASE-14969:
---
{quote}
Does the field have to be volatile ?
I don't see synchronization
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101229#comment-15101229
]
Ted Yu commented on HBASE-14969:
I think the volatile can be removed
> Add throughput controller for
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101186#comment-15101186
]
Ted Yu commented on HBASE-14969:
For NoLimitThroughputController :
{code}
44private volatile
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098921#comment-15098921
]
Hadoop QA commented on HBASE-14969:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075281#comment-15075281
]
Hadoop QA commented on HBASE-14969:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071720#comment-15071720
]
Ted Yu commented on HBASE-14969:
https://builds.apache.org/job/PreCommit-HBASE-Build/16896//testReport/
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067930#comment-15067930
]
Yu Li commented on HBASE-14969:
---
The javadoc issue is not introduced by this JIRA and already got resolved
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063370#comment-15063370
]
Yu Li commented on HBASE-14969:
---
Thanks [~Apache9] for the follow up.
bq. do you have some perf results
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061575#comment-15061575
]
Hadoop QA commented on HBASE-14969:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061315#comment-15061315
]
Duo Zhang commented on HBASE-14969:
---
Will review the patch later on rb and do you have some perf
53 matches
Mail list logo
