[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166864#comment-15166864
]
Hudson commented on HBASE-15264:
FAILURE: Integrated in HBase-Trunk_matrix #737 (See
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163521#comment-15163521
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163164#comment-15163164
]
stack commented on HBASE-15264:
---
Says
[WARNING]
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163156#comment-15163156
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162923#comment-15162923
]
Duo Zhang commented on HBASE-15264:
---
Oh the problem is the @link tag. If I remove it the warning will
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162906#comment-15162906
]
Duo Zhang commented on HBASE-15264:
---
Let me see what's wrong with the javadoc...
> Implement a fan out
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15162901#comment-15162901
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160164#comment-15160164
]
stack commented on HBASE-15264:
---
Ugh. Forget what i said about checkstyle. I forgot what the errors were.
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160060#comment-15160060
]
Duo Zhang commented on HBASE-15264:
---
Sure, I will fix the javadoc issue. For checkstyle, I could fix
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159960#comment-15159960
]
stack commented on HBASE-15264:
---
Patch looks good to me. Can fix the checkstyle and javadoc on commit (if
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159955#comment-15159955
]
stack commented on HBASE-15264:
---
Ok. Just go for master. Makes sense.
> Implement a fan out HDFS
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159930#comment-15159930
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158505#comment-15158505
]
Duo Zhang commented on HBASE-15264:
---
Commit this on master is a bit simple for me since I haven't
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158447#comment-15158447
]
stack commented on HBASE-15264:
---
[~Apache9] This patch is four new classes that do not touch any other
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158051#comment-15158051
]
Duo Zhang commented on HBASE-15264:
---
[~stack] What do you think we should go next？ On master or a new
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156412#comment-15156412
]
Duo Zhang commented on HBASE-15264:
---
The javadoc and license issue can be fixed when committing.
>
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156269#comment-15156269
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155257#comment-15155257
]
Duo Zhang commented on HBASE-15264:
---
I placed them in regionserver.wal on the POC branch. And here, as
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155254#comment-15155254
]
Duo Zhang commented on HBASE-15264:
---
There is no problem if master renamed our WAL directory because we
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155163#comment-15155163
]
Duo Zhang commented on HBASE-15264:
---
Here we just want to split a big patch into several little ones,
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154528#comment-15154528
]
stack commented on HBASE-15264:
---
Lets do in a branch first? Then you can commit willy-nilly and we can
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154511#comment-15154511
]
stack commented on HBASE-15264:
---
bq. then we should not start a new one?
We might not be able to if
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154509#comment-15154509
]
stack commented on HBASE-15264:
---
So, WAL goes bad, we abandon it and replay unacked edits into new file.
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154502#comment-15154502
]
stack commented on HBASE-15264:
---
Yes. Can backport working system to branch-1 once all is in.
> Implement
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154014#comment-15154014
]
Duo Zhang commented on HBASE-15264:
---
So let's commit this and focus on HBASE-15265? [~stack]
Thanks.
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153990#comment-15153990
]
Duo Zhang commented on HBASE-15264:
---
Oh, master will move the RS's log directory to another place to
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153951#comment-15153951
]
Duo Zhang commented on HBASE-15264:
---
Oh, I forgot an important thing, we can not close WAL writer
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153845#comment-15153845
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151576#comment-15151576
]
Duo Zhang commented on HBASE-15264:
---
{quote}
You want to commit this Duo Zhang to master branch ahead
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150749#comment-15150749
]
stack commented on HBASE-15264:
---
bq. Yes, Payload and RingBufferTruck are the same thing
OK. When you have
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150716#comment-15150716
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150003#comment-15150003
]
Duo Zhang commented on HBASE-15264:
---
{quote}
That Payload looks like RingBufferTruck
Is the RingBuffer
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149994#comment-15149994
]
stack commented on HBASE-15264:
---
bq. I will stop renew lease for this file first, and then call
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149959#comment-15149959
]
Duo Zhang commented on HBASE-15264:
---
[~stack] You can see this, it is almost done.
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149866#comment-15149866
]
stack commented on HBASE-15264:
---
I like 1 thread instead of six.
Stick the above list on head of the class
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149863#comment-15149863
]
stack commented on HBASE-15264:
---
Sweet. Stick on head of the class too.
How we know when to flush? We'll
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149763#comment-15149763
]
Duo Zhang commented on HBASE-15264:
---
There are several advantages
1. The fan out mechanism. This will
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149715#comment-15149715
]
Duo Zhang commented on HBASE-15264:
---
Basically, the stream works as follow
1. {{write}} will just copy
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149526#comment-15149526
]
stack commented on HBASE-15264:
---
The checkstyle complaints are mostly silly. The two failures are flakies.
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148369#comment-15148369
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147383#comment-15147383
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146507#comment-15146507
]
Hadoop QA commented on HBASE-15264:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146518#comment-15146518
]
Duo Zhang commented on HBASE-15264:
---
Let me try addressing the hadoop version issue...
For checkstyle,
43 matches
Mail list logo
