[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207075#comment-15207075
]
Hadoop QA commented on HBASE-15398:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203888#comment-15203888
]
Phil Yang commented on HBASE-15398:
---
We will not allow partial only when we use row filter
> Cells
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203841#comment-15203841
]
Anoop Sam John commented on HBASE-15398:
At present (with out any fix) we will not allow any
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203828#comment-15203828
]
Phil Yang commented on HBASE-15398:
---
Before we support partial protocol, we already have family
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203806#comment-15203806
]
Anoop Sam John commented on HBASE-15398:
Ya let us see all pros and cons and decide based on
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203805#comment-15203805
]
Anoop Sam John commented on HBASE-15398:
IMHO that is too much of a restriction.. Specially
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203801#comment-15203801
]
Phil Yang commented on HBASE-15398:
---
Oh forgive me, I was wrong. We can not do this because we should
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203791#comment-15203791
]
Anoop Sam John commented on HBASE-15398:
bq.We have banned batch when filter's hasFilterRow
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203790#comment-15203790
]
Phil Yang commented on HBASE-15398:
---
To be more clear, setting size/time limit to BETWEEM_CELLS after
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203787#comment-15203787
]
Phil Yang commented on HBASE-15398:
---
{quote}
But I can not see we reset the setTimeLimitScope.
{quote}
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203654#comment-15203654
]
Anoop Sam John commented on HBASE-15398:
Checking the code
{code}
if (hasFilterRow) {
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201774#comment-15201774
]
Hadoop QA commented on HBASE-15398:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197333#comment-15197333
]
stack commented on HBASE-15398:
---
bq. Is it a good idea that adding a new flag in protocol of Result? If we
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197421#comment-15197421
]
Phil Yang commented on HBASE-15398:
---
SingleColumnValueFilter is one kind of essential filter which will
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197393#comment-15197393
]
Phil Yang commented on HBASE-15398:
---
{quote}
You think it not possible for server to deliver results
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197514#comment-15197514
]
Phil Yang commented on HBASE-15398:
---
{quote}
In your list, #3 is the optional. #1 and #2 are
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197477#comment-15197477
]
stack commented on HBASE-15398:
---
In your list, #3 is the optional. #1 and #2 are required/fundamentals.
I
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197703#comment-15197703
]
stack commented on HBASE-15398:
---
Thanks [~yangzhe1991]
Yes, lets warn users against joinedHeap if doing
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197600#comment-15197600
]
Phil Yang commented on HBASE-15398:
---
I checked all filters we offer to users. There is no filter which
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198776#comment-15198776
]
Phil Yang commented on HBASE-15398:
---
{quote}
If hasFilterRow returns true, and it is a wide row, there
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197524#comment-15197524
]
stack commented on HBASE-15398:
---
bq. I checked the code and run a small test locally, as long as a filter's
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194676#comment-15194676
]
Phil Yang commented on HBASE-15398:
---
Is it a good idea that adding a new flag in protocol of Result? If
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193512#comment-15193512
]
ramkrishna.s.vasudevan commented on HBASE-15398:
bq.Or use MetaCellComparator if
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192875#comment-15192875
]
Phil Yang commented on HBASE-15398:
---
{quote}
The following comparator will work for user-space results
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187579#comment-15187579
]
Hadoop QA commented on HBASE-15398:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187477#comment-15187477
]
stack commented on HBASE-15398:
---
Result has up to this not needed sorting. Adding it implies a new 'order'
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186635#comment-15186635
]
Phil Yang commented on HBASE-15398:
---
I find if I add a client-side logic to judge if joinedHeap will
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186595#comment-15186595
]
stack commented on HBASE-15398:
---
The storeHeap/joinedHeap came in here:
{code}
commit
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186526#comment-15186526
]
Phil Yang commented on HBASE-15398:
---
It seems that if we put all cf into joinedHeap, we will not scan
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186502#comment-15186502
]
ramkrishna.s.vasudevan commented on HBASE-15398:
To start with (I may be wrong here
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186339#comment-15186339
]
Phil Yang commented on HBASE-15398:
---
Still working :) I refactor RegionSannerImpl.nextInternal so I
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185367#comment-15185367
]
Anoop Sam John commented on HBASE-15398:
So what is the approach being taken in patch?
> Cells
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184273#comment-15184273
]
Ted Yu commented on HBASE-15398:
bq. should the exception be thrown in server or client?
I would say
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184234#comment-15184234
]
Phil Yang commented on HBASE-15398:
---
Some tests failed, trying to fix them. And maybe I need a refactor
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184224#comment-15184224
]
Phil Yang commented on HBASE-15398:
---
{quote}
I don't see new exception added which would alert the user
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183334#comment-15183334
]
Ted Yu commented on HBASE-15398:
bq. And if hasEssentialFilter is true, we should sort in
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183285#comment-15183285
]
Hadoop QA commented on HBASE-15398:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183187#comment-15183187
]
Phil Yang commented on HBASE-15398:
---
I expected that if there is a family need not be filtered(not
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183151#comment-15183151
]
Ted Yu commented on HBASE-15398:
The return value of checkEssentialFilter() is assigned to:
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182990#comment-15182990
]
Phil Yang commented on HBASE-15398:
---
I check the comment in:
{code}
/**
* Check that given column
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182988#comment-15182988
]
Ted Yu commented on HBASE-15398:
{code}
174 if(!filter.isFamilyEssential(family)){
175
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182648#comment-15182648
]
Phil Yang commented on HBASE-15398:
---
{quote}
should we enforce that essential family filter and
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181748#comment-15181748
]
Ted Yu commented on HBASE-15398:
This is what I meant:
http://pastebin.com/mdLyUsc1
> Cells loss or
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180178#comment-15180178
]
Ted Yu commented on HBASE-15398:
Server side, should we enforce that essential family filter and
[
https://issues.apache.org/jira/browse/HBASE-15398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180160#comment-15180160
]
Phil Yang commented on HBASE-15398:
---
And this may be not simple to fix especially when user
45 matches
Mail list logo
