[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329365#comment-15329365
]
Hadoop QA commented on HBASE-15499:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323497#comment-15323497
]
stack commented on HBASE-15499:
---
Sounds good to me. Which branches to commit to [~heliangliang]?
> Add
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321628#comment-15321628
]
Nick Dimiduk commented on HBASE-15499:
--
That's the direction I'm thinking, yes. The difference is
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318222#comment-15318222
]
He Liangliang commented on HBASE-15499:
---
[~ndimiduk] Do you suggest adding an extra interface like
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316150#comment-15316150
]
stack commented on HBASE-15499:
---
[~heliangliang] What you think of [~ndimiduk] comment boss? Thanks.
> Add
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315145#comment-15315145
]
Nick Dimiduk commented on HBASE-15499:
--
Wiring our atomic ops for arbitrary user extension via the
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308645#comment-15308645
]
stack commented on HBASE-15499:
---
I am +1 on this. Needs a release note. [~ndimiduk] The number type stuff
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306124#comment-15306124
]
Hadoop QA commented on HBASE-15499:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219503#comment-15219503
]
Hadoop QA commented on HBASE-15499:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218561#comment-15218561
]
Hadoop QA commented on HBASE-15499:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216631#comment-15216631
]
Hadoop QA commented on HBASE-15499:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216441#comment-15216441
]
Hadoop QA commented on HBASE-15499:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216054#comment-15216054
]
stack commented on HBASE-15499:
---
Patch looks good. What did you change [~heliangliang]? Thanks.
> Add
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214487#comment-15214487
]
Hadoop QA commented on HBASE-15499:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214044#comment-15214044
]
He Liangliang commented on HBASE-15499:
---
added missing annotation
> Add multiple data type support
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212591#comment-15212591
]
stack commented on HBASE-15499:
---
Patch looks good to me. I like your use of our existing type system
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212300#comment-15212300
]
stack commented on HBASE-15499:
---
Why? Looks like non-controversial feature addition to me.
> Add multiple
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212261#comment-15212261
]
Hadoop QA commented on HBASE-15499:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212201#comment-15212201
]
Ted Yu commented on HBASE-15499:
{code}
+public enum NumberCodecType {
{code}
This seems a relatively big
19 matches
Mail list logo
