[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-24 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519242#comment-15519242 ] Ashish Singhi commented on HBASE-16672: --- +1 pending QA run. {code} /** 536* Create a

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-24 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519123#comment-15519123 ] Ashish Singhi commented on HBASE-16672: --- {code} +finalPath =

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517099#comment-15517099 ] Hadoop QA commented on HBASE-16672: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517034#comment-15517034 ] Ted Yu commented on HBASE-16672: The above description is not accurate. The normal bulk load would not

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517018#comment-15517018 ] Jerry He commented on HBASE-16672: -- There could be a problem with rolling upgrade compatibility. If some

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516966#comment-15516966 ] Ashish Singhi commented on HBASE-16672: --- In your next patch, please correct the log message also.

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516960#comment-15516960 ] Ashish Singhi commented on HBASE-16672: --- [~tedyu], can we implement master branch patch considering

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516415#comment-15516415 ] Ashish Singhi commented on HBASE-16672: --- Can we change add a new method in LimitedPrivate interface

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516396#comment-15516396 ] Ted Yu commented on HBASE-16672: I also target branch-1 where secure bulk load endpoint is not mandatory.

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516380#comment-15516380 ] Ashish Singhi commented on HBASE-16672: --- I think you are targeting this only in master branch and I

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516373#comment-15516373 ] Ted Yu commented on HBASE-16672: This is to cover the case where secure bulk load endpoint (manager) is

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516368#comment-15516368 ] Ashish Singhi commented on HBASE-16672: --- bq. Once hfile is copied to staging dir, there wouldn't be

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516218#comment-15516218 ] Ted Yu commented on HBASE-16672: The first copy is part of backup artifacts which should be immutable.

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-23 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516010#comment-15516010 ] Ashish Singhi commented on HBASE-16672: --- With this patch if copyFile is true then we are

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514292#comment-15514292 ] Ted Yu commented on HBASE-16672: Test failures were not related. I ran a few with patch which passed:

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513778#comment-15513778 ] Hadoop QA commented on HBASE-16672: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512565#comment-15512565 ] Hadoop QA commented on HBASE-16672: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-22 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512359#comment-15512359 ] Ted Yu commented on HBASE-16672: Restoring to another cluster is one scenario. Local restore (target

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-22 Thread Ashish Singhi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512313#comment-15512313 ] Ashish Singhi commented on HBASE-16672: --- One doubt here, pardon me I haven't went through backup

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512213#comment-15512213 ] Ted Yu commented on HBASE-16672: SecureBulkLoadListener has logic for the copy through staging dir. I

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512172#comment-15512172 ] Anoop Sam John commented on HBASE-16672: The copy of the backup files should be done by the

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512001#comment-15512001 ] Hadoop QA commented on HBASE-16672: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511718#comment-15511718 ] Ted Yu commented on HBASE-16672: w.r.t. the SecureBulkLoadListener, we have this code: {code}

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511681#comment-15511681 ] Ted Yu commented on HBASE-16672: I agree that there is no need to dive into the details of the

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511653#comment-15511653 ] Jerry He commented on HBASE-16672: -- Also there is another place that needs to be taken care of, in the

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Jerry He (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511645#comment-15511645 ] Jerry He commented on HBASE-16672: -- Hi, Ted The stack trace looks confusing. 1. Why incremental restore

[jira] [Commented] (HBASE-16672) Add option for bulk load to copy hfile(s) instead of renaming

2016-09-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511544#comment-15511544 ] Hadoop QA commented on HBASE-16672: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem