[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264241#comment-16264241
]
Hudson commented on HBASE-16868:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4103 (See
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264210#comment-16264210
]
Hudson commented on HBASE-16868:
FAILURE: Integrated in Jenkins build HBase-2.0 #901 (See
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263872#comment-16263872
]
Guanghao Zhang commented on HBASE-16868:
Ok. All ut passed. Will fix the checkstyle when commit.
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263826#comment-16263826
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263602#comment-16263602
]
Guanghao Zhang commented on HBASE-16868:
TestAsyncReplicationAdminApiWithClusters was added
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262860#comment-16262860
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262364#comment-16262364
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262026#comment-16262026
]
Guanghao Zhang commented on HBASE-16868:
Thanks for reviewing. :-) Let me take a code rebase and
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262011#comment-16262011
]
stack commented on HBASE-16868:
---
Thanks for chiming in [~ashish singhi] Good to commit I'd say [~zghaobac]
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261976#comment-16261976
]
Ashish Singhi commented on HBASE-16868:
---
+1 on the patch.
Nit(can address on the commit):
{code}
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261946#comment-16261946
]
Guanghao Zhang commented on HBASE-16868:
This replicate_all flag is useful to avoid misuse of
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261570#comment-16261570
]
stack commented on HBASE-16868:
---
Thanks [~zghaobac] for explanation. Is this good by you [~ashish singhi]?
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256178#comment-16256178
]
Guanghao Zhang commented on HBASE-16868:
bq. What is the 'misuse' we are trying to avoid?
In our
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256034#comment-16256034
]
stack commented on HBASE-16868:
---
Why do we need this flag [~zghaobac]? What is the 'misuse' we are trying
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220262#comment-16220262
]
Guanghao Zhang commented on HBASE-16868:
bq. Is this change acceptable ?
This behavior change is
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219048#comment-16219048
]
Ashish Singhi commented on HBASE-16868:
---
I reviewed the patch, left couple of comments. Overall
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218357#comment-16218357
]
Guanghao Zhang commented on HBASE-16868:
{code}
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218330#comment-16218330
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217995#comment-16217995
]
Guanghao Zhang commented on HBASE-16868:
bq. if I create a peer with no namespace/table, we will
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217984#comment-16217984
]
Duo Zhang commented on HBASE-16868:
---
So in general, if I create a peer with no namespace/table, we will
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217980#comment-16217980
]
Guanghao Zhang commented on HBASE-16868:
ping [~ashish singhi] for reviewing.
> Add a
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217972#comment-16217972
]
Guanghao Zhang commented on HBASE-16868:
ping [~Apache9] for reviewing.
> Add a replicate_all
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216982#comment-16216982
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204578#comment-16204578
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204520#comment-16204520
]
Guanghao Zhang commented on HBASE-16868:
I already open a issue HBASE-18956 to address the ruby
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203866#comment-16203866
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203551#comment-16203551
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203315#comment-16203315
]
Guanghao Zhang commented on HBASE-16868:
bq. Let's pick this up
Ok. Let me take a rebase for
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201893#comment-16201893
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201859#comment-16201859
]
Duo Zhang commented on HBASE-16868:
---
I think this is very important improvement. Let's pick this up
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16059439#comment-16059439
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055664#comment-16055664
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16053846#comment-16053846
]
Hadoop QA commented on HBASE-16868:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
33 matches
Mail list logo